linux/arch/blackfin
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
boot
configs Blackfin arch: update default kernel configuration 2009-03-28 23:46:17 +08:00
include/asm Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/blackfin-2.6 2009-03-28 13:55:49 -07:00
kernel Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/blackfin-2.6 2009-03-28 13:55:49 -07:00
lib Blackfin arch: merge adeos blackfin part to arch/blackfin/ 2009-01-07 23:14:39 +08:00
mach-bf518 Blackfin arch: add RSI's definitions to bf514 and bf516 2009-03-29 01:03:20 +08:00
mach-bf527 Blackfin arch: convert BF5{18,27,48}_FAMILY to CONFIG_BF{51,52,54}x 2009-03-28 20:32:57 +08:00
mach-bf533 Blackfin arch: SPI_MMC is now mainlined MMC_SPI 2009-03-06 00:27:57 +08:00
mach-bf537 Blackfin arch: add sport-spi related resource stuff to board file 2009-03-28 23:28:51 +08:00
mach-bf538 Blackfin arch: add stubs for anomalies 447 and 448 2009-03-06 00:20:49 +08:00
mach-bf548 Blackfin arch: convert BF5{18,27,48}_FAMILY to CONFIG_BF{51,52,54}x 2009-03-28 20:32:57 +08:00
mach-bf561 Blackfin arch: SPI_MMC is now mainlined MMC_SPI 2009-03-06 00:27:57 +08:00
mach-common Blackfin arch: Blacklist Hibernate (PM_SUSPEND_MEM) on BF561 as well 2009-03-28 23:14:41 +08:00
mm proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
oprofile Blackfin arch: remove hardware PM code, oprofile not use it 2009-01-07 23:14:39 +08:00
Kconfig Blackfin arch: PM_BFIN_WAKE_GP: update help 2009-03-05 16:45:55 +08:00
Kconfig.debug Blackfin arch: use common KGDB_TESTS rather than our own KGDB_TESTCASE 2009-03-02 18:14:47 +08:00
Makefile Blackfin arch: line up machine-/cpu- vars after BF54xM addition 2009-02-04 16:49:45 +08:00