linux/tools/perf/ui
Jin Yao 80f62589fa perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target
When the jump instruction is displayed at the row 0 in annotate view,
the arrow is broken. An example:

 16.86 │   ┌──je     82
  0.01 │      movsd  (%rsp),%xmm0
       │      movsd  0x8(%rsp),%xmm4
       │      movsd  0x8(%rsp),%xmm1
       │      movsd  (%rsp),%xmm3
       │      divsd  %xmm4,%xmm0
       │      divsd  %xmm3,%xmm1
       │      movsd  (%rsp),%xmm2
       │      addsd  %xmm1,%xmm0
       │      addsd  %xmm2,%xmm0
       │      movsd  %xmm0,(%rsp)
       │82:   sub    $0x1,%ebx
 83.03 │    ↑ jne    38
       │      add    $0x10,%rsp
       │      xor    %eax,%eax
       │      pop    %rbx
       │    ← retq

The patch increments the row number before checking with 0.

Signed-off-by: Yao Jin <yao.jin@linux.intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Fixes: 944e1abed9 ("perf ui browser: Add method to draw up/down arrow line")
Link: http://lkml.kernel.org/r/1496901704-30275-1-git-send-email-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2017-07-10 16:36:40 -03:00
..
browsers perf annotate: Return arch from symbol__disassemble() and save it in browser 2017-06-19 15:27:09 -03:00
gtk perf annotate: Return arch from symbol__disassemble() and save it in browser 2017-06-19 15:27:09 -03:00
stdio perf tools: Use just forward declarations for struct thread where possible 2017-04-24 13:43:35 -03:00
tui perf tools: Add include <linux/kernel.h> where ARRAY_SIZE() is used 2017-04-19 13:01:44 -03:00
Build perf build: Add slang objects building 2015-02-12 11:48:13 -03:00
browser.c perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target 2017-07-10 16:36:40 -03:00
browser.h perf annotate: Rename 'colors.code' to 'colors.jump_arrows' 2016-01-26 11:52:46 -03:00
helpline.c perf ui helpline: Provide a printf variant 2016-11-25 15:49:16 -03:00
helpline.h perf ui helpline: Provide a printf variant 2016-11-25 15:49:16 -03:00
hist.c perf tools: Put caller above callee in --children mode 2017-05-24 08:41:49 +02:00
keysyms.h
libslang.h perf ui browser: Introduce ui_browser__printf() 2015-08-12 10:27:05 -03:00
progress.c
progress.h perf tools: Remove EOL whitespaces 2015-01-21 13:24:31 -03:00
setup.c perf ui gtk: Move gtk .so name to the only place where it is used 2017-04-26 15:31:57 -03:00
ui.h perf ui stdio: Add way to setup the color output mode selection 2016-07-12 00:00:39 -03:00
util.c
util.h