27ac792ca0
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit boundary. For example: u64 val = PAGE_ALIGN(size); always returns a value < 4GB even if size is greater than 4GB. The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for example): #define PAGE_SHIFT 12 #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) ... #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK) The "~" is performed on a 32-bit value, so everything in "and" with PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary. Using the ALIGN() macro seems to be the right way, because it uses typeof(addr) for the mask. Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in include/linux/mm.h. See also lkml discussion: http://lkml.org/lkml/2008/6/11/237 [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c] [akpm@linux-foundation.org: fix v850] [akpm@linux-foundation.org: fix powerpc] [akpm@linux-foundation.org: fix arm] [akpm@linux-foundation.org: fix mips] [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c] [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c] [akpm@linux-foundation.org: fix powerpc] Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| a.out-core.h | ||
| a.out.h | ||
| alternative-asm.h | ||
| alternative.h | ||
| apic.h | ||
| archparam-i386.h | ||
| archparam-ppc.h | ||
| archparam-x86_64.h | ||
| asm.h | ||
| atomic.h | ||
| auxvec.h | ||
| bitops.h | ||
| boot.h | ||
| bug.h | ||
| bugs.h | ||
| byteorder.h | ||
| cache.h | ||
| cacheflush.h | ||
| calling.h | ||
| checksum.h | ||
| cmpxchg.h | ||
| cobalt.h | ||
| common.lds.S | ||
| cpufeature.h | ||
| cputime.h | ||
| current.h | ||
| delay.h | ||
| desc.h | ||
| device.h | ||
| div64.h | ||
| dma-mapping.h | ||
| dma.h | ||
| dwarf2.h | ||
| elf-i386.h | ||
| elf-ppc.h | ||
| elf-x86_64.h | ||
| emergency-restart.h | ||
| errno.h | ||
| fcntl.h | ||
| fixmap.h | ||
| floppy.h | ||
| frame.h | ||
| futex.h | ||
| hardirq.h | ||
| highmem.h | ||
| host_ldt-i386.h | ||
| host_ldt-x86_64.h | ||
| hw_irq.h | ||
| ide.h | ||
| io.h | ||
| ioctl.h | ||
| ioctls.h | ||
| ipcbuf.h | ||
| irq_regs.h | ||
| irq_vectors.h | ||
| irq.h | ||
| irqflags.h | ||
| kdebug.h | ||
| kmap_types.h | ||
| kvm.h | ||
| ldt.h | ||
| linkage.h | ||
| local.h | ||
| locks.h | ||
| mca_dma.h | ||
| mman.h | ||
| mmu_context.h | ||
| mmu.h | ||
| module-generic.h | ||
| module-i386.h | ||
| module-x86_64.h | ||
| msgbuf.h | ||
| mtrr.h | ||
| mutex.h | ||
| namei.h | ||
| nops.h | ||
| page_offset.h | ||
| page.h | ||
| param.h | ||
| paravirt.h | ||
| pci.h | ||
| pda.h | ||
| percpu.h | ||
| pgalloc.h | ||
| pgtable-2level.h | ||
| pgtable-3level.h | ||
| pgtable.h | ||
| poll.h | ||
| posix_types.h | ||
| prctl.h | ||
| processor-generic.h | ||
| processor-i386.h | ||
| processor-ppc.h | ||
| processor-x86_64.h | ||
| ptrace-generic.h | ||
| ptrace-i386.h | ||
| ptrace-x86_64.h | ||
| required-features.h | ||
| resource.h | ||
| rwlock.h | ||
| rwsem.h | ||
| scatterlist.h | ||
| sections.h | ||
| segment.h | ||
| semaphore.h | ||
| sembuf.h | ||
| serial.h | ||
| setup.h | ||
| shmbuf.h | ||
| shmparam.h | ||
| sigcontext-generic.h | ||
| sigcontext-i386.h | ||
| sigcontext-ppc.h | ||
| sigcontext-x86_64.h | ||
| siginfo.h | ||
| signal.h | ||
| smp.h | ||
| socket.h | ||
| sockios.h | ||
| spinlock_types.h | ||
| spinlock.h | ||
| stat.h | ||
| statfs.h | ||
| string.h | ||
| suspend.h | ||
| system-generic.h | ||
| system-i386.h | ||
| system-ppc.h | ||
| system-x86_64.h | ||
| termbits.h | ||
| termios.h | ||
| thread_info.h | ||
| timex.h | ||
| tlb.h | ||
| tlbflush.h | ||
| topology.h | ||
| types.h | ||
| uaccess.h | ||
| ucontext.h | ||
| unaligned.h | ||
| unistd.h | ||
| user.h | ||
| vga.h | ||
| vm86.h | ||
| vm-flags-i386.h | ||
| vm-flags-x86_64.h | ||
| xor.h | ||