linux/net/sunrpc
Chuck Lever 55c3e7fac9 svcrdma: Fix backchannel return code
[ Upstream commit ea740bd5f5 ]

Way back when I was writing the RPC/RDMA server-side backchannel
code, I misread the TCP backchannel reply handler logic. When
svc_tcp_recvfrom() successfully receives a backchannel reply, it
does not return -EAGAIN. It sets XPT_DATA and returns zero.

Update svc_rdma_recvfrom() to return zero. Here, XPT_DATA doesn't
need to be set again: it is set whenever a new message is received,
behind a spin lock in a single threaded context.

Also, if handling the cb reply is not successful, the message is
simply dropped. There's no special message framing to deal with as
there is in the TCP case.

Now that the handle_bc_reply() return value is ignored, I've removed
the dprintk call sites in the error exit of handle_bc_reply() in
favor of trace points in other areas that already report the error
cases.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-10-01 13:18:01 +02:00
..
auth_gss SUNRPC: Fix ("SUNRPC: Add "@len" parameter to gss_unwrap()") 2020-08-19 08:16:21 +02:00
xprtrdma svcrdma: Fix backchannel return code 2020-10-01 13:18:01 +02:00
addr.c
auth_null.c
auth_unix.c
auth.c
backchannel_rqst.c
cache.c
clnt.c
debugfs.c
Kconfig
Makefile
netns.h
rpc_pipe.c
rpcb_clnt.c SUNRPC: stop printk reading past end of string 2020-09-23 12:40:36 +02:00
sched.c SUNRPC: Don't start a timer on an already queued rpc task 2020-10-01 13:17:53 +02:00
socklib.c
stats.c
sunrpc_syms.c
sunrpc.h
svc_xprt.c SUNRPC: Fix a potential buffer overflow in 'svc_print_xprts()' 2020-10-01 13:17:50 +02:00
svc.c nfsd: Fix NFSv4 READ on RDMA when using readv 2020-08-11 15:33:42 +02:00
svcauth_unix.c
svcauth.c
svcsock.c nfsd: Fix NFSv4 READ on RDMA when using readv 2020-08-11 15:33:42 +02:00
sysctl.c
timer.c
xdr.c
xprt.c
xprtmultipath.c
xprtsock.c