Josh Poimboeuf d85044145f objtool: Fix noreturn detection for ignored functions ... [ Upstream commit db6c6a0df8 ] When a function is annotated with STACK_FRAME_NON_STANDARD, objtool doesn't validate its code paths. It also skips sibling call detection within the function. But sibling call detection is actually needed for the case where the ignored function doesn't have any return instructions. Otherwise objtool naively marks the function as implicit static noreturn, which affects the reachability of its callers, resulting in "unreachable instruction" warnings. Fix it by just enabling sibling call detection for ignored functions. The 'insn->ignore' check in add_jump_destinations() is no longer needed after e6da956795 ("objtool: Don't use ignore flag for fake jumps"). Fixes the following warning: arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x142: unreachable instruction which triggers on an allmodconfig with CONFIG_GCOV_KERNEL unset. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Borislav Petkov <bp@suse.de> Acked-by: Linus Torvalds <torvalds@linux-foundation.org> Link: https://lkml.kernel.org/r/5b1e2536cdbaa5246b60d7791b76130a74082c62.1599751464.git.jpoimboe@redhat.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-10-01 13:18:15 +02:00
..
arch/x86
Documentation
.gitignore
arch.h
Build
builtin-check.c
builtin-orc.c
builtin.h
cfi.h
check.c	objtool: Fix noreturn detection for ignored functions	2020-10-01 13:18:15 +02:00
check.h
elf.c
elf.h
Makefile	kbuild: support LLVM=1 to switch the default tools to Clang/LLVM	2020-08-26 10:40:47 +02:00
objtool.c
orc_dump.c	objtool: Support Clang non-section symbols in ORC dump	2020-05-02 08:48:57 +02:00
orc_gen.c
orc.h
special.c
special.h
sync-check.sh
warn.h