Marek Vasut 8e6cb470ba iio:adc:at91-sama5d2: Repair crash on module removal ... The driver never calls platform_set_drvdata() , so platform_get_drvdata() in .remove returns NULL and thus $indio_dev variable in .remove is NULL. Then it's only a matter of dereferencing the indio_dev variable to make the kernel blow as seen below. This patch adds the platform_set_drvdata() call to fix the problem. root@armhf:~# rmmod at91-sama5d2_adc Unable to handle kernel NULL pointer dereference at virtual address 000001d4 pgd = dd57c000 [000001d4] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: at91_sama5d2_adc(-) CPU: 0 PID: 1334 Comm: rmmod Not tainted 4.6.0-rc3-next-20160418+ #3 Hardware name: Atmel SAMA5 task: dd4fcc40 ti: de910000 task.ti: de910000 PC is at mutex_lock+0x4/0x24 LR is at iio_device_unregister+0x14/0x6c pc : [<c05f4624>] lr : [<c0471f74>] psr: a00d0013 sp : de911f00 ip : 00000000 fp : be898bd8 r10: 00000000 r9 : de910000 r8 : c0107724 r7 : 00000081 r6 : bf001048 r5 : 000001d4 r4 : 00000000 r3 : bf000000 r2 : 00000000 r1 : 00000004 r0 : 000001d4 Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c53c7d Table: 3d57c059 DAC: 00000051 Process rmmod (pid: 1334, stack limit = 0xde910208) Stack: (0xde911f00 to 0xde912000) 1f00: bf000000 00000000 df5c7e10 bf000010 bf000000 df5c7e10 df5c7e10 c0351ca8 1f20: c0351c84 df5c7e10 bf001048 c0350734 bf001048 df5c7e10 df5c7e44 c035087c 1f40: bf001048 7f62dd4c 00000800 c034fb30 bf0010c0 c0158ee8 de910000 31397461 1f60: 6d61735f 32643561 6364615f 00000000 de911f90 de910000 de910000 00000000 1f80: de911fb0 10c53c7d de911f9c c05f33d8 de911fa0 00910000 be898ecb 7f62dd10 1fa0: 00000000 c0107560 be898ecb 7f62dd10 7f62dd4c 00000800 6f844800 6f844800 1fc0: be898ecb 7f62dd10 00000000 00000081 00000000 7f62dd10 be898bd8 be898bd8 1fe0: b6eedab1 be898b6c 7f61056b b6eedab6 000d0030 7f62dd4c 00000000 00000000 [<c05f4624>] (mutex_lock) from [<c0471f74>] (iio_device_unregister+0x14/0x6c) [<c0471f74>] (iio_device_unregister) from [<bf000010>] (at91_adc_remove+0x10/0x3c [at91_sama5d2_adc]) [<bf000010>] (at91_adc_remove [at91_sama5d2_adc]) from [<c0351ca8>] (platform_drv_remove+0x24/0x3c) [<c0351ca8>] (platform_drv_remove) from [<c0350734>] (__device_release_driver+0x84/0x110) [<c0350734>] (__device_release_driver) from [<c035087c>] (driver_detach+0x8c/0x90) [<c035087c>] (driver_detach) from [<c034fb30>] (bus_remove_driver+0x4c/0xa0) [<c034fb30>] (bus_remove_driver) from [<c0158ee8>] (SyS_delete_module+0x110/0x1d0) [<c0158ee8>] (SyS_delete_module) from [<c0107560>] (ret_fast_syscall+0x0/0x3c) Code: e3520001 1affffd5 eafffff4 f5d0f000 (e1902f9f) ---[ end trace 86914d7ad3696fca ]--- Signed-off-by: Marek Vasut <marex@denx.de> Cc: Ludovic Desroches <ludovic.desroches@atmel.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org>		2016-04-18 19:53:34 +01:00
..
accel	iio: accel: bmc150: fix endianness when reading axes	2016-04-03 11:16:11 +01:00
adc	iio:adc:at91-sama5d2: Repair crash on module removal	2016-04-18 19:53:34 +01:00
amplifiers	spi: Updates for v4.4	2015-11-05 13:15:12 -08:00
buffer	iio: buffer-dmaengine: Use dmaengine_terminate_sync()	2016-02-09 21:05:17 +00:00
chemical	iio: convert to common i2c_check_functionality() return value	2016-02-27 17:17:43 +00:00
common	iio: st_sensors: support active-low interrupts	2016-01-10 12:35:32 +00:00
dac	iio: dac: vf610_dac: Add IIO DAC driver for Vybrid SoC	2016-02-24 20:52:55 +00:00
dummy	Second set of IIO new drivers, functionality and cleanups for the 4.5 cycle.	2015-12-26 17:03:33 -08:00
frequency	spi: Updates for v4.4	2015-11-05 13:15:12 -08:00
gyro	iio: gyro: bmg160: fix buffer read values	2016-04-03 11:21:33 +01:00
health	iio: health: max30100: correct FIFO check condition	2016-03-28 10:09:58 +01:00
humidity	iio: convert to common i2c_check_functionality() return value	2016-02-27 17:17:43 +00:00
imu	iio: imu: Fix inv_mpu6050 dependencies	2016-03-28 09:52:09 +01:00
light	First round of IIO fixes for the 4.6 cycle.	2016-04-04 12:59:48 -07:00
magnetometer	iio: ak8975: fix maybe-uninitialized warning	2016-04-17 12:16:36 +01:00
orientation
potentiometer	iio: convert to common i2c_check_functionality() return value	2016-02-27 17:17:43 +00:00
pressure	iio: convert to common i2c_check_functionality() return value	2016-02-27 17:17:43 +00:00
proximity	iio: convert to common i2c_check_functionality() return value	2016-02-27 17:17:43 +00:00
temperature	iio: convert to common i2c_check_functionality() return value	2016-02-27 17:17:43 +00:00
trigger	iio: trigger: Introduce IIO hrtimer based trigger	2015-12-03 18:19:27 +00:00
iio_core_trigger.h
iio_core.h
industrialio-buffer.c	iio: fix config watermark initial value	2016-03-28 11:00:38 +01:00
industrialio-configfs.c	iio:configfs: Introduce iio/configfs.h to provide a location for the configfs_subsystem	2015-12-05 16:25:30 +00:00
industrialio-core.c	First round of new IIO device support, features and cleanups for the 4.6 cycle.	2016-02-01 13:10:03 -08:00
industrialio-event.c	iio: event: Remove negative error code from iio_event_poll	2015-08-12 19:26:39 +01:00
industrialio-sw-trigger.c	iio: core: fix ptr_ret.cocci warnings	2016-01-20 17:09:18 -08:00
industrialio-trigger.c	iio: Support triggered events	2015-08-27 20:47:09 +01:00
industrialio-triggered-event.c	iio: Support triggered events	2015-08-27 20:47:09 +01:00
inkern.c	First set of IIO fixes for the 4.5 cycle.	2016-02-01 13:07:38 -08:00
Kconfig	iio: light: add MAX30100 oximeter driver support	2015-12-12 12:14:37 +00:00
Makefile	iio: light: add MAX30100 oximeter driver support	2015-12-12 12:14:37 +00:00