OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
8f9702aad1
linux/drivers/net/bonding
History
Eric W. Biederman a8779ec1c5 netpoll: Remove gfp parameter from __netpoll_setup 
The gfp parameter was added in:
commit 47be03a28c
Author: Amerigo Wang <amwang@redhat.com>
Date:   Fri Aug 10 01:24:37 2012 +0000

    netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()

    slave_enable_netpoll() and __netpoll_setup() may be called
    with read_lock() held, so should use GFP_ATOMIC to allocate
    memory. Eric suggested to pass gfp flags to __netpoll_setup().

    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: Cong Wang <amwang@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

The reason for the gfp parameter was removed in:
commit c4cdef9b71
Author: dingtianhong <dingtianhong@huawei.com>
Date:   Tue Jul 23 15:25:27 2013 +0800

    bonding: don't call slave_xxx_netpoll under spinlocks

    The slave_xxx_netpoll will call synchronize_rcu_bh(),
    so the function may schedule and sleep, it should't be
    called under spinlocks.

    bond_netpoll_setup() and bond_netpoll_cleanup() are always
    protected by rtnl lock, it is no need to take the read lock,
    as the slave list couldn't be changed outside rtnl lock.

    Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
    Cc: Jay Vosburgh <fubar@us.ibm.com>
    Cc: Andy Gospodarek <andy@greyhouse.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Nothing else that calls __netpoll_setup or ndo_netpoll_setup
requires a gfp paramter, so remove the gfp parameter from both
of these functions making the code clearer.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-03-29 17:58:37 -04:00
..
bond_3ad.c bonding: ratelimit pr_warn()s in 802.3ad mode 2014-03-18 14:50:48 -04:00
bond_3ad.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2014-02-19 01:24:22 -05:00
bond_alb.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2014-03-14 22:31:55 -04:00
bond_alb.h
bond_debugfs.c bonding: Convert pr_warning to pr_warn, neatening 2014-02-17 00:29:23 -05:00
bond_main.c netpoll: Remove gfp parameter from __netpoll_setup 2014-03-29 17:58:37 -04:00
bond_netlink.c bonding: force cast of IP address in options 2014-03-11 16:37:14 -04:00
bond_options.c drivers/net: Use RCU_INIT_POINTER(x, NULL) in bonding/bond_options.c 2014-03-27 00:18:09 -04:00
bond_options.h bonding: fix const in options processing 2014-03-06 17:39:19 -05:00
bond_procfs.c bonding: fix const in options processing 2014-03-06 17:39:19 -05:00
bond_sysfs_slave.c bonding: change name of sysfs dir for bonding slaves 2014-01-22 21:57:05 -08:00
bond_sysfs.c bonding: options handling cleanup 2014-03-06 16:08:52 -05:00
bonding.h bonding: support QinQ for bond arp interval 2014-03-26 16:41:28 -04:00
Makefile bonding: add sysfs /slave dir for bond slave devices. 2014-01-17 18:51:58 -08:00