7b4577a9da
Open vSwitch allows moving internal vport to different namespace while still connected to the bridge. But when namespace deleted OVS does not detach these vports, that results in dangling pointer to netdevice which causes kernel panic as follows. This issue is fixed by detaching all ovs ports from the deleted namespace at net-exit. BUG: unable to handle kernel NULL pointer dereference at 0000000000000028 IP: [<ffffffffa0aadaa5>] ovs_vport_locate+0x35/0x80 [openvswitch] Oops: 0000 [#1] SMP Call Trace: [<ffffffffa0aa6391>] lookup_vport+0x21/0xd0 [openvswitch] [<ffffffffa0aa65f9>] ovs_vport_cmd_get+0x59/0xf0 [openvswitch] [<ffffffff8167e07c>] genl_family_rcv_msg+0x1bc/0x3e0 [<ffffffff8167e319>] genl_rcv_msg+0x79/0xc0 [<ffffffff8167d919>] netlink_rcv_skb+0xb9/0xe0 [<ffffffff8167deac>] genl_rcv+0x2c/0x40 [<ffffffff8167cffd>] netlink_unicast+0x12d/0x1c0 [<ffffffff8167d3da>] netlink_sendmsg+0x34a/0x6b0 [<ffffffff8162e140>] sock_sendmsg+0xa0/0xe0 [<ffffffff8162e5e8>] ___sys_sendmsg+0x408/0x420 [<ffffffff8162f541>] __sys_sendmsg+0x51/0x90 [<ffffffff8162f592>] SyS_sendmsg+0x12/0x20 [<ffffffff81764ee9>] system_call_fastpath+0x12/0x17 Reported-by: Assaf Muller <amuller@redhat.com> Fixes: 46df7b81454("openvswitch: Add support for network namespaces.") Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Reviewed-by: Thomas Graf <tgraf@noironetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
260 lines
7.9 KiB
C
260 lines
7.9 KiB
C
/*
|
|
* Copyright (c) 2007-2012 Nicira, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
|
* 02110-1301, USA
|
|
*/
|
|
|
|
#ifndef VPORT_H
|
|
#define VPORT_H 1
|
|
|
|
#include <linux/if_tunnel.h>
|
|
#include <linux/list.h>
|
|
#include <linux/netlink.h>
|
|
#include <linux/openvswitch.h>
|
|
#include <linux/reciprocal_div.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/u64_stats_sync.h>
|
|
|
|
#include "datapath.h"
|
|
|
|
struct vport;
|
|
struct vport_parms;
|
|
|
|
/* The following definitions are for users of the vport subsytem: */
|
|
|
|
struct vport_net {
|
|
struct vport __rcu *gre_vport;
|
|
};
|
|
|
|
int ovs_vport_init(void);
|
|
void ovs_vport_exit(void);
|
|
|
|
struct vport *ovs_vport_add(const struct vport_parms *);
|
|
void ovs_vport_del(struct vport *);
|
|
|
|
struct vport *ovs_vport_locate(const struct net *net, const char *name);
|
|
|
|
void ovs_vport_get_stats(struct vport *, struct ovs_vport_stats *);
|
|
|
|
int ovs_vport_set_options(struct vport *, struct nlattr *options);
|
|
int ovs_vport_get_options(const struct vport *, struct sk_buff *);
|
|
|
|
int ovs_vport_set_upcall_portids(struct vport *, const struct nlattr *pids);
|
|
int ovs_vport_get_upcall_portids(const struct vport *, struct sk_buff *);
|
|
u32 ovs_vport_find_upcall_portid(const struct vport *, struct sk_buff *);
|
|
|
|
int ovs_vport_send(struct vport *, struct sk_buff *);
|
|
|
|
int ovs_tunnel_get_egress_info(struct ovs_tunnel_info *egress_tun_info,
|
|
struct net *net,
|
|
const struct ovs_tunnel_info *tun_info,
|
|
u8 ipproto,
|
|
u32 skb_mark,
|
|
__be16 tp_src,
|
|
__be16 tp_dst);
|
|
int ovs_vport_get_egress_tun_info(struct vport *vport, struct sk_buff *skb,
|
|
struct ovs_tunnel_info *info);
|
|
|
|
/* The following definitions are for implementers of vport devices: */
|
|
|
|
struct vport_err_stats {
|
|
atomic_long_t rx_dropped;
|
|
atomic_long_t rx_errors;
|
|
atomic_long_t tx_dropped;
|
|
atomic_long_t tx_errors;
|
|
};
|
|
/**
|
|
* struct vport_portids - array of netlink portids of a vport.
|
|
* must be protected by rcu.
|
|
* @rn_ids: The reciprocal value of @n_ids.
|
|
* @rcu: RCU callback head for deferred destruction.
|
|
* @n_ids: Size of @ids array.
|
|
* @ids: Array storing the Netlink socket pids to be used for packets received
|
|
* on this port that miss the flow table.
|
|
*/
|
|
struct vport_portids {
|
|
struct reciprocal_value rn_ids;
|
|
struct rcu_head rcu;
|
|
u32 n_ids;
|
|
u32 ids[];
|
|
};
|
|
|
|
/**
|
|
* struct vport - one port within a datapath
|
|
* @rcu: RCU callback head for deferred destruction.
|
|
* @dp: Datapath to which this port belongs.
|
|
* @upcall_portids: RCU protected 'struct vport_portids'.
|
|
* @port_no: Index into @dp's @ports array.
|
|
* @hash_node: Element in @dev_table hash table in vport.c.
|
|
* @dp_hash_node: Element in @datapath->ports hash table in datapath.c.
|
|
* @ops: Class structure.
|
|
* @percpu_stats: Points to per-CPU statistics used and maintained by vport
|
|
* @err_stats: Points to error statistics used and maintained by vport
|
|
* @detach_list: list used for detaching vport in net-exit call.
|
|
*/
|
|
struct vport {
|
|
struct rcu_head rcu;
|
|
struct datapath *dp;
|
|
struct vport_portids __rcu *upcall_portids;
|
|
u16 port_no;
|
|
|
|
struct hlist_node hash_node;
|
|
struct hlist_node dp_hash_node;
|
|
const struct vport_ops *ops;
|
|
|
|
struct pcpu_sw_netstats __percpu *percpu_stats;
|
|
|
|
struct vport_err_stats err_stats;
|
|
struct list_head detach_list;
|
|
};
|
|
|
|
/**
|
|
* struct vport_parms - parameters for creating a new vport
|
|
*
|
|
* @name: New vport's name.
|
|
* @type: New vport's type.
|
|
* @options: %OVS_VPORT_ATTR_OPTIONS attribute from Netlink message, %NULL if
|
|
* none was supplied.
|
|
* @dp: New vport's datapath.
|
|
* @port_no: New vport's port number.
|
|
*/
|
|
struct vport_parms {
|
|
const char *name;
|
|
enum ovs_vport_type type;
|
|
struct nlattr *options;
|
|
|
|
/* For ovs_vport_alloc(). */
|
|
struct datapath *dp;
|
|
u16 port_no;
|
|
struct nlattr *upcall_portids;
|
|
};
|
|
|
|
/**
|
|
* struct vport_ops - definition of a type of virtual port
|
|
*
|
|
* @type: %OVS_VPORT_TYPE_* value for this type of virtual port.
|
|
* @create: Create a new vport configured as specified. On success returns
|
|
* a new vport allocated with ovs_vport_alloc(), otherwise an ERR_PTR() value.
|
|
* @destroy: Destroys a vport. Must call vport_free() on the vport but not
|
|
* before an RCU grace period has elapsed.
|
|
* @set_options: Modify the configuration of an existing vport. May be %NULL
|
|
* if modification is not supported.
|
|
* @get_options: Appends vport-specific attributes for the configuration of an
|
|
* existing vport to a &struct sk_buff. May be %NULL for a vport that does not
|
|
* have any configuration.
|
|
* @get_name: Get the device's name.
|
|
* @send: Send a packet on the device. Returns the length of the packet sent,
|
|
* zero for dropped packets or negative for error.
|
|
* @get_egress_tun_info: Get the egress tunnel 5-tuple and other info for
|
|
* a packet.
|
|
*/
|
|
struct vport_ops {
|
|
enum ovs_vport_type type;
|
|
|
|
/* Called with ovs_mutex. */
|
|
struct vport *(*create)(const struct vport_parms *);
|
|
void (*destroy)(struct vport *);
|
|
|
|
int (*set_options)(struct vport *, struct nlattr *);
|
|
int (*get_options)(const struct vport *, struct sk_buff *);
|
|
|
|
/* Called with rcu_read_lock or ovs_mutex. */
|
|
const char *(*get_name)(const struct vport *);
|
|
|
|
int (*send)(struct vport *, struct sk_buff *);
|
|
int (*get_egress_tun_info)(struct vport *, struct sk_buff *,
|
|
struct ovs_tunnel_info *);
|
|
|
|
struct module *owner;
|
|
struct list_head list;
|
|
};
|
|
|
|
enum vport_err_type {
|
|
VPORT_E_RX_DROPPED,
|
|
VPORT_E_RX_ERROR,
|
|
VPORT_E_TX_DROPPED,
|
|
VPORT_E_TX_ERROR,
|
|
};
|
|
|
|
struct vport *ovs_vport_alloc(int priv_size, const struct vport_ops *,
|
|
const struct vport_parms *);
|
|
void ovs_vport_free(struct vport *);
|
|
void ovs_vport_deferred_free(struct vport *vport);
|
|
|
|
#define VPORT_ALIGN 8
|
|
|
|
/**
|
|
* vport_priv - access private data area of vport
|
|
*
|
|
* @vport: vport to access
|
|
*
|
|
* If a nonzero size was passed in priv_size of vport_alloc() a private data
|
|
* area was allocated on creation. This allows that area to be accessed and
|
|
* used for any purpose needed by the vport implementer.
|
|
*/
|
|
static inline void *vport_priv(const struct vport *vport)
|
|
{
|
|
return (u8 *)(uintptr_t)vport + ALIGN(sizeof(struct vport), VPORT_ALIGN);
|
|
}
|
|
|
|
/**
|
|
* vport_from_priv - lookup vport from private data pointer
|
|
*
|
|
* @priv: Start of private data area.
|
|
*
|
|
* It is sometimes useful to translate from a pointer to the private data
|
|
* area to the vport, such as in the case where the private data pointer is
|
|
* the result of a hash table lookup. @priv must point to the start of the
|
|
* private data area.
|
|
*/
|
|
static inline struct vport *vport_from_priv(void *priv)
|
|
{
|
|
return (struct vport *)((u8 *)priv - ALIGN(sizeof(struct vport), VPORT_ALIGN));
|
|
}
|
|
|
|
void ovs_vport_receive(struct vport *, struct sk_buff *,
|
|
const struct ovs_tunnel_info *);
|
|
|
|
static inline void ovs_skb_postpush_rcsum(struct sk_buff *skb,
|
|
const void *start, unsigned int len)
|
|
{
|
|
if (skb->ip_summed == CHECKSUM_COMPLETE)
|
|
skb->csum = csum_add(skb->csum, csum_partial(start, len, 0));
|
|
}
|
|
|
|
int ovs_vport_ops_register(struct vport_ops *ops);
|
|
void ovs_vport_ops_unregister(struct vport_ops *ops);
|
|
|
|
static inline struct rtable *ovs_tunnel_route_lookup(struct net *net,
|
|
const struct ovs_key_ipv4_tunnel *key,
|
|
u32 mark,
|
|
struct flowi4 *fl,
|
|
u8 protocol)
|
|
{
|
|
struct rtable *rt;
|
|
|
|
memset(fl, 0, sizeof(*fl));
|
|
fl->daddr = key->ipv4_dst;
|
|
fl->saddr = key->ipv4_src;
|
|
fl->flowi4_tos = RT_TOS(key->ipv4_tos);
|
|
fl->flowi4_mark = mark;
|
|
fl->flowi4_proto = protocol;
|
|
|
|
rt = ip_route_output_key(net, fl);
|
|
return rt;
|
|
}
|
|
#endif /* vport.h */
|