912ad92220
The bug occurred to me when a UML left an empty ~/.uml/Sarge-norm folder - when trying to reuse not_dead_yet() failed one of its check. The comment says that's ok and means that we can take the directory, but while normally not_dead_yet() removes it and returns 0 (i.e. go on, use this), on failure it returns 0 but forgets to remove it. The fix is to remove it anytime we're going to return 0. But since "not_dead_yet" didn't make the interface so clear, causing this bug, and I couldn't find a convenient name for the mix of things it did, I split it into two parts: is_umdir_used() - returns a boolean, contains all checks of not_dead_yet() umdir_take_if_dead - tries to remove the dir unless it's used - returns whether it removed it, that is we now own it. With this changes the control flow is IMHO a bit clearer and needs less comment for control flow. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Cc: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> |
||
|---|---|---|
| .. | ||
| drivers | ||
| include | ||
| kernel | ||
| os-Linux | ||
| scripts | ||
| sys-i386 | ||
| sys-ia64 | ||
| sys-ppc | ||
| sys-x86_64 | ||
| config.release | ||
| defconfig | ||
| Kconfig | ||
| Kconfig.char | ||
| Kconfig.debug | ||
| Kconfig.i386 | ||
| Kconfig.net | ||
| Kconfig.scsi | ||
| Kconfig.x86_64 | ||
| Makefile | ||
| Makefile-i386 | ||
| Makefile-ia64 | ||
| Makefile-os-Linux | ||
| Makefile-ppc | ||
| Makefile-skas | ||
| Makefile-tt | ||
| Makefile-x86_64 | ||