linux/drivers/gpu/drm/rockchip
Thomas Hebb 1fe8005303 drm/rockchip: dsi: remove extra component_del() call
commit b354498bbe65c917d521b3b56317ddc9ab217425 upstream.

commit cf6d100dd2 ("drm/rockchip: dsi: add dual mipi support") added
this devcnt field and call to component_del(). However, these both
appear to be erroneous changes left over from an earlier version of the
patch. In the version merged, nothing ever modifies devcnt, meaning
component_del() runs unconditionally and in addition to the
component_del() calls in dw_mipi_dsi_rockchip_host_detach(). The second
call fails to delete anything and produces a warning in dmesg.

If we look at the previous version of the patch[1], however, we see that
it had logic to calculate devcnt and call component_add() in certain
situations. This was removed in v6, and the fact that the deletion code
was not appears to have been an oversight.

[1] https://patchwork.kernel.org/project/dri-devel/patch/20180821140515.22246-8-heiko@sntech.de/

Fixes: cf6d100dd2 ("drm/rockchip: dsi: add dual mipi support")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/201385acb0eeb5dfb037afdc6a94bfbcdab97f99.1618797778.git.tommyhebb@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-19 08:53:14 +02:00
..
analogix_dp-rockchip.c
cdn-dp-core.c
cdn-dp-core.h
cdn-dp-reg.c
cdn-dp-reg.h
dw_hdmi-rockchip.c
dw-mipi-dsi-rockchip.c drm/rockchip: dsi: remove extra component_del() call 2021-07-19 08:53:14 +02:00
inno_hdmi.c
inno_hdmi.h
Kconfig
Makefile
rk3066_hdmi.c
rk3066_hdmi.h
rockchip_drm_drv.c
rockchip_drm_drv.h
rockchip_drm_fb.c
rockchip_drm_fb.h
rockchip_drm_fbdev.c
rockchip_drm_fbdev.h
rockchip_drm_gem.c
rockchip_drm_gem.h
rockchip_drm_vop.c
rockchip_drm_vop.h
rockchip_lvds.c
rockchip_lvds.h
rockchip_rgb.c
rockchip_rgb.h
rockchip_vop_reg.c
rockchip_vop_reg.h