linux

Go to file

Ido Schimmel 9b37a7bcdd ipv4: Silence suspicious RCU usage warning [ Upstream commit `83f3522860` ] fib_trie_unmerge() is called with RTNL held, but not from an RCU read-side critical section. This leads to the following warning [1] when the FIB alias list in a leaf is traversed with hlist_for_each_entry_rcu(). Since the function is always called with RTNL held and since modification of the list is protected by RTNL, simply use hlist_for_each_entry() and silence the warning. [1] WARNING: suspicious RCU usage 5.8.0-rc4-custom-01520-gc1f937f3f83b #30 Not tainted ----------------------------- net/ipv4/fib_trie.c:1867 RCU-list traversed in non-reader section!! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by ip/164: #0: ffffffff85a27850 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x49a/0xbd0 stack backtrace: CPU: 0 PID: 164 Comm: ip Not tainted 5.8.0-rc4-custom-01520-gc1f937f3f83b #30 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-2.fc32 04/01/2014 Call Trace: dump_stack+0x100/0x184 lockdep_rcu_suspicious+0x153/0x15d fib_trie_unmerge+0x608/0xdb0 fib_unmerge+0x44/0x360 fib4_rule_configure+0xc8/0xad0 fib_nl_newrule+0x37a/0x1dd0 rtnetlink_rcv_msg+0x4f7/0xbd0 netlink_rcv_skb+0x17a/0x480 rtnetlink_rcv+0x22/0x30 netlink_unicast+0x5ae/0x890 netlink_sendmsg+0x98a/0xf40 ____sys_sendmsg+0x879/0xa00 ___sys_sendmsg+0x122/0x190 __sys_sendmsg+0x103/0x1d0 __x64_sys_sendmsg+0x7d/0xb0 do_syscall_64+0x54/0xa0 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7fc80a234e97 Code: Bad RIP value. RSP: 002b:00007ffef8b66798 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fc80a234e97 RDX: 0000000000000000 RSI: 00007ffef8b66800 RDI: 0000000000000003 RBP: 000000005f141b1c R08: 0000000000000001 R09: 0000000000000000 R10: 00007fc80a2a8ac0 R11: 0000000000000246 R12: 0000000000000001 R13: 0000000000000000 R14: 00007ffef8b67008 R15: 0000556fccb10020 Fixes: `0ddcf43d5d` ("ipv4: FIB Local/MAIN table collapse") Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-08-11 15:33:39 +02:00
Documentation	doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode	2020-07-22 09:32:59 +02:00
LICENSES	…
arch	Revert "powerpc/kasan: Fix shadow pages allocation failure"	2020-08-11 15:33:39 +02:00
block	block: fix get_max_segment_size() overflow on 32bit arch	2020-07-22 09:33:17 +02:00
certs	…
crypto	keys: asymmetric: fix error return code in software_key_query()	2020-07-22 09:33:04 +02:00
drivers	PCI: tegra: Revert tegra124 raw_violation_fixup	2020-08-11 15:33:39 +02:00
fs	xattr: break delegations in {set,remove}xattr	2020-08-11 15:33:39 +02:00
include	xattr: break delegations in {set,remove}xattr	2020-08-11 15:33:39 +02:00
init	…
ipc	…
kernel	perf/core: Fix endless multiplex timer	2020-08-11 15:33:32 +02:00
lib	random32: remove net_rand_state from the latent entropy gcc plugin	2020-08-07 09:34:01 +02:00
mm	mm/filemap.c: don't bother dropping mmap_sem for zero size readahead	2020-08-05 09:59:41 +02:00
net	ipv4: Silence suspicious RCU usage warning	2020-08-11 15:33:39 +02:00
samples	samples/vfs: avoid warning in statx override	2020-07-09 09:37:54 +02:00
scripts	scripts: add dummy report mode to add_namespace.cocci	2020-08-11 15:33:35 +02:00
security	Smack: fix use-after-free in smk_write_relabel_self()	2020-08-11 15:33:35 +02:00
sound	ALSA: hda: fix NULL pointer dereference during suspend	2020-08-11 15:33:37 +02:00
tools	tools lib traceevent: Fix memory leak in process_dynamic_array_len	2020-08-11 15:33:38 +02:00
usr	…
virt	KVM: arm64: Don't inherit exec permission across page-table levels	2020-08-05 09:59:51 +02:00
.clang-format	…
.cocciconfig	…
.get_maintainer.ignore	…
.gitattributes	…
.gitignore	…
.mailmap	…
COPYING	…
CREDITS	…
Kbuild	…
Kconfig	…
MAINTAINERS	…
Makefile	Linux 5.4.57	2020-08-07 09:34:02 +02:00
README	…

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.