Clang/scan-build complains about a possible buffer overflow in ieee80211_wx_get_name: .../staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c:499:3: warning: String copy function overflows destination buffer strcat(wrqu->name," link.."); .../staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c:497:3: warning: String copy function overflows destination buffer strcat(wrqu->name," linked"); The buffer wrqu->name is only IFNAMSIZ bytes big (currently 16), so if we have a "802.11b/g/n linked" device we overrun the buffer by 3 bytes. -> Use strlcopy / strlcat to populate the name. This is done in a similar fashion in staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c While at it cleaned some whitespace issues. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
---|---|---|
.. | ||
EndianFree.h | ||
Makefile | ||
aes.c | ||
arc4.c | ||
autoload.c | ||
cipher.c | ||
compress.c | ||
crypto_compat.h | ||
digest.c | ||
dot11d.c | ||
dot11d.h | ||
ieee80211.h | ||
ieee80211_crypt.c | ||
ieee80211_crypt.h | ||
ieee80211_crypt_ccmp.c | ||
ieee80211_crypt_tkip.c | ||
ieee80211_crypt_wep.c | ||
ieee80211_module.c | ||
ieee80211_rx.c | ||
ieee80211_softmac.c | ||
ieee80211_softmac_wx.c | ||
ieee80211_tx.c | ||
ieee80211_wx.c | ||
internal.h | ||
michael_mic.c | ||
proc.c | ||
rtl819x_BA.h | ||
rtl819x_BAProc.c | ||
rtl819x_HT.h | ||
rtl819x_HTProc.c | ||
rtl819x_Qos.h | ||
rtl819x_TS.h | ||
rtl819x_TSProc.c | ||
rtl_crypto.h | ||
scatterwalk.c | ||
scatterwalk.h |