linux/drivers/ptp
Vladis Dronov 4fd16cfcc3 ptp: free ptp device pin descriptors properly
[ Upstream commit 75718584cb ]

There is a bug in ptp_clock_unregister(), where ptp_cleanup_pin_groups()
first frees ptp->pin_{,dev_}attr, but then posix_clock_unregister() needs
them to destroy a related sysfs device.

These functions can not be just swapped, as posix_clock_unregister() frees
ptp which is needed in the ptp_cleanup_pin_groups(). Fix this by calling
ptp_cleanup_pin_groups() in ptp_clock_release(), right before ptp is freed.

This makes this patch fix an UAF bug in a patch which fixes an UAF bug.

Reported-by: Antti Laakso <antti.laakso@intel.com>
Fixes: a33121e548 ("ptp: fix the race between the release of ptp_clock and cdev")
Link: https://lore.kernel.org/netdev/3d2bd09735dbdaf003585ca376b7c1e5b69a19bd.camel@intel.com/
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-23 08:22:51 +01:00
..
Kconfig
Makefile
ptp_chardev.c ptp: Introduce strict checking of external time stamp options. 2019-11-15 12:48:32 -08:00
ptp_clock.c ptp: free ptp device pin descriptors properly 2020-01-23 08:22:51 +01:00
ptp_dte.c
ptp_ixp46x.c
ptp_kvm.c
ptp_pch.c
ptp_private.h ptp: fix the race between the release of ptp_clock and cdev 2020-01-04 19:18:48 +01:00
ptp_qoriq.c
ptp_qoriq_debugfs.c
ptp_sysfs.c