linux/net/ncsi
Johannes Berg d58ff35122 networking: make skb_push & __skb_push return void pointers
It seems like a historic accident that these return unsigned char *,
and in many places that means casts are required, more often than not.

Make these functions return void * and remove all the casts across
the tree, adding a (u8 *) cast only where the unsigned char pointer
was used directly, all done with the following spatch:

    @@
    expression SKB, LEN;
    typedef u8;
    identifier fn = { skb_push, __skb_push, skb_push_rcsum };
    @@
    - *(fn(SKB, LEN))
    + *(u8 *)fn(SKB, LEN)

    @@
    expression E, SKB, LEN;
    identifier fn = { skb_push, __skb_push, skb_push_rcsum };
    type T;
    @@
    - E = ((T *)(fn(SKB, LEN)))
    + E = fn(SKB, LEN)

    @@
    expression SKB, LEN;
    identifier fn = { skb_push, __skb_push, skb_push_rcsum };
    @@
    - fn(SKB, LEN)[0]
    + *(u8 *)fn(SKB, LEN)

Note that the last part there converts from push(...)[0] to the
more idiomatic *(u8 *)push(...).

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:40 -04:00
..
Kconfig net/ncsi: Resource management 2016-07-19 20:49:16 -07:00
Makefile net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00
internal.h net/ncsi: Choose hot channel as active one if necessary 2016-10-20 11:23:07 -04:00
ncsi-aen.c net/ncsi: Improve HNCDSC AEN handler 2016-10-20 11:23:08 -04:00
ncsi-cmd.c networking: make skb_push & __skb_push return void pointers 2017-06-16 11:48:40 -04:00
ncsi-manage.c net/ncsi: Choose hot channel as active one if necessary 2016-10-20 11:23:07 -04:00
ncsi-pkt.h net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00
ncsi-rsp.c net/ncsi: Rework the channel monitoring 2016-10-04 02:11:51 -04:00