linux/drivers/atm
Sasha Levin b67bfe0d42 hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived

        list_for_each_entry(pos, head, member)

The hlist ones were greedy and wanted an extra parameter:

        hlist_for_each_entry(tpos, pos, head, member)

Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.

Besides the semantic patch, there was some manual work required:

 - Fix up the actual hlist iterators in linux/list.h
 - Fix up the declaration of other iterators based on the hlist ones.
 - A very small amount of places were using the 'node' parameter, this
 was modified to use 'obj->member' instead.
 - Coccinelle didn't handle the hlist_for_each_entry_safe iterator
 properly, so those had to be fixed up manually.

The semantic patch which is mostly the work of Peter Senna Tschudin is here:

@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;

type T;
expression a,c,d,e;
identifier b;
statement S;
@@

-T b;
    <+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
    ...+>

[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-27 19:10:24 -08:00
..
.gitignore
Kconfig Update broken web addresses in the kernel. 2010-10-18 11:03:14 +02:00
Makefile Drivers: atm: Makefile: replace the use of <module>-objs with <module>-y 2010-10-21 03:09:48 -07:00
adummy.c atm: correct sysfs 'device' link creation and parent relationships 2010-12-10 15:45:05 -08:00
ambassador.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
ambassador.h ATM: Delete no use FILL_RX_POOLS_IN_BH marco 2011-07-08 09:06:31 -07:00
atmtcp.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
eni.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
eni.h eni: fix driver remove function and driver probe error path. 2012-03-16 23:13:20 -07:00
firestream.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
firestream.h
fore200e.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
fore200e.h Fix common misspellings 2011-03-31 11:26:23 -03:00
he.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
he.h
horizon.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
horizon.h
idt77105.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
idt77105.h
idt77252.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
idt77252.h Fix common misspellings 2011-03-31 11:26:23 -03:00
idt77252_tables.h
iphase.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
iphase.h atm/iphase: rename fregt_t -> ffreg_t 2013-02-08 14:22:05 -05:00
lanai.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
midway.h
nicstar.c atm/nicstar: convert to idr_alloc() 2013-02-27 19:10:15 -08:00
nicstar.h
nicstarmac.c
nicstarmac.copyright
solos-attrlist.c solos: Add 'Firmware' attribute for Traverse overall firmware version 2010-11-08 12:17:04 -08:00
solos-pci.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
suni.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
suni.h
tonga.h
uPD98401.h
uPD98402.c atomic: use <linux/atomic.h> 2011-07-26 16:49:47 -07:00
uPD98402.h
zatm.c Drivers: atm: remove __dev* attributes. 2013-01-03 15:57:04 -08:00
zatm.h
zeprom.h