linux/drivers/net/cxgb3
Roland Dreier b1186dee3e cxgb3: Fix lockdep problems with sge.reg_lock
Using iWARP with a Chelsio T3 NIC generates the following lockdep warning:

    =================================
    [ INFO: inconsistent lock state ]
    2.6.25-rc6 #50
    ---------------------------------
    inconsistent {softirq-on-W} -> {in-softirq-W} usage.
    swapper/0 [HC0[0]:SC1[1]:HE0:SE0] takes:
     (&adap->sge.reg_lock){-+..}, at: [<ffffffff880e5ee2>] cxgb_offload_ctl+0x3af/0x507 [cxgb3]

The problem is that reg_lock is used with plain spin_lock() in
drivers/net/cxgb3/sge.c but is used with spin_lock_irqsave() in
drivers/net/cxgb3/cxgb3_offload.c.  This is technically a false
positive, since the uses in sge.c are only in the initialization and
cleanup paths and cannot overlap with any use in interrupt context.

The best fix is probably just to use spin_lock_irq() with reg_lock in
sge.c.  Even though it's not strictly required for correctness, it
avoids triggering lockdep and the extra overhead of disabling
interrupts is not important at all in the initialization and cleanup
slow paths.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2008-03-25 23:42:05 -04:00
..
Makefile Add support for the latest 1G/10G Chelsio adapter, T3. 2007-02-05 16:58:46 -05:00
adapter.h cxgb3 - parity initialization for T3C adapters. 2008-01-28 15:07:22 -08:00
ael1002.c cxgb3 - Fix direct XAUI support 2007-06-20 19:16:58 -04:00
common.h annotate cxgb3 2008-01-28 15:10:30 -08:00
cxgb3_ctl_defs.h cxgb3 - Expose HW memory page info 2007-10-10 16:50:49 -07:00
cxgb3_defs.h cxgb3 - tighten checks on TID values 2007-10-10 16:50:49 -07:00
cxgb3_ioctl.h cxgb3 - private ioctl cleanup 2007-02-27 04:27:12 -05:00
cxgb3_main.c annotate cxgb3 2008-01-28 15:10:30 -08:00
cxgb3_offload.c is_vmalloc_addr(): Check if an address is within the vmalloc boundaries 2008-02-05 09:44:14 -08:00
cxgb3_offload.h cxgb3 - Fix dev->priv usage 2007-08-31 07:29:08 -04:00
firmware_exports.h drivers/net/cxgb3: trim trailing whitespace 2008-01-28 15:04:13 -08:00
l2t.c cxgb3: Handle ARP completions that mark neighbors stale. 2008-02-11 11:09:17 -05:00
l2t.h cxgb3 Fix copyrights in the cxgb3 driver. 2007-02-17 15:30:46 -05:00
mc5.c cxgb3: Remove incorrect __devinit annotations 2008-02-03 04:28:35 -08:00
regs.h cxgb3 - parity initialization for T3C adapters. 2008-01-28 15:07:22 -08:00
sge.c cxgb3: Fix lockdep problems with sge.reg_lock 2008-03-25 23:42:05 -04:00
sge_defs.h cxgb3 - Set the CQ_ERR bit in CQ contexts. 2007-10-10 16:51:05 -07:00
t3_cpl.h cxgb3 - Add dual licensing 2007-02-05 16:58:51 -05:00
t3_hw.c cxgb3: Remove incorrect __devinit annotations 2008-02-03 04:28:35 -08:00
t3cdev.h cxgb3 - Fix dev->priv usage 2007-08-31 07:29:08 -04:00
version.h cxgb3 - FW upgrade 2008-01-28 15:04:09 -08:00
vsc8211.c cxgb3 - Add dual licensing 2007-02-05 16:58:51 -05:00
xgmac.c drivers/net/cxgb3: trim trailing whitespace 2008-01-28 15:04:13 -08:00