linux/net/batman-adv
Antonio Quartulli b27b36d5d0 batman-adv: avoid NULL dereferences and fix if check
[ Upstream commit 0d16449195 ]

Gateway having bandwidth_down equal to zero are not accepted
at all and so never added to the Gateway list.
For this reason checking the bandwidth_down member in
batadv_gw_out_of_range() is useless.

This is probably a copy/paste error and this check was supposed
to be "!gw_node" only. Moreover, the way the check is written
now may also lead to a NULL dereference.

Fix this by rewriting the if-condition properly.

Introduced by 414254e342
("batman-adv: tvlv - gateway download/upload bandwidth container")

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-27 08:18:53 -08:00
..
bat_algo.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
bat_iv_ogm.c batman-adv: fix neigh_ifinfo imbalance 2014-05-31 13:20:37 -07:00
bitarray.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
bitarray.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
bridge_loop_avoidance.c batman-adv: use consistent kerneldoc style 2014-01-16 00:16:00 +01:00
bridge_loop_avoidance.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
debugfs.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
debugfs.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
distributed-arp-table.c batman-adv: fix local TT check for outgoing arp requests in DAT 2014-05-31 13:20:39 -07:00
distributed-arp-table.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
fragmentation.c batman-adv: Unify fragment size calculation 2015-01-27 08:18:53 -08:00
fragmentation.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
gateway_client.c batman-adv: avoid NULL dereferences and fix if check 2015-01-27 08:18:53 -08:00
gateway_client.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
gateway_common.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
gateway_common.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
hard-interface.c batman: fix a bogus warning from batadv_is_on_batman_iface() 2014-12-06 15:55:39 -08:00
hard-interface.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
hash.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
hash.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
icmp_socket.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
icmp_socket.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
Kconfig Revert "batman-adv: drop dependency against CRC16" 2014-01-15 16:54:14 -08:00
main.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2014-01-18 00:55:41 -08:00
main.h batman-adv: Start new development cycle 2014-01-12 14:41:20 +01:00
Makefile batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
network-coding.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
network-coding.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
originator.c batman-adv: fix indirect hard_iface NULL dereference 2014-05-31 13:20:38 -07:00
originator.h batman-adv: avoid potential race condition when adding a new neighbour 2014-02-17 17:17:01 +01:00
packet.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
routing.c batman-adv: free skb on TVLV parsing success 2014-02-17 17:17:02 +01:00
routing.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
send.c batman-adv: fix potential kernel paging error for unicast transmissions 2014-02-17 17:17:02 +01:00
send.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
soft-interface.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
soft-interface.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
sysfs.c batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
sysfs.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
translation-table.c batman-adv: fix TT CRC computation by ensuring byte order 2014-02-17 17:17:02 +01:00
translation-table.h batman-adv: update copyright years for 2014 2014-01-12 14:41:19 +01:00
types.h batman-adv: use consistent kerneldoc style 2014-01-16 00:16:00 +01:00