5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
148 lines
3.5 KiB
C
148 lines
3.5 KiB
C
/*
|
|
* Detection routine for the NCR53c710 based Amiga SCSI Controllers for Linux.
|
|
* Amiga Technologies A4000T SCSI controller.
|
|
*
|
|
* Written 1997 by Alan Hourihane <alanh@fairlite.demon.co.uk>
|
|
* plus modifications of the 53c7xx.c driver to support the Amiga.
|
|
*
|
|
* Rewritten to use 53c700.c by Kars de Jong <jongk@linux-m68k.org>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/slab.h>
|
|
#include <asm/amigahw.h>
|
|
#include <asm/amigaints.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <scsi/scsi_transport_spi.h>
|
|
|
|
#include "53c700.h"
|
|
|
|
MODULE_AUTHOR("Alan Hourihane <alanh@fairlite.demon.co.uk> / Kars de Jong <jongk@linux-m68k.org>");
|
|
MODULE_DESCRIPTION("Amiga A4000T NCR53C710 driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|
|
static struct scsi_host_template a4000t_scsi_driver_template = {
|
|
.name = "A4000T builtin SCSI",
|
|
.proc_name = "A4000t",
|
|
.this_id = 7,
|
|
.module = THIS_MODULE,
|
|
};
|
|
|
|
static struct platform_device *a4000t_scsi_device;
|
|
|
|
#define A4000T_SCSI_ADDR 0xdd0040
|
|
|
|
static int __devinit a4000t_probe(struct platform_device *dev)
|
|
{
|
|
struct Scsi_Host *host;
|
|
struct NCR_700_Host_Parameters *hostdata;
|
|
|
|
if (!(MACH_IS_AMIGA && AMIGAHW_PRESENT(A4000_SCSI)))
|
|
goto out;
|
|
|
|
if (!request_mem_region(A4000T_SCSI_ADDR, 0x1000,
|
|
"A4000T builtin SCSI"))
|
|
goto out;
|
|
|
|
hostdata = kzalloc(sizeof(struct NCR_700_Host_Parameters), GFP_KERNEL);
|
|
if (!hostdata) {
|
|
printk(KERN_ERR "a4000t-scsi: Failed to allocate host data\n");
|
|
goto out_release;
|
|
}
|
|
|
|
/* Fill in the required pieces of hostdata */
|
|
hostdata->base = (void __iomem *)ZTWO_VADDR(A4000T_SCSI_ADDR);
|
|
hostdata->clock = 50;
|
|
hostdata->chip710 = 1;
|
|
hostdata->dmode_extra = DMODE_FC2;
|
|
hostdata->dcntl_extra = EA_710;
|
|
|
|
/* and register the chip */
|
|
host = NCR_700_detect(&a4000t_scsi_driver_template, hostdata,
|
|
&dev->dev);
|
|
if (!host) {
|
|
printk(KERN_ERR "a4000t-scsi: No host detected; "
|
|
"board configuration problem?\n");
|
|
goto out_free;
|
|
}
|
|
|
|
host->this_id = 7;
|
|
host->base = A4000T_SCSI_ADDR;
|
|
host->irq = IRQ_AMIGA_PORTS;
|
|
|
|
if (request_irq(host->irq, NCR_700_intr, IRQF_SHARED, "a4000t-scsi",
|
|
host)) {
|
|
printk(KERN_ERR "a4000t-scsi: request_irq failed\n");
|
|
goto out_put_host;
|
|
}
|
|
|
|
platform_set_drvdata(dev, host);
|
|
scsi_scan_host(host);
|
|
|
|
return 0;
|
|
|
|
out_put_host:
|
|
scsi_host_put(host);
|
|
out_free:
|
|
kfree(hostdata);
|
|
out_release:
|
|
release_mem_region(A4000T_SCSI_ADDR, 0x1000);
|
|
out:
|
|
return -ENODEV;
|
|
}
|
|
|
|
static __devexit int a4000t_device_remove(struct platform_device *dev)
|
|
{
|
|
struct Scsi_Host *host = platform_get_drvdata(dev);
|
|
struct NCR_700_Host_Parameters *hostdata = shost_priv(host);
|
|
|
|
scsi_remove_host(host);
|
|
|
|
NCR_700_release(host);
|
|
kfree(hostdata);
|
|
free_irq(host->irq, host);
|
|
release_mem_region(A4000T_SCSI_ADDR, 0x1000);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver a4000t_scsi_driver = {
|
|
.driver = {
|
|
.name = "a4000t-scsi",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
.probe = a4000t_probe,
|
|
.remove = __devexit_p(a4000t_device_remove),
|
|
};
|
|
|
|
static int __init a4000t_scsi_init(void)
|
|
{
|
|
int err;
|
|
|
|
err = platform_driver_register(&a4000t_scsi_driver);
|
|
if (err)
|
|
return err;
|
|
|
|
a4000t_scsi_device = platform_device_register_simple("a4000t-scsi",
|
|
-1, NULL, 0);
|
|
if (IS_ERR(a4000t_scsi_device)) {
|
|
platform_driver_unregister(&a4000t_scsi_driver);
|
|
return PTR_ERR(a4000t_scsi_device);
|
|
}
|
|
|
|
return err;
|
|
}
|
|
|
|
static void __exit a4000t_scsi_exit(void)
|
|
{
|
|
platform_device_unregister(a4000t_scsi_device);
|
|
platform_driver_unregister(&a4000t_scsi_driver);
|
|
}
|
|
|
|
module_init(a4000t_scsi_init);
|
|
module_exit(a4000t_scsi_exit);
|