linux/arch/powerpc/platforms
Srivatsa S. Bhat f274ef8747 powerpc/pseries: Always enable CONFIG_HOTPLUG_CPU on PSERIES SMP
Adam Lackorzynski reported the following build failure on
!CONFIG_HOTPLUG_CPU configuration:

  CC      arch/powerpc/kernel/rtas.o
arch/powerpc/kernel/rtas.c: In function ‘rtas_cpu_state_change_mask’:
arch/powerpc/kernel/rtas.c:843:4: error: implicit declaration of function ‘cpu_down’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[1]: *** [arch/powerpc/kernel/rtas.o] Error 1
make: *** [arch/powerpc/kernel] Error 2

The build fails because cpu_down() is defined only under CONFIG_HOTPLUG_CPU.

Looking further, the mobility code in pseries is one of the call-sites which
uses rtas_ibm_suspend_me(), which in turn calls rtas_cpu_state_change_mask().
And the mobility code is unconditionally compiled-in (it does not fall under
any Kconfig option). And commit 120496ac (powerpc: Bring all threads online
prior to migration/hibernation) which introduced this build regression is
critical for the proper functioning of the migration code. So it appears
that the only solution to this problem is to enable CONFIG_HOTPLUG_CPU if
SMP is enabled on PPC_PSERIES platforms. So make that change in the Kconfig.

Reported-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: stable@vger.kernel.org
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-06-01 08:29:27 +10:00
..
8xx
40x Removal of GENERIC_GPIO for v3.10 2013-05-09 09:59:16 -07:00
44x Removal of GENERIC_GPIO for v3.10 2013-05-09 09:59:16 -07:00
52xx
82xx
83xx
85xx Removal of GENERIC_GPIO for v3.10 2013-05-09 09:59:16 -07:00
86xx
512x Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc 2013-05-02 10:16:16 -07:00
amigaone
cell powerpc/cell/iommu: Improve error message for missing node 2013-05-06 12:03:49 +10:00
chrp
embedded6xx powerpc/pci: Support per-aperture memory offset 2013-05-06 13:40:40 +10:00
maple
pasemi
powermac powerpc/pci: Support per-aperture memory offset 2013-05-06 13:40:40 +10:00
powernv powerpc/powernv: Build a zImage.epapr 2013-05-24 18:13:46 +10:00
ps3 powerpc: Decode the pte-lp-encoding bits correctly. 2013-04-30 16:00:14 +10:00
pseries powerpc/pseries: Always enable CONFIG_HOTPLUG_CPU on PSERIES SMP 2013-06-01 08:29:27 +10:00
wsp powerpc: Fix irq_set_affinity() return values 2013-05-14 16:00:18 +10:00
Kconfig Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc 2013-05-14 07:43:11 -07:00
Kconfig.cputype Merge remote-tracking branch 'kumar/next' into next 2013-04-30 11:10:09 +10:00
Makefile
fsl_uli1575.c