linux/drivers/char/pcmcia
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
Kconfig char/pcmcia: add scr24x_cs chip card interface driver 2016-11-10 17:03:36 +01:00
Makefile char/pcmcia: add scr24x_cs chip card interface driver 2016-11-10 17:03:36 +01:00
cm4000_cs.c lib/vsprintf.c: remove %Z support 2017-02-27 18:43:47 -08:00
cm4040_cs.c pcmcia: remove left-over %Z format 2017-06-02 15:07:37 -07:00
cm4040_cs.h
scr24x_cs.c char/pcmcia: add some error checking in scr24x_read() 2016-11-29 20:43:12 +01:00
synclink_cs.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00