OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/block
History
Ming Lei 2434af79c8 blk-mq: Revert "blk-mq: reimplement blk_mq_hw_queue_mapped" 
This reverts commit 127276c6ce.

When all CPUs of one hw queue become offline, there still may have IOs
not completed from this hctx. But blk_mq_hw_queue_mapped() is called in
blk_mq_queue_tag_busy_iter(), which is used for iterating request in timeout
handler, timeout event will be missed on the inactive hctx, then request may
never be completed.

Also the replementation of blk_mq_hw_queue_mapped() doesn't match the helper's
name any more, and it should have been named as blk_mq_hw_queue_active().

Even other callers need further verification about this reimplemenation.

So revert this patch now, and we can improve hw queue activate/inactivate event
after adequent researching and test.

Cc: Stefan Haberland <sth@linux.vnet.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>
Reported-by: Jens Axboe <axboe@kernel.dk>
Fixes: 	127276c6ce ("blk-mq: reimplement blk_mq_hw_queue_mapped")
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
 		2018-04-11 07:59:15 -06:00
..
partitions partitions/msdos: Unable to mount UFS 44bsd partitions 2018-01-10 09:12:16 -07:00
Kconfig
…
Kconfig.iosched
…
Makefile
…
badblocks.c
…
bfq-cgroup.c block, bfq: put async queues for root bfq groups too 2018-01-09 08:45:25 -07:00
bfq-iosched.c block, bfq: lower-bound the estimated peak rate to 1 2018-03-26 10:18:27 -06:00
bfq-iosched.h block, bfq: lower-bound the estimated peak rate to 1 2018-03-26 10:18:27 -06:00
bfq-wf2q.c block, bfq: limit sectors served with interactive weight raising 2018-01-18 08:21:37 -07:00
bio-integrity.c block: Fix __bio_integrity_endio() documentation 2018-01-17 09:59:33 -07:00
bio.c Fix slab name "biovec-(1<<(21-12))" 2018-03-21 19:25:22 -06:00
blk-cgroup.c blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir() 2018-03-16 10:35:12 -06:00
blk-core.c blk-mq: Avoid that submitting a bio concurrently with device removal triggers a crash 2018-04-10 17:46:40 -06:00
blk-exec.c blk-mq-sched: remove unused 'can_block' arg from blk_mq_sched_insert_request 2018-01-17 09:49:21 -07:00
blk-flush.c
…
blk-integrity.c
…
blk-ioc.c
…
blk-lib.c block: add bdev_read_only() checks to common helpers 2018-01-18 12:57:19 -07:00
blk-map.c Merge branch 'for-4.16/block' of git://git.kernel.dk/linux-block 2018-01-29 11:51:49 -08:00
blk-merge.c blk-mq: fix discard merge with scheduler attached 2018-02-01 14:01:02 -07:00
blk-mq-cpumap.c blk-mq: don't keep offline CPUs mapped to hctx 0 2018-04-10 08:38:46 -06:00
blk-mq-debugfs.c blk-mq: remove blk_mq_delay_queue() 2018-04-10 08:38:46 -06:00
blk-mq-debugfs.h
…
blk-mq-pci.c blk-mq: Allow PCI vector offset for mapping queues 2018-03-27 21:25:36 -06:00
blk-mq-rdma.c
…
blk-mq-sched.c blk-mq-sched: Enable merging discard bio into request 2018-02-01 14:45:11 -07:00
blk-mq-sched.h blk-mq-sched: remove unused 'can_block' arg from blk_mq_sched_insert_request 2018-01-17 09:49:21 -07:00
blk-mq-sysfs.c block: properly protect the 'queue' kobj in blk_unregister_queue 2018-01-15 08:41:38 -07:00
blk-mq-tag.c blk-mq: improve heavily contended tag case 2017-12-22 11:09:37 -07:00
blk-mq-tag.h Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block 2017-11-14 15:32:19 -08:00
blk-mq-virtio.c
…
blk-mq.c blk-mq: remove code for dealing with remapping queue 2018-04-10 08:38:46 -06:00
blk-mq.h blk-mq: Revert "blk-mq: reimplement blk_mq_hw_queue_mapped" 2018-04-11 07:59:15 -06:00
blk-settings.c block: Introduce blk_queue_flag_{set,clear,test_and_{set,clear}}() 2018-03-08 14:13:48 -07:00
blk-softirq.c
…
blk-stat.c block: Protect queue flag changes with the queue lock 2018-03-08 14:13:48 -07:00
blk-stat.h
…
blk-sysfs.c block: Introduce blk_queue_flag_{set,clear,test_and_{set,clear}}() 2018-03-08 14:13:48 -07:00
blk-tag.c
…
blk-throttle.c Merge branch 'for-4.16/block' of git://git.kernel.dk/linux-block 2018-01-29 11:51:49 -08:00
blk-timeout.c blk-mq: Directly schedule q->timeout_work when aborting a request 2018-04-02 16:36:13 -06:00
blk-wbt.c blk-wbt: account flush requests correctly 2018-02-06 14:14:03 -07:00
blk-wbt.h
…
blk-zoned.c block: Suppress kernel-doc warnings triggered by blk-zoned.c 2018-03-09 08:23:32 -07:00
blk.h block: Move the queue_flag_*() functions from a public into a private header file 2018-03-08 14:13:48 -07:00
bounce.c treewide: simplify Kconfig dependencies for removed archs 2018-03-26 15:55:57 +02:00
bsg-lib.c bsg: split handling of SCSI CDBs vs transport requeues 2018-03-13 11:40:24 -06:00
bsg.c bsg: split handling of SCSI CDBs vs transport requeues 2018-03-13 11:40:24 -06:00
cfq-iosched.c
…
cmdline-parser.c
…
compat_ioctl.c
…
deadline-iosched.c deadline-iosched: Introduce zone locking support 2018-01-05 09:22:17 -07:00
elevator.c block: Document scheduler modification locking requirements 2018-01-18 12:54:42 -07:00
genhd.c block, char_dev: Use correct format specifier for unsigned ints 2018-03-15 17:59:24 +01:00
ioctl.c block: pass inclusive 'lend' parameter to truncate_inode_pages_range 2018-02-23 15:20:19 -07:00
ioprio.c
…
kyber-iosched.c block: kyber: fix domain token leak during requeue 2018-02-24 15:55:54 -07:00
mq-deadline.c mq-deadline: Make sure to always unlock zones 2018-03-01 08:39:24 -07:00
noop-iosched.c
…
opal_proto.h
…
partition-generic.c block: display the correct diskname for bio 2018-03-01 08:41:25 -07:00
scsi_ioctl.c block: silently forbid sending any ioctl to a partition 2018-01-10 12:30:37 -07:00
sed-opal.c for-4.17/block-20180402 2018-04-05 14:27:02 -07:00
t10-pi.c
…