linux/drivers/usb/serial
Johan Hovold 9258106980 USB: serial: iuu_phoenix: fix led-activity helpers
[ Upstream commit de37458f8c ]

The set-led command is eight bytes long and starts with a command byte
followed by six bytes of RGB data and ends with a byte encoding a
frequency (see iuu_led() and iuu_rgbf_fill_buffer()).

The led activity helpers had a few long-standing bugs which corrupted
the command packets by inserting a second command byte and thereby
offsetting the RGB data and dropping the frequency in non-xmas mode.

In xmas mode, a related off-by-one error left the frequency field
uninitialised.

Fixes: 60a8fc0171 ("USB: add iuu_phoenix driver")
Reported-by: George Spelvin <lkml@sdf.org>
Link: https://lore.kernel.org/r/20200716085056.31471-1-johan@kernel.org
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-19 08:16:14 +02:00
..
Kconfig docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
Makefile
Makefile-keyspan_pda_fw
aircable.c
ark3116.c USB: serial: ark3116: drop redundant init_termios 2019-04-26 08:37:53 +02:00
belkin_sa.c docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
belkin_sa.h docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
bus.c
ch341.c USB: serial: ch341: add new Product ID for CH340 2020-07-22 09:33:10 +02:00
console.c
cp210x.c usb-serial: cp201x: support Mark-10 digital force gauge 2019-11-29 10:10:23 +01:00
cyberjack.c
cypress_m8.c USB: serial: cypress_m8: enable Simply Automated UPB PIM 2020-07-22 09:33:10 +02:00
cypress_m8.h USB: serial: cypress_m8: enable Simply Automated UPB PIM 2020-07-22 09:33:10 +02:00
digi_acceleport.c USB: serial: digi_acceleport: clean up set_termios 2019-04-21 14:24:12 +02:00
empeg.c docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
ezusb_convert.pl
f81232.c USB: serial: f81232: implement break control 2019-05-03 09:19:55 +02:00
f81534.c
ftdi_sio.c USB: serial: ftdi_sio: add device IDs for U-Blox C099-F9P 2019-12-04 22:30:48 +01:00
ftdi_sio.h
ftdi_sio_ids.h USB: serial: ftdi_sio: add device IDs for U-Blox C099-F9P 2019-12-04 22:30:48 +01:00
garmin_gps.c USB: serial: garmin_gps: add sanity checking for data length 2020-05-14 07:58:25 +02:00
generic.c USB: serial: drop unnecessary goto 2019-04-30 10:25:04 +02:00
io_16654.h
io_edgeport.c USB: serial: io_edgeport: fix slab-out-of-bounds read in edge_interrupt_callback 2020-04-01 11:02:15 +02:00
io_edgeport.h
io_ionsp.h
io_ti.c
io_ti.h
io_usbvend.h
ipaq.c
ipw.c
ir-usb.c USB: serial: ir-usb: fix IrLAP framing 2020-02-01 09:34:32 +00:00
iuu_phoenix.c USB: serial: iuu_phoenix: fix led-activity helpers 2020-08-19 08:16:14 +02:00
iuu_phoenix.h
keyspan.c USB: serial: keyspan: handle unbound ports 2020-01-23 08:22:34 +01:00
keyspan_pda.c docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
keyspan_usa26msg.h USB: serial: keyspan_usa: add proper SPDX lines for .h files 2019-01-18 11:09:32 +01:00
keyspan_usa28msg.h USB: serial: keyspan_usa: add proper SPDX lines for .h files 2019-01-18 11:09:32 +01:00
keyspan_usa49msg.h USB: serial: keyspan_usa: add proper SPDX lines for .h files 2019-01-18 11:09:32 +01:00
keyspan_usa67msg.h USB: serial: keyspan_usa: add proper SPDX lines for .h files 2019-01-18 11:09:32 +01:00
keyspan_usa90msg.h USB: serial: keyspan_usa: add proper SPDX lines for .h files 2019-01-18 11:09:32 +01:00
kl5kusb105.c
kl5kusb105.h
kobil_sct.c
kobil_sct.h
mct_u232.c
mct_u232.h
metro-usb.c
mos7720.c USB: serial: mos7720: fix remote wakeup 2019-11-29 10:10:26 +01:00
mos7840.c USB: serial: mos7840: fix remote wakeup 2019-11-29 10:10:27 +01:00
mxuport.c
navman.c
omninet.c docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
opticon.c USB: serial: opticon: fix control-message timeouts 2020-01-23 08:22:34 +01:00
option.c USB: serial: option: add Quectel EG95 LTE modem 2020-07-22 09:33:11 +02:00
oti6858.c docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
oti6858.h
pl2303.c USB: serial: pl2303: add device-id for HP LD381 2020-03-25 08:25:50 +01:00
pl2303.h USB: serial: pl2303: add device-id for HP LD381 2020-03-25 08:25:50 +01:00
qcaux.c
qcserial.c USB: serial: qcserial: add EM7305 QDL product ID 2020-08-11 15:33:32 +02:00
quatech2.c USB: serial: quatech2: handle unbound ports 2020-01-23 08:22:35 +01:00
safe_serial.c
sierra.c
spcp8x5.c USB: serial: spcp8x5: simplify init_termios 2019-04-26 08:38:02 +02:00
ssu100.c
symbolserial.c
ti_usb_3410_5052.c USB: serial: ti_usb_3410_5052: clean up serial data access 2019-10-16 10:29:23 +02:00
upd78f0730.c
usb-serial-simple.c USB: serial: simple: Add Motorola Solutions TETRA MTP3xxx and MTP85xx 2020-01-23 08:22:33 +01:00
usb-serial.c USB: serial: suppress driver bind attributes 2020-01-23 08:22:34 +01:00
usb-wwan.h USB: serial: option: add ZLP support for 0x1bc7/0x9010 2020-01-14 20:08:30 +01:00
usb_debug.c
usb_wwan.c USB: serial: usb_wwan: do not resubmit rx urb on fatal errors 2020-06-10 20:24:55 +02:00
visor.c docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
visor.h docs: usb: rename files to .rst and add them to drivers-api 2019-06-20 14:28:36 +02:00
whiteheat.c USB: serial: whiteheat: fix line-speed endianness 2019-10-30 10:06:32 +01:00
whiteheat.h USB: serial: whiteheat: fix line-speed endianness 2019-10-30 10:06:32 +01:00
wishbone-serial.c
xsens_mt.c