linux/net/l2tp
Sasha Levin 5a47f7ed64 net/l2tp: don't fall back on UDP [get|set]sockopt
commit 3cf521f7dc upstream.

The l2tp [get|set]sockopt() code has fallen back to the UDP functions
for socket option levels != SOL_PPPOL2TP since day one, but that has
never actually worked, since the l2tp socket isn't an inet socket.

As David Miller points out:

  "If we wanted this to work, it'd have to look up the tunnel and then
   use tunnel->sk, but I wonder how useful that would be"

Since this can never have worked so nobody could possibly have depended
on that functionality, just remove the broken code and return -EINVAL.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: James Chapman <jchapman@katalix.com>
Acked-by: David Miller <davem@davemloft.net>
Cc: Phil Turnbull <phil.turnbull@oracle.com>
Cc: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Willy Tarreau <w@1wt.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-07 14:52:39 -07:00
..
Kconfig
Makefile
l2tp_core.c l2tp: fix manual sequencing (de)activation in L2TPv2 2014-03-06 14:25:39 -05:00
l2tp_core.h l2tp: fix manual sequencing (de)activation in L2TPv2 2014-03-06 14:25:39 -05:00
l2tp_debugfs.c ipv6: make lookups simpler and faster 2013-10-09 00:01:25 -04:00
l2tp_eth.c
l2tp_ip.c net: add build-time checks for msg->msg_name size 2014-01-18 23:04:16 -08:00
l2tp_ip6.c ipv6: protect protocols not handling ipv4 from v4 connection/bind attempts 2014-01-21 16:59:19 -08:00
l2tp_netlink.c l2tp: fix manual sequencing (de)activation in L2TPv2 2014-03-06 14:25:39 -05:00
l2tp_ppp.c net/l2tp: don't fall back on UDP [get|set]sockopt 2014-08-07 14:52:39 -07:00