linux/drivers/net/wireless/intel
Bolarinwa Olayemi Saheed ff3fde9d45 iwlegacy: Check the return value of pcie_capability_read_*()
[ Upstream commit 9018fd7f2a ]

On failure pcie_capability_read_dword() sets it's last parameter, val
to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
failure. This would introduce a bug because (x & x) == (~0 & x).

This bug can be avoided without changing the function's behaviour if the
return value of pcie_capability_read_dword is checked to confirm success.

Check the return value of pcie_capability_read_dword() to ensure success.

Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200713175529.29715-3-refactormyself@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-19 08:16:04 +02:00
..
ipw2x00
iwlegacy iwlegacy: Check the return value of pcie_capability_read_*() 2020-08-19 08:16:04 +02:00
iwlwifi iwlwifi: mvm: don't call iwl_mvm_free_inactive_queue() under RCU 2020-07-29 10:18:41 +02:00
Kconfig
Makefile