linux/net/x25
Hannes Frederic Sowa f3d3342602 net: rework recvmsg handler msg_name and msg_namelen logic
This patch now always passes msg->msg_namelen as 0. recvmsg handlers must
set msg_namelen to the proper size <= sizeof(struct sockaddr_storage)
to return msg_name to the user.

This prevents numerous uninitialized memory leaks we had in the
recvmsg handlers and makes it harder for new code to accidentally leak
uninitialized memory.

Optimize for the case recvfrom is called with NULL as address. We don't
need to copy the address at all, so set it to NULL before invoking the
recvmsg handler. We can do so, because all the recvmsg handlers must
cope with the case a plain read() is called on them. read() also sets
msg_name to NULL.

Also document these changes in include/linux/net.h as suggested by David
Miller.

Changes since RFC:

Set msg->msg_name = NULL if user specified a NULL in msg_name but had a
non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't
affect sendto as it would bail out earlier while trying to copy-in the
address. It also more naturally reflects the logic by the callers of
verify_iovec.

With this change in place I could remove "
if (!uaddr || msg_sys->msg_namelen == 0)
	msg->msg_name = NULL
".

This change does not alter the user visible error logic as we ignore
msg_namelen as long as msg_name is NULL.

Also remove two unnecessary curly brackets in ___sys_recvmsg and change
comments to netdev style.

Cc: David Miller <davem@davemloft.net>
Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-11-20 21:52:30 -05:00
..
Kconfig net: x25: Fix dead URLs in Kconfig 2013-10-29 17:35:17 -04:00
Makefile [X.25]: Add call forwarding 2007-02-08 13:34:02 -08:00
af_x25.c net: rework recvmsg handler msg_name and msg_namelen logic 2013-11-20 21:52:30 -05:00
sysctl_net_x25.c net: Convert all sysctl registrations to register_net_sysctl 2012-04-20 21:22:30 -04:00
x25_dev.c net: add a limit parameter to sk_add_backlog() 2012-04-23 22:28:28 -04:00
x25_facilities.c x25: add a sanity check parsing X.25 facilities 2013-09-04 00:27:27 -04:00
x25_forward.c Fix common misspellings 2011-03-31 11:26:23 -03:00
x25_in.c x25: Handle undersized/fragmented skbs 2011-10-17 19:31:39 -04:00
x25_link.c x25: Handle undersized/fragmented skbs 2011-10-17 19:31:39 -04:00
x25_out.c x25: remove the BKL 2011-03-05 10:55:45 +01:00
x25_proc.c x25: use proc_remove_subtree() 2013-04-09 14:13:35 -04:00
x25_route.c net: Fix (nearly-)kernel-doc comments for various functions 2012-07-10 23:13:45 -07:00
x25_subr.c x25: Handle undersized/fragmented skbs 2011-10-17 19:31:39 -04:00
x25_timer.c x25: Fix sleep from timer on socket destroy. 2009-06-16 05:40:30 -07:00