Clang warns when an enumerated type is implicitly converted to another. drivers/scsi/isci/request.c:3476:13: warning: implicit conversion from enumeration type 'enum sci_task_status' to different enumeration type 'enum sci_status' [-Wenum-conversion] status = sci_controller_start_task(ihost, ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/isci/host.c:2744:10: warning: implicit conversion from enumeration type 'enum sci_status' to different enumeration type 'enum sci_task_status' [-Wenum-conversion] return SCI_SUCCESS; ~~~~~~ ^~~~~~~~~~~ drivers/scsi/isci/host.c:2753:9: warning: implicit conversion from enumeration type 'enum sci_status' to different enumeration type 'enum sci_task_status' [-Wenum-conversion] return status; ~~~~~~ ^~~~~~ Avoid all of these implicit conversion by just making sci_controller_start_task use sci_status. This silences Clang and has no functional change since sci_task_status has all of its values mapped to something in sci_status. Link: https://github.com/ClangBuiltLinux/linux/issues/153 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
||
---|---|---|
.. | ||
Makefile | ||
host.c | ||
host.h | ||
init.c | ||
isci.h | ||
phy.c | ||
phy.h | ||
port.c | ||
port.h | ||
port_config.c | ||
probe_roms.c | ||
probe_roms.h | ||
registers.h | ||
remote_device.c | ||
remote_device.h | ||
remote_node_context.c | ||
remote_node_context.h | ||
remote_node_table.c | ||
remote_node_table.h | ||
request.c | ||
request.h | ||
sas.h | ||
scu_completion_codes.h | ||
scu_event_codes.h | ||
scu_remote_node_context.h | ||
scu_task_context.h | ||
task.c | ||
task.h | ||
unsolicited_frame_control.c | ||
unsolicited_frame_control.h |