linux/drivers/of
Wladislav Wiebe 9e40127526 of: fdt: fix memory initialization for expanded DT
Already existing property flags are filled wrong for properties created from
initial FDT. This could cause problems if this DYNAMIC device-tree functions
are used later, i.e. properties are attached/detached/replaced. Simply dumping
flags from the running system show, that some initial static (not allocated via
kzmalloc()) nodes are marked as dynamic.

I putted some debug extensions to property_proc_show(..) :
..
+       if (OF_IS_DYNAMIC(pp))
+               pr_err("DEBUG: xxx : OF_IS_DYNAMIC\n");
+       if (OF_IS_DETACHED(pp))
+               pr_err("DEBUG: xxx : OF_IS_DETACHED\n");

when you operate on the nodes (e.g.: ~$ cat /proc/device-tree/*some_node*) you
will see that those flags are filled wrong, basically in most cases it will dump
a DYNAMIC or DETACHED status, which is in not true.
(BTW. this OF_IS_DETACHED is a own define for debug purposes which which just
make a test_bit(OF_DETACHED, &x->_flags)

If nodes are dynamic kernel is allowed to kfree() them. But it will crash
attempting to do so on the nodes from FDT -- they are not allocated via
kzmalloc().

Signed-off-by: Wladislav Wiebe <wladislav.kw@gmail.com>
Acked-by: Alexander Sverdlin <alexander.sverdlin@nsn.com>
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
2013-08-21 20:05:49 -05:00
..
Kconfig of: remove CONFIG_OF_DEVICE 2013-06-12 12:37:40 +01:00
Makefile of: remove CONFIG_OF_DEVICE 2013-06-12 12:37:40 +01:00
address.c Device tree updates for v3.11 2013-07-04 15:51:45 -07:00
base.c Device tree updates for v3.11 2013-07-04 15:51:45 -07:00
device.c of: Output devicetree alias names in uevent 2013-02-06 11:06:35 +00:00
fdt.c of: fdt: fix memory initialization for expanded DT 2013-08-21 20:05:49 -05:00
irq.c of/irq: init struct resource to 0 in of_irq_to_resource() 2013-07-22 19:40:38 +01:00
of_i2c.c of_i2c: Honour "status=disabled" property of device 2012-11-29 17:28:08 +00:00
of_mdio.c net: of_mdio: fix behavior on missing phy device 2013-05-08 13:13:29 -07:00
of_mtd.c of: mtd: nuke useless const qualifier 2012-07-10 10:32:06 -05:00
of_net.c phy: add reverse MII PHY connection type 2013-05-31 17:19:05 -07:00
of_pci.c of/pci: Add of_pci_parse_bus_range() function 2013-05-19 20:30:10 +00:00
of_pci_irq.c OF: PCI: const usage needed by MIPS 2012-05-21 14:31:48 +01:00
of_private.h of: Output devicetree alias names in uevent 2013-02-06 11:06:35 +00:00
pdt.c open firmware: "/aliasas" -> "/aliases" 2013-06-18 13:46:26 +02:00
platform.c Revert "of: use platform_device_add" 2013-02-17 20:03:27 +00:00
selftest.c of: Create function for counting number of phandles in a property 2013-02-13 10:09:31 +00:00