linux/tools/lib
Andrii Nakryiko 91097fbee4 btf: fix bug with resolving STRUCT/UNION into corresponding FWD
When checking available canonical candidates for struct/union algorithm
utilizes btf_dedup_is_equiv to determine if candidate is suitable. This
check is not enough when candidate is corresponding FWD for that
struct/union, because according to equivalence logic they are
equivalent. When it so happens that FWD and STRUCT/UNION end in hashing
to the same bucket, it's possible to create remapping loop from FWD to
STRUCT and STRUCT to same FWD, which will cause btf_dedup() to loop
forever.

This patch fixes the issue by additionally checking that type and
canonical candidate are strictly equal (utilizing btf_equal_struct).

Fixes: d5caef5b56 ("btf: add BTF types deduplication algorithm")
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Song Liu <songliubraving@fb.com>
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2019-03-01 01:31:48 +01:00
..
api perf tools: Fix tracing_path_mount proper path 2018-10-16 12:27:46 -03:00
bpf btf: fix bug with resolving STRUCT/UNION into corresponding FWD 2019-03-01 01:31:48 +01:00
lockdep tools/lib/lockdep/tests: Test the lockdep_reset_lock() implementation 2018-12-11 14:54:51 +01:00
subcmd tools lib subcmd: Don't add the kernel sources to the include path 2018-12-18 12:23:56 -03:00
symbol
traceevent tools lib traceevent: Remove tep_data_event_from_type() API 2019-01-08 13:28:13 -03:00
bitmap.c
find_bit.c
hweight.c
rbtree.c
str_error_r.c
string.c
vsprintf.c