6038f373a3
All file_operations should get a .llseek operation so we can make nonseekable_open the default for future file operations without a .llseek pointer. The three cases that we can automatically detect are no_llseek, seq_lseek and default_llseek. For cases where we can we can automatically prove that the file offset is always ignored, we use noop_llseek, which maintains the current behavior of not returning an error from a seek. New drivers should normally not use noop_llseek but instead use no_llseek and call nonseekable_open at open time. Existing drivers can be converted to do the same when the maintainer knows for certain that no user code relies on calling seek on the device file. The generated code is often incorrectly indented and right now contains comments that clarify for each added line why a specific variant was chosen. In the version that gets submitted upstream, the comments will be gone and I will manually fix the indentation, because there does not seem to be a way to do that using coccinelle. Some amount of new code is currently sitting in linux-next that should get the same modifications, which I will do at the end of the merge window. Many thanks to Julia Lawall for helping me learn to write a semantic patch that does all this. ===== begin semantic patch ===== // This adds an llseek= method to all file operations, // as a preparation for making no_llseek the default. // // The rules are // - use no_llseek explicitly if we do nonseekable_open // - use seq_lseek for sequential files // - use default_llseek if we know we access f_pos // - use noop_llseek if we know we don't access f_pos, // but we still want to allow users to call lseek // @ open1 exists @ identifier nested_open; @@ nested_open(...) { <+... nonseekable_open(...) ...+> } @ open exists@ identifier open_f; identifier i, f; identifier open1.nested_open; @@ int open_f(struct inode *i, struct file *f) { <+... ( nonseekable_open(...) | nested_open(...) ) ...+> } @ read disable optional_qualifier exists @ identifier read_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; expression E; identifier func; @@ ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) { <+... ( *off = E | *off += E | func(..., off, ...) | E = *off ) ...+> } @ read_no_fpos disable optional_qualifier exists @ identifier read_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; @@ ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) { ... when != off } @ write @ identifier write_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; expression E; identifier func; @@ ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) { <+... ( *off = E | *off += E | func(..., off, ...) | E = *off ) ...+> } @ write_no_fpos @ identifier write_f; identifier f, p, s, off; type ssize_t, size_t, loff_t; @@ ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) { ... when != off } @ fops0 @ identifier fops; @@ struct file_operations fops = { ... }; @ has_llseek depends on fops0 @ identifier fops0.fops; identifier llseek_f; @@ struct file_operations fops = { ... .llseek = llseek_f, ... }; @ has_read depends on fops0 @ identifier fops0.fops; identifier read_f; @@ struct file_operations fops = { ... .read = read_f, ... }; @ has_write depends on fops0 @ identifier fops0.fops; identifier write_f; @@ struct file_operations fops = { ... .write = write_f, ... }; @ has_open depends on fops0 @ identifier fops0.fops; identifier open_f; @@ struct file_operations fops = { ... .open = open_f, ... }; // use no_llseek if we call nonseekable_open //////////////////////////////////////////// @ nonseekable1 depends on !has_llseek && has_open @ identifier fops0.fops; identifier nso ~= "nonseekable_open"; @@ struct file_operations fops = { ... .open = nso, ... +.llseek = no_llseek, /* nonseekable */ }; @ nonseekable2 depends on !has_llseek @ identifier fops0.fops; identifier open.open_f; @@ struct file_operations fops = { ... .open = open_f, ... +.llseek = no_llseek, /* open uses nonseekable */ }; // use seq_lseek for sequential files ///////////////////////////////////// @ seq depends on !has_llseek @ identifier fops0.fops; identifier sr ~= "seq_read"; @@ struct file_operations fops = { ... .read = sr, ... +.llseek = seq_lseek, /* we have seq_read */ }; // use default_llseek if there is a readdir /////////////////////////////////////////// @ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier readdir_e; @@ // any other fop is used that changes pos struct file_operations fops = { ... .readdir = readdir_e, ... +.llseek = default_llseek, /* readdir is present */ }; // use default_llseek if at least one of read/write touches f_pos ///////////////////////////////////////////////////////////////// @ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read.read_f; @@ // read fops use offset struct file_operations fops = { ... .read = read_f, ... +.llseek = default_llseek, /* read accesses f_pos */ }; @ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier write.write_f; @@ // write fops use offset struct file_operations fops = { ... .write = write_f, ... + .llseek = default_llseek, /* write accesses f_pos */ }; // Use noop_llseek if neither read nor write accesses f_pos /////////////////////////////////////////////////////////// @ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read_no_fpos.read_f; identifier write_no_fpos.write_f; @@ // write fops use offset struct file_operations fops = { ... .write = write_f, .read = read_f, ... +.llseek = noop_llseek, /* read and write both use no f_pos */ }; @ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier write_no_fpos.write_f; @@ struct file_operations fops = { ... .write = write_f, ... +.llseek = noop_llseek, /* write uses no f_pos */ }; @ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; identifier read_no_fpos.read_f; @@ struct file_operations fops = { ... .read = read_f, ... +.llseek = noop_llseek, /* read uses no f_pos */ }; @ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops; @@ struct file_operations fops = { ... +.llseek = noop_llseek, /* no read or write fn */ }; ===== End semantic patch ===== Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Julia Lawall <julia@diku.dk> Cc: Christoph Hellwig <hch@infradead.org>
202 lines
4.0 KiB
C
202 lines
4.0 KiB
C
/*
|
|
* Sample dynamic sized record fifo implementation
|
|
*
|
|
* Copyright (C) 2010 Stefani Seibold <stefani@seibold.net>
|
|
*
|
|
* Released under the GPL version 2 only.
|
|
*
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/kfifo.h>
|
|
|
|
/*
|
|
* This module shows how to create a variable sized record fifo.
|
|
*/
|
|
|
|
/* fifo size in elements (bytes) */
|
|
#define FIFO_SIZE 128
|
|
|
|
/* name of the proc entry */
|
|
#define PROC_FIFO "record-fifo"
|
|
|
|
/* lock for procfs read access */
|
|
static DEFINE_MUTEX(read_lock);
|
|
|
|
/* lock for procfs write access */
|
|
static DEFINE_MUTEX(write_lock);
|
|
|
|
/*
|
|
* define DYNAMIC in this example for a dynamically allocated fifo.
|
|
*
|
|
* Otherwise the fifo storage will be a part of the fifo structure.
|
|
*/
|
|
#if 0
|
|
#define DYNAMIC
|
|
#endif
|
|
|
|
/*
|
|
* struct kfifo_rec_ptr_1 and STRUCT_KFIFO_REC_1 can handle records of a
|
|
* length between 0 and 255 bytes.
|
|
*
|
|
* struct kfifo_rec_ptr_2 and STRUCT_KFIFO_REC_2 can handle records of a
|
|
* length between 0 and 65535 bytes.
|
|
*/
|
|
|
|
#ifdef DYNAMIC
|
|
struct kfifo_rec_ptr_1 test;
|
|
|
|
#else
|
|
typedef STRUCT_KFIFO_REC_1(FIFO_SIZE) mytest;
|
|
|
|
static mytest test;
|
|
#endif
|
|
|
|
static const char *expected_result[] = {
|
|
"a",
|
|
"bb",
|
|
"ccc",
|
|
"dddd",
|
|
"eeeee",
|
|
"ffffff",
|
|
"ggggggg",
|
|
"hhhhhhhh",
|
|
"iiiiiiiii",
|
|
"jjjjjjjjjj",
|
|
};
|
|
|
|
static int __init testfunc(void)
|
|
{
|
|
char buf[100];
|
|
unsigned int i;
|
|
unsigned int ret;
|
|
struct { unsigned char buf[6]; } hello = { "hello" };
|
|
|
|
printk(KERN_INFO "record fifo test start\n");
|
|
|
|
kfifo_in(&test, &hello, sizeof(hello));
|
|
|
|
/* show the size of the next record in the fifo */
|
|
printk(KERN_INFO "fifo peek len: %u\n", kfifo_peek_len(&test));
|
|
|
|
/* put in variable length data */
|
|
for (i = 0; i < 10; i++) {
|
|
memset(buf, 'a' + i, i + 1);
|
|
kfifo_in(&test, buf, i + 1);
|
|
}
|
|
|
|
/* skip first element of the fifo */
|
|
printk(KERN_INFO "skip 1st element\n");
|
|
kfifo_skip(&test);
|
|
|
|
printk(KERN_INFO "fifo len: %u\n", kfifo_len(&test));
|
|
|
|
/* show the first record without removing from the fifo */
|
|
ret = kfifo_out_peek(&test, buf, sizeof(buf));
|
|
if (ret)
|
|
printk(KERN_INFO "%.*s\n", ret, buf);
|
|
|
|
/* check the correctness of all values in the fifo */
|
|
i = 0;
|
|
while (!kfifo_is_empty(&test)) {
|
|
ret = kfifo_out(&test, buf, sizeof(buf));
|
|
buf[ret] = '\0';
|
|
printk(KERN_INFO "item = %.*s\n", ret, buf);
|
|
if (strcmp(buf, expected_result[i++])) {
|
|
printk(KERN_WARNING "value mismatch: test failed\n");
|
|
return -EIO;
|
|
}
|
|
}
|
|
if (i != ARRAY_SIZE(expected_result)) {
|
|
printk(KERN_WARNING "size mismatch: test failed\n");
|
|
return -EIO;
|
|
}
|
|
printk(KERN_INFO "test passed\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t fifo_write(struct file *file, const char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
int ret;
|
|
unsigned int copied;
|
|
|
|
if (mutex_lock_interruptible(&write_lock))
|
|
return -ERESTARTSYS;
|
|
|
|
ret = kfifo_from_user(&test, buf, count, &copied);
|
|
|
|
mutex_unlock(&write_lock);
|
|
|
|
return ret ? ret : copied;
|
|
}
|
|
|
|
static ssize_t fifo_read(struct file *file, char __user *buf,
|
|
size_t count, loff_t *ppos)
|
|
{
|
|
int ret;
|
|
unsigned int copied;
|
|
|
|
if (mutex_lock_interruptible(&read_lock))
|
|
return -ERESTARTSYS;
|
|
|
|
ret = kfifo_to_user(&test, buf, count, &copied);
|
|
|
|
mutex_unlock(&read_lock);
|
|
|
|
return ret ? ret : copied;
|
|
}
|
|
|
|
static const struct file_operations fifo_fops = {
|
|
.owner = THIS_MODULE,
|
|
.read = fifo_read,
|
|
.write = fifo_write,
|
|
.llseek = noop_llseek,
|
|
};
|
|
|
|
static int __init example_init(void)
|
|
{
|
|
#ifdef DYNAMIC
|
|
int ret;
|
|
|
|
ret = kfifo_alloc(&test, FIFO_SIZE, GFP_KERNEL);
|
|
if (ret) {
|
|
printk(KERN_ERR "error kfifo_alloc\n");
|
|
return ret;
|
|
}
|
|
#else
|
|
INIT_KFIFO(test);
|
|
#endif
|
|
if (testfunc() < 0) {
|
|
#ifdef DYNAMIC
|
|
kfifo_free(&test);
|
|
#endif
|
|
return -EIO;
|
|
}
|
|
|
|
if (proc_create(PROC_FIFO, 0, NULL, &fifo_fops) == NULL) {
|
|
#ifdef DYNAMIC
|
|
kfifo_free(&test);
|
|
#endif
|
|
return -ENOMEM;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void __exit example_exit(void)
|
|
{
|
|
remove_proc_entry(PROC_FIFO, NULL);
|
|
#ifdef DYNAMIC
|
|
kfifo_free(&test);
|
|
#endif
|
|
}
|
|
|
|
module_init(example_init);
|
|
module_exit(example_exit);
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Stefani Seibold <stefani@seibold.net>");
|