OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/drivers/video/backlight
History
Robert Jarzmik 2023b0524a backlight: tdo24m: Fix the SPI CS between transfers 
Currently the LCD display (TD035S) on the cm-x300 platform is broken and
remains blank.

The TD0245S specification requires that the chipselect is toggled
between commands sent to the panel. This was also the purpose of the
former patch of commit f64dcac0b1 ("backlight: tdo24m: ensure chip
select changes between transfers").

Unfortunately, the "cs_change" field of a SPI transfer is
misleading. Its true meaning is that for a SPI message holding multiple
transfers, the chip select is toggled between each transfer, but for the
last transfer it remains asserted.

In this driver, all the SPI messages contain exactly one transfer, which
means that each transfer is the last of its message, and as a
consequence the chip select is never toggled.

Actually, there was a second bug hidding the first one, hence the
problem was not seen until v4.6. This problem was fixed by commit
a52db659c7 ("spi: pxa2xx: Fix cs_change management") for PXA based
boards.

This fix makes the TD035S work again on a cm-x300 board. The same
applies to other PXA boards, ie. corgi and tosa.

Fixes: a52db659c7 ("spi: pxa2xx: Fix cs_change management")
Reported-by: Andrea Adami <andrea.adami@gmail.com>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
 		2018-01-08 09:21:57 +00:00
..
88pm860x_bl.c backlight: 88pm860x_bl: Add missing of_node_put 2015-10-15 12:06:21 +01:00
Kconfig backlight: Add support for Arctic Sand LED backlight driver chips 2017-04-25 09:22:23 +01:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
aat2870_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
adp5520_bl.c backlight: adp5520: Fix error handling in adp5520_bl_probe() 2017-01-04 11:37:31 +00:00
adp8860_bl.c backlight: adp8860: Move header file out of I2C realm 2017-07-06 08:56:08 +01:00
adp8870_bl.c video: adp8870: move header file out of I2C realm 2017-07-06 08:58:39 +01:00
ams369fg06.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
apple_bl.c backlight: apple_bl: Deprecate pci_get_bus_and_slot() 2017-12-20 13:47:05 +00:00
arcxcnn_bl.c backlight: Add support for Arctic Sand LED backlight driver chips 2017-04-25 09:22:23 +01:00
as3711_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
backlight.c backlight: Report error on failure 2017-05-30 09:27:53 +01:00
bd6107.c backlight: Remove trivial get_brightness implementations 2014-06-23 13:24:22 +01:00
corgi_lcd.c backlight: tdo24m: Fix the SPI CS between transfers 2018-01-08 09:21:57 +00:00
cr_bllcd.c backlight: cr_bllcd: Add blank line after declarations 2014-08-29 08:24:51 +01:00
da903x_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
da9052_bl.c backlight: da9052: Fix module autoload 2017-01-04 11:37:58 +00:00
ep93xx_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
generic_bl.c backlight: generic_bl: Remove unused function 2014-08-28 14:10:16 +01:00
gpio_backlight.c backlight: gpio_backlight: Delete pdata inversion 2017-08-07 17:11:28 +01:00
hp680_bl.c backlight: hp680_bl: use devm_backlight_device_register() 2014-01-23 16:36:56 -08:00
hx8357.c backlight: hx8357: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili922x.c backlight: ili922x: Remove redundant variable len 2017-11-08 10:43:49 +00:00
ili9320.c backlight: ili9320: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili9320.h backlight: vgg2432a4: convert vgg2432a4_driver to dev_pm_ops 2013-04-29 18:28:18 -07:00
ipaq_micro_bl.c backlight: ipaq_micro: Fix sparse non static symbol warning 2014-07-31 10:31:22 +01:00
jornada720_bl.c backlight: jornada720: Remove 'else' after a return 2014-08-29 08:26:32 +01:00
jornada720_lcd.c backlight: jornada720: Remove 'else' after a return 2014-08-29 08:26:51 +01:00
kb3886_bl.c dmi: Mark all struct dmi_system_id instances const 2017-09-14 11:59:30 +02:00
l4f00242t03.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
lcd.c backlight: lcd: Fix race condition during register 2017-01-04 11:37:31 +00:00
ld9040.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
ld9040_gamma.h backlight: ld9040: Staticize local variable gamma_table 2013-11-13 12:09:15 +09:00
lm3533_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
lm3630a_bl.c backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F 2017-07-17 13:27:06 +01:00
lm3639_bl.c backlight: lm3639: Remove unnecessary return statements 2014-08-29 08:25:23 +01:00
lms283gf05.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
lms501kf03.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
locomolcd.c backlight: locomolcd: convert locomolcd to dev_pm_ops 2013-04-29 18:28:16 -07:00
lp855x_bl.c backlight: lp855x: Add enable regulator 2016-06-29 10:06:21 +01:00
lp8788_bl.c backlight: lp8788: Explicitly apply PWM config extracted from pwm_args 2016-05-17 14:45:04 +02:00
ltv350qv.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
ltv350qv.h
…
lv5207lp.c backlight: Remove trivial get_brightness implementations 2014-06-23 13:24:22 +01:00
max8925_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
omap1_bl.c backlight: omap1: add blank line after declarations 2014-08-29 08:27:53 +01:00
ot200_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
pandora_bl.c mfd: twl: Move header file out of I2C realm 2017-09-04 14:41:02 +01:00
pcf50633-backlight.c backlight: pcf50633: Add blank line after declarations 2014-08-29 08:25:53 +01:00
platform_lcd.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
pm8941-wled.c backlight: pm8941-wled: Add default-brightness property 2015-10-30 18:47:51 +00:00
pwm_bl.c backlight: pwm_bl: Fix overflow condition 2017-10-13 10:41:20 +01:00
s6e63m0.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
s6e63m0_gamma.h backlight: add S6E63M0 AMOLED LCD Panel driver 2010-05-26 17:34:16 +01:00
sky81452-backlight.c backlight: sky81452: Remove unneeded use of IS_ERR_VALUE() macro 2015-08-25 08:43:21 +01:00
tdo24m.c backlight: tdo24m: Fix the SPI CS between transfers 2018-01-08 09:21:57 +00:00
tosa_bl.c backlight-tosa: Delete unnecessary assignment for the field "owner" 2016-10-06 09:27:25 +01:00
tosa_lcd.c backlight: tdo24m: Fix the SPI CS between transfers 2018-01-08 09:21:57 +00:00
tps65217_bl.c - Fix-ups 2017-11-16 10:36:46 -08:00
vgg2432a4.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
wm831x_bl.c backlight: wm831x_bl: Add blank line after declarations 2014-08-29 08:26:21 +01:00