linux/drivers/input
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
gameport
joystick sh: maple: Support block reads and writes. 2009-02-27 16:07:32 +09:00
keyboard Merge branch 'devel' of master.kernel.org:/home/rmk/linux-2.6-arm 2009-03-28 14:03:14 -07:00
misc
mouse Merge branch 'devel' of master.kernel.org:/home/rmk/linux-2.6-arm 2009-03-28 14:03:14 -07:00
serio Merge branch 'origin' into devel 2009-03-28 20:29:51 +00:00
tablet
touchscreen Merge branch 'for-rmk' of git://git.pengutronix.de/git/imx/linux-2.6 into devel 2009-03-13 21:44:51 +00:00
apm-power.c
evbug.c
evdev.c Rationalize fasync return values 2009-03-16 08:34:35 -06:00
ff-core.c
ff-memless.c
fixp-arith.h
input-compat.c
input-compat.h
input-polldev.c
input.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
joydev.c Rationalize fasync return values 2009-03-16 08:34:35 -06:00
Kconfig
Makefile
mousedev.c Rationalize fasync return values 2009-03-16 08:34:35 -06:00
xen-kbdfront.c