linux/drivers/usb/renesas_usbhs
Yoshihiro Shimoda 15e4292a2d usb: renesas_usbhs: protect the CFIFOSEL setting in usbhsg_ep_enable()
This patch fixes an issue that the CFIFOSEL register value is possible
to be changed by usbhsg_ep_enable() wrongly. And then, a data transfer
using CFIFO may not work correctly.

For example:
 # modprobe g_multi file=usb-storage.bin
 # ifconfig usb0 192.168.1.1 up
 (During the USB host is sending file to the mass storage)
 # ifconfig usb0 down

In this case, since the u_ether.c may call usb_ep_enable() in
eth_stop(), if the renesas_usbhs driver is also using CFIFO for
mass storage, the mass storage may not work correctly.

So, this patch adds usbhs_lock() and usbhs_unlock() calling in
usbhsg_ep_enable() to protect CFIFOSEL register. This is because:
 - CFIFOSEL.CURPIPE = 0 is also needed for the pipe configuration
 - The CFIFOSEL (fifo->sel) is already protected by usbhs_lock()

Fixes: 97664a207b ("usb: renesas_usbhs: shrink spin lock area")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
2016-06-29 11:14:44 +03:00
..
Kconfig usb: renesas_usbhs: Use ARCH_RENESAS 2016-02-20 20:21:53 -08:00
Makefile usb: renesas_usbhs: add R-Car Gen3 power control 2016-03-04 15:14:28 +02:00
common.c usb: renesas_usbhs: show error code when probe failed 2016-06-29 11:07:27 +03:00
common.h usb: renesas_usbhs: add support for USB-DMAC 2015-03-13 10:41:19 -05:00
fifo.c usb: renesas_usbhs: fix NULL pointer dereference in xfer_work() 2016-06-29 11:14:33 +03:00
fifo.h usb: renesas_usbhs: constify usbhs_pkt_handle structures 2016-01-24 19:45:09 -08:00
mod.c usb: renesas_usbhs: avoid uninitialized variable use 2015-05-22 08:52:16 -05:00
mod.h renesas_usbhs: cleanup quoted includes 2012-06-05 10:15:25 +02:00
mod_gadget.c usb: renesas_usbhs: protect the CFIFOSEL setting in usbhsg_ep_enable() 2016-06-29 11:14:44 +03:00
mod_host.c usb: renesas_usbhs: change arguments of dma_map_ctrl() 2016-04-19 11:11:54 +03:00
pipe.c usb: renesas_usbhs: fix signed-unsigned return 2016-05-03 14:32:07 -07:00
pipe.h usb: renesas_usbhs: change arguments of dma_map_ctrl() 2016-04-19 11:11:54 +03:00
rcar2.c usb: renesas_usbhs: Remove unneeded #include <linux/platform_data/gpio-rcar.h> 2015-10-20 16:03:36 +02:00
rcar2.h usb: renesas_usbhs: add R-Car Gen. 2 init and power control 2014-07-16 10:06:32 -05:00
rcar3.c usb: renesas_usbhs: make usbhs_write32() static 2016-06-22 11:16:07 +03:00
rcar3.h usb: renesas_usbhs: add R-Car Gen3 power control 2016-03-04 15:14:28 +02:00