OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
d78757e780
linux/drivers/hwtracing/coresight
History
Paul Gortmaker fc368ea1ea drivers/hwtracing: fix coresight-etm4x implicit <module.h> usage 
In commit 2e1cdfe184 ("coresight-etm4x:
Adding CoreSight ETM4x driver") this driver was added.

It uses module_amba_driver() to register itself with the system,
which is just an alias for module_driver.  This currently works by
relying on getting that via init.h but we are planning to move that
code[1] to module.h -- at which time this will fail to compile since
it does not include module.h currently, resulting in:

drivers/hwtracing/coresight/coresight-etm4x.c:2701:1: note: in expansion of macro ‘module_amba_driver’
 module_amba_driver(etm4x_driver);
 ^
include/linux/device.h:1296:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int]
 module_init(__driver##_init); \
 ^

In the future, the amba support may want to create another alias that
uses builtin_driver[2] for cases like this which are using bool Kconfig
triggers, but for now we just fix the implicit include.

[1] https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com
[2] https://lkml.kernel.org/r/1431287385-1526-1-git-send-email-paul.gortmaker@windriver.com

Cc: Pratik Patel <pratikp@codeaurora.org>
Cc: Kaixu Xia <xiakaixu@huawei.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-06-08 13:46:43 -07:00
..
coresight-etb10.c coresight: etb: retrieve and handle atclk 2015-05-24 11:12:08 -07:00
coresight-etm3x.c coresight: etm: retrieve and handle atclk 2015-05-24 11:12:08 -07:00
coresight-etm4x.c drivers/hwtracing: fix coresight-etm4x implicit <module.h> usage 2015-06-08 13:46:43 -07:00
coresight-etm4x.h coresight-etm4x: Adding CoreSight ETM4x driver 2015-05-24 11:11:20 -07:00
coresight-etm-cp14.c
coresight-etm.h coresight: etm: retrieve and handle atclk 2015-05-24 11:12:08 -07:00
coresight-funnel.c coresight: funnel: retrieve and handle atclk 2015-05-24 11:12:08 -07:00
coresight-priv.h
coresight-replicator-qcom.c drivers/hwtracing: fix coresight-replicator-qcom implicit <module.h> usage 2015-06-08 13:46:43 -07:00
coresight-replicator.c coresight: replicator: retrieve and handle atclk 2015-05-24 11:12:08 -07:00
coresight-tmc.c coresight: tmc: let runtime PM handle core clock 2015-05-24 11:12:08 -07:00
coresight-tpiu.c coresight: tpiu: retrieve and handle atclk 2015-05-24 11:12:08 -07:00
coresight.c
Kconfig coresight: replicator: Add Qualcomm CoreSight Replicator driver 2015-05-24 11:12:08 -07:00
Makefile coresight: replicator: Add Qualcomm CoreSight Replicator driver 2015-05-24 11:12:08 -07:00
of_coresight.c coresight: fix typo in of_coresight.c 2015-05-24 11:12:08 -07:00