linux/drivers/net/ethernet/qlogic/qlcnic
Michael Zhivich d63da85a42 qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant
qlcnic driver uses u16 to store SPEED_UKNOWN ethtool constant,
which is defined as -1, resulting in value truncation and
thus incorrect test results against SPEED_UNKNOWN.

For example, the following test will print "False":

    u16 speed = SPEED_UNKNOWN;

    if (speed == SPEED_UNKNOWN)
        printf("True");
    else
        printf("False");

Change storage of speed to use u32 to avoid this issue.

Signed-off-by: Michael Zhivich <mzhivich@akamai.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-04-08 16:30:43 -07:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qlcnic.h qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant 2019-04-08 16:30:43 -07:00
qlcnic_83xx_hw.c pci-v4.20-changes 2018-10-25 06:50:48 -07:00
qlcnic_83xx_hw.h qlcnic: fix Tx descriptor corruption on 82xx devices 2018-09-29 11:46:07 -07:00
qlcnic_83xx_init.c
qlcnic_83xx_vnic.c
qlcnic_ctx.c cross-tree: phase out dma_zalloc_coherent() 2019-01-08 07:58:37 -05:00
qlcnic_dcb.c qlcnic: fix a return in qlcnic_dcb_get_capability() 2018-10-22 19:34:16 -07:00
qlcnic_dcb.h
qlcnic_ethtool.c qlcnic: Avoid potential NULL pointer dereference 2019-03-15 11:55:53 -07:00
qlcnic_hdr.h
qlcnic_hw.c ethernet/qlogic: remove unused array msi_tgt_status 2018-08-09 14:16:51 -07:00
qlcnic_hw.h qlcnic: fix Tx descriptor corruption on 82xx devices 2018-09-29 11:46:07 -07:00
qlcnic_init.c qlcnic: remove redundant zero check on retries counter 2017-09-01 10:33:55 -07:00
qlcnic_io.c qlcnic: remove assumption that vlan_tci != 0 2018-11-07 22:37:55 -08:00
qlcnic_main.c net: Add extack argument to ndo_fdb_add() 2019-01-17 15:18:47 -08:00
qlcnic_minidump.c qlcnic: remove unnecessary static in qlcnic_dump_fw() 2017-07-19 16:33:57 -07:00
qlcnic_sriov.h net: Update API for VF vlan protocol 802.1ad support 2016-09-24 08:01:26 -04:00
qlcnic_sriov_common.c qlcnic: Remove set but not used variables 'fw_mbx' and 'hdr_size' 2018-09-12 20:33:11 -07:00
qlcnic_sriov_pf.c qlcnic: remove set but not used variables 'op, cmd_op' 2018-12-18 15:49:46 -08:00
qlcnic_sysfs.c qlogic: check kstrtoul() for errors 2018-07-13 18:28:58 -07:00