OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/drivers/pcmcia
History
Paul Mackerras f7d1d23c30 [PATCH] Obvious bugfix for yenta resource allocation 
Recent changes (well, dating from 12 July) have broken cardbus on my
powerbook: I get 3 messages saying "no resource of type xxx available,
trying to continue", and if I plug in my wireless card, it complains
that there are no resources allocated to the card.  This all worked in
2.6.12.

Looking at the code in yenta_socket.c, function yenta_allocate_res,
it's obvious what is wrong: if we get to line 639 (i.e. there wasn't a
usable preassigned resource), we will always flow through to line 668,
which is the printk that I was seeing, even if a resource was
successfully allocated.  It looks to me as though there should be a
return statement after the two config_writel's in each of the 3
branches of the if statements, so that the function returns after
successfully setting up the resource.

The patch below adds these return statements, and with this patch,
cardbus works on my powerbook once again.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
 		2005-08-02 08:28:48 -07:00
..
Kconfig [PATCH] yenta: don't depend on CardBus 2005-07-07 18:24:07 -07:00
Makefile [PATCH] pcmcia: move pcmcia resource handling out of cs.c 2005-06-27 18:03:20 -07:00
au1000_db1x00.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
au1000_generic.c [PATCH] pcmcia: update au1000 to work with recent changes 2005-07-28 08:39:00 -07:00
au1000_generic.h [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
au1000_pb1x00.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
au1000_xxs1500.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
cardbus.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
cirrus.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cistpl.c [PATCH] pcmcia: avoid duble iounmap of one address 2005-07-28 08:39:00 -07:00
cs.c [PATCH] yenta: no CardBus if IRQ fails 2005-07-07 18:24:07 -07:00
cs_internal.h [PATCH] pcmcia: remove client_t usage 2005-07-07 18:24:06 -07:00
ds.c [PATCH] pcmcia: fix multiple insertion of multifunction cards 2005-08-01 10:03:56 -07:00
ds_internal.h [PATCH] pcmcia: merge struct pcmcia_bus_socket into struct pcmcia_socket 2005-06-27 18:03:19 -07:00
hd64465_ss.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
i82092.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
i82092aa.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
i82365.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
i82365.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
m32r_cfc.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
m32r_cfc.h [PATCH] m32r: Update m32r_cfc.[ch] to support Mappi-III platform 2005-06-21 19:07:30 -07:00
m32r_pcc.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
m32r_pcc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
o2micro.h [PATCH] pcmcia: disable read prefetch/write burst on old O2Micro bridges 2005-07-28 08:39:01 -07:00
pcmcia_compat.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
pcmcia_ioctl.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
pcmcia_resource.c [PATCH] pcmcia: fix sharing IRQs and request_irq without IRQ_HANDLE_PRESENT 2005-07-28 08:39:01 -07:00
pd6729.c [PATCH] pcmcia: enable 32-bit memory windows on pd6729 2005-05-05 16:36:43 -07:00
pd6729.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pxa2xx_base.c [PATCH] fix u32 vs. pm_message_t in pcmcia 2005-04-16 15:25:26 -07:00
pxa2xx_base.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pxa2xx_lubbock.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pxa2xx_mainstone.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pxa2xx_sharpsl.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ricoh.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
rsrc_mgr.c [PATCH] pcmcia: move pcmcia resource handling out of cs.c 2005-06-27 18:03:20 -07:00
rsrc_nonstatic.c [PATCH] ACPI-based PCI resources: PCMCIA bugfix, but resources missing in trees 2005-06-27 18:03:22 -07:00
sa11xx_base.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa11xx_base.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_assabet.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_badge4.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_cerf.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_generic.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
sa1100_generic.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_h3600.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_jornada720.c [PATCH] ARM: 2830/1: Fix Jornada 720 PCMCIA-support 2005-07-26 19:21:47 +01:00
sa1100_neponset.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_shannon.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1100_simpad.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sa1111_generic.c [PATCH] fix u32 vs. pm_message_t in pcmcia 2005-04-16 15:25:26 -07:00
sa1111_generic.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
soc_common.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
soc_common.h [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
socket_sysfs.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
tcic.c [PATCH] pcmcia: remove references to pcmcia/version.h 2005-07-07 18:24:07 -07:00
tcic.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ti113x.h [PATCH] yenta: don't depend on CardBus 2005-07-07 18:24:07 -07:00
topic.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
vg468.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
vrc4171_card.c [PATCH] fix u32 vs. pm_message_t in pcmcia 2005-04-16 15:25:26 -07:00
vrc4173_cardu.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
vrc4173_cardu.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
yenta_socket.c [PATCH] Obvious bugfix for yenta resource allocation 2005-08-02 08:28:48 -07:00
yenta_socket.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00