linux/fs/ceph
Jeff Layton c3f4688a08 ceph: don't set req->r_locked_dir in ceph_d_revalidate
This function sets req->r_locked_dir which is supposed to indicate to
ceph_fill_trace that the parent's i_rwsem is locked for write.
Unfortunately, there is no guarantee that the dir will be locked when
d_revalidate is called, so we really don't want ceph_fill_trace to do
any dcache manipulation from this context. Clear req->r_locked_dir since
it's clearly not safe to do that.

What we really want to know with d_revalidate is whether the dentry
still points to the same inode. ceph_fill_trace installs a pointer to
the inode in req->r_target_inode, so we can just compare that to
d_inode(dentry) to see if it's the same one after the lookup.

Also, since we aren't generally interested in the parent here, we can
switch to using a GETATTR to hint that to the MDS, which also means that
we only need to reserve one cap.

Finally, just remove the d_unhashed check. That's really outside the
purview of a filesystem's d_revalidate. If the thing became unhashed
while we're checking it, then that's up to the VFS to handle anyway.

Fixes: 200fd27c8f ("ceph: use lookup request to revalidate dentry")
Link: http://tracker.ceph.com/issues/18041
Reported-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2016-12-08 14:32:16 +01:00
..
Kconfig ceph: add acl for cephfs 2013-12-31 20:32:01 +02:00
Makefile ceph: add acl for cephfs 2013-12-31 20:32:01 +02:00
acl.c ceph: Propagate dentry down to inode_change_ok() 2016-09-22 10:56:19 +02:00
addr.c ceph: remove warning when ceph_releasepage() is called on dirty page 2016-10-03 16:13:49 +02:00
cache.c ceph: fix spelling mistake: "resgister" -> "register" 2016-07-28 02:55:40 +02:00
cache.h ceph: improve fscache revalidation 2016-06-01 10:31:50 +02:00
caps.c ceph: fix null pointer dereference in ceph_flush_snaps() 2016-08-08 21:41:43 +02:00
ceph_frag.c ceph: factor out libceph from Ceph file system 2010-10-20 15:37:28 -07:00
debugfs.c ceph: don't show symlink target in debugfs/mdsc 2016-05-26 01:15:32 +02:00
dir.c ceph: don't set req->r_locked_dir in ceph_d_revalidate 2016-12-08 14:32:16 +01:00
export.c ceph: fix d_obtain_alias() misuses 2016-06-24 23:49:03 -04:00
file.c ceph: use default file splice read callback 2016-11-10 20:13:04 +01:00
inode.c ceph: fix readdir vs fragmentation race 2016-10-18 12:09:58 +02:00
ioctl.c ceph: reduce i_nr_by_mode array size 2016-07-28 02:55:39 +02:00
ioctl.h ceph: fully initialize new layout 2012-05-16 14:28:27 -05:00
locks.c ceph: fix mandatory flock check 2016-10-03 16:13:49 +02:00
mds_client.c ceph: use list_move instead of list_del/list_add 2016-10-03 16:13:50 +02:00
mds_client.h ceph: handle CEPH_SESSION_REJECT message 2016-10-03 16:13:50 +02:00
mdsmap.c ceph: CEPH_FEATURE_MDSENC support 2016-05-26 01:15:31 +02:00
snap.c ceph: cleanup ceph_flush_snaps() 2016-07-28 03:00:44 +02:00
strings.c ceph: handle CEPH_SESSION_REJECT message 2016-10-03 16:13:50 +02:00
super.c ceph: fix uninitialized dentry pointer in ceph_real_mount() 2016-10-18 12:10:59 +02:00
super.h ceph: optimize cap flush waiting 2016-07-28 03:00:45 +02:00
xattr.c ceph: fix non static symbol warning 2016-10-18 12:30:32 +02:00