Alexey Dobriyan
0147fc058d
tcp: restrict net.ipv4.tcp_adv_win_scale ( #20312 ) ...
tcp_win_from_space() does the following:
if (sysctl_tcp_adv_win_scale <= 0)
return space >> (-sysctl_tcp_adv_win_scale);
else
return space - (space >> sysctl_tcp_adv_win_scale);
"space" is int.
As per C99 6.5.7 (3) shifting int for 32 or more bits is
undefined behaviour.
Indeed, if sysctl_tcp_adv_win_scale is exactly 32,
space >> 32 equals space and function returns 0.
Which means we busyloop in tcp_fixup_rcvbuf().
Restrict net.ipv4.tcp_adv_win_scale to [-31, 31].
Fix https://bugzilla.kernel.org/show_bug.cgi?id=20312
Steps to reproduce:
echo 32 >/proc/sys/net/ipv4/tcp_adv_win_scale
wget www.kernel.org
[softlockup]
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-11-28 10:39:45 -08:00
2010-11-12 07:55:31 -08:00
2010-10-27 18:03:17 -07:00
2010-08-14 23:02:14 -04:00
2010-08-04 15:21:40 +02:00
2010-10-24 13:41:39 -07:00
2009-09-24 07:20:57 -07:00
2010-08-06 12:55:52 -04:00
2010-11-11 12:09:59 +01:00
2010-08-04 15:21:40 +02:00
2010-08-04 15:21:40 +02:00
2010-10-27 18:03:09 -07:00
2010-04-23 02:09:52 +02:00
2010-02-24 13:51:32 +01:00
2010-01-13 10:55:16 -05:00
2008-10-16 11:21:30 -07:00
2009-08-29 19:09:27 -07:00
2010-08-04 15:21:40 +02:00
2010-08-04 15:21:40 +02:00
2010-10-29 11:49:38 -07:00
2010-02-05 12:22:34 +01:00
2010-10-22 22:22:47 -02:00
2008-04-21 22:19:05 +00:00
2010-03-06 11:26:32 -08:00
2010-10-27 19:02:41 -07:00
2010-11-10 12:00:47 -06:00
2010-08-05 13:53:34 -07:00
2010-10-28 20:31:51 +02:00
2010-10-31 21:07:00 +01:00
2010-08-04 15:21:40 +02:00
2009-06-07 13:52:52 +02:00
2010-08-04 15:21:40 +02:00
2010-08-30 15:25:18 +02:00
2010-10-28 12:13:00 -07:00
2010-08-04 15:31:02 -07:00
2010-08-04 15:21:40 +02:00
2010-10-28 16:18:59 -07:00
2009-06-12 18:01:47 +02:00
2010-08-04 15:21:40 +02:00
2010-10-24 10:52:48 +02:00
2010-08-16 11:54:50 -04:00
2010-11-12 07:55:32 -08:00
2010-10-19 09:13:04 +02:00
2009-01-14 19:19:03 +01:00
2010-10-26 16:52:14 -07:00
2010-08-12 08:43:30 -07:00
2009-06-12 18:01:47 +02:00
2010-08-04 15:21:40 +02:00
2010-04-23 02:09:52 +02:00
2010-11-28 10:39:45 -08:00
2010-07-11 22:17:45 +02:00
2010-09-29 17:20:24 +02:00
2010-10-17 01:57:50 +02:00
2010-10-22 20:30:48 -07:00
2009-06-18 13:04:04 -07:00
2008-04-19 19:19:55 +02:00
2010-09-23 09:16:53 -07:00
2010-08-04 15:21:40 +02:00
2010-04-02 20:12:01 +02:00
2010-10-26 11:11:12 -05:00
2010-08-04 15:21:40 +02:00
2008-12-22 18:44:05 +09:00
2010-10-25 10:40:05 +02:00
2008-08-29 02:15:25 -07:00
2010-05-25 00:23:16 -06:00
2010-11-12 07:55:32 -08:00
2010-08-04 15:21:40 +02:00
2009-11-05 18:18:10 -05:00
2010-10-26 16:52:11 -07:00
2010-10-26 16:52:07 -07:00
2010-08-04 15:21:40 +02:00
2010-10-22 10:21:40 -07:00
2010-10-22 20:55:43 -02:00
2010-10-26 16:52:08 -07:00
2010-08-04 15:21:40 +02:00
2010-07-01 16:02:55 +00:00
2009-01-07 10:00:18 -08:00
2010-10-22 08:54:21 -07:00
2010-08-04 15:21:40 +02:00
2010-04-08 11:34:34 +02:00
2010-08-12 08:43:30 -07:00
2010-08-02 15:35:15 +10:00
2010-04-23 02:09:52 +02:00
2008-12-03 16:09:53 -07:00
2010-08-04 15:21:40 +02:00
2009-06-12 18:01:47 +02:00
2008-07-25 10:53:30 -07:00
2009-08-22 14:25:32 -07:00
2010-07-20 17:49:30 +00:00
2010-04-23 02:09:52 +02:00
2010-07-11 21:55:42 +02:00
2010-03-24 16:31:22 -07:00
2010-10-28 00:32:23 +02:00
2009-06-12 18:01:46 +02:00
2010-08-11 23:04:10 +09:30
2010-09-09 20:41:25 +02:00
2010-07-29 15:16:18 -07:00
2009-10-03 09:28:11 +02:00
2009-06-12 18:01:50 +02:00
2010-10-28 09:35:11 -07:00
2010-08-14 11:56:46 -07:00
2010-08-11 08:59:21 -07:00
2008-07-22 10:39:36 +10:00
2009-01-05 18:10:19 -07:00
2010-02-25 14:43:57 -08:00
2010-10-22 10:16:42 -07:00
2010-05-10 11:49:30 -03:00
2010-02-05 12:22:39 +01:00
2010-03-12 15:52:35 -08:00
2010-10-28 09:35:11 -07:00
2009-10-15 07:25:20 -06:00
2009-05-09 07:12:50 +02:00
2009-09-21 15:14:56 +02:00
2010-09-09 18:57:24 -07:00
2008-04-21 15:10:15 -07:00
2010-08-04 15:21:40 +02:00
2008-03-24 19:22:19 -07:00
2010-03-06 11:26:29 -08:00
2010-08-04 15:21:40 +02:00
2009-09-19 09:37:23 -07:00
2008-11-03 18:21:44 +01:00
2008-07-26 12:00:06 -07:00
2010-03-12 15:52:39 -08:00
2008-06-05 15:18:30 +02:00
2010-09-11 16:49:21 -07:00
2010-08-04 15:21:40 +02:00
2010-11-11 12:09:59 +01:00
2008-04-29 08:06:16 -07:00
2009-09-02 21:29:22 +10:00
2009-07-01 22:36:22 +02:00
2009-09-08 16:36:08 +01:00
2010-03-19 07:12:20 -07:00
2010-10-14 08:55:27 +02:00
2009-09-18 09:48:52 -07:00
2010-08-04 15:21:40 +02:00
2010-11-12 07:55:32 -08:00
2009-06-23 20:21:38 +01:00
2009-06-12 18:01:47 +02:00
2009-08-07 12:03:46 +02:00
2009-12-06 13:20:02 +01:00
2009-04-27 12:00:27 -07:00
2009-04-27 12:00:27 -07:00
2009-01-06 15:59:28 -08:00
2010-03-12 15:52:35 -08:00
2008-10-30 11:38:46 -07:00
2008-03-17 09:03:05 +01:00
2010-08-04 15:21:40 +02:00
2010-03-24 16:31:22 -07:00
2009-12-15 08:53:17 -08:00
2009-09-22 07:17:26 -07:00
2010-09-03 08:19:51 +02:00
2008-10-30 19:07:04 +01:00
2009-12-15 08:53:24 -08:00
2009-09-22 07:17:39 -07:00
2010-05-19 08:37:43 +01:00
2010-08-11 08:59:18 -07:00
2010-02-05 12:22:44 +01:00
2008-11-12 17:17:17 -08:00
2010-11-11 12:09:59 +01:00
2010-03-10 17:09:33 -05:00
2009-06-18 13:03:56 -07:00
2010-06-05 17:39:09 +02:00
2009-09-23 07:39:46 -07:00
2008-10-16 11:21:32 -07:00
2008-08-27 08:54:08 +10:00
2009-06-12 18:01:47 +02:00
2010-04-23 02:09:52 +02:00
2010-07-19 10:56:54 +02:00
2009-12-14 09:46:56 -08:00
2010-04-22 15:24:56 -07:00
2010-05-24 07:31:20 -07:00
2010-08-04 15:21:40 +02:00
2010-08-09 20:45:05 -07:00
2010-03-16 11:47:56 +01:00
2010-10-26 17:32:41 -07:00
2010-08-02 15:35:10 +10:00
2008-07-25 10:53:27 -07:00
2009-12-16 11:28:58 -08:00
2010-03-24 16:31:20 -07:00
2010-10-11 15:20:26 +02:00
0147fc058d
