2020-10-27 20:05:42 +01:00
|
|
|
/*
|
|
|
|
* Present a block device as a raw image through FUSE
|
|
|
|
*
|
|
|
|
* Copyright (c) 2020 Max Reitz <mreitz@redhat.com>
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; under version 2 or later of the License.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define FUSE_USE_VERSION 31
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
2022-02-26 19:07:23 +01:00
|
|
|
#include "qemu/memalign.h"
|
2020-10-27 20:05:42 +01:00
|
|
|
#include "block/aio.h"
|
2022-12-21 14:35:49 +01:00
|
|
|
#include "block/block_int-common.h"
|
2020-10-27 20:05:42 +01:00
|
|
|
#include "block/export.h"
|
|
|
|
#include "block/fuse.h"
|
|
|
|
#include "block/qapi.h"
|
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "qapi/qapi-commands-block.h"
|
2022-12-21 14:35:49 +01:00
|
|
|
#include "qemu/main-loop.h"
|
2020-10-27 20:05:42 +01:00
|
|
|
#include "sysemu/block-backend.h"
|
|
|
|
|
|
|
|
#include <fuse.h>
|
|
|
|
#include <fuse_lowlevel.h>
|
|
|
|
|
2021-10-22 11:52:09 +02:00
|
|
|
#if defined(CONFIG_FALLOCATE_ZERO_RANGE)
|
|
|
|
#include <linux/falloc.h>
|
|
|
|
#endif
|
|
|
|
|
2021-08-28 00:03:01 +02:00
|
|
|
#ifdef __linux__
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#endif
|
2020-10-27 20:05:42 +01:00
|
|
|
|
|
|
|
/* Prevent overly long bounce buffer allocations */
|
|
|
|
#define FUSE_MAX_BOUNCE_BYTES (MIN(BDRV_REQUEST_MAX_BYTES, 64 * 1024 * 1024))
|
|
|
|
|
|
|
|
|
|
|
|
typedef struct FuseExport {
|
|
|
|
BlockExport common;
|
|
|
|
|
|
|
|
struct fuse_session *fuse_session;
|
|
|
|
struct fuse_buf fuse_buf;
|
2023-05-16 21:02:33 +02:00
|
|
|
unsigned int in_flight; /* atomic */
|
2020-10-27 20:05:42 +01:00
|
|
|
bool mounted, fd_handler_set_up;
|
|
|
|
|
|
|
|
char *mountpoint;
|
|
|
|
bool writable;
|
2020-10-27 20:05:44 +01:00
|
|
|
bool growable;
|
export/fuse: Add allow-other option
Without the allow_other mount option, no user (not even root) but the
one who started qemu/the storage daemon can access the export. Allow
users to configure the export such that such accesses are possible.
While allow_other is probably what users want, we cannot make it an
unconditional default, because passing it is only possible (for non-root
users) if the global fuse.conf configuration file allows it. Thus, the
default is an 'auto' mode, in which we first try with allow_other, and
then fall back to without.
FuseExport.allow_other reports whether allow_other was actually used as
a mount option or not. Currently, this information is not used, but a
future patch will let this field decide whether e.g. an export's UID and
GID can be changed through chmod.
One notable thing about 'auto' mode is that libfuse may print error
messages directly to stderr, and so may fusermount (which it executes).
Our export code cannot really filter or hide them. Therefore, if 'auto'
fails its first attempt and has to fall back, fusermount will print an
error message that mounting with allow_other failed.
This behavior necessitates a change to iotest 308, namely we need to
filter out this error message (because if the first attempt at mounting
with allow_other succeeds, there will be no such message).
Furthermore, common.rc's _make_test_img should use allow-other=off for
FUSE exports, because iotests generally do not need to access images
from other users, so allow-other=on or allow-other=auto have no
advantage. OTOH, allow-other=on will not work on systems where
user_allow_other is disabled, and with allow-other=auto, we get said
error message that we would need to filter out again. Just disabling
allow-other is simplest.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210625142317.271673-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-06-25 16:23:13 +02:00
|
|
|
/* Whether allow_other was used as a mount option or not */
|
|
|
|
bool allow_other;
|
2021-06-25 16:23:15 +02:00
|
|
|
|
|
|
|
mode_t st_mode;
|
|
|
|
uid_t st_uid;
|
|
|
|
gid_t st_gid;
|
2020-10-27 20:05:42 +01:00
|
|
|
} FuseExport;
|
|
|
|
|
|
|
|
static GHashTable *exports;
|
|
|
|
static const struct fuse_lowlevel_ops fuse_ops;
|
|
|
|
|
|
|
|
static void fuse_export_shutdown(BlockExport *exp);
|
|
|
|
static void fuse_export_delete(BlockExport *exp);
|
|
|
|
|
|
|
|
static void init_exports_table(void);
|
|
|
|
|
|
|
|
static int setup_fuse_export(FuseExport *exp, const char *mountpoint,
|
export/fuse: Add allow-other option
Without the allow_other mount option, no user (not even root) but the
one who started qemu/the storage daemon can access the export. Allow
users to configure the export such that such accesses are possible.
While allow_other is probably what users want, we cannot make it an
unconditional default, because passing it is only possible (for non-root
users) if the global fuse.conf configuration file allows it. Thus, the
default is an 'auto' mode, in which we first try with allow_other, and
then fall back to without.
FuseExport.allow_other reports whether allow_other was actually used as
a mount option or not. Currently, this information is not used, but a
future patch will let this field decide whether e.g. an export's UID and
GID can be changed through chmod.
One notable thing about 'auto' mode is that libfuse may print error
messages directly to stderr, and so may fusermount (which it executes).
Our export code cannot really filter or hide them. Therefore, if 'auto'
fails its first attempt and has to fall back, fusermount will print an
error message that mounting with allow_other failed.
This behavior necessitates a change to iotest 308, namely we need to
filter out this error message (because if the first attempt at mounting
with allow_other succeeds, there will be no such message).
Furthermore, common.rc's _make_test_img should use allow-other=off for
FUSE exports, because iotests generally do not need to access images
from other users, so allow-other=on or allow-other=auto have no
advantage. OTOH, allow-other=on will not work on systems where
user_allow_other is disabled, and with allow-other=auto, we get said
error message that we would need to filter out again. Just disabling
allow-other is simplest.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210625142317.271673-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-06-25 16:23:13 +02:00
|
|
|
bool allow_other, Error **errp);
|
2020-10-27 20:05:42 +01:00
|
|
|
static void read_from_fuse_export(void *opaque);
|
|
|
|
|
|
|
|
static bool is_regular_file(const char *path, Error **errp);
|
|
|
|
|
|
|
|
|
2023-05-16 21:02:33 +02:00
|
|
|
static void fuse_export_drained_begin(void *opaque)
|
|
|
|
{
|
|
|
|
FuseExport *exp = opaque;
|
|
|
|
|
|
|
|
aio_set_fd_handler(exp->common.ctx,
|
aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.
Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().
The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().
Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:
@@
expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
@@
- aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
+ aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
@@
expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
@@
- aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
+ aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2023-05-16 21:02:38 +02:00
|
|
|
fuse_session_fd(exp->fuse_session),
|
2023-05-16 21:02:33 +02:00
|
|
|
NULL, NULL, NULL, NULL, NULL);
|
|
|
|
exp->fd_handler_set_up = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fuse_export_drained_end(void *opaque)
|
|
|
|
{
|
|
|
|
FuseExport *exp = opaque;
|
|
|
|
|
|
|
|
/* Refresh AioContext in case it changed */
|
|
|
|
exp->common.ctx = blk_get_aio_context(exp->common.blk);
|
|
|
|
|
|
|
|
aio_set_fd_handler(exp->common.ctx,
|
aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.
Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().
The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().
Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:
@@
expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
@@
- aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
+ aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
@@
expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
@@
- aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
+ aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2023-05-16 21:02:38 +02:00
|
|
|
fuse_session_fd(exp->fuse_session),
|
2023-05-16 21:02:33 +02:00
|
|
|
read_from_fuse_export, NULL, NULL, NULL, exp);
|
|
|
|
exp->fd_handler_set_up = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool fuse_export_drained_poll(void *opaque)
|
|
|
|
{
|
|
|
|
FuseExport *exp = opaque;
|
|
|
|
|
|
|
|
return qatomic_read(&exp->in_flight) > 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const BlockDevOps fuse_export_blk_dev_ops = {
|
|
|
|
.drained_begin = fuse_export_drained_begin,
|
|
|
|
.drained_end = fuse_export_drained_end,
|
|
|
|
.drained_poll = fuse_export_drained_poll,
|
|
|
|
};
|
|
|
|
|
2020-10-27 20:05:42 +01:00
|
|
|
static int fuse_export_create(BlockExport *blk_exp,
|
|
|
|
BlockExportOptions *blk_exp_args,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
FuseExport *exp = container_of(blk_exp, FuseExport, common);
|
|
|
|
BlockExportOptionsFuse *args = &blk_exp_args->u.fuse;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
assert(blk_exp_args->type == BLOCK_EXPORT_TYPE_FUSE);
|
|
|
|
|
2022-03-03 16:15:51 +01:00
|
|
|
/* For growable and writable exports, take the RESIZE permission */
|
|
|
|
if (args->growable || blk_exp_args->writable) {
|
2020-10-27 20:05:44 +01:00
|
|
|
uint64_t blk_perm, blk_shared_perm;
|
|
|
|
|
|
|
|
blk_get_perm(exp->common.blk, &blk_perm, &blk_shared_perm);
|
|
|
|
|
|
|
|
ret = blk_set_perm(exp->common.blk, blk_perm | BLK_PERM_RESIZE,
|
|
|
|
blk_shared_perm, errp);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-05-16 21:02:33 +02:00
|
|
|
blk_set_dev_ops(exp->common.blk, &fuse_export_blk_dev_ops, exp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We handle draining ourselves using an in-flight counter and by disabling
|
|
|
|
* the FUSE fd handler. Do not queue BlockBackend requests, they need to
|
|
|
|
* complete so the in-flight counter reaches zero.
|
|
|
|
*/
|
|
|
|
blk_set_disable_request_queuing(exp->common.blk, true);
|
|
|
|
|
2020-10-27 20:05:42 +01:00
|
|
|
init_exports_table();
|
|
|
|
|
|
|
|
/*
|
|
|
|
* It is important to do this check before calling is_regular_file() --
|
|
|
|
* that function will do a stat(), which we would have to handle if we
|
|
|
|
* already exported something on @mountpoint. But we cannot, because
|
|
|
|
* we are currently caught up here.
|
|
|
|
* (Note that ideally we would want to resolve relative paths here,
|
|
|
|
* but bdrv_make_absolute_filename() might do the wrong thing for
|
|
|
|
* paths that contain colons, and realpath() would resolve symlinks,
|
|
|
|
* which we do not want: The mount point is not going to be the
|
|
|
|
* symlink's destination, but the link itself.)
|
|
|
|
* So this will not catch all potential clashes, but hopefully at
|
|
|
|
* least the most common one of specifying exactly the same path
|
|
|
|
* string twice.
|
|
|
|
*/
|
|
|
|
if (g_hash_table_contains(exports, args->mountpoint)) {
|
|
|
|
error_setg(errp, "There already is a FUSE export on '%s'",
|
|
|
|
args->mountpoint);
|
|
|
|
ret = -EEXIST;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!is_regular_file(args->mountpoint, errp)) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
exp->mountpoint = g_strdup(args->mountpoint);
|
|
|
|
exp->writable = blk_exp_args->writable;
|
2020-10-27 20:05:44 +01:00
|
|
|
exp->growable = args->growable;
|
2020-10-27 20:05:42 +01:00
|
|
|
|
export/fuse: Add allow-other option
Without the allow_other mount option, no user (not even root) but the
one who started qemu/the storage daemon can access the export. Allow
users to configure the export such that such accesses are possible.
While allow_other is probably what users want, we cannot make it an
unconditional default, because passing it is only possible (for non-root
users) if the global fuse.conf configuration file allows it. Thus, the
default is an 'auto' mode, in which we first try with allow_other, and
then fall back to without.
FuseExport.allow_other reports whether allow_other was actually used as
a mount option or not. Currently, this information is not used, but a
future patch will let this field decide whether e.g. an export's UID and
GID can be changed through chmod.
One notable thing about 'auto' mode is that libfuse may print error
messages directly to stderr, and so may fusermount (which it executes).
Our export code cannot really filter or hide them. Therefore, if 'auto'
fails its first attempt and has to fall back, fusermount will print an
error message that mounting with allow_other failed.
This behavior necessitates a change to iotest 308, namely we need to
filter out this error message (because if the first attempt at mounting
with allow_other succeeds, there will be no such message).
Furthermore, common.rc's _make_test_img should use allow-other=off for
FUSE exports, because iotests generally do not need to access images
from other users, so allow-other=on or allow-other=auto have no
advantage. OTOH, allow-other=on will not work on systems where
user_allow_other is disabled, and with allow-other=auto, we get said
error message that we would need to filter out again. Just disabling
allow-other is simplest.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210625142317.271673-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-06-25 16:23:13 +02:00
|
|
|
/* set default */
|
|
|
|
if (!args->has_allow_other) {
|
|
|
|
args->allow_other = FUSE_EXPORT_ALLOW_OTHER_AUTO;
|
|
|
|
}
|
|
|
|
|
2021-06-25 16:23:15 +02:00
|
|
|
exp->st_mode = S_IFREG | S_IRUSR;
|
|
|
|
if (exp->writable) {
|
|
|
|
exp->st_mode |= S_IWUSR;
|
|
|
|
}
|
|
|
|
exp->st_uid = getuid();
|
|
|
|
exp->st_gid = getgid();
|
|
|
|
|
export/fuse: Add allow-other option
Without the allow_other mount option, no user (not even root) but the
one who started qemu/the storage daemon can access the export. Allow
users to configure the export such that such accesses are possible.
While allow_other is probably what users want, we cannot make it an
unconditional default, because passing it is only possible (for non-root
users) if the global fuse.conf configuration file allows it. Thus, the
default is an 'auto' mode, in which we first try with allow_other, and
then fall back to without.
FuseExport.allow_other reports whether allow_other was actually used as
a mount option or not. Currently, this information is not used, but a
future patch will let this field decide whether e.g. an export's UID and
GID can be changed through chmod.
One notable thing about 'auto' mode is that libfuse may print error
messages directly to stderr, and so may fusermount (which it executes).
Our export code cannot really filter or hide them. Therefore, if 'auto'
fails its first attempt and has to fall back, fusermount will print an
error message that mounting with allow_other failed.
This behavior necessitates a change to iotest 308, namely we need to
filter out this error message (because if the first attempt at mounting
with allow_other succeeds, there will be no such message).
Furthermore, common.rc's _make_test_img should use allow-other=off for
FUSE exports, because iotests generally do not need to access images
from other users, so allow-other=on or allow-other=auto have no
advantage. OTOH, allow-other=on will not work on systems where
user_allow_other is disabled, and with allow-other=auto, we get said
error message that we would need to filter out again. Just disabling
allow-other is simplest.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210625142317.271673-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-06-25 16:23:13 +02:00
|
|
|
if (args->allow_other == FUSE_EXPORT_ALLOW_OTHER_AUTO) {
|
|
|
|
/* Ignore errors on our first attempt */
|
|
|
|
ret = setup_fuse_export(exp, args->mountpoint, true, NULL);
|
|
|
|
exp->allow_other = ret == 0;
|
|
|
|
if (ret < 0) {
|
|
|
|
ret = setup_fuse_export(exp, args->mountpoint, false, errp);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
exp->allow_other = args->allow_other == FUSE_EXPORT_ALLOW_OTHER_ON;
|
|
|
|
ret = setup_fuse_export(exp, args->mountpoint, exp->allow_other, errp);
|
|
|
|
}
|
2020-10-27 20:05:42 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
fuse_export_delete(blk_exp);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Allocates the global @exports hash table.
|
|
|
|
*/
|
|
|
|
static void init_exports_table(void)
|
|
|
|
{
|
|
|
|
if (exports) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
exports = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Create exp->fuse_session and mount it.
|
|
|
|
*/
|
|
|
|
static int setup_fuse_export(FuseExport *exp, const char *mountpoint,
|
export/fuse: Add allow-other option
Without the allow_other mount option, no user (not even root) but the
one who started qemu/the storage daemon can access the export. Allow
users to configure the export such that such accesses are possible.
While allow_other is probably what users want, we cannot make it an
unconditional default, because passing it is only possible (for non-root
users) if the global fuse.conf configuration file allows it. Thus, the
default is an 'auto' mode, in which we first try with allow_other, and
then fall back to without.
FuseExport.allow_other reports whether allow_other was actually used as
a mount option or not. Currently, this information is not used, but a
future patch will let this field decide whether e.g. an export's UID and
GID can be changed through chmod.
One notable thing about 'auto' mode is that libfuse may print error
messages directly to stderr, and so may fusermount (which it executes).
Our export code cannot really filter or hide them. Therefore, if 'auto'
fails its first attempt and has to fall back, fusermount will print an
error message that mounting with allow_other failed.
This behavior necessitates a change to iotest 308, namely we need to
filter out this error message (because if the first attempt at mounting
with allow_other succeeds, there will be no such message).
Furthermore, common.rc's _make_test_img should use allow-other=off for
FUSE exports, because iotests generally do not need to access images
from other users, so allow-other=on or allow-other=auto have no
advantage. OTOH, allow-other=on will not work on systems where
user_allow_other is disabled, and with allow-other=auto, we get said
error message that we would need to filter out again. Just disabling
allow-other is simplest.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210625142317.271673-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-06-25 16:23:13 +02:00
|
|
|
bool allow_other, Error **errp)
|
2020-10-27 20:05:42 +01:00
|
|
|
{
|
|
|
|
const char *fuse_argv[4];
|
|
|
|
char *mount_opts;
|
|
|
|
struct fuse_args fuse_args;
|
|
|
|
int ret;
|
|
|
|
|
2021-06-25 16:23:12 +02:00
|
|
|
/*
|
|
|
|
* max_read needs to match what fuse_init() sets.
|
|
|
|
* max_write need not be supplied.
|
|
|
|
*/
|
export/fuse: Add allow-other option
Without the allow_other mount option, no user (not even root) but the
one who started qemu/the storage daemon can access the export. Allow
users to configure the export such that such accesses are possible.
While allow_other is probably what users want, we cannot make it an
unconditional default, because passing it is only possible (for non-root
users) if the global fuse.conf configuration file allows it. Thus, the
default is an 'auto' mode, in which we first try with allow_other, and
then fall back to without.
FuseExport.allow_other reports whether allow_other was actually used as
a mount option or not. Currently, this information is not used, but a
future patch will let this field decide whether e.g. an export's UID and
GID can be changed through chmod.
One notable thing about 'auto' mode is that libfuse may print error
messages directly to stderr, and so may fusermount (which it executes).
Our export code cannot really filter or hide them. Therefore, if 'auto'
fails its first attempt and has to fall back, fusermount will print an
error message that mounting with allow_other failed.
This behavior necessitates a change to iotest 308, namely we need to
filter out this error message (because if the first attempt at mounting
with allow_other succeeds, there will be no such message).
Furthermore, common.rc's _make_test_img should use allow-other=off for
FUSE exports, because iotests generally do not need to access images
from other users, so allow-other=on or allow-other=auto have no
advantage. OTOH, allow-other=on will not work on systems where
user_allow_other is disabled, and with allow-other=auto, we get said
error message that we would need to filter out again. Just disabling
allow-other is simplest.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210625142317.271673-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-06-25 16:23:13 +02:00
|
|
|
mount_opts = g_strdup_printf("max_read=%zu,default_permissions%s",
|
|
|
|
FUSE_MAX_BOUNCE_BYTES,
|
|
|
|
allow_other ? ",allow_other" : "");
|
2020-10-27 20:05:42 +01:00
|
|
|
|
|
|
|
fuse_argv[0] = ""; /* Dummy program name */
|
|
|
|
fuse_argv[1] = "-o";
|
|
|
|
fuse_argv[2] = mount_opts;
|
|
|
|
fuse_argv[3] = NULL;
|
|
|
|
fuse_args = (struct fuse_args)FUSE_ARGS_INIT(3, (char **)fuse_argv);
|
|
|
|
|
|
|
|
exp->fuse_session = fuse_session_new(&fuse_args, &fuse_ops,
|
|
|
|
sizeof(fuse_ops), exp);
|
|
|
|
g_free(mount_opts);
|
|
|
|
if (!exp->fuse_session) {
|
|
|
|
error_setg(errp, "Failed to set up FUSE session");
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = fuse_session_mount(exp->fuse_session, mountpoint);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_setg(errp, "Failed to mount FUSE session to export");
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
exp->mounted = true;
|
|
|
|
|
|
|
|
g_hash_table_insert(exports, g_strdup(mountpoint), NULL);
|
|
|
|
|
|
|
|
aio_set_fd_handler(exp->common.ctx,
|
aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.
Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().
The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().
Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:
@@
expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
@@
- aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
+ aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
@@
expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
@@
- aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
+ aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2023-05-16 21:02:38 +02:00
|
|
|
fuse_session_fd(exp->fuse_session),
|
aio-posix: split poll check from ready handler
Adaptive polling measures the execution time of the polling check plus
handlers called when a polled event becomes ready. Handlers can take a
significant amount of time, making it look like polling was running for
a long time when in fact the event handler was running for a long time.
For example, on Linux the io_submit(2) syscall invoked when a virtio-blk
device's virtqueue becomes ready can take 10s of microseconds. This
can exceed the default polling interval (32 microseconds) and cause
adaptive polling to stop polling.
By excluding the handler's execution time from the polling check we make
the adaptive polling calculation more accurate. As a result, the event
loop now stays in polling mode where previously it would have fallen
back to file descriptor monitoring.
The following data was collected with virtio-blk num-queues=2
event_idx=off using an IOThread. Before:
168k IOPS, IOThread syscalls:
9837.115 ( 0.020 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 16, iocbpp: 0x7fcb9f937db0) = 16
9837.158 ( 0.002 ms): IO iothread1/620155 write(fd: 103, buf: 0x556a2ef71b88, count: 8) = 8
9837.161 ( 0.001 ms): IO iothread1/620155 write(fd: 104, buf: 0x556a2ef71b88, count: 8) = 8
9837.163 ( 0.001 ms): IO iothread1/620155 ppoll(ufds: 0x7fcb90002800, nfds: 4, tsp: 0x7fcb9f1342d0, sigsetsize: 8) = 3
9837.164 ( 0.001 ms): IO iothread1/620155 read(fd: 107, buf: 0x7fcb9f939cc0, count: 512) = 8
9837.174 ( 0.001 ms): IO iothread1/620155 read(fd: 105, buf: 0x7fcb9f939cc0, count: 512) = 8
9837.176 ( 0.001 ms): IO iothread1/620155 read(fd: 106, buf: 0x7fcb9f939cc0, count: 512) = 8
9837.209 ( 0.035 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 32, iocbpp: 0x7fca7d0cebe0) = 32
174k IOPS (+3.6%), IOThread syscalls:
9809.566 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0cdd62be0) = 32
9809.625 ( 0.001 ms): IO iothread1/623061 write(fd: 103, buf: 0x5647cfba5f58, count: 8) = 8
9809.627 ( 0.002 ms): IO iothread1/623061 write(fd: 104, buf: 0x5647cfba5f58, count: 8) = 8
9809.663 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0d0388b50) = 32
Notice that ppoll(2) and eventfd read(2) syscalls are eliminated because
the IOThread stays in polling mode instead of falling back to file
descriptor monitoring.
As usual, polling is not implemented on Windows so this patch ignores
the new io_poll_read() callback in aio-win32.c.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20211207132336.36627-2-stefanha@redhat.com
[Fixed up aio_set_event_notifier() calls in
tests/unit/test-fdmon-epoll.c added after this series was queued.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2021-12-07 14:23:31 +01:00
|
|
|
read_from_fuse_export, NULL, NULL, NULL, exp);
|
2020-10-27 20:05:42 +01:00
|
|
|
exp->fd_handler_set_up = true;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
fuse_export_shutdown(&exp->common);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Callback to be invoked when the FUSE session FD can be read from.
|
|
|
|
* (This is basically the FUSE event loop.)
|
|
|
|
*/
|
|
|
|
static void read_from_fuse_export(void *opaque)
|
|
|
|
{
|
|
|
|
FuseExport *exp = opaque;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
blk_exp_ref(&exp->common);
|
|
|
|
|
2023-05-16 21:02:33 +02:00
|
|
|
qatomic_inc(&exp->in_flight);
|
|
|
|
|
2020-10-27 20:05:42 +01:00
|
|
|
do {
|
|
|
|
ret = fuse_session_receive_buf(exp->fuse_session, &exp->fuse_buf);
|
|
|
|
} while (ret == -EINTR);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
fuse_session_process_buf(exp->fuse_session, &exp->fuse_buf);
|
|
|
|
|
|
|
|
out:
|
2023-05-16 21:02:33 +02:00
|
|
|
if (qatomic_fetch_dec(&exp->in_flight) == 1) {
|
|
|
|
aio_wait_kick(); /* wake AIO_WAIT_WHILE() */
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:42 +01:00
|
|
|
blk_exp_unref(&exp->common);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fuse_export_shutdown(BlockExport *blk_exp)
|
|
|
|
{
|
|
|
|
FuseExport *exp = container_of(blk_exp, FuseExport, common);
|
|
|
|
|
|
|
|
if (exp->fuse_session) {
|
|
|
|
fuse_session_exit(exp->fuse_session);
|
|
|
|
|
|
|
|
if (exp->fd_handler_set_up) {
|
|
|
|
aio_set_fd_handler(exp->common.ctx,
|
aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and
aio_set_event_notifier(). The aio_disable_external() API that
temporarily disables fd handlers that were registered is_external=true
is therefore dead code.
Remove aio_disable_external(), aio_enable_external(), and the
is_external arguments to aio_set_fd_handler() and
aio_set_event_notifier().
The entire test-fdmon-epoll test is removed because its sole purpose was
testing aio_disable_external().
Parts of this patch were generated using the following coccinelle
(https://coccinelle.lip6.fr/) semantic patch:
@@
expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
@@
- aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
+ aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
@@
expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
@@
- aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
+ aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2023-05-16 21:02:38 +02:00
|
|
|
fuse_session_fd(exp->fuse_session),
|
aio-posix: split poll check from ready handler
Adaptive polling measures the execution time of the polling check plus
handlers called when a polled event becomes ready. Handlers can take a
significant amount of time, making it look like polling was running for
a long time when in fact the event handler was running for a long time.
For example, on Linux the io_submit(2) syscall invoked when a virtio-blk
device's virtqueue becomes ready can take 10s of microseconds. This
can exceed the default polling interval (32 microseconds) and cause
adaptive polling to stop polling.
By excluding the handler's execution time from the polling check we make
the adaptive polling calculation more accurate. As a result, the event
loop now stays in polling mode where previously it would have fallen
back to file descriptor monitoring.
The following data was collected with virtio-blk num-queues=2
event_idx=off using an IOThread. Before:
168k IOPS, IOThread syscalls:
9837.115 ( 0.020 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 16, iocbpp: 0x7fcb9f937db0) = 16
9837.158 ( 0.002 ms): IO iothread1/620155 write(fd: 103, buf: 0x556a2ef71b88, count: 8) = 8
9837.161 ( 0.001 ms): IO iothread1/620155 write(fd: 104, buf: 0x556a2ef71b88, count: 8) = 8
9837.163 ( 0.001 ms): IO iothread1/620155 ppoll(ufds: 0x7fcb90002800, nfds: 4, tsp: 0x7fcb9f1342d0, sigsetsize: 8) = 3
9837.164 ( 0.001 ms): IO iothread1/620155 read(fd: 107, buf: 0x7fcb9f939cc0, count: 512) = 8
9837.174 ( 0.001 ms): IO iothread1/620155 read(fd: 105, buf: 0x7fcb9f939cc0, count: 512) = 8
9837.176 ( 0.001 ms): IO iothread1/620155 read(fd: 106, buf: 0x7fcb9f939cc0, count: 512) = 8
9837.209 ( 0.035 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 32, iocbpp: 0x7fca7d0cebe0) = 32
174k IOPS (+3.6%), IOThread syscalls:
9809.566 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0cdd62be0) = 32
9809.625 ( 0.001 ms): IO iothread1/623061 write(fd: 103, buf: 0x5647cfba5f58, count: 8) = 8
9809.627 ( 0.002 ms): IO iothread1/623061 write(fd: 104, buf: 0x5647cfba5f58, count: 8) = 8
9809.663 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0d0388b50) = 32
Notice that ppoll(2) and eventfd read(2) syscalls are eliminated because
the IOThread stays in polling mode instead of falling back to file
descriptor monitoring.
As usual, polling is not implemented on Windows so this patch ignores
the new io_poll_read() callback in aio-win32.c.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20211207132336.36627-2-stefanha@redhat.com
[Fixed up aio_set_event_notifier() calls in
tests/unit/test-fdmon-epoll.c added after this series was queued.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2021-12-07 14:23:31 +01:00
|
|
|
NULL, NULL, NULL, NULL, NULL);
|
2020-10-27 20:05:42 +01:00
|
|
|
exp->fd_handler_set_up = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (exp->mountpoint) {
|
|
|
|
/*
|
|
|
|
* Safe to drop now, because we will not handle any requests
|
|
|
|
* for this export anymore anyway.
|
|
|
|
*/
|
|
|
|
g_hash_table_remove(exports, exp->mountpoint);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fuse_export_delete(BlockExport *blk_exp)
|
|
|
|
{
|
|
|
|
FuseExport *exp = container_of(blk_exp, FuseExport, common);
|
|
|
|
|
|
|
|
if (exp->fuse_session) {
|
|
|
|
if (exp->mounted) {
|
|
|
|
fuse_session_unmount(exp->fuse_session);
|
|
|
|
}
|
|
|
|
|
|
|
|
fuse_session_destroy(exp->fuse_session);
|
|
|
|
}
|
|
|
|
|
|
|
|
free(exp->fuse_buf.mem);
|
|
|
|
g_free(exp->mountpoint);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Check whether @path points to a regular file. If not, put an
|
|
|
|
* appropriate message into *errp.
|
|
|
|
*/
|
|
|
|
static bool is_regular_file(const char *path, Error **errp)
|
|
|
|
{
|
|
|
|
struct stat statbuf;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = stat(path, &statbuf);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_setg_errno(errp, errno, "Failed to stat '%s'", path);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!S_ISREG(statbuf.st_mode)) {
|
|
|
|
error_setg(errp, "'%s' is not a regular file", path);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* A chance to set change some parameters supplied to FUSE_INIT.
|
|
|
|
*/
|
|
|
|
static void fuse_init(void *userdata, struct fuse_conn_info *conn)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* MIN_NON_ZERO() would not be wrong here, but what we set here
|
|
|
|
* must equal what has been passed to fuse_session_new().
|
|
|
|
* Therefore, as long as max_read must be passed as a mount option
|
|
|
|
* (which libfuse claims will be changed at some point), we have
|
|
|
|
* to set max_read to a fixed value here.
|
|
|
|
*/
|
|
|
|
conn->max_read = FUSE_MAX_BOUNCE_BYTES;
|
|
|
|
|
|
|
|
conn->max_write = MIN_NON_ZERO(BDRV_REQUEST_MAX_BYTES, conn->max_write);
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:43 +01:00
|
|
|
/**
|
|
|
|
* Let clients look up files. Always return ENOENT because we only
|
|
|
|
* care about the mountpoint itself.
|
|
|
|
*/
|
|
|
|
static void fuse_lookup(fuse_req_t req, fuse_ino_t parent, const char *name)
|
|
|
|
{
|
|
|
|
fuse_reply_err(req, ENOENT);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Let clients get file attributes (i.e., stat() the file).
|
|
|
|
*/
|
|
|
|
static void fuse_getattr(fuse_req_t req, fuse_ino_t inode,
|
|
|
|
struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
struct stat statbuf;
|
|
|
|
int64_t length, allocated_blocks;
|
|
|
|
time_t now = time(NULL);
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
|
|
|
|
|
|
|
length = blk_getlength(exp->common.blk);
|
|
|
|
if (length < 0) {
|
|
|
|
fuse_reply_err(req, -length);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
allocated_blocks = bdrv_get_allocated_file_size(blk_bs(exp->common.blk));
|
|
|
|
if (allocated_blocks <= 0) {
|
|
|
|
allocated_blocks = DIV_ROUND_UP(length, 512);
|
|
|
|
} else {
|
|
|
|
allocated_blocks = DIV_ROUND_UP(allocated_blocks, 512);
|
|
|
|
}
|
|
|
|
|
|
|
|
statbuf = (struct stat) {
|
|
|
|
.st_ino = inode,
|
2021-06-25 16:23:15 +02:00
|
|
|
.st_mode = exp->st_mode,
|
2020-10-27 20:05:43 +01:00
|
|
|
.st_nlink = 1,
|
2021-06-25 16:23:15 +02:00
|
|
|
.st_uid = exp->st_uid,
|
|
|
|
.st_gid = exp->st_gid,
|
2020-10-27 20:05:43 +01:00
|
|
|
.st_size = length,
|
|
|
|
.st_blksize = blk_bs(exp->common.blk)->bl.request_alignment,
|
|
|
|
.st_blocks = allocated_blocks,
|
|
|
|
.st_atime = now,
|
|
|
|
.st_mtime = now,
|
|
|
|
.st_ctime = now,
|
|
|
|
};
|
|
|
|
|
|
|
|
fuse_reply_attr(req, &statbuf, 1.);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int fuse_do_truncate(const FuseExport *exp, int64_t size,
|
|
|
|
bool req_zero_write, PreallocMode prealloc)
|
|
|
|
{
|
|
|
|
uint64_t blk_perm, blk_shared_perm;
|
|
|
|
BdrvRequestFlags truncate_flags = 0;
|
2022-03-03 16:15:51 +01:00
|
|
|
bool add_resize_perm;
|
|
|
|
int ret, ret_check;
|
|
|
|
|
|
|
|
/* Growable and writable exports have a permanent RESIZE permission */
|
|
|
|
add_resize_perm = !exp->growable && !exp->writable;
|
2020-10-27 20:05:43 +01:00
|
|
|
|
|
|
|
if (req_zero_write) {
|
|
|
|
truncate_flags |= BDRV_REQ_ZERO_WRITE;
|
|
|
|
}
|
|
|
|
|
2022-03-03 16:15:51 +01:00
|
|
|
if (add_resize_perm) {
|
|
|
|
|
|
|
|
if (!qemu_in_main_thread()) {
|
|
|
|
/* Changing permissions like below only works in the main thread */
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:44 +01:00
|
|
|
blk_get_perm(exp->common.blk, &blk_perm, &blk_shared_perm);
|
2020-10-27 20:05:43 +01:00
|
|
|
|
2020-10-27 20:05:44 +01:00
|
|
|
ret = blk_set_perm(exp->common.blk, blk_perm | BLK_PERM_RESIZE,
|
|
|
|
blk_shared_perm, NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2020-10-27 20:05:43 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
ret = blk_truncate(exp->common.blk, size, true, prealloc,
|
|
|
|
truncate_flags, NULL);
|
|
|
|
|
2022-03-03 16:15:51 +01:00
|
|
|
if (add_resize_perm) {
|
2020-10-27 20:05:44 +01:00
|
|
|
/* Must succeed, because we are only giving up the RESIZE permission */
|
2022-03-03 16:15:51 +01:00
|
|
|
ret_check = blk_set_perm(exp->common.blk, blk_perm,
|
|
|
|
blk_shared_perm, &error_abort);
|
|
|
|
assert(ret_check == 0);
|
2020-10-27 20:05:44 +01:00
|
|
|
}
|
2020-10-27 20:05:43 +01:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2021-06-25 16:23:15 +02:00
|
|
|
* Let clients set file attributes. Only resizing and changing
|
|
|
|
* permissions (st_mode, st_uid, st_gid) is allowed.
|
|
|
|
* Changing permissions is only allowed as far as it will actually
|
|
|
|
* permit access: Read-only exports cannot be given +w, and exports
|
|
|
|
* without allow_other cannot be given a different UID or GID, and
|
|
|
|
* they cannot be given non-owner access.
|
2020-10-27 20:05:43 +01:00
|
|
|
*/
|
|
|
|
static void fuse_setattr(fuse_req_t req, fuse_ino_t inode, struct stat *statbuf,
|
|
|
|
int to_set, struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
2021-06-25 16:23:15 +02:00
|
|
|
int supported_attrs;
|
2020-10-27 20:05:43 +01:00
|
|
|
int ret;
|
|
|
|
|
2021-06-25 16:23:15 +02:00
|
|
|
supported_attrs = FUSE_SET_ATTR_SIZE | FUSE_SET_ATTR_MODE;
|
|
|
|
if (exp->allow_other) {
|
|
|
|
supported_attrs |= FUSE_SET_ATTR_UID | FUSE_SET_ATTR_GID;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (to_set & ~supported_attrs) {
|
2020-10-27 20:05:43 +01:00
|
|
|
fuse_reply_err(req, ENOTSUP);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2021-06-25 16:23:15 +02:00
|
|
|
/* Do some argument checks first before committing to anything */
|
|
|
|
if (to_set & FUSE_SET_ATTR_MODE) {
|
|
|
|
/*
|
|
|
|
* Without allow_other, non-owners can never access the export, so do
|
|
|
|
* not allow setting permissions for them
|
|
|
|
*/
|
|
|
|
if (!exp->allow_other &&
|
|
|
|
(statbuf->st_mode & (S_IRWXG | S_IRWXO)) != 0)
|
|
|
|
{
|
|
|
|
fuse_reply_err(req, EPERM);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* +w for read-only exports makes no sense, disallow it */
|
|
|
|
if (!exp->writable &&
|
|
|
|
(statbuf->st_mode & (S_IWUSR | S_IWGRP | S_IWOTH)) != 0)
|
|
|
|
{
|
|
|
|
fuse_reply_err(req, EROFS);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-06-25 16:23:14 +02:00
|
|
|
if (to_set & FUSE_SET_ATTR_SIZE) {
|
|
|
|
if (!exp->writable) {
|
|
|
|
fuse_reply_err(req, EACCES);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = fuse_do_truncate(exp, statbuf->st_size, true, PREALLOC_MODE_OFF);
|
|
|
|
if (ret < 0) {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
return;
|
|
|
|
}
|
2020-10-27 20:05:43 +01:00
|
|
|
}
|
|
|
|
|
2021-06-25 16:23:15 +02:00
|
|
|
if (to_set & FUSE_SET_ATTR_MODE) {
|
|
|
|
/* Ignore FUSE-supplied file type, only change the mode */
|
|
|
|
exp->st_mode = (statbuf->st_mode & 07777) | S_IFREG;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (to_set & FUSE_SET_ATTR_UID) {
|
|
|
|
exp->st_uid = statbuf->st_uid;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (to_set & FUSE_SET_ATTR_GID) {
|
|
|
|
exp->st_gid = statbuf->st_gid;
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:43 +01:00
|
|
|
fuse_getattr(req, inode, fi);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Let clients open a file (i.e., the exported image).
|
|
|
|
*/
|
|
|
|
static void fuse_open(fuse_req_t req, fuse_ino_t inode,
|
|
|
|
struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
fuse_reply_open(req, fi);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Handle client reads from the exported image.
|
|
|
|
*/
|
|
|
|
static void fuse_read(fuse_req_t req, fuse_ino_t inode,
|
|
|
|
size_t size, off_t offset, struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
|
|
|
int64_t length;
|
|
|
|
void *buf;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* Limited by max_read, should not happen */
|
|
|
|
if (size > FUSE_MAX_BOUNCE_BYTES) {
|
|
|
|
fuse_reply_err(req, EINVAL);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Clients will expect short reads at EOF, so we have to limit
|
|
|
|
* offset+size to the image length.
|
|
|
|
*/
|
|
|
|
length = blk_getlength(exp->common.blk);
|
|
|
|
if (length < 0) {
|
|
|
|
fuse_reply_err(req, -length);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (offset + size > length) {
|
|
|
|
size = length - offset;
|
|
|
|
}
|
|
|
|
|
|
|
|
buf = qemu_try_blockalign(blk_bs(exp->common.blk), size);
|
|
|
|
if (!buf) {
|
|
|
|
fuse_reply_err(req, ENOMEM);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
block: Change blk_{pread,pwrite}() param order
Swap 'buf' and 'bytes' around for consistency with
blk_co_{pread,pwrite}(), and in preparation to implement these functions
using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression blk, offset, buf, bytes, flags; @@
- blk_pread(blk, offset, buf, bytes, flags)
+ blk_pread(blk, offset, bytes, buf, flags)
@@ expression blk, offset, buf, bytes, flags; @@
- blk_pwrite(blk, offset, buf, bytes, flags)
+ blk_pwrite(blk, offset, bytes, buf, flags)
It had no effect on hw/block/nand.c, presumably due to the #if, so that
file was updated manually.
Overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220705161527.1054072-4-afaria@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-07-05 18:15:11 +02:00
|
|
|
ret = blk_pread(exp->common.blk, offset, size, buf, 0);
|
2020-10-27 20:05:43 +01:00
|
|
|
if (ret >= 0) {
|
|
|
|
fuse_reply_buf(req, buf, size);
|
|
|
|
} else {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_vfree(buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Handle client writes to the exported image.
|
|
|
|
*/
|
|
|
|
static void fuse_write(fuse_req_t req, fuse_ino_t inode, const char *buf,
|
|
|
|
size_t size, off_t offset, struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
|
|
|
int64_t length;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* Limited by max_write, should not happen */
|
|
|
|
if (size > BDRV_REQUEST_MAX_BYTES) {
|
|
|
|
fuse_reply_err(req, EINVAL);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!exp->writable) {
|
|
|
|
fuse_reply_err(req, EACCES);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Clients will expect short writes at EOF, so we have to limit
|
|
|
|
* offset+size to the image length.
|
|
|
|
*/
|
|
|
|
length = blk_getlength(exp->common.blk);
|
|
|
|
if (length < 0) {
|
|
|
|
fuse_reply_err(req, -length);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (offset + size > length) {
|
2020-10-27 20:05:44 +01:00
|
|
|
if (exp->growable) {
|
|
|
|
ret = fuse_do_truncate(exp, offset + size, true, PREALLOC_MODE_OFF);
|
|
|
|
if (ret < 0) {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
size = length - offset;
|
|
|
|
}
|
2020-10-27 20:05:43 +01:00
|
|
|
}
|
|
|
|
|
block: Change blk_{pread,pwrite}() param order
Swap 'buf' and 'bytes' around for consistency with
blk_co_{pread,pwrite}(), and in preparation to implement these functions
using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression blk, offset, buf, bytes, flags; @@
- blk_pread(blk, offset, buf, bytes, flags)
+ blk_pread(blk, offset, bytes, buf, flags)
@@ expression blk, offset, buf, bytes, flags; @@
- blk_pwrite(blk, offset, buf, bytes, flags)
+ blk_pwrite(blk, offset, bytes, buf, flags)
It had no effect on hw/block/nand.c, presumably due to the #if, so that
file was updated manually.
Overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220705161527.1054072-4-afaria@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-07-05 18:15:11 +02:00
|
|
|
ret = blk_pwrite(exp->common.blk, offset, size, buf, 0);
|
2020-10-27 20:05:43 +01:00
|
|
|
if (ret >= 0) {
|
|
|
|
fuse_reply_write(req, size);
|
|
|
|
} else {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:45 +01:00
|
|
|
/**
|
|
|
|
* Let clients perform various fallocate() operations.
|
|
|
|
*/
|
|
|
|
static void fuse_fallocate(fuse_req_t req, fuse_ino_t inode, int mode,
|
|
|
|
off_t offset, off_t length,
|
|
|
|
struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
|
|
|
int64_t blk_len;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (!exp->writable) {
|
|
|
|
fuse_reply_err(req, EACCES);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
blk_len = blk_getlength(exp->common.blk);
|
|
|
|
if (blk_len < 0) {
|
|
|
|
fuse_reply_err(req, -blk_len);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-02-01 12:26:55 +01:00
|
|
|
#ifdef CONFIG_FALLOCATE_PUNCH_HOLE
|
2020-10-27 20:05:45 +01:00
|
|
|
if (mode & FALLOC_FL_KEEP_SIZE) {
|
|
|
|
length = MIN(length, blk_len - offset);
|
|
|
|
}
|
2022-02-01 12:26:55 +01:00
|
|
|
#endif /* CONFIG_FALLOCATE_PUNCH_HOLE */
|
2020-10-27 20:05:45 +01:00
|
|
|
|
2022-02-01 12:26:54 +01:00
|
|
|
if (!mode) {
|
|
|
|
/* We can only fallocate at the EOF with a truncate */
|
|
|
|
if (offset < blk_len) {
|
|
|
|
fuse_reply_err(req, EOPNOTSUPP);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (offset > blk_len) {
|
|
|
|
/* No preallocation needed here */
|
|
|
|
ret = fuse_do_truncate(exp, offset, true, PREALLOC_MODE_OFF);
|
|
|
|
if (ret < 0) {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = fuse_do_truncate(exp, offset + length, true,
|
|
|
|
PREALLOC_MODE_FALLOC);
|
|
|
|
}
|
2022-02-01 12:26:55 +01:00
|
|
|
#ifdef CONFIG_FALLOCATE_PUNCH_HOLE
|
2022-02-01 12:26:54 +01:00
|
|
|
else if (mode & FALLOC_FL_PUNCH_HOLE) {
|
2020-10-27 20:05:45 +01:00
|
|
|
if (!(mode & FALLOC_FL_KEEP_SIZE)) {
|
|
|
|
fuse_reply_err(req, EINVAL);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
do {
|
|
|
|
int size = MIN(length, BDRV_REQUEST_MAX_BYTES);
|
|
|
|
|
2023-02-27 11:47:24 +01:00
|
|
|
ret = blk_pwrite_zeroes(exp->common.blk, offset, size,
|
|
|
|
BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK);
|
|
|
|
if (ret == -ENOTSUP) {
|
|
|
|
/*
|
|
|
|
* fallocate() specifies to return EOPNOTSUPP for unsupported
|
|
|
|
* operations
|
|
|
|
*/
|
|
|
|
ret = -EOPNOTSUPP;
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:45 +01:00
|
|
|
offset += size;
|
|
|
|
length -= size;
|
|
|
|
} while (ret == 0 && length > 0);
|
2021-08-09 11:51:01 +02:00
|
|
|
}
|
2022-02-01 12:26:55 +01:00
|
|
|
#endif /* CONFIG_FALLOCATE_PUNCH_HOLE */
|
2021-08-09 11:51:01 +02:00
|
|
|
#ifdef CONFIG_FALLOCATE_ZERO_RANGE
|
|
|
|
else if (mode & FALLOC_FL_ZERO_RANGE) {
|
2020-10-27 20:05:45 +01:00
|
|
|
if (!(mode & FALLOC_FL_KEEP_SIZE) && offset + length > blk_len) {
|
|
|
|
/* No need for zeroes, we are going to write them ourselves */
|
|
|
|
ret = fuse_do_truncate(exp, offset + length, false,
|
|
|
|
PREALLOC_MODE_OFF);
|
|
|
|
if (ret < 0) {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
do {
|
|
|
|
int size = MIN(length, BDRV_REQUEST_MAX_BYTES);
|
|
|
|
|
|
|
|
ret = blk_pwrite_zeroes(exp->common.blk,
|
|
|
|
offset, size, 0);
|
|
|
|
offset += size;
|
|
|
|
length -= size;
|
|
|
|
} while (ret == 0 && length > 0);
|
2021-08-09 11:51:01 +02:00
|
|
|
}
|
|
|
|
#endif /* CONFIG_FALLOCATE_ZERO_RANGE */
|
2022-02-01 12:26:54 +01:00
|
|
|
else {
|
2020-10-27 20:05:45 +01:00
|
|
|
ret = -EOPNOTSUPP;
|
|
|
|
}
|
|
|
|
|
|
|
|
fuse_reply_err(req, ret < 0 ? -ret : 0);
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:43 +01:00
|
|
|
/**
|
|
|
|
* Let clients fsync the exported image.
|
|
|
|
*/
|
|
|
|
static void fuse_fsync(fuse_req_t req, fuse_ino_t inode, int datasync,
|
|
|
|
struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = blk_flush(exp->common.blk);
|
|
|
|
fuse_reply_err(req, ret < 0 ? -ret : 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Called before an FD to the exported image is closed. (libfuse
|
|
|
|
* notes this to be a way to return last-minute errors.)
|
|
|
|
*/
|
|
|
|
static void fuse_flush(fuse_req_t req, fuse_ino_t inode,
|
|
|
|
struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
fuse_fsync(req, inode, 1, fi);
|
|
|
|
}
|
|
|
|
|
2020-10-27 20:05:46 +01:00
|
|
|
#ifdef CONFIG_FUSE_LSEEK
|
|
|
|
/**
|
|
|
|
* Let clients inquire allocation status.
|
|
|
|
*/
|
|
|
|
static void fuse_lseek(fuse_req_t req, fuse_ino_t inode, off_t offset,
|
|
|
|
int whence, struct fuse_file_info *fi)
|
|
|
|
{
|
|
|
|
FuseExport *exp = fuse_req_userdata(req);
|
|
|
|
|
|
|
|
if (whence != SEEK_HOLE && whence != SEEK_DATA) {
|
|
|
|
fuse_reply_err(req, EINVAL);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (true) {
|
|
|
|
int64_t pnum;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = bdrv_block_status_above(blk_bs(exp->common.blk), NULL,
|
|
|
|
offset, INT64_MAX, &pnum, NULL, NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
fuse_reply_err(req, -ret);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!pnum && (ret & BDRV_BLOCK_EOF)) {
|
|
|
|
int64_t blk_len;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If blk_getlength() rounds (e.g. by sectors), then the
|
|
|
|
* export length will be rounded, too. However,
|
|
|
|
* bdrv_block_status_above() may return EOF at unaligned
|
|
|
|
* offsets. We must not let this become visible and thus
|
|
|
|
* always simulate a hole between @offset (the real EOF)
|
|
|
|
* and @blk_len (the client-visible EOF).
|
|
|
|
*/
|
|
|
|
|
|
|
|
blk_len = blk_getlength(exp->common.blk);
|
|
|
|
if (blk_len < 0) {
|
|
|
|
fuse_reply_err(req, -blk_len);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (offset > blk_len || whence == SEEK_DATA) {
|
|
|
|
fuse_reply_err(req, ENXIO);
|
|
|
|
} else {
|
|
|
|
fuse_reply_lseek(req, offset);
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ret & BDRV_BLOCK_DATA) {
|
|
|
|
if (whence == SEEK_DATA) {
|
|
|
|
fuse_reply_lseek(req, offset);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (whence == SEEK_HOLE) {
|
|
|
|
fuse_reply_lseek(req, offset);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Safety check against infinite loops */
|
|
|
|
if (!pnum) {
|
|
|
|
fuse_reply_err(req, ENXIO);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
offset += pnum;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2020-10-27 20:05:42 +01:00
|
|
|
static const struct fuse_lowlevel_ops fuse_ops = {
|
|
|
|
.init = fuse_init,
|
2020-10-27 20:05:43 +01:00
|
|
|
.lookup = fuse_lookup,
|
|
|
|
.getattr = fuse_getattr,
|
|
|
|
.setattr = fuse_setattr,
|
|
|
|
.open = fuse_open,
|
|
|
|
.read = fuse_read,
|
|
|
|
.write = fuse_write,
|
2020-10-27 20:05:45 +01:00
|
|
|
.fallocate = fuse_fallocate,
|
2020-10-27 20:05:43 +01:00
|
|
|
.flush = fuse_flush,
|
|
|
|
.fsync = fuse_fsync,
|
2020-10-27 20:05:46 +01:00
|
|
|
#ifdef CONFIG_FUSE_LSEEK
|
|
|
|
.lseek = fuse_lseek,
|
|
|
|
#endif
|
2020-10-27 20:05:42 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
const BlockExportDriver blk_exp_fuse = {
|
|
|
|
.type = BLOCK_EXPORT_TYPE_FUSE,
|
|
|
|
.instance_size = sizeof(FuseExport),
|
|
|
|
.create = fuse_export_create,
|
|
|
|
.delete = fuse_export_delete,
|
|
|
|
.request_shutdown = fuse_export_shutdown,
|
|
|
|
};
|