2013-01-11 18:25:29 +01:00
|
|
|
/*
|
|
|
|
* QEMU IndustryPack emulation
|
|
|
|
*
|
|
|
|
* Copyright (C) 2012 Igalia, S.L.
|
2016-02-23 09:44:25 +01:00
|
|
|
* Author: Alberto Garcia <berto@igalia.com>
|
2013-01-11 18:25:29 +01:00
|
|
|
*
|
|
|
|
* This code is licensed under the GNU GPL v2 or (at your option) any
|
|
|
|
* later version.
|
|
|
|
*/
|
|
|
|
|
2016-01-26 19:17:30 +01:00
|
|
|
#include "qemu/osdep.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 09:01:28 +01:00
|
|
|
#include "qapi/error.h"
|
2019-05-23 16:35:07 +02:00
|
|
|
#include "qemu/module.h"
|
2013-08-02 00:48:40 +02:00
|
|
|
#include "hw/ipack/ipack.h"
|
2019-08-12 07:23:42 +02:00
|
|
|
#include "hw/irq.h"
|
2019-08-12 07:23:51 +02:00
|
|
|
#include "hw/qdev-properties.h"
|
2019-08-12 07:23:45 +02:00
|
|
|
#include "migration/vmstate.h"
|
2013-01-11 18:25:29 +01:00
|
|
|
|
|
|
|
IPackDevice *ipack_device_find(IPackBus *bus, int32_t slot)
|
|
|
|
{
|
|
|
|
BusChild *kid;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH(kid, &BUS(bus)->children, sibling) {
|
|
|
|
DeviceState *qdev = kid->child;
|
|
|
|
IPackDevice *ip = IPACK_DEVICE(qdev);
|
|
|
|
if (ip->slot == slot) {
|
|
|
|
return ip;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2013-08-23 20:07:28 +02:00
|
|
|
void ipack_bus_new_inplace(IPackBus *bus, size_t bus_size,
|
|
|
|
DeviceState *parent,
|
2013-01-11 18:25:29 +01:00
|
|
|
const char *name, uint8_t n_slots,
|
|
|
|
qemu_irq_handler handler)
|
|
|
|
{
|
2013-08-24 00:02:27 +02:00
|
|
|
qbus_create_inplace(bus, bus_size, TYPE_IPACK_BUS, parent, name);
|
2013-01-11 18:25:29 +01:00
|
|
|
bus->n_slots = n_slots;
|
|
|
|
bus->set_irq = handler;
|
|
|
|
}
|
|
|
|
|
2013-08-01 18:45:02 +02:00
|
|
|
static void ipack_device_realize(DeviceState *dev, Error **errp)
|
2013-01-11 18:25:29 +01:00
|
|
|
{
|
2013-08-01 18:45:02 +02:00
|
|
|
IPackDevice *idev = IPACK_DEVICE(dev);
|
|
|
|
IPackBus *bus = IPACK_BUS(qdev_get_parent_bus(dev));
|
2013-01-11 18:25:29 +01:00
|
|
|
IPackDeviceClass *k = IPACK_DEVICE_GET_CLASS(dev);
|
|
|
|
|
2013-08-01 18:45:02 +02:00
|
|
|
if (idev->slot < 0) {
|
|
|
|
idev->slot = bus->free_slot;
|
2013-01-11 18:25:29 +01:00
|
|
|
}
|
2013-08-01 18:45:02 +02:00
|
|
|
if (idev->slot >= bus->n_slots) {
|
|
|
|
error_setg(errp, "Only %" PRIu8 " slots available.", bus->n_slots);
|
|
|
|
return;
|
2013-01-11 18:25:29 +01:00
|
|
|
}
|
2013-08-01 18:45:02 +02:00
|
|
|
bus->free_slot = idev->slot + 1;
|
2013-01-11 18:25:29 +01:00
|
|
|
|
2013-08-01 18:45:02 +02:00
|
|
|
idev->irq = qemu_allocate_irqs(bus->set_irq, idev, 2);
|
2013-01-11 18:25:29 +01:00
|
|
|
|
2013-08-01 18:45:02 +02:00
|
|
|
k->realize(dev, errp);
|
2013-01-11 18:25:29 +01:00
|
|
|
}
|
|
|
|
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 17:29:24 +02:00
|
|
|
static void ipack_device_unrealize(DeviceState *dev)
|
2013-01-11 18:25:29 +01:00
|
|
|
{
|
2013-08-01 18:45:02 +02:00
|
|
|
IPackDevice *idev = IPACK_DEVICE(dev);
|
2013-01-11 18:25:29 +01:00
|
|
|
IPackDeviceClass *k = IPACK_DEVICE_GET_CLASS(dev);
|
|
|
|
|
2013-08-01 18:45:02 +02:00
|
|
|
if (k->unrealize) {
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 17:29:24 +02:00
|
|
|
k->unrealize(dev);
|
2013-08-01 18:45:02 +02:00
|
|
|
return;
|
2013-01-11 18:25:29 +01:00
|
|
|
}
|
|
|
|
|
2014-06-18 09:56:31 +02:00
|
|
|
qemu_free_irqs(idev->irq, 2);
|
2013-01-11 18:25:29 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static Property ipack_device_props[] = {
|
|
|
|
DEFINE_PROP_INT32("slot", IPackDevice, slot, -1),
|
|
|
|
DEFINE_PROP_END_OF_LIST()
|
|
|
|
};
|
|
|
|
|
|
|
|
static void ipack_device_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *k = DEVICE_CLASS(klass);
|
2013-08-01 18:45:02 +02:00
|
|
|
|
2013-07-29 16:17:45 +02:00
|
|
|
set_bit(DEVICE_CATEGORY_INPUT, k->categories);
|
2013-01-11 18:25:29 +01:00
|
|
|
k->bus_type = TYPE_IPACK_BUS;
|
2013-08-01 18:45:02 +02:00
|
|
|
k->realize = ipack_device_realize;
|
|
|
|
k->unrealize = ipack_device_unrealize;
|
2020-01-10 16:30:32 +01:00
|
|
|
device_class_set_props(k, ipack_device_props);
|
2013-01-11 18:25:29 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
const VMStateDescription vmstate_ipack_device = {
|
|
|
|
.name = "ipack_device",
|
|
|
|
.version_id = 1,
|
|
|
|
.minimum_version_id = 1,
|
2014-04-16 16:01:33 +02:00
|
|
|
.fields = (VMStateField[]) {
|
2013-01-11 18:25:29 +01:00
|
|
|
VMSTATE_INT32(slot, IPackDevice),
|
|
|
|
VMSTATE_END_OF_LIST()
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
static const TypeInfo ipack_device_info = {
|
|
|
|
.name = TYPE_IPACK_DEVICE,
|
|
|
|
.parent = TYPE_DEVICE,
|
|
|
|
.instance_size = sizeof(IPackDevice),
|
|
|
|
.class_size = sizeof(IPackDeviceClass),
|
|
|
|
.class_init = ipack_device_class_init,
|
|
|
|
.abstract = true,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const TypeInfo ipack_bus_info = {
|
|
|
|
.name = TYPE_IPACK_BUS,
|
|
|
|
.parent = TYPE_BUS,
|
|
|
|
.instance_size = sizeof(IPackBus),
|
|
|
|
};
|
|
|
|
|
|
|
|
static void ipack_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&ipack_device_info);
|
|
|
|
type_register_static(&ipack_bus_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(ipack_register_types)
|