2019-03-07 15:58:38 +01:00
|
|
|
#!/usr/bin/env bash
|
2010-10-15 16:56:35 +02:00
|
|
|
#
|
|
|
|
# Test that backing files can be smaller than the image
|
|
|
|
#
|
|
|
|
# Copyright (C) 2010 IBM, Corp.
|
|
|
|
#
|
|
|
|
# Based on 017:
|
|
|
|
# Copyright (C) 2009 Red Hat, Inc.
|
|
|
|
#
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
|
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
|
|
# (at your option) any later version.
|
|
|
|
#
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
|
|
|
#
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
|
|
|
|
|
|
# creator
|
|
|
|
owner=stefanha@linux.vnet.ibm.com
|
|
|
|
|
|
|
|
seq=`basename $0`
|
|
|
|
echo "QA output created by $seq"
|
|
|
|
|
|
|
|
status=1 # failure is the default!
|
|
|
|
|
|
|
|
_cleanup()
|
|
|
|
{
|
2017-04-18 21:42:41 +02:00
|
|
|
_cleanup_qemu
|
2019-11-07 17:37:01 +01:00
|
|
|
_rm_test_img "${TEST_IMG}.copy"
|
2014-07-07 16:38:58 +02:00
|
|
|
_cleanup_test_img
|
2010-10-15 16:56:35 +02:00
|
|
|
}
|
|
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
|
|
|
|
# get standard environment, filters and checks
|
|
|
|
. ./common.rc
|
|
|
|
. ./common.filter
|
|
|
|
. ./common.pattern
|
2014-07-07 16:38:58 +02:00
|
|
|
. ./common.qemu
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
# Any format supporting backing files except vmdk and qcow which do not support
|
|
|
|
# smaller backing files.
|
2010-10-31 21:10:20 +01:00
|
|
|
_supported_fmt qcow2 qed
|
2014-02-03 10:26:14 +01:00
|
|
|
_supported_proto file
|
2010-10-15 16:56:35 +02:00
|
|
|
_supported_os Linux
|
|
|
|
|
|
|
|
# Choose a size that is not necessarily a cluster size multiple for image
|
|
|
|
# formats that use clusters. This will ensure that the base image doesn't end
|
|
|
|
# precisely on a cluster boundary (the easy case).
|
|
|
|
image_size=$(( 4 * 1024 * 1024 * 1024 + 3 * 512 ))
|
|
|
|
|
|
|
|
# The base image is smaller than the image file
|
|
|
|
base_size=$(( image_size - 1024 * 1024 * 1024 ))
|
|
|
|
|
|
|
|
offset=$(( base_size - 32 * 1024 ))
|
|
|
|
|
2015-12-22 03:49:15 +01:00
|
|
|
TEST_IMG_SAVE="$TEST_IMG"
|
|
|
|
TEST_IMG="$TEST_IMG.base"
|
|
|
|
|
2010-10-15 16:56:35 +02:00
|
|
|
_make_test_img $base_size
|
|
|
|
|
|
|
|
echo "Filling base image"
|
|
|
|
echo
|
|
|
|
|
|
|
|
# Fill end of base image with a pattern, skipping every other sector
|
qemu-iotests: Use zero-based offsets for IO patterns
The io_pattern style functions have the following loop:
for i in `seq 1 $count`; do
echo ... $(( start + i * step )) ...
done
Offsets are 1-based so start=1024, step=512, count=4 yields:
1536, 2048, 2560, 3072
Normally we expect:
1024, 1536, 2048, 2560
Most tests ignore this detail, which means that they perform I/O to a
slightly different range than expected by the test author.
Later on things got less innocent and tests started trying to compensate
for the 1-based indexing. This included negative start values in test
024 and my own attempt with count-1 in test 028!
The end result is that tests that use io_pattern are hard to reason
about and don't work the way you'd expect. It's time to clean this mess
up.
This patch switches io_pattern to 0-based offsets. This requires
adjusting the golden outputs since I/O ranges are now shifted and output
differs.
Verifying these output diffs is easy, however. Each diff hunk moves one
I/O from beyond the end of the pattern range to the beginning.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2011-02-04 13:55:02 +01:00
|
|
|
io writev $offset 512 1024 32
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
_check_test_img
|
|
|
|
|
|
|
|
echo "Creating test image with backing file"
|
|
|
|
echo
|
|
|
|
|
2015-12-22 03:49:15 +01:00
|
|
|
TEST_IMG="$TEST_IMG_SAVE"
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 22:39:52 +02:00
|
|
|
_make_test_img -b "$TEST_IMG.base" -F $IMGFMT $image_size
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
echo "Filling test image"
|
|
|
|
echo
|
|
|
|
|
|
|
|
# Write every other sector around where the base image ends
|
qemu-iotests: Use zero-based offsets for IO patterns
The io_pattern style functions have the following loop:
for i in `seq 1 $count`; do
echo ... $(( start + i * step )) ...
done
Offsets are 1-based so start=1024, step=512, count=4 yields:
1536, 2048, 2560, 3072
Normally we expect:
1024, 1536, 2048, 2560
Most tests ignore this detail, which means that they perform I/O to a
slightly different range than expected by the test author.
Later on things got less innocent and tests started trying to compensate
for the 1-based indexing. This included negative start values in test
024 and my own attempt with count-1 in test 028!
The end result is that tests that use io_pattern are hard to reason
about and don't work the way you'd expect. It's time to clean this mess
up.
This patch switches io_pattern to 0-based offsets. This requires
adjusting the golden outputs since I/O ranges are now shifted and output
differs.
Verifying these output diffs is easy, however. Each diff hunk moves one
I/O from beyond the end of the pattern range to the beginning.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2011-02-04 13:55:02 +01:00
|
|
|
io writev $(( offset + 512 )) 512 1024 64
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
_check_test_img
|
|
|
|
|
|
|
|
echo "Reading"
|
|
|
|
echo
|
|
|
|
|
|
|
|
# Base image sectors
|
qemu-iotests: Use zero-based offsets for IO patterns
The io_pattern style functions have the following loop:
for i in `seq 1 $count`; do
echo ... $(( start + i * step )) ...
done
Offsets are 1-based so start=1024, step=512, count=4 yields:
1536, 2048, 2560, 3072
Normally we expect:
1024, 1536, 2048, 2560
Most tests ignore this detail, which means that they perform I/O to a
slightly different range than expected by the test author.
Later on things got less innocent and tests started trying to compensate
for the 1-based indexing. This included negative start values in test
024 and my own attempt with count-1 in test 028!
The end result is that tests that use io_pattern are hard to reason
about and don't work the way you'd expect. It's time to clean this mess
up.
This patch switches io_pattern to 0-based offsets. This requires
adjusting the golden outputs since I/O ranges are now shifted and output
differs.
Verifying these output diffs is easy, however. Each diff hunk moves one
I/O from beyond the end of the pattern range to the beginning.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2011-02-04 13:55:02 +01:00
|
|
|
io readv $(( offset )) 512 1024 32
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
# Image sectors
|
qemu-iotests: Use zero-based offsets for IO patterns
The io_pattern style functions have the following loop:
for i in `seq 1 $count`; do
echo ... $(( start + i * step )) ...
done
Offsets are 1-based so start=1024, step=512, count=4 yields:
1536, 2048, 2560, 3072
Normally we expect:
1024, 1536, 2048, 2560
Most tests ignore this detail, which means that they perform I/O to a
slightly different range than expected by the test author.
Later on things got less innocent and tests started trying to compensate
for the 1-based indexing. This included negative start values in test
024 and my own attempt with count-1 in test 028!
The end result is that tests that use io_pattern are hard to reason
about and don't work the way you'd expect. It's time to clean this mess
up.
This patch switches io_pattern to 0-based offsets. This requires
adjusting the golden outputs since I/O ranges are now shifted and output
differs.
Verifying these output diffs is easy, however. Each diff hunk moves one
I/O from beyond the end of the pattern range to the beginning.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2011-02-04 13:55:02 +01:00
|
|
|
io readv $(( offset + 512 )) 512 1024 64
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
# Zero sectors beyond end of base image
|
qemu-iotests: Use zero-based offsets for IO patterns
The io_pattern style functions have the following loop:
for i in `seq 1 $count`; do
echo ... $(( start + i * step )) ...
done
Offsets are 1-based so start=1024, step=512, count=4 yields:
1536, 2048, 2560, 3072
Normally we expect:
1024, 1536, 2048, 2560
Most tests ignore this detail, which means that they perform I/O to a
slightly different range than expected by the test author.
Later on things got less innocent and tests started trying to compensate
for the 1-based indexing. This included negative start values in test
024 and my own attempt with count-1 in test 028!
The end result is that tests that use io_pattern are hard to reason
about and don't work the way you'd expect. It's time to clean this mess
up.
This patch switches io_pattern to 0-based offsets. This requires
adjusting the golden outputs since I/O ranges are now shifted and output
differs.
Verifying these output diffs is easy, however. Each diff hunk moves one
I/O from beyond the end of the pattern range to the beginning.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2011-02-04 13:55:02 +01:00
|
|
|
io_zero readv $(( offset + 32 * 1024 )) 512 1024 32
|
2010-10-15 16:56:35 +02:00
|
|
|
|
|
|
|
_check_test_img
|
|
|
|
|
2012-02-15 15:03:25 +01:00
|
|
|
# Rebase it on top of its base image
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 22:39:52 +02:00
|
|
|
$QEMU_IMG rebase -b "$TEST_IMG.base" -F $IMGFMT "$TEST_IMG"
|
2012-02-15 15:03:25 +01:00
|
|
|
|
2014-07-07 16:38:58 +02:00
|
|
|
echo
|
|
|
|
echo block-backup
|
|
|
|
echo
|
|
|
|
|
|
|
|
qemu_comm_method="monitor"
|
2020-01-20 15:18:58 +01:00
|
|
|
_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},aio=${AIOMODE},id=disk
|
2014-07-07 16:38:58 +02:00
|
|
|
h=$QEMU_HANDLE
|
2019-09-04 11:11:23 +02:00
|
|
|
if [ "${VALGRIND_QEMU}" == "y" ]; then
|
|
|
|
QEMU_COMM_TIMEOUT=7
|
|
|
|
else
|
|
|
|
QEMU_COMM_TIMEOUT=1
|
|
|
|
fi
|
2014-07-07 16:38:58 +02:00
|
|
|
|
2014-07-17 20:09:39 +02:00
|
|
|
# Silence output since it contains the disk image path and QEMU's readline
|
2015-12-11 04:27:17 +01:00
|
|
|
# character echoing makes it very hard to filter the output. Plus, there
|
|
|
|
# is no telling how many times the command will repeat before succeeding.
|
2019-10-11 14:18:08 +02:00
|
|
|
# (Note that creating the image results in a "Formatting..." message over
|
|
|
|
# stdout, which is the same channel the monitor uses. We cannot reliably
|
|
|
|
# wait for it because the monitor output may interact with it in such a
|
|
|
|
# way that _timed_wait_for cannot read it. However, once the block job is
|
|
|
|
# done, we know that the "Formatting..." message must have appeared
|
|
|
|
# already, so the output is still deterministic.)
|
|
|
|
silent=y _send_qemu_cmd $h "drive_backup disk ${TEST_IMG}.copy" "(qemu)"
|
|
|
|
silent=y qemu_cmd_repeat=20 _send_qemu_cmd $h "info block-jobs" "No active jobs"
|
2015-12-11 04:27:17 +01:00
|
|
|
_send_qemu_cmd $h "info block-jobs" "No active jobs"
|
2014-07-07 16:38:58 +02:00
|
|
|
_send_qemu_cmd $h 'quit' ""
|
|
|
|
|
|
|
|
# Base image sectors
|
|
|
|
TEST_IMG="${TEST_IMG}.copy" io readv $(( offset )) 512 1024 32
|
|
|
|
|
|
|
|
# Image sectors
|
|
|
|
TEST_IMG="${TEST_IMG}.copy" io readv $(( offset + 512 )) 512 1024 64
|
|
|
|
|
|
|
|
# Zero sectors beyond end of base image
|
|
|
|
TEST_IMG="${TEST_IMG}.copy" io_zero readv $(( offset + 32 * 1024 )) 512 1024 32
|
|
|
|
|
|
|
|
|
2012-02-15 15:03:25 +01:00
|
|
|
_check_test_img
|
|
|
|
|
2020-07-28 14:08:05 +02:00
|
|
|
echo
|
|
|
|
echo '=== Reading across backing EOF in one operation ==='
|
|
|
|
echo
|
|
|
|
|
|
|
|
# Use a cluster boundary as the base end here
|
|
|
|
base_size=$((3 * 1024 * 1024 * 1024))
|
|
|
|
|
|
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img $base_size
|
|
|
|
_make_test_img -b "$TEST_IMG.base" -F $IMGFMT $image_size
|
|
|
|
|
|
|
|
# Write 16 times 42 at the end of the base image
|
|
|
|
$QEMU_IO -c "write -P 42 $((base_size - 16)) 16" "$TEST_IMG.base" \
|
|
|
|
| _filter_qemu_io
|
|
|
|
|
|
|
|
# Read 32 bytes across the base EOF from the top;
|
|
|
|
# should be 16 times 0x2a, then 16 times 0x00
|
|
|
|
$QEMU_IO -c "read -v $((base_size - 16)) 32" "$TEST_IMG" \
|
|
|
|
| _filter_qemu_io
|
|
|
|
|
2010-10-15 16:56:35 +02:00
|
|
|
# success, all done
|
|
|
|
echo "*** done"
|
|
|
|
rm -f $seq.full
|
|
|
|
status=0
|