2017-04-11 17:30:05 +02:00
|
|
|
/*
|
|
|
|
* QEMU PowerNV, BMC related functions
|
|
|
|
*
|
|
|
|
* Copyright (c) 2016-2017, IBM Corporation.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License, version 2, as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
ppc/pnv: Create BMC devices at machine init
The BMC of the OpenPOWER systems monitors the machine state using
sensors, controls the power and controls the access to the PNOR flash
device containing the firmware image required to boot the host.
QEMU models the power cycle process, access to the sensors and access
to the PNOR device. But, for these features to be available, the QEMU
PowerNV machine needs two extras devices on the command line, an IPMI
BT device for communication and a BMC backend device:
-device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
The BMC properties are then defined accordingly in the device tree and
OPAL self adapts. If a BMC device and an IPMI BT device are not
available, OPAL does not try to communicate with the BMC in any
manner. This is not how real systems behave.
To be closer to the default behavior, create an IPMI BMC simulator
device and an IPMI BT device at machine initialization time. We loose
the ability to define an external BMC device but there are benefits:
- a better match with real systems,
- a better test coverage of the OPAL code,
- system powerdown and reset commands that work,
- a QEMU device tree compliant with the specifications (*).
(*) Still needs a MBOX device.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20191121162340.11049-1-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-11-21 17:23:40 +01:00
|
|
|
#include "qapi/error.h"
|
2017-04-11 17:30:05 +02:00
|
|
|
#include "target/ppc/cpu.h"
|
|
|
|
#include "qemu/log.h"
|
|
|
|
#include "hw/ipmi/ipmi.h"
|
|
|
|
#include "hw/ppc/fdt.h"
|
|
|
|
|
|
|
|
#include "hw/ppc/pnv.h"
|
|
|
|
|
|
|
|
#include <libfdt.h>
|
|
|
|
|
|
|
|
/* TODO: include definition in ipmi.h */
|
|
|
|
#define IPMI_SDR_FULL_TYPE 1
|
|
|
|
|
2017-04-11 17:30:06 +02:00
|
|
|
/*
|
|
|
|
* OEM SEL Event data packet sent by BMC in response of a Read Event
|
|
|
|
* Message Buffer command
|
|
|
|
*/
|
|
|
|
typedef struct OemSel {
|
|
|
|
/* SEL header */
|
|
|
|
uint8_t id[2];
|
|
|
|
uint8_t type;
|
|
|
|
uint8_t timestamp[4];
|
|
|
|
uint8_t manuf_id[3];
|
|
|
|
|
|
|
|
/* OEM SEL data (6 bytes) follows */
|
|
|
|
uint8_t netfun;
|
|
|
|
uint8_t cmd;
|
|
|
|
uint8_t data[4];
|
|
|
|
} OemSel;
|
|
|
|
|
|
|
|
#define SOFT_OFF 0x00
|
|
|
|
#define SOFT_REBOOT 0x01
|
|
|
|
|
ppc/pnv: Discard internal BMC initialization when BMC is external
The PowerNV machine can be run with an external IPMI BMC device
connected to a remote QEMU machine acting as BMC, using these options :
-chardev socket,id=ipmi0,host=localhost,port=9002,reconnect=10 \
-device ipmi-bmc-extern,id=bmc0,chardev=ipmi0 \
-device isa-ipmi-bt,bmc=bmc0,irq=10 \
-nodefaults
In that case, some aspects of the BMC initialization should be
skipped, since they rely on the simulator interface.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210126171059.307867-6-clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2021-01-26 18:10:57 +01:00
|
|
|
static bool pnv_bmc_is_simulator(IPMIBmc *bmc)
|
|
|
|
{
|
|
|
|
return object_dynamic_cast(OBJECT(bmc), TYPE_IPMI_BMC_SIMULATOR);
|
|
|
|
}
|
|
|
|
|
2017-04-11 17:30:06 +02:00
|
|
|
static void pnv_gen_oem_sel(IPMIBmc *bmc, uint8_t reboot)
|
|
|
|
{
|
|
|
|
/* IPMI SEL Event are 16 bytes long */
|
|
|
|
OemSel sel = {
|
|
|
|
.id = { 0x55 , 0x55 },
|
|
|
|
.type = 0xC0, /* OEM */
|
|
|
|
.manuf_id = { 0x0, 0x0, 0x0 },
|
|
|
|
.timestamp = { 0x0, 0x0, 0x0, 0x0 },
|
|
|
|
.netfun = 0x3A, /* IBM */
|
|
|
|
.cmd = 0x04, /* AMI OEM SEL Power Notification */
|
|
|
|
.data = { reboot, 0xFF, 0xFF, 0xFF },
|
|
|
|
};
|
|
|
|
|
|
|
|
ipmi_bmc_gen_event(bmc, (uint8_t *) &sel, 0 /* do not log the event */);
|
|
|
|
}
|
|
|
|
|
|
|
|
void pnv_bmc_powerdown(IPMIBmc *bmc)
|
|
|
|
{
|
|
|
|
pnv_gen_oem_sel(bmc, SOFT_OFF);
|
|
|
|
}
|
|
|
|
|
2017-12-15 14:56:01 +01:00
|
|
|
void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt)
|
2017-04-11 17:30:05 +02:00
|
|
|
{
|
|
|
|
int offset;
|
|
|
|
int i;
|
|
|
|
const struct ipmi_sdr_compact *sdr;
|
|
|
|
uint16_t nextrec;
|
|
|
|
|
ppc/pnv: Discard internal BMC initialization when BMC is external
The PowerNV machine can be run with an external IPMI BMC device
connected to a remote QEMU machine acting as BMC, using these options :
-chardev socket,id=ipmi0,host=localhost,port=9002,reconnect=10 \
-device ipmi-bmc-extern,id=bmc0,chardev=ipmi0 \
-device isa-ipmi-bt,bmc=bmc0,irq=10 \
-nodefaults
In that case, some aspects of the BMC initialization should be
skipped, since they rely on the simulator interface.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210126171059.307867-6-clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2021-01-26 18:10:57 +01:00
|
|
|
if (!pnv_bmc_is_simulator(bmc)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-09-02 11:29:32 +02:00
|
|
|
offset = fdt_add_subnode(fdt, 0, "bmc");
|
2017-04-11 17:30:05 +02:00
|
|
|
_FDT(offset);
|
|
|
|
|
|
|
|
_FDT((fdt_setprop_string(fdt, offset, "name", "bmc")));
|
|
|
|
offset = fdt_add_subnode(fdt, offset, "sensors");
|
|
|
|
_FDT(offset);
|
|
|
|
|
|
|
|
_FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1)));
|
|
|
|
_FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0)));
|
|
|
|
|
|
|
|
for (i = 0; !ipmi_bmc_sdr_find(bmc, i, &sdr, &nextrec); i++) {
|
|
|
|
int off;
|
|
|
|
char *name;
|
|
|
|
|
|
|
|
if (sdr->header.rec_type != IPMI_SDR_COMPACT_TYPE &&
|
|
|
|
sdr->header.rec_type != IPMI_SDR_FULL_TYPE) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
name = g_strdup_printf("sensor@%x", sdr->sensor_owner_number);
|
|
|
|
off = fdt_add_subnode(fdt, offset, name);
|
|
|
|
_FDT(off);
|
|
|
|
g_free(name);
|
|
|
|
|
|
|
|
_FDT((fdt_setprop_cell(fdt, off, "reg", sdr->sensor_owner_number)));
|
|
|
|
_FDT((fdt_setprop_string(fdt, off, "name", "sensor")));
|
|
|
|
_FDT((fdt_setprop_string(fdt, off, "compatible", "ibm,ipmi-sensor")));
|
|
|
|
_FDT((fdt_setprop_cell(fdt, off, "ipmi-sensor-reading-type",
|
|
|
|
sdr->reading_type)));
|
|
|
|
_FDT((fdt_setprop_cell(fdt, off, "ipmi-entity-id",
|
|
|
|
sdr->entity_id)));
|
|
|
|
_FDT((fdt_setprop_cell(fdt, off, "ipmi-entity-instance",
|
|
|
|
sdr->entity_instance)));
|
|
|
|
_FDT((fdt_setprop_cell(fdt, off, "ipmi-sensor-type",
|
|
|
|
sdr->sensor_type)));
|
|
|
|
}
|
|
|
|
}
|
2019-10-28 08:00:27 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* HIOMAP protocol handler
|
|
|
|
*/
|
|
|
|
#define HIOMAP_C_RESET 1
|
|
|
|
#define HIOMAP_C_GET_INFO 2
|
|
|
|
#define HIOMAP_C_GET_FLASH_INFO 3
|
|
|
|
#define HIOMAP_C_CREATE_READ_WINDOW 4
|
|
|
|
#define HIOMAP_C_CLOSE_WINDOW 5
|
|
|
|
#define HIOMAP_C_CREATE_WRITE_WINDOW 6
|
|
|
|
#define HIOMAP_C_MARK_DIRTY 7
|
|
|
|
#define HIOMAP_C_FLUSH 8
|
|
|
|
#define HIOMAP_C_ACK 9
|
|
|
|
#define HIOMAP_C_ERASE 10
|
|
|
|
#define HIOMAP_C_DEVICE_NAME 11
|
|
|
|
#define HIOMAP_C_LOCK 12
|
|
|
|
|
|
|
|
#define BLOCK_SHIFT 12 /* 4K */
|
|
|
|
|
|
|
|
static uint16_t bytes_to_blocks(uint32_t bytes)
|
|
|
|
{
|
|
|
|
return bytes >> BLOCK_SHIFT;
|
|
|
|
}
|
|
|
|
|
2020-08-20 18:46:38 +02:00
|
|
|
static uint32_t blocks_to_bytes(uint16_t blocks)
|
|
|
|
{
|
|
|
|
return blocks << BLOCK_SHIFT;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int hiomap_erase(PnvPnor *pnor, uint32_t offset, uint32_t size)
|
|
|
|
{
|
|
|
|
MemTxResult result;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < size / 4; i++) {
|
|
|
|
result = memory_region_dispatch_write(&pnor->mmio, offset + i * 4,
|
|
|
|
0xFFFFFFFF, MO_32,
|
|
|
|
MEMTXATTRS_UNSPECIFIED);
|
|
|
|
if (result != MEMTX_OK) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-10-28 08:00:27 +01:00
|
|
|
static void hiomap_cmd(IPMIBmcSim *ibs, uint8_t *cmd, unsigned int cmd_len,
|
|
|
|
RspBuffer *rsp)
|
|
|
|
{
|
2020-01-06 15:56:40 +01:00
|
|
|
PnvPnor *pnor = PNV_PNOR(object_property_get_link(OBJECT(ibs), "pnor",
|
|
|
|
&error_abort));
|
2019-10-28 08:00:27 +01:00
|
|
|
uint32_t pnor_size = pnor->size;
|
|
|
|
uint32_t pnor_addr = PNOR_SPI_OFFSET;
|
|
|
|
bool readonly = false;
|
|
|
|
|
|
|
|
rsp_buffer_push(rsp, cmd[2]);
|
|
|
|
rsp_buffer_push(rsp, cmd[3]);
|
|
|
|
|
|
|
|
switch (cmd[2]) {
|
|
|
|
case HIOMAP_C_MARK_DIRTY:
|
|
|
|
case HIOMAP_C_FLUSH:
|
|
|
|
case HIOMAP_C_ACK:
|
|
|
|
break;
|
|
|
|
|
2020-08-20 18:46:38 +02:00
|
|
|
case HIOMAP_C_ERASE:
|
|
|
|
if (hiomap_erase(pnor, blocks_to_bytes(cmd[5] << 8 | cmd[4]),
|
|
|
|
blocks_to_bytes(cmd[7] << 8 | cmd[6]))) {
|
|
|
|
rsp_buffer_set_error(rsp, IPMI_CC_UNSPECIFIED);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
2019-10-28 08:00:27 +01:00
|
|
|
case HIOMAP_C_GET_INFO:
|
|
|
|
rsp_buffer_push(rsp, 2); /* Version 2 */
|
|
|
|
rsp_buffer_push(rsp, BLOCK_SHIFT); /* block size */
|
|
|
|
rsp_buffer_push(rsp, 0); /* Timeout */
|
|
|
|
rsp_buffer_push(rsp, 0); /* Timeout */
|
|
|
|
break;
|
|
|
|
|
|
|
|
case HIOMAP_C_GET_FLASH_INFO:
|
|
|
|
rsp_buffer_push(rsp, bytes_to_blocks(pnor_size) & 0xFF);
|
|
|
|
rsp_buffer_push(rsp, bytes_to_blocks(pnor_size) >> 8);
|
|
|
|
rsp_buffer_push(rsp, 0x01); /* erase size */
|
|
|
|
rsp_buffer_push(rsp, 0x00); /* erase size */
|
|
|
|
break;
|
|
|
|
|
|
|
|
case HIOMAP_C_CREATE_READ_WINDOW:
|
|
|
|
readonly = true;
|
|
|
|
/* Fall through */
|
|
|
|
|
|
|
|
case HIOMAP_C_CREATE_WRITE_WINDOW:
|
|
|
|
memory_region_set_readonly(&pnor->mmio, readonly);
|
|
|
|
memory_region_set_enabled(&pnor->mmio, true);
|
|
|
|
|
|
|
|
rsp_buffer_push(rsp, bytes_to_blocks(pnor_addr) & 0xFF);
|
|
|
|
rsp_buffer_push(rsp, bytes_to_blocks(pnor_addr) >> 8);
|
|
|
|
rsp_buffer_push(rsp, bytes_to_blocks(pnor_size) & 0xFF);
|
|
|
|
rsp_buffer_push(rsp, bytes_to_blocks(pnor_size) >> 8);
|
|
|
|
rsp_buffer_push(rsp, 0x00); /* offset */
|
|
|
|
rsp_buffer_push(rsp, 0x00); /* offset */
|
|
|
|
break;
|
|
|
|
|
|
|
|
case HIOMAP_C_CLOSE_WINDOW:
|
|
|
|
memory_region_set_enabled(&pnor->mmio, false);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case HIOMAP_C_DEVICE_NAME:
|
|
|
|
case HIOMAP_C_RESET:
|
|
|
|
case HIOMAP_C_LOCK:
|
|
|
|
default:
|
2021-03-09 12:15:10 +01:00
|
|
|
qemu_log_mask(LOG_GUEST_ERROR, "HIOMAP: unknown command %02X\n", cmd[2]);
|
2019-10-28 08:00:27 +01:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#define HIOMAP 0x5a
|
|
|
|
|
|
|
|
static const IPMICmdHandler hiomap_cmds[] = {
|
|
|
|
[HIOMAP] = { hiomap_cmd, 3 },
|
|
|
|
};
|
|
|
|
|
|
|
|
static const IPMINetfn hiomap_netfn = {
|
|
|
|
.cmd_nums = ARRAY_SIZE(hiomap_cmds),
|
|
|
|
.cmd_handlers = hiomap_cmds
|
|
|
|
};
|
|
|
|
|
2020-04-04 17:36:55 +02:00
|
|
|
|
|
|
|
void pnv_bmc_set_pnor(IPMIBmc *bmc, PnvPnor *pnor)
|
|
|
|
{
|
ppc/pnv: Discard internal BMC initialization when BMC is external
The PowerNV machine can be run with an external IPMI BMC device
connected to a remote QEMU machine acting as BMC, using these options :
-chardev socket,id=ipmi0,host=localhost,port=9002,reconnect=10 \
-device ipmi-bmc-extern,id=bmc0,chardev=ipmi0 \
-device isa-ipmi-bt,bmc=bmc0,irq=10 \
-nodefaults
In that case, some aspects of the BMC initialization should be
skipped, since they rely on the simulator interface.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210126171059.307867-6-clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2021-01-26 18:10:57 +01:00
|
|
|
if (!pnv_bmc_is_simulator(bmc)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-04-04 17:36:55 +02:00
|
|
|
object_ref(OBJECT(pnor));
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
object_property_add_const_link(OBJECT(bmc), "pnor", OBJECT(pnor));
|
2020-04-04 17:36:55 +02:00
|
|
|
|
|
|
|
/* Install the HIOMAP protocol handlers to access the PNOR */
|
|
|
|
ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(bmc), IPMI_NETFN_OEM,
|
|
|
|
&hiomap_netfn);
|
|
|
|
}
|
|
|
|
|
ppc/pnv: Create BMC devices at machine init
The BMC of the OpenPOWER systems monitors the machine state using
sensors, controls the power and controls the access to the PNOR flash
device containing the firmware image required to boot the host.
QEMU models the power cycle process, access to the sensors and access
to the PNOR device. But, for these features to be available, the QEMU
PowerNV machine needs two extras devices on the command line, an IPMI
BT device for communication and a BMC backend device:
-device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
The BMC properties are then defined accordingly in the device tree and
OPAL self adapts. If a BMC device and an IPMI BT device are not
available, OPAL does not try to communicate with the BMC in any
manner. This is not how real systems behave.
To be closer to the default behavior, create an IPMI BMC simulator
device and an IPMI BT device at machine initialization time. We loose
the ability to define an external BMC device but there are benefits:
- a better match with real systems,
- a better test coverage of the OPAL code,
- system powerdown and reset commands that work,
- a QEMU device tree compliant with the specifications (*).
(*) Still needs a MBOX device.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20191121162340.11049-1-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-11-21 17:23:40 +01:00
|
|
|
/*
|
|
|
|
* Instantiate the machine BMC. PowerNV uses the QEMU internal
|
|
|
|
* simulator but it could also be external.
|
|
|
|
*/
|
2020-01-06 15:56:40 +01:00
|
|
|
IPMIBmc *pnv_bmc_create(PnvPnor *pnor)
|
2019-10-28 08:00:27 +01:00
|
|
|
{
|
ppc/pnv: Create BMC devices at machine init
The BMC of the OpenPOWER systems monitors the machine state using
sensors, controls the power and controls the access to the PNOR flash
device containing the firmware image required to boot the host.
QEMU models the power cycle process, access to the sensors and access
to the PNOR device. But, for these features to be available, the QEMU
PowerNV machine needs two extras devices on the command line, an IPMI
BT device for communication and a BMC backend device:
-device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
The BMC properties are then defined accordingly in the device tree and
OPAL self adapts. If a BMC device and an IPMI BT device are not
available, OPAL does not try to communicate with the BMC in any
manner. This is not how real systems behave.
To be closer to the default behavior, create an IPMI BMC simulator
device and an IPMI BT device at machine initialization time. We loose
the ability to define an external BMC device but there are benefits:
- a better match with real systems,
- a better test coverage of the OPAL code,
- system powerdown and reset commands that work,
- a QEMU device tree compliant with the specifications (*).
(*) Still needs a MBOX device.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20191121162340.11049-1-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-11-21 17:23:40 +01:00
|
|
|
Object *obj;
|
|
|
|
|
|
|
|
obj = object_new(TYPE_IPMI_BMC_SIMULATOR);
|
qdev: Convert bus-less devices to qdev_realize() with Coccinelle
All remaining conversions to qdev_realize() are for bus-less devices.
Coccinelle script:
// only correct for bus-less @dev!
@@
expression errp;
expression dev;
@@
- qdev_init_nofail(dev);
+ qdev_realize(dev, NULL, &error_fatal);
@ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
expression errp;
expression dev;
symbol true;
@@
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize(DEVICE(dev), NULL, errp);
@ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
expression errp;
expression dev;
symbol true;
@@
- object_property_set_bool(dev, true, "realized", errp);
+ qdev_realize(DEVICE(dev), NULL, errp);
Note that Coccinelle chokes on ARMSSE typedef vs. macro in
hw/arm/armsse.c. Worked around by temporarily renaming the macro for
the spatch run.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-57-armbru@redhat.com>
2020-06-10 07:32:45 +02:00
|
|
|
qdev_realize(DEVICE(obj), NULL, &error_fatal);
|
2021-01-26 18:10:56 +01:00
|
|
|
pnv_bmc_set_pnor(IPMI_BMC(obj), pnor);
|
ppc/pnv: Create BMC devices at machine init
The BMC of the OpenPOWER systems monitors the machine state using
sensors, controls the power and controls the access to the PNOR flash
device containing the firmware image required to boot the host.
QEMU models the power cycle process, access to the sensors and access
to the PNOR device. But, for these features to be available, the QEMU
PowerNV machine needs two extras devices on the command line, an IPMI
BT device for communication and a BMC backend device:
-device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
The BMC properties are then defined accordingly in the device tree and
OPAL self adapts. If a BMC device and an IPMI BT device are not
available, OPAL does not try to communicate with the BMC in any
manner. This is not how real systems behave.
To be closer to the default behavior, create an IPMI BMC simulator
device and an IPMI BT device at machine initialization time. We loose
the ability to define an external BMC device but there are benefits:
- a better match with real systems,
- a better test coverage of the OPAL code,
- system powerdown and reset commands that work,
- a QEMU device tree compliant with the specifications (*).
(*) Still needs a MBOX device.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20191121162340.11049-1-clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-11-21 17:23:40 +01:00
|
|
|
|
|
|
|
return IPMI_BMC(obj);
|
2019-10-28 08:00:27 +01:00
|
|
|
}
|
2020-04-04 17:36:55 +02:00
|
|
|
|
|
|
|
typedef struct ForeachArgs {
|
|
|
|
const char *name;
|
|
|
|
Object *obj;
|
|
|
|
} ForeachArgs;
|
|
|
|
|
|
|
|
static int bmc_find(Object *child, void *opaque)
|
|
|
|
{
|
|
|
|
ForeachArgs *args = opaque;
|
|
|
|
|
|
|
|
if (object_dynamic_cast(child, args->name)) {
|
|
|
|
if (args->obj) {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
args->obj = child;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
IPMIBmc *pnv_bmc_find(Error **errp)
|
|
|
|
{
|
ppc/pnv: Discard internal BMC initialization when BMC is external
The PowerNV machine can be run with an external IPMI BMC device
connected to a remote QEMU machine acting as BMC, using these options :
-chardev socket,id=ipmi0,host=localhost,port=9002,reconnect=10 \
-device ipmi-bmc-extern,id=bmc0,chardev=ipmi0 \
-device isa-ipmi-bt,bmc=bmc0,irq=10 \
-nodefaults
In that case, some aspects of the BMC initialization should be
skipped, since they rely on the simulator interface.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210126171059.307867-6-clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2021-01-26 18:10:57 +01:00
|
|
|
ForeachArgs args = { TYPE_IPMI_BMC, NULL };
|
2020-04-04 17:36:55 +02:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = object_child_foreach_recursive(object_get_root(), bmc_find, &args);
|
|
|
|
if (ret) {
|
|
|
|
error_setg(errp, "machine should have only one BMC device. "
|
|
|
|
"Use '-nodefaults'");
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return args.obj ? IPMI_BMC(args.obj) : NULL;
|
|
|
|
}
|