2018-03-02 13:31:13 +01:00
|
|
|
/*
|
|
|
|
* QEMU RISC-V VirtIO Board
|
|
|
|
*
|
|
|
|
* Copyright (c) 2017 SiFive, Inc.
|
|
|
|
*
|
|
|
|
* RISC-V machine with 16550a UART and VirtIO MMIO
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
|
|
* under the terms and conditions of the GNU General Public License,
|
|
|
|
* version 2 or later, as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
|
|
* more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along with
|
|
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
2018-06-25 14:42:08 +02:00
|
|
|
#include "qemu/units.h"
|
2018-03-02 13:31:13 +01:00
|
|
|
#include "qemu/log.h"
|
|
|
|
#include "qemu/error-report.h"
|
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "hw/boards.h"
|
|
|
|
#include "hw/loader.h"
|
|
|
|
#include "hw/sysbus.h"
|
2019-10-09 01:32:25 +02:00
|
|
|
#include "hw/qdev-properties.h"
|
2018-03-02 13:31:13 +01:00
|
|
|
#include "hw/char/serial.h"
|
|
|
|
#include "target/riscv/cpu.h"
|
|
|
|
#include "hw/riscv/riscv_hart.h"
|
|
|
|
#include "hw/riscv/sifive_plic.h"
|
|
|
|
#include "hw/riscv/sifive_clint.h"
|
|
|
|
#include "hw/riscv/sifive_test.h"
|
|
|
|
#include "hw/riscv/virt.h"
|
2019-06-25 00:11:49 +02:00
|
|
|
#include "hw/riscv/boot.h"
|
2018-03-02 13:31:13 +01:00
|
|
|
#include "chardev/char.h"
|
|
|
|
#include "sysemu/arch_init.h"
|
|
|
|
#include "sysemu/device_tree.h"
|
2019-08-12 07:23:57 +02:00
|
|
|
#include "sysemu/sysemu.h"
|
2018-12-11 23:37:36 +01:00
|
|
|
#include "hw/pci/pci.h"
|
|
|
|
#include "hw/pci-host/gpex.h"
|
2018-03-02 13:31:13 +01:00
|
|
|
|
2019-07-16 20:47:25 +02:00
|
|
|
#if defined(TARGET_RISCV32)
|
|
|
|
# define BIOS_FILENAME "opensbi-riscv32-virt-fw_jump.bin"
|
|
|
|
#else
|
|
|
|
# define BIOS_FILENAME "opensbi-riscv64-virt-fw_jump.bin"
|
|
|
|
#endif
|
|
|
|
|
2018-03-02 13:31:13 +01:00
|
|
|
static const struct MemmapEntry {
|
|
|
|
hwaddr base;
|
|
|
|
hwaddr size;
|
|
|
|
} virt_memmap[] = {
|
2018-12-11 23:37:26 +01:00
|
|
|
[VIRT_DEBUG] = { 0x0, 0x100 },
|
2020-07-09 12:05:43 +02:00
|
|
|
[VIRT_MROM] = { 0x1000, 0xf000 },
|
2018-12-11 23:37:26 +01:00
|
|
|
[VIRT_TEST] = { 0x100000, 0x1000 },
|
2019-11-06 12:56:43 +01:00
|
|
|
[VIRT_RTC] = { 0x101000, 0x1000 },
|
2018-12-11 23:37:26 +01:00
|
|
|
[VIRT_CLINT] = { 0x2000000, 0x10000 },
|
2020-07-03 05:21:51 +02:00
|
|
|
[VIRT_PCIE_PIO] = { 0x3000000, 0x10000 },
|
2018-12-11 23:37:26 +01:00
|
|
|
[VIRT_PLIC] = { 0xc000000, 0x4000000 },
|
|
|
|
[VIRT_UART0] = { 0x10000000, 0x100 },
|
|
|
|
[VIRT_VIRTIO] = { 0x10001000, 0x1000 },
|
2019-11-07 01:47:20 +01:00
|
|
|
[VIRT_FLASH] = { 0x20000000, 0x4000000 },
|
2018-12-11 23:37:36 +01:00
|
|
|
[VIRT_PCIE_ECAM] = { 0x30000000, 0x10000000 },
|
2020-07-03 05:21:51 +02:00
|
|
|
[VIRT_PCIE_MMIO] = { 0x40000000, 0x40000000 },
|
|
|
|
[VIRT_DRAM] = { 0x80000000, 0x0 },
|
2018-03-02 13:31:13 +01:00
|
|
|
};
|
|
|
|
|
2019-10-09 01:32:25 +02:00
|
|
|
#define VIRT_FLASH_SECTOR_SIZE (256 * KiB)
|
|
|
|
|
|
|
|
static PFlashCFI01 *virt_flash_create1(RISCVVirtState *s,
|
|
|
|
const char *name,
|
|
|
|
const char *alias_prop_name)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Create a single flash device. We use the same parameters as
|
|
|
|
* the flash devices on the ARM virt board.
|
|
|
|
*/
|
2020-06-10 07:31:59 +02:00
|
|
|
DeviceState *dev = qdev_new(TYPE_PFLASH_CFI01);
|
2019-10-09 01:32:25 +02:00
|
|
|
|
|
|
|
qdev_prop_set_uint64(dev, "sector-length", VIRT_FLASH_SECTOR_SIZE);
|
|
|
|
qdev_prop_set_uint8(dev, "width", 4);
|
|
|
|
qdev_prop_set_uint8(dev, "device-width", 2);
|
|
|
|
qdev_prop_set_bit(dev, "big-endian", false);
|
|
|
|
qdev_prop_set_uint16(dev, "id0", 0x89);
|
|
|
|
qdev_prop_set_uint16(dev, "id1", 0x18);
|
|
|
|
qdev_prop_set_uint16(dev, "id2", 0x00);
|
|
|
|
qdev_prop_set_uint16(dev, "id3", 0x00);
|
|
|
|
qdev_prop_set_string(dev, "name", name);
|
|
|
|
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
object_property_add_child(OBJECT(s), name, OBJECT(dev));
|
2019-10-09 01:32:25 +02:00
|
|
|
object_property_add_alias(OBJECT(s), alias_prop_name,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
OBJECT(dev), "drive");
|
2019-10-09 01:32:25 +02:00
|
|
|
|
|
|
|
return PFLASH_CFI01(dev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void virt_flash_create(RISCVVirtState *s)
|
|
|
|
{
|
|
|
|
s->flash[0] = virt_flash_create1(s, "virt.flash0", "pflash0");
|
|
|
|
s->flash[1] = virt_flash_create1(s, "virt.flash1", "pflash1");
|
|
|
|
}
|
|
|
|
|
|
|
|
static void virt_flash_map1(PFlashCFI01 *flash,
|
|
|
|
hwaddr base, hwaddr size,
|
|
|
|
MemoryRegion *sysmem)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(flash);
|
|
|
|
|
2020-05-11 22:52:46 +02:00
|
|
|
assert(QEMU_IS_ALIGNED(size, VIRT_FLASH_SECTOR_SIZE));
|
2019-10-09 01:32:25 +02:00
|
|
|
assert(size / VIRT_FLASH_SECTOR_SIZE <= UINT32_MAX);
|
|
|
|
qdev_prop_set_uint32(dev, "num-blocks", size / VIRT_FLASH_SECTOR_SIZE);
|
sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
@@
expression dev, errp;
@@
- qdev_realize(DEVICE(dev), NULL, errp);
+ sysbus_realize(SYS_BUS_DEVICE(dev), errp);
@@
expression sysbus_dev, dev, errp;
@@
+ sysbus_dev = SYS_BUS_DEVICE(dev);
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
- sysbus_dev = SYS_BUS_DEVICE(dev);
@@
expression sysbus_dev, dev, errp;
expression expr;
@@
sysbus_dev = SYS_BUS_DEVICE(dev);
... when != dev = expr;
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(DEVICE(dev), NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:32:34 +02:00
|
|
|
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
|
2019-10-09 01:32:25 +02:00
|
|
|
|
|
|
|
memory_region_add_subregion(sysmem, base,
|
|
|
|
sysbus_mmio_get_region(SYS_BUS_DEVICE(dev),
|
|
|
|
0));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void virt_flash_map(RISCVVirtState *s,
|
|
|
|
MemoryRegion *sysmem)
|
|
|
|
{
|
|
|
|
hwaddr flashsize = virt_memmap[VIRT_FLASH].size / 2;
|
|
|
|
hwaddr flashbase = virt_memmap[VIRT_FLASH].base;
|
|
|
|
|
|
|
|
virt_flash_map1(s->flash[0], flashbase, flashsize,
|
|
|
|
sysmem);
|
|
|
|
virt_flash_map1(s->flash[1], flashbase + flashsize, flashsize,
|
|
|
|
sysmem);
|
|
|
|
}
|
|
|
|
|
2018-12-11 23:37:36 +01:00
|
|
|
static void create_pcie_irq_map(void *fdt, char *nodename,
|
|
|
|
uint32_t plic_phandle)
|
|
|
|
{
|
|
|
|
int pin, dev;
|
|
|
|
uint32_t
|
|
|
|
full_irq_map[GPEX_NUM_IRQS * GPEX_NUM_IRQS * FDT_INT_MAP_WIDTH] = {};
|
|
|
|
uint32_t *irq_map = full_irq_map;
|
|
|
|
|
|
|
|
/* This code creates a standard swizzle of interrupts such that
|
|
|
|
* each device's first interrupt is based on it's PCI_SLOT number.
|
|
|
|
* (See pci_swizzle_map_irq_fn())
|
|
|
|
*
|
|
|
|
* We only need one entry per interrupt in the table (not one per
|
|
|
|
* possible slot) seeing the interrupt-map-mask will allow the table
|
|
|
|
* to wrap to any number of devices.
|
|
|
|
*/
|
|
|
|
for (dev = 0; dev < GPEX_NUM_IRQS; dev++) {
|
|
|
|
int devfn = dev * 0x8;
|
|
|
|
|
|
|
|
for (pin = 0; pin < GPEX_NUM_IRQS; pin++) {
|
|
|
|
int irq_nr = PCIE_IRQ + ((pin + PCI_SLOT(devfn)) % GPEX_NUM_IRQS);
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
irq_map[i] = cpu_to_be32(devfn << 8);
|
|
|
|
|
|
|
|
i += FDT_PCI_ADDR_CELLS;
|
|
|
|
irq_map[i] = cpu_to_be32(pin + 1);
|
|
|
|
|
|
|
|
i += FDT_PCI_INT_CELLS;
|
|
|
|
irq_map[i++] = cpu_to_be32(plic_phandle);
|
|
|
|
|
|
|
|
i += FDT_PLIC_ADDR_CELLS;
|
|
|
|
irq_map[i] = cpu_to_be32(irq_nr);
|
|
|
|
|
|
|
|
irq_map += FDT_INT_MAP_WIDTH;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_fdt_setprop(fdt, nodename, "interrupt-map",
|
|
|
|
full_irq_map, sizeof(full_irq_map));
|
|
|
|
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "interrupt-map-mask",
|
|
|
|
0x1800, 0, 0, 0x7);
|
|
|
|
}
|
|
|
|
|
2019-09-06 18:19:53 +02:00
|
|
|
static void create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap,
|
2018-03-02 13:31:13 +01:00
|
|
|
uint64_t mem_size, const char *cmdline)
|
|
|
|
{
|
|
|
|
void *fdt;
|
2020-01-22 14:17:23 +01:00
|
|
|
int cpu, i;
|
2018-03-02 13:31:13 +01:00
|
|
|
uint32_t *cells;
|
|
|
|
char *nodename;
|
2020-01-22 14:17:23 +01:00
|
|
|
uint32_t plic_phandle, test_phandle, phandle = 1;
|
2019-10-09 01:32:25 +02:00
|
|
|
hwaddr flashsize = virt_memmap[VIRT_FLASH].size / 2;
|
|
|
|
hwaddr flashbase = virt_memmap[VIRT_FLASH].base;
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
fdt = s->fdt = create_device_tree(&s->fdt_size);
|
|
|
|
if (!fdt) {
|
|
|
|
error_report("create_device_tree() failed");
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_fdt_setprop_string(fdt, "/", "model", "riscv-virtio,qemu");
|
|
|
|
qemu_fdt_setprop_string(fdt, "/", "compatible", "riscv-virtio");
|
|
|
|
qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2);
|
|
|
|
qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2);
|
|
|
|
|
|
|
|
qemu_fdt_add_subnode(fdt, "/soc");
|
|
|
|
qemu_fdt_setprop(fdt, "/soc", "ranges", NULL, 0);
|
2018-06-19 23:21:47 +02:00
|
|
|
qemu_fdt_setprop_string(fdt, "/soc", "compatible", "simple-bus");
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_cell(fdt, "/soc", "#size-cells", 0x2);
|
|
|
|
qemu_fdt_setprop_cell(fdt, "/soc", "#address-cells", 0x2);
|
|
|
|
|
|
|
|
nodename = g_strdup_printf("/memory@%lx",
|
|
|
|
(long)memmap[VIRT_DRAM].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
memmap[VIRT_DRAM].base >> 32, memmap[VIRT_DRAM].base,
|
|
|
|
mem_size >> 32, mem_size);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "device_type", "memory");
|
|
|
|
g_free(nodename);
|
|
|
|
|
|
|
|
qemu_fdt_add_subnode(fdt, "/cpus");
|
2018-03-03 02:30:07 +01:00
|
|
|
qemu_fdt_setprop_cell(fdt, "/cpus", "timebase-frequency",
|
|
|
|
SIFIVE_CLINT_TIMEBASE_FREQ);
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_cell(fdt, "/cpus", "#size-cells", 0x0);
|
|
|
|
qemu_fdt_setprop_cell(fdt, "/cpus", "#address-cells", 0x1);
|
|
|
|
|
|
|
|
for (cpu = s->soc.num_harts - 1; cpu >= 0; cpu--) {
|
|
|
|
int cpu_phandle = phandle++;
|
2019-06-25 01:41:44 +02:00
|
|
|
int intc_phandle;
|
2018-03-02 13:31:13 +01:00
|
|
|
nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
|
|
|
|
char *intc = g_strdup_printf("/cpus/cpu@%d/interrupt-controller", cpu);
|
|
|
|
char *isa = riscv_isa_string(&s->soc.harts[cpu]);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
2020-03-07 13:48:39 +01:00
|
|
|
#if defined(TARGET_RISCV32)
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "mmu-type", "riscv,sv32");
|
|
|
|
#else
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "mmu-type", "riscv,sv48");
|
2020-03-07 13:48:39 +01:00
|
|
|
#endif
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "riscv,isa", isa);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "riscv");
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "status", "okay");
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "reg", cpu);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "device_type", "cpu");
|
2019-06-25 01:41:44 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "phandle", cpu_phandle);
|
|
|
|
intc_phandle = phandle++;
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_add_subnode(fdt, intc);
|
2019-06-25 01:41:44 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, intc, "phandle", intc_phandle);
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_string(fdt, intc, "compatible", "riscv,cpu-intc");
|
|
|
|
qemu_fdt_setprop(fdt, intc, "interrupt-controller", NULL, 0);
|
|
|
|
qemu_fdt_setprop_cell(fdt, intc, "#interrupt-cells", 1);
|
|
|
|
g_free(isa);
|
|
|
|
g_free(intc);
|
|
|
|
g_free(nodename);
|
|
|
|
}
|
|
|
|
|
2019-06-25 01:41:44 +02:00
|
|
|
/* Add cpu-topology node */
|
|
|
|
qemu_fdt_add_subnode(fdt, "/cpus/cpu-map");
|
|
|
|
qemu_fdt_add_subnode(fdt, "/cpus/cpu-map/cluster0");
|
|
|
|
for (cpu = s->soc.num_harts - 1; cpu >= 0; cpu--) {
|
|
|
|
char *core_nodename = g_strdup_printf("/cpus/cpu-map/cluster0/core%d",
|
|
|
|
cpu);
|
|
|
|
char *cpu_nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
|
|
|
|
uint32_t intc_phandle = qemu_fdt_get_phandle(fdt, cpu_nodename);
|
|
|
|
qemu_fdt_add_subnode(fdt, core_nodename);
|
|
|
|
qemu_fdt_setprop_cell(fdt, core_nodename, "cpu", intc_phandle);
|
|
|
|
g_free(core_nodename);
|
|
|
|
g_free(cpu_nodename);
|
|
|
|
}
|
|
|
|
|
2018-03-02 13:31:13 +01:00
|
|
|
cells = g_new0(uint32_t, s->soc.num_harts * 4);
|
|
|
|
for (cpu = 0; cpu < s->soc.num_harts; cpu++) {
|
|
|
|
nodename =
|
|
|
|
g_strdup_printf("/cpus/cpu@%d/interrupt-controller", cpu);
|
|
|
|
uint32_t intc_phandle = qemu_fdt_get_phandle(fdt, nodename);
|
|
|
|
cells[cpu * 4 + 0] = cpu_to_be32(intc_phandle);
|
|
|
|
cells[cpu * 4 + 1] = cpu_to_be32(IRQ_M_SOFT);
|
|
|
|
cells[cpu * 4 + 2] = cpu_to_be32(intc_phandle);
|
|
|
|
cells[cpu * 4 + 3] = cpu_to_be32(IRQ_M_TIMER);
|
|
|
|
g_free(nodename);
|
|
|
|
}
|
|
|
|
nodename = g_strdup_printf("/soc/clint@%lx",
|
|
|
|
(long)memmap[VIRT_CLINT].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "riscv,clint0");
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
0x0, memmap[VIRT_CLINT].base,
|
|
|
|
0x0, memmap[VIRT_CLINT].size);
|
|
|
|
qemu_fdt_setprop(fdt, nodename, "interrupts-extended",
|
|
|
|
cells, s->soc.num_harts * sizeof(uint32_t) * 4);
|
|
|
|
g_free(cells);
|
|
|
|
g_free(nodename);
|
|
|
|
|
|
|
|
plic_phandle = phandle++;
|
|
|
|
cells = g_new0(uint32_t, s->soc.num_harts * 4);
|
|
|
|
for (cpu = 0; cpu < s->soc.num_harts; cpu++) {
|
|
|
|
nodename =
|
|
|
|
g_strdup_printf("/cpus/cpu@%d/interrupt-controller", cpu);
|
|
|
|
uint32_t intc_phandle = qemu_fdt_get_phandle(fdt, nodename);
|
|
|
|
cells[cpu * 4 + 0] = cpu_to_be32(intc_phandle);
|
|
|
|
cells[cpu * 4 + 1] = cpu_to_be32(IRQ_M_EXT);
|
|
|
|
cells[cpu * 4 + 2] = cpu_to_be32(intc_phandle);
|
|
|
|
cells[cpu * 4 + 3] = cpu_to_be32(IRQ_S_EXT);
|
|
|
|
g_free(nodename);
|
|
|
|
}
|
|
|
|
nodename = g_strdup_printf("/soc/interrupt-controller@%lx",
|
|
|
|
(long)memmap[VIRT_PLIC].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
2019-09-06 18:19:51 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "#address-cells",
|
|
|
|
FDT_PLIC_ADDR_CELLS);
|
2018-12-11 23:37:36 +01:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells",
|
|
|
|
FDT_PLIC_INT_CELLS);
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "riscv,plic0");
|
|
|
|
qemu_fdt_setprop(fdt, nodename, "interrupt-controller", NULL, 0);
|
|
|
|
qemu_fdt_setprop(fdt, nodename, "interrupts-extended",
|
|
|
|
cells, s->soc.num_harts * sizeof(uint32_t) * 4);
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
0x0, memmap[VIRT_PLIC].base,
|
|
|
|
0x0, memmap[VIRT_PLIC].size);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "riscv,ndev", VIRTIO_NDEV);
|
2019-09-06 18:19:51 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "phandle", plic_phandle);
|
2018-03-02 13:31:13 +01:00
|
|
|
plic_phandle = qemu_fdt_get_phandle(fdt, nodename);
|
|
|
|
g_free(cells);
|
|
|
|
g_free(nodename);
|
|
|
|
|
|
|
|
for (i = 0; i < VIRTIO_COUNT; i++) {
|
|
|
|
nodename = g_strdup_printf("/virtio_mmio@%lx",
|
|
|
|
(long)(memmap[VIRT_VIRTIO].base + i * memmap[VIRT_VIRTIO].size));
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "virtio,mmio");
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
0x0, memmap[VIRT_VIRTIO].base + i * memmap[VIRT_VIRTIO].size,
|
|
|
|
0x0, memmap[VIRT_VIRTIO].size);
|
2019-09-06 18:19:51 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "interrupt-parent", plic_phandle);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "interrupts", VIRTIO_IRQ + i);
|
2018-03-02 13:31:13 +01:00
|
|
|
g_free(nodename);
|
|
|
|
}
|
|
|
|
|
2018-12-11 23:37:36 +01:00
|
|
|
nodename = g_strdup_printf("/soc/pci@%lx",
|
|
|
|
(long) memmap[VIRT_PCIE_ECAM].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
2019-09-06 18:19:51 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "#address-cells",
|
|
|
|
FDT_PCI_ADDR_CELLS);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells",
|
|
|
|
FDT_PCI_INT_CELLS);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "#size-cells", 0x2);
|
2018-12-11 23:37:36 +01:00
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible",
|
|
|
|
"pci-host-ecam-generic");
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "device_type", "pci");
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "linux,pci-domain", 0);
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "bus-range", 0,
|
2019-05-29 10:52:01 +02:00
|
|
|
memmap[VIRT_PCIE_ECAM].size /
|
2018-12-11 23:37:36 +01:00
|
|
|
PCIE_MMCFG_SIZE_MIN - 1);
|
|
|
|
qemu_fdt_setprop(fdt, nodename, "dma-coherent", NULL, 0);
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg", 0, memmap[VIRT_PCIE_ECAM].base,
|
|
|
|
0, memmap[VIRT_PCIE_ECAM].size);
|
|
|
|
qemu_fdt_setprop_sized_cells(fdt, nodename, "ranges",
|
|
|
|
1, FDT_PCI_RANGE_IOPORT, 2, 0,
|
|
|
|
2, memmap[VIRT_PCIE_PIO].base, 2, memmap[VIRT_PCIE_PIO].size,
|
|
|
|
1, FDT_PCI_RANGE_MMIO,
|
|
|
|
2, memmap[VIRT_PCIE_MMIO].base,
|
|
|
|
2, memmap[VIRT_PCIE_MMIO].base, 2, memmap[VIRT_PCIE_MMIO].size);
|
|
|
|
create_pcie_irq_map(fdt, nodename, plic_phandle);
|
|
|
|
g_free(nodename);
|
|
|
|
|
2020-01-22 14:17:23 +01:00
|
|
|
test_phandle = phandle++;
|
2018-03-02 13:31:13 +01:00
|
|
|
nodename = g_strdup_printf("/test@%lx",
|
|
|
|
(long)memmap[VIRT_TEST].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
2019-11-07 23:25:00 +01:00
|
|
|
{
|
2020-01-22 14:17:23 +01:00
|
|
|
const char compat[] = "sifive,test1\0sifive,test0\0syscon";
|
2019-11-07 23:25:00 +01:00
|
|
|
qemu_fdt_setprop(fdt, nodename, "compatible", compat, sizeof(compat));
|
|
|
|
}
|
2018-03-02 13:31:13 +01:00
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
0x0, memmap[VIRT_TEST].base,
|
|
|
|
0x0, memmap[VIRT_TEST].size);
|
2020-01-22 14:17:23 +01:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "phandle", test_phandle);
|
|
|
|
test_phandle = qemu_fdt_get_phandle(fdt, nodename);
|
|
|
|
g_free(nodename);
|
|
|
|
|
|
|
|
nodename = g_strdup_printf("/reboot");
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "syscon-reboot");
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "regmap", test_phandle);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "offset", 0x0);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "value", FINISHER_RESET);
|
|
|
|
g_free(nodename);
|
|
|
|
|
|
|
|
nodename = g_strdup_printf("/poweroff");
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "syscon-poweroff");
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "regmap", test_phandle);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "offset", 0x0);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "value", FINISHER_PASS);
|
2018-11-07 22:51:45 +01:00
|
|
|
g_free(nodename);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
nodename = g_strdup_printf("/uart@%lx",
|
|
|
|
(long)memmap[VIRT_UART0].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible", "ns16550a");
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
0x0, memmap[VIRT_UART0].base,
|
|
|
|
0x0, memmap[VIRT_UART0].size);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "clock-frequency", 3686400);
|
2019-09-06 18:19:51 +02:00
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "interrupt-parent", plic_phandle);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "interrupts", UART0_IRQ);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
qemu_fdt_add_subnode(fdt, "/chosen");
|
|
|
|
qemu_fdt_setprop_string(fdt, "/chosen", "stdout-path", nodename);
|
2018-05-22 03:33:28 +02:00
|
|
|
if (cmdline) {
|
|
|
|
qemu_fdt_setprop_string(fdt, "/chosen", "bootargs", cmdline);
|
|
|
|
}
|
2018-03-02 13:31:13 +01:00
|
|
|
g_free(nodename);
|
2019-10-09 01:32:25 +02:00
|
|
|
|
2019-11-06 12:56:43 +01:00
|
|
|
nodename = g_strdup_printf("/rtc@%lx",
|
|
|
|
(long)memmap[VIRT_RTC].base);
|
|
|
|
qemu_fdt_add_subnode(fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(fdt, nodename, "compatible",
|
|
|
|
"google,goldfish-rtc");
|
|
|
|
qemu_fdt_setprop_cells(fdt, nodename, "reg",
|
|
|
|
0x0, memmap[VIRT_RTC].base,
|
|
|
|
0x0, memmap[VIRT_RTC].size);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "interrupt-parent", plic_phandle);
|
|
|
|
qemu_fdt_setprop_cell(fdt, nodename, "interrupts", RTC_IRQ);
|
|
|
|
g_free(nodename);
|
|
|
|
|
2019-10-09 01:32:25 +02:00
|
|
|
nodename = g_strdup_printf("/flash@%" PRIx64, flashbase);
|
|
|
|
qemu_fdt_add_subnode(s->fdt, nodename);
|
|
|
|
qemu_fdt_setprop_string(s->fdt, nodename, "compatible", "cfi-flash");
|
|
|
|
qemu_fdt_setprop_sized_cells(s->fdt, nodename, "reg",
|
|
|
|
2, flashbase, 2, flashsize,
|
|
|
|
2, flashbase + flashsize, 2, flashsize);
|
|
|
|
qemu_fdt_setprop_cell(s->fdt, nodename, "bank-width", 4);
|
|
|
|
g_free(nodename);
|
2018-03-02 13:31:13 +01:00
|
|
|
}
|
|
|
|
|
2018-12-11 23:37:36 +01:00
|
|
|
|
|
|
|
static inline DeviceState *gpex_pcie_init(MemoryRegion *sys_mem,
|
|
|
|
hwaddr ecam_base, hwaddr ecam_size,
|
|
|
|
hwaddr mmio_base, hwaddr mmio_size,
|
|
|
|
hwaddr pio_base,
|
|
|
|
DeviceState *plic, bool link_up)
|
|
|
|
{
|
|
|
|
DeviceState *dev;
|
|
|
|
MemoryRegion *ecam_alias, *ecam_reg;
|
|
|
|
MemoryRegion *mmio_alias, *mmio_reg;
|
|
|
|
qemu_irq irq;
|
|
|
|
int i;
|
|
|
|
|
qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:31:58 +02:00
|
|
|
dev = qdev_new(TYPE_GPEX_HOST);
|
2018-12-11 23:37:36 +01:00
|
|
|
|
sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
@@
expression dev, errp;
@@
- qdev_realize(DEVICE(dev), NULL, errp);
+ sysbus_realize(SYS_BUS_DEVICE(dev), errp);
@@
expression sysbus_dev, dev, errp;
@@
+ sysbus_dev = SYS_BUS_DEVICE(dev);
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
- sysbus_dev = SYS_BUS_DEVICE(dev);
@@
expression sysbus_dev, dev, errp;
expression expr;
@@
sysbus_dev = SYS_BUS_DEVICE(dev);
... when != dev = expr;
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(DEVICE(dev), NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:32:34 +02:00
|
|
|
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
|
2018-12-11 23:37:36 +01:00
|
|
|
|
|
|
|
ecam_alias = g_new0(MemoryRegion, 1);
|
|
|
|
ecam_reg = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
|
|
|
|
memory_region_init_alias(ecam_alias, OBJECT(dev), "pcie-ecam",
|
|
|
|
ecam_reg, 0, ecam_size);
|
|
|
|
memory_region_add_subregion(get_system_memory(), ecam_base, ecam_alias);
|
|
|
|
|
|
|
|
mmio_alias = g_new0(MemoryRegion, 1);
|
|
|
|
mmio_reg = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 1);
|
|
|
|
memory_region_init_alias(mmio_alias, OBJECT(dev), "pcie-mmio",
|
|
|
|
mmio_reg, mmio_base, mmio_size);
|
|
|
|
memory_region_add_subregion(get_system_memory(), mmio_base, mmio_alias);
|
|
|
|
|
|
|
|
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 2, pio_base);
|
|
|
|
|
|
|
|
for (i = 0; i < GPEX_NUM_IRQS; i++) {
|
|
|
|
irq = qdev_get_gpio_in(plic, PCIE_IRQ + i);
|
|
|
|
|
|
|
|
sysbus_connect_irq(SYS_BUS_DEVICE(dev), i, irq);
|
|
|
|
gpex_set_irq_num(GPEX_HOST(dev), i, PCIE_IRQ + i);
|
|
|
|
}
|
|
|
|
|
|
|
|
return dev;
|
|
|
|
}
|
|
|
|
|
2020-05-21 16:42:27 +02:00
|
|
|
static void virt_machine_init(MachineState *machine)
|
2018-03-02 13:31:13 +01:00
|
|
|
{
|
|
|
|
const struct MemmapEntry *memmap = virt_memmap;
|
2019-10-09 01:32:22 +02:00
|
|
|
RISCVVirtState *s = RISCV_VIRT_MACHINE(machine);
|
2018-03-02 13:31:13 +01:00
|
|
|
MemoryRegion *system_memory = get_system_memory();
|
|
|
|
MemoryRegion *main_mem = g_new(MemoryRegion, 1);
|
2018-03-03 23:52:13 +01:00
|
|
|
MemoryRegion *mask_rom = g_new(MemoryRegion, 1);
|
2018-03-02 13:31:13 +01:00
|
|
|
char *plic_hart_config;
|
|
|
|
size_t plic_hart_config_len;
|
2019-10-09 01:32:29 +02:00
|
|
|
target_ulong start_addr = memmap[VIRT_DRAM].base;
|
2020-07-01 20:39:47 +02:00
|
|
|
uint32_t fdt_load_addr;
|
2020-07-01 20:39:48 +02:00
|
|
|
uint64_t kernel_entry;
|
2018-03-02 13:31:13 +01:00
|
|
|
int i;
|
2019-05-18 22:54:23 +02:00
|
|
|
unsigned int smp_cpus = machine->smp.cpus;
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
/* Initialize SOC */
|
sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1
I'm converting from qdev_set_parent_bus()/realize to qdev_realize();
recent commit "qdev: Convert uses of qdev_set_parent_bus() with
Coccinelle" explains why.
sysbus_init_child_obj() is a wrapper around
object_initialize_child_with_props() and qdev_set_parent_bus(). It
passes no properties.
Convert sysbus_init_child_obj()/realize to object_initialize_child()/
qdev_realize().
Coccinelle script:
@@
expression parent, name, size, type, errp;
expression child;
symbol true;
@@
- sysbus_init_child_obj(parent, name, &child, size, type);
+ sysbus_init_child_XXX(parent, name, &child, size, type);
...
- object_property_set_bool(OBJECT(&child), true, "realized", errp);
+ sysbus_realize(SYS_BUS_DEVICE(&child), errp);
@@
expression parent, name, size, type, errp;
expression child;
symbol true;
@@
- sysbus_init_child_obj(parent, name, child, size, type);
+ sysbus_init_child_XXX(parent, name, child, size, type);
...
- object_property_set_bool(OBJECT(child), true, "realized", errp);
+ sysbus_realize(SYS_BUS_DEVICE(child), errp);
@@
expression parent, name, size, type;
expression child;
expression dev;
expression expr;
@@
- sysbus_init_child_obj(parent, name, child, size, type);
+ sysbus_init_child_XXX(parent, name, child, size, type);
...
dev = DEVICE(child);
... when != dev = expr;
- qdev_init_nofail(dev);
+ sysbus_realize(SYS_BUS_DEVICE(dev), &error_fatal);
@@
expression parent, propname, type;
expression child;
@@
- sysbus_init_child_XXX(parent, propname, child, sizeof(*child), type)
+ object_initialize_child(parent, propname, child, type)
@@
expression parent, propname, type;
expression child;
@@
- sysbus_init_child_XXX(parent, propname, &child, sizeof(child), type)
+ object_initialize_child(parent, propname, &child, type)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-48-armbru@redhat.com>
2020-06-10 07:32:36 +02:00
|
|
|
object_initialize_child(OBJECT(machine), "soc", &s->soc,
|
|
|
|
TYPE_RISCV_HART_ARRAY);
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 18:05:54 +02:00
|
|
|
object_property_set_str(OBJECT(&s->soc), "cpu-type", machine->cpu_type,
|
2018-03-02 13:31:13 +01:00
|
|
|
&error_abort);
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 18:05:54 +02:00
|
|
|
object_property_set_int(OBJECT(&s->soc), "num-harts", smp_cpus,
|
2018-03-02 13:31:13 +01:00
|
|
|
&error_abort);
|
sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1
I'm converting from qdev_set_parent_bus()/realize to qdev_realize();
recent commit "qdev: Convert uses of qdev_set_parent_bus() with
Coccinelle" explains why.
sysbus_init_child_obj() is a wrapper around
object_initialize_child_with_props() and qdev_set_parent_bus(). It
passes no properties.
Convert sysbus_init_child_obj()/realize to object_initialize_child()/
qdev_realize().
Coccinelle script:
@@
expression parent, name, size, type, errp;
expression child;
symbol true;
@@
- sysbus_init_child_obj(parent, name, &child, size, type);
+ sysbus_init_child_XXX(parent, name, &child, size, type);
...
- object_property_set_bool(OBJECT(&child), true, "realized", errp);
+ sysbus_realize(SYS_BUS_DEVICE(&child), errp);
@@
expression parent, name, size, type, errp;
expression child;
symbol true;
@@
- sysbus_init_child_obj(parent, name, child, size, type);
+ sysbus_init_child_XXX(parent, name, child, size, type);
...
- object_property_set_bool(OBJECT(child), true, "realized", errp);
+ sysbus_realize(SYS_BUS_DEVICE(child), errp);
@@
expression parent, name, size, type;
expression child;
expression dev;
expression expr;
@@
- sysbus_init_child_obj(parent, name, child, size, type);
+ sysbus_init_child_XXX(parent, name, child, size, type);
...
dev = DEVICE(child);
... when != dev = expr;
- qdev_init_nofail(dev);
+ sysbus_realize(SYS_BUS_DEVICE(dev), &error_fatal);
@@
expression parent, propname, type;
expression child;
@@
- sysbus_init_child_XXX(parent, propname, child, sizeof(*child), type)
+ object_initialize_child(parent, propname, child, type)
@@
expression parent, propname, type;
expression child;
@@
- sysbus_init_child_XXX(parent, propname, &child, sizeof(child), type)
+ object_initialize_child(parent, propname, &child, type)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-48-armbru@redhat.com>
2020-06-10 07:32:36 +02:00
|
|
|
sysbus_realize(SYS_BUS_DEVICE(&s->soc), &error_abort);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
/* register system main memory (actual RAM) */
|
|
|
|
memory_region_init_ram(main_mem, NULL, "riscv_virt_board.ram",
|
|
|
|
machine->ram_size, &error_fatal);
|
|
|
|
memory_region_add_subregion(system_memory, memmap[VIRT_DRAM].base,
|
|
|
|
main_mem);
|
|
|
|
|
|
|
|
/* create device tree */
|
2019-09-06 18:19:53 +02:00
|
|
|
create_fdt(s, memmap, machine->ram_size, machine->kernel_cmdline);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
/* boot rom */
|
2018-03-03 23:52:13 +01:00
|
|
|
memory_region_init_rom(mask_rom, NULL, "riscv_virt_board.mrom",
|
|
|
|
memmap[VIRT_MROM].size, &error_fatal);
|
|
|
|
memory_region_add_subregion(system_memory, memmap[VIRT_MROM].base,
|
|
|
|
mask_rom);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
2019-07-16 20:47:25 +02:00
|
|
|
riscv_find_and_load_firmware(machine, BIOS_FILENAME,
|
2020-04-27 10:06:42 +02:00
|
|
|
memmap[VIRT_DRAM].base, NULL);
|
2019-06-25 00:11:52 +02:00
|
|
|
|
2018-03-02 13:31:13 +01:00
|
|
|
if (machine->kernel_filename) {
|
2020-07-01 20:39:48 +02:00
|
|
|
kernel_entry = riscv_load_kernel(machine->kernel_filename, NULL);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
if (machine->initrd_filename) {
|
|
|
|
hwaddr start;
|
2019-06-25 00:11:49 +02:00
|
|
|
hwaddr end = riscv_load_initrd(machine->initrd_filename,
|
|
|
|
machine->ram_size, kernel_entry,
|
|
|
|
&start);
|
2019-09-06 18:19:53 +02:00
|
|
|
qemu_fdt_setprop_cell(s->fdt, "/chosen",
|
2018-03-02 13:31:13 +01:00
|
|
|
"linux,initrd-start", start);
|
2019-09-06 18:19:53 +02:00
|
|
|
qemu_fdt_setprop_cell(s->fdt, "/chosen", "linux,initrd-end",
|
2018-03-02 13:31:13 +01:00
|
|
|
end);
|
|
|
|
}
|
2020-07-01 20:39:48 +02:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* If dynamic firmware is used, it doesn't know where is the next mode
|
|
|
|
* if kernel argument is not set.
|
|
|
|
*/
|
|
|
|
kernel_entry = 0;
|
2018-03-02 13:31:13 +01:00
|
|
|
}
|
|
|
|
|
2019-10-09 01:32:29 +02:00
|
|
|
if (drive_get(IF_PFLASH, 0, 0)) {
|
|
|
|
/*
|
|
|
|
* Pflash was supplied, let's overwrite the address we jump to after
|
|
|
|
* reset to the base of the flash.
|
|
|
|
*/
|
|
|
|
start_addr = virt_memmap[VIRT_FLASH].base;
|
|
|
|
}
|
|
|
|
|
2020-07-01 20:39:47 +02:00
|
|
|
/* Compute the fdt load address in dram */
|
|
|
|
fdt_load_addr = riscv_load_fdt(memmap[VIRT_DRAM].base,
|
|
|
|
machine->ram_size, s->fdt);
|
2020-07-01 20:39:46 +02:00
|
|
|
/* load the reset vector */
|
|
|
|
riscv_setup_rom_reset_vec(start_addr, virt_memmap[VIRT_MROM].base,
|
2020-07-01 20:39:48 +02:00
|
|
|
virt_memmap[VIRT_MROM].size, kernel_entry,
|
2020-07-01 20:39:47 +02:00
|
|
|
fdt_load_addr, s->fdt);
|
2018-03-02 13:31:13 +01:00
|
|
|
|
|
|
|
/* create PLIC hart topology configuration string */
|
|
|
|
plic_hart_config_len = (strlen(VIRT_PLIC_HART_CONFIG) + 1) * smp_cpus;
|
|
|
|
plic_hart_config = g_malloc0(plic_hart_config_len);
|
|
|
|
for (i = 0; i < smp_cpus; i++) {
|
|
|
|
if (i != 0) {
|
|
|
|
strncat(plic_hart_config, ",", plic_hart_config_len);
|
|
|
|
}
|
|
|
|
strncat(plic_hart_config, VIRT_PLIC_HART_CONFIG, plic_hart_config_len);
|
|
|
|
plic_hart_config_len -= (strlen(VIRT_PLIC_HART_CONFIG) + 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* MMIO */
|
|
|
|
s->plic = sifive_plic_create(memmap[VIRT_PLIC].base,
|
|
|
|
plic_hart_config,
|
|
|
|
VIRT_PLIC_NUM_SOURCES,
|
|
|
|
VIRT_PLIC_NUM_PRIORITIES,
|
|
|
|
VIRT_PLIC_PRIORITY_BASE,
|
|
|
|
VIRT_PLIC_PENDING_BASE,
|
|
|
|
VIRT_PLIC_ENABLE_BASE,
|
|
|
|
VIRT_PLIC_ENABLE_STRIDE,
|
|
|
|
VIRT_PLIC_CONTEXT_BASE,
|
|
|
|
VIRT_PLIC_CONTEXT_STRIDE,
|
|
|
|
memmap[VIRT_PLIC].size);
|
|
|
|
sifive_clint_create(memmap[VIRT_CLINT].base,
|
|
|
|
memmap[VIRT_CLINT].size, smp_cpus,
|
2020-02-02 14:42:17 +01:00
|
|
|
SIFIVE_SIP_BASE, SIFIVE_TIMECMP_BASE, SIFIVE_TIME_BASE, true);
|
2018-03-02 13:31:13 +01:00
|
|
|
sifive_test_create(memmap[VIRT_TEST].base);
|
|
|
|
|
|
|
|
for (i = 0; i < VIRTIO_COUNT; i++) {
|
|
|
|
sysbus_create_simple("virtio-mmio",
|
|
|
|
memmap[VIRT_VIRTIO].base + i * memmap[VIRT_VIRTIO].size,
|
2018-04-26 22:54:12 +02:00
|
|
|
qdev_get_gpio_in(DEVICE(s->plic), VIRTIO_IRQ + i));
|
2018-03-02 13:31:13 +01:00
|
|
|
}
|
|
|
|
|
2018-12-11 23:37:36 +01:00
|
|
|
gpex_pcie_init(system_memory,
|
|
|
|
memmap[VIRT_PCIE_ECAM].base,
|
|
|
|
memmap[VIRT_PCIE_ECAM].size,
|
|
|
|
memmap[VIRT_PCIE_MMIO].base,
|
|
|
|
memmap[VIRT_PCIE_MMIO].size,
|
|
|
|
memmap[VIRT_PCIE_PIO].base,
|
|
|
|
DEVICE(s->plic), true);
|
|
|
|
|
2018-03-02 13:31:13 +01:00
|
|
|
serial_mm_init(system_memory, memmap[VIRT_UART0].base,
|
2018-04-26 22:54:12 +02:00
|
|
|
0, qdev_get_gpio_in(DEVICE(s->plic), UART0_IRQ), 399193,
|
2018-04-20 16:52:43 +02:00
|
|
|
serial_hd(0), DEVICE_LITTLE_ENDIAN);
|
2018-04-30 02:29:34 +02:00
|
|
|
|
2019-11-06 12:56:43 +01:00
|
|
|
sysbus_create_simple("goldfish_rtc", memmap[VIRT_RTC].base,
|
|
|
|
qdev_get_gpio_in(DEVICE(s->plic), RTC_IRQ));
|
|
|
|
|
2019-10-09 01:32:25 +02:00
|
|
|
virt_flash_create(s);
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(s->flash); i++) {
|
|
|
|
/* Map legacy -drive if=pflash to machine properties */
|
|
|
|
pflash_cfi01_legacy_drive(s->flash[i],
|
|
|
|
drive_get(IF_PFLASH, 0, i));
|
|
|
|
}
|
|
|
|
virt_flash_map(s, system_memory);
|
|
|
|
|
2018-04-30 02:29:34 +02:00
|
|
|
g_free(plic_hart_config);
|
2018-03-02 13:31:13 +01:00
|
|
|
}
|
|
|
|
|
2020-05-21 16:42:27 +02:00
|
|
|
static void virt_machine_instance_init(Object *obj)
|
2018-03-02 13:31:13 +01:00
|
|
|
{
|
2019-10-09 01:32:22 +02:00
|
|
|
}
|
|
|
|
|
2020-05-21 16:42:27 +02:00
|
|
|
static void virt_machine_class_init(ObjectClass *oc, void *data)
|
2019-10-09 01:32:22 +02:00
|
|
|
{
|
|
|
|
MachineClass *mc = MACHINE_CLASS(oc);
|
|
|
|
|
|
|
|
mc->desc = "RISC-V VirtIO board";
|
2020-05-21 16:42:27 +02:00
|
|
|
mc->init = virt_machine_init;
|
2019-10-09 01:32:22 +02:00
|
|
|
mc->max_cpus = 8;
|
2019-04-20 04:23:53 +02:00
|
|
|
mc->default_cpu_type = VIRT_CPU;
|
2019-11-22 16:27:52 +01:00
|
|
|
mc->pci_allow_0_address = true;
|
2018-03-02 13:31:13 +01:00
|
|
|
}
|
|
|
|
|
2020-05-21 16:42:27 +02:00
|
|
|
static const TypeInfo virt_machine_typeinfo = {
|
2019-10-09 01:32:22 +02:00
|
|
|
.name = MACHINE_TYPE_NAME("virt"),
|
|
|
|
.parent = TYPE_MACHINE,
|
2020-05-21 16:42:27 +02:00
|
|
|
.class_init = virt_machine_class_init,
|
|
|
|
.instance_init = virt_machine_instance_init,
|
2019-10-09 01:32:22 +02:00
|
|
|
.instance_size = sizeof(RISCVVirtState),
|
|
|
|
};
|
|
|
|
|
2020-05-21 16:42:27 +02:00
|
|
|
static void virt_machine_init_register_types(void)
|
2019-10-09 01:32:22 +02:00
|
|
|
{
|
2020-05-21 16:42:27 +02:00
|
|
|
type_register_static(&virt_machine_typeinfo);
|
2019-10-09 01:32:22 +02:00
|
|
|
}
|
|
|
|
|
2020-05-21 16:42:27 +02:00
|
|
|
type_init(virt_machine_init_register_types)
|