2013-07-24 17:56:02 +02:00
|
|
|
/*
|
|
|
|
* Bochs/QEMU ACPI DSDT ASL definition
|
|
|
|
*
|
|
|
|
* Copyright (c) 2006 Fabrice Bellard
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License version 2 as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
|
|
*/
|
|
|
|
/*
|
|
|
|
* Copyright (c) 2010 Isaku Yamahata
|
|
|
|
* yamahata at valinux co jp
|
|
|
|
* Based on acpi-dsdt.dsl, but heavily modified for q35 chipset.
|
|
|
|
*/
|
|
|
|
|
|
|
|
ACPI_EXTRACT_ALL_CODE Q35AcpiDsdtAmlCode
|
|
|
|
|
|
|
|
DefinitionBlock (
|
|
|
|
"q35-acpi-dsdt.aml",// Output Filename
|
|
|
|
"DSDT", // Signature
|
|
|
|
0x01, // DSDT Compliance Revision
|
|
|
|
"BXPC", // OEMID
|
|
|
|
"BXDSDT", // TABLE ID
|
|
|
|
0x2 // OEM Revision
|
|
|
|
)
|
|
|
|
{
|
|
|
|
|
|
|
|
#include "acpi-dsdt-dbug.dsl"
|
|
|
|
|
|
|
|
Scope(\_SB) {
|
|
|
|
OperationRegion(PCST, SystemIO, 0xae00, 0x0c)
|
|
|
|
OperationRegion(PCSB, SystemIO, 0xae0c, 0x01)
|
|
|
|
Field(PCSB, AnyAcc, NoLock, WriteAsZeros) {
|
|
|
|
PCIB, 8,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/****************************************************************
|
|
|
|
* PCI Bus definition
|
|
|
|
****************************************************************/
|
2014-01-09 17:36:35 +01:00
|
|
|
#define BOARD_SPECIFIC_PCI_RESOURSES \
|
2014-01-09 17:36:36 +01:00
|
|
|
WordIO(ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, \
|
|
|
|
0x0000, \
|
|
|
|
0x0000, \
|
|
|
|
0x0CD7, \
|
|
|
|
0x0000, \
|
|
|
|
0x0CD8, \
|
|
|
|
,, , TypeStatic) \
|
|
|
|
/* 0xcd8-0xcf7 hole for CPU hotplug, hw/acpi/ich9.c:ICH9_PROC_BASE */ \
|
2014-01-09 17:36:35 +01:00
|
|
|
WordIO(ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, \
|
|
|
|
0x0000, \
|
|
|
|
0x0D00, \
|
|
|
|
0xFFFF, \
|
|
|
|
0x0000, \
|
|
|
|
0xF300, \
|
|
|
|
,, , TypeStatic)
|
2013-07-24 17:56:02 +02:00
|
|
|
|
|
|
|
Scope(\_SB) {
|
|
|
|
Device(PCI0) {
|
|
|
|
Name(_HID, EisaId("PNP0A08"))
|
|
|
|
Name(_CID, EisaId("PNP0A03"))
|
|
|
|
Name(_ADR, 0x00)
|
|
|
|
Name(_UID, 1)
|
|
|
|
|
acpi-build: append description for non-hotplug
As reported in
http://article.gmane.org/gmane.comp.emulators.qemu/253987
Mac OSX actually requires describing all occupied slots
in ACPI - even if hotplug isn't enabled.
I didn't expect this so I dropped description of all
non hotpluggable slots from ACPI.
As a result: before
commit 99fd437dee468609de8218f0eb3b16621fb6a9c9 (enable
hotplug for pci bridges), PCI cards show up in the "device tree" of OS X
(System Information). E.g., on MountainLion users have:
Hardware -> PCI Cards:
Card Type Driver Installed Slot
*ethernet Ethernet Controller Yes PCI Slot 2
pci8086,2934 USB UHC Yes PCI Slot 29
ethernet:
Type: Ethernet Controller
Driver Installed: Yes
MSI: No
Bus: PCI
Slot PCI Slot 2
Vendor ID: 0x8086
Device ID: 0x100e
Subsystem Vendor ID: 0x1af4
Subsystem ID: 0x1100
Revision ID: 0x0003
Hardware -> Ethernet Cards
ethernet:
Type: Ethernet Controller
Bus: PCI
Slot PCI Slot 2
Vendor ID: 0x8086
Device ID: 0x100e
Subsystem Vendor ID: 0x1af4
Subsystem ID: 0x1100
Revision ID: 0x0003
BSD name: en0
Kext name: AppleIntel8254XEthernet.kext
Location: /System/Library/Extensions/...
Version: 3.1.1b1
After commit 99fd437dee468609de8218f0eb3b16621fb6a9c9, users get:
Hardware -> PCI Cards:
This computer doesn't contain any PCI cards. If you installed PCI
cards, make sure they're properly installed.
Hardware -> Ethernet Cards
ethernet:
Type: Ethernet Controller
Bus: PCI
Vendor ID: 0x8086
Device ID: 0x100e
Subsystem Vendor ID: 0x1af4
Subsystem ID: 0x1100
Revision ID: 0x0003
BSD name: en0
Kext name: AppleIntel8254XEthernet.kext
Location: /System/Library/Extensions/...
Version: 3.1.1b1
Ethernet still works, but it's not showing up on the PCI bus, and it
no longer thinks it's plugged in to slot #2, as it used to before the
change.
To fix, append description for all occupied non hotpluggable PCI slots.
One need to be careful when doing this: VGA devices
are now described in SSDT, so we need to drop description from DSDT.
And ISA devices are used in DSDT so drop them from SSDT.
Reported-by: Gabriel L. Somlo <gsomlo@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Also update generated dsdt and pcihp hex dump files.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2014-02-04 16:43:47 +01:00
|
|
|
External(ISA, DeviceObj)
|
|
|
|
|
2013-07-24 17:56:02 +02:00
|
|
|
// _OSC: based on sample of ACPI3.0b spec
|
|
|
|
Name(SUPP, 0) // PCI _OSC Support Field value
|
|
|
|
Name(CTRL, 0) // PCI _OSC Control Field value
|
|
|
|
Method(_OSC, 4) {
|
|
|
|
// Create DWORD-addressable fields from the Capabilities Buffer
|
|
|
|
CreateDWordField(Arg3, 0, CDW1)
|
|
|
|
|
|
|
|
// Check for proper UUID
|
|
|
|
If (LEqual(Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) {
|
|
|
|
// Create DWORD-addressable fields from the Capabilities Buffer
|
|
|
|
CreateDWordField(Arg3, 4, CDW2)
|
|
|
|
CreateDWordField(Arg3, 8, CDW3)
|
|
|
|
|
|
|
|
// Save Capabilities DWORD2 & 3
|
|
|
|
Store(CDW2, SUPP)
|
|
|
|
Store(CDW3, CTRL)
|
|
|
|
|
|
|
|
// Always allow native PME, AER (no dependencies)
|
|
|
|
// Never allow SHPC (no SHPC controller in this system)
|
|
|
|
And(CTRL, 0x1D, CTRL)
|
|
|
|
|
|
|
|
#if 0 // For now, nothing to do
|
|
|
|
If (Not(And(CDW1, 1))) { // Query flag clear?
|
|
|
|
// Disable GPEs for features granted native control.
|
|
|
|
If (And(CTRL, 0x01)) { // Hot plug control granted?
|
|
|
|
Store(0, HPCE) // clear the hot plug SCI enable bit
|
|
|
|
Store(1, HPCS) // clear the hot plug SCI status bit
|
|
|
|
}
|
|
|
|
If (And(CTRL, 0x04)) { // PME control granted?
|
|
|
|
Store(0, PMCE) // clear the PME SCI enable bit
|
|
|
|
Store(1, PMCS) // clear the PME SCI status bit
|
|
|
|
}
|
|
|
|
If (And(CTRL, 0x10)) { // OS restoring PCI Express cap structure?
|
|
|
|
// Set status to not restore PCI Express cap structure
|
|
|
|
// upon resume from S3
|
|
|
|
Store(1, S3CR)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
If (LNotEqual(Arg1, One)) {
|
|
|
|
// Unknown revision
|
|
|
|
Or(CDW1, 0x08, CDW1)
|
|
|
|
}
|
|
|
|
If (LNotEqual(CDW3, CTRL)) {
|
|
|
|
// Capabilities bits were masked
|
|
|
|
Or(CDW1, 0x10, CDW1)
|
|
|
|
}
|
|
|
|
// Update DWORD3 in the buffer
|
|
|
|
Store(CTRL, CDW3)
|
|
|
|
} Else {
|
|
|
|
Or(CDW1, 4, CDW1) // Unrecognized UUID
|
|
|
|
}
|
|
|
|
Return (Arg3)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#include "acpi-dsdt-pci-crs.dsl"
|
|
|
|
#include "acpi-dsdt-hpet.dsl"
|
|
|
|
|
|
|
|
|
|
|
|
/****************************************************************
|
|
|
|
* LPC ISA bridge
|
|
|
|
****************************************************************/
|
|
|
|
|
|
|
|
Scope(\_SB.PCI0) {
|
|
|
|
/* PCI D31:f0 LPC ISA bridge */
|
|
|
|
Device(ISA) {
|
acpi-build: append description for non-hotplug
As reported in
http://article.gmane.org/gmane.comp.emulators.qemu/253987
Mac OSX actually requires describing all occupied slots
in ACPI - even if hotplug isn't enabled.
I didn't expect this so I dropped description of all
non hotpluggable slots from ACPI.
As a result: before
commit 99fd437dee468609de8218f0eb3b16621fb6a9c9 (enable
hotplug for pci bridges), PCI cards show up in the "device tree" of OS X
(System Information). E.g., on MountainLion users have:
Hardware -> PCI Cards:
Card Type Driver Installed Slot
*ethernet Ethernet Controller Yes PCI Slot 2
pci8086,2934 USB UHC Yes PCI Slot 29
ethernet:
Type: Ethernet Controller
Driver Installed: Yes
MSI: No
Bus: PCI
Slot PCI Slot 2
Vendor ID: 0x8086
Device ID: 0x100e
Subsystem Vendor ID: 0x1af4
Subsystem ID: 0x1100
Revision ID: 0x0003
Hardware -> Ethernet Cards
ethernet:
Type: Ethernet Controller
Bus: PCI
Slot PCI Slot 2
Vendor ID: 0x8086
Device ID: 0x100e
Subsystem Vendor ID: 0x1af4
Subsystem ID: 0x1100
Revision ID: 0x0003
BSD name: en0
Kext name: AppleIntel8254XEthernet.kext
Location: /System/Library/Extensions/...
Version: 3.1.1b1
After commit 99fd437dee468609de8218f0eb3b16621fb6a9c9, users get:
Hardware -> PCI Cards:
This computer doesn't contain any PCI cards. If you installed PCI
cards, make sure they're properly installed.
Hardware -> Ethernet Cards
ethernet:
Type: Ethernet Controller
Bus: PCI
Vendor ID: 0x8086
Device ID: 0x100e
Subsystem Vendor ID: 0x1af4
Subsystem ID: 0x1100
Revision ID: 0x0003
BSD name: en0
Kext name: AppleIntel8254XEthernet.kext
Location: /System/Library/Extensions/...
Version: 3.1.1b1
Ethernet still works, but it's not showing up on the PCI bus, and it
no longer thinks it's plugged in to slot #2, as it used to before the
change.
To fix, append description for all occupied non hotpluggable PCI slots.
One need to be careful when doing this: VGA devices
are now described in SSDT, so we need to drop description from DSDT.
And ISA devices are used in DSDT so drop them from SSDT.
Reported-by: Gabriel L. Somlo <gsomlo@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Also update generated dsdt and pcihp hex dump files.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2014-02-04 16:43:47 +01:00
|
|
|
Name (_ADR, 0x001F0000) // _ADR: Address
|
2013-07-24 17:56:02 +02:00
|
|
|
|
|
|
|
/* ICH9 PCI to ISA irq remapping */
|
|
|
|
OperationRegion(PIRQ, PCI_Config, 0x60, 0x0C)
|
|
|
|
|
|
|
|
OperationRegion(LPCD, PCI_Config, 0x80, 0x2)
|
|
|
|
Field(LPCD, AnyAcc, NoLock, Preserve) {
|
|
|
|
COMA, 3,
|
|
|
|
, 1,
|
|
|
|
COMB, 3,
|
|
|
|
|
|
|
|
Offset(0x01),
|
|
|
|
LPTD, 2,
|
|
|
|
, 2,
|
|
|
|
FDCD, 2
|
|
|
|
}
|
|
|
|
OperationRegion(LPCE, PCI_Config, 0x82, 0x2)
|
|
|
|
Field(LPCE, AnyAcc, NoLock, Preserve) {
|
|
|
|
CAEN, 1,
|
|
|
|
CBEN, 1,
|
|
|
|
LPEN, 1,
|
|
|
|
FDEN, 1
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-22 16:34:56 +01:00
|
|
|
#define DSDT_APPLESMC_STA q35_dsdt_applesmc_sta
|
2013-07-24 17:56:02 +02:00
|
|
|
#include "acpi-dsdt-isa.dsl"
|
|
|
|
|
|
|
|
|
|
|
|
/****************************************************************
|
|
|
|
* PCI IRQs
|
|
|
|
****************************************************************/
|
|
|
|
|
|
|
|
/* Zero => PIC mode, One => APIC Mode */
|
|
|
|
Name(\PICF, Zero)
|
|
|
|
Method(\_PIC, 1, NotSerialized) {
|
|
|
|
Store(Arg0, \PICF)
|
|
|
|
}
|
|
|
|
|
|
|
|
Scope(\_SB) {
|
|
|
|
Scope(PCI0) {
|
|
|
|
#define prt_slot_lnk(nr, lnk0, lnk1, lnk2, lnk3) \
|
|
|
|
Package() { nr##ffff, 0, lnk0, 0 }, \
|
|
|
|
Package() { nr##ffff, 1, lnk1, 0 }, \
|
|
|
|
Package() { nr##ffff, 2, lnk2, 0 }, \
|
|
|
|
Package() { nr##ffff, 3, lnk3, 0 }
|
|
|
|
|
|
|
|
#define prt_slot_lnkA(nr) prt_slot_lnk(nr, LNKA, LNKB, LNKC, LNKD)
|
|
|
|
#define prt_slot_lnkB(nr) prt_slot_lnk(nr, LNKB, LNKC, LNKD, LNKA)
|
|
|
|
#define prt_slot_lnkC(nr) prt_slot_lnk(nr, LNKC, LNKD, LNKA, LNKB)
|
|
|
|
#define prt_slot_lnkD(nr) prt_slot_lnk(nr, LNKD, LNKA, LNKB, LNKC)
|
|
|
|
|
|
|
|
#define prt_slot_lnkE(nr) prt_slot_lnk(nr, LNKE, LNKF, LNKG, LNKH)
|
|
|
|
#define prt_slot_lnkF(nr) prt_slot_lnk(nr, LNKF, LNKG, LNKH, LNKE)
|
|
|
|
#define prt_slot_lnkG(nr) prt_slot_lnk(nr, LNKG, LNKH, LNKE, LNKF)
|
|
|
|
#define prt_slot_lnkH(nr) prt_slot_lnk(nr, LNKH, LNKE, LNKF, LNKG)
|
|
|
|
|
|
|
|
Name(PRTP, package() {
|
|
|
|
prt_slot_lnkE(0x0000),
|
|
|
|
prt_slot_lnkF(0x0001),
|
|
|
|
prt_slot_lnkG(0x0002),
|
|
|
|
prt_slot_lnkH(0x0003),
|
|
|
|
prt_slot_lnkE(0x0004),
|
|
|
|
prt_slot_lnkF(0x0005),
|
|
|
|
prt_slot_lnkG(0x0006),
|
|
|
|
prt_slot_lnkH(0x0007),
|
|
|
|
prt_slot_lnkE(0x0008),
|
|
|
|
prt_slot_lnkF(0x0009),
|
|
|
|
prt_slot_lnkG(0x000a),
|
|
|
|
prt_slot_lnkH(0x000b),
|
|
|
|
prt_slot_lnkE(0x000c),
|
|
|
|
prt_slot_lnkF(0x000d),
|
|
|
|
prt_slot_lnkG(0x000e),
|
|
|
|
prt_slot_lnkH(0x000f),
|
|
|
|
prt_slot_lnkE(0x0010),
|
|
|
|
prt_slot_lnkF(0x0011),
|
|
|
|
prt_slot_lnkG(0x0012),
|
|
|
|
prt_slot_lnkH(0x0013),
|
|
|
|
prt_slot_lnkE(0x0014),
|
|
|
|
prt_slot_lnkF(0x0015),
|
|
|
|
prt_slot_lnkG(0x0016),
|
|
|
|
prt_slot_lnkH(0x0017),
|
|
|
|
prt_slot_lnkE(0x0018),
|
|
|
|
|
|
|
|
/* INTA -> PIRQA for slot 25 - 31
|
|
|
|
see the default value of D<N>IR */
|
|
|
|
prt_slot_lnkA(0x0019),
|
|
|
|
prt_slot_lnkA(0x001a),
|
|
|
|
prt_slot_lnkA(0x001b),
|
|
|
|
prt_slot_lnkA(0x001c),
|
|
|
|
prt_slot_lnkA(0x001d),
|
|
|
|
|
|
|
|
/* PCIe->PCI bridge. use PIRQ[E-H] */
|
|
|
|
prt_slot_lnkE(0x001e),
|
|
|
|
|
|
|
|
prt_slot_lnkA(0x001f)
|
|
|
|
})
|
|
|
|
|
|
|
|
#define prt_slot_gsi(nr, gsi0, gsi1, gsi2, gsi3) \
|
|
|
|
Package() { nr##ffff, 0, gsi0, 0 }, \
|
|
|
|
Package() { nr##ffff, 1, gsi1, 0 }, \
|
|
|
|
Package() { nr##ffff, 2, gsi2, 0 }, \
|
|
|
|
Package() { nr##ffff, 3, gsi3, 0 }
|
|
|
|
|
|
|
|
#define prt_slot_gsiA(nr) prt_slot_gsi(nr, GSIA, GSIB, GSIC, GSID)
|
|
|
|
#define prt_slot_gsiB(nr) prt_slot_gsi(nr, GSIB, GSIC, GSID, GSIA)
|
|
|
|
#define prt_slot_gsiC(nr) prt_slot_gsi(nr, GSIC, GSID, GSIA, GSIB)
|
|
|
|
#define prt_slot_gsiD(nr) prt_slot_gsi(nr, GSID, GSIA, GSIB, GSIC)
|
|
|
|
|
|
|
|
#define prt_slot_gsiE(nr) prt_slot_gsi(nr, GSIE, GSIF, GSIG, GSIH)
|
|
|
|
#define prt_slot_gsiF(nr) prt_slot_gsi(nr, GSIF, GSIG, GSIH, GSIE)
|
|
|
|
#define prt_slot_gsiG(nr) prt_slot_gsi(nr, GSIG, GSIH, GSIE, GSIF)
|
|
|
|
#define prt_slot_gsiH(nr) prt_slot_gsi(nr, GSIH, GSIE, GSIF, GSIG)
|
|
|
|
|
|
|
|
Name(PRTA, package() {
|
|
|
|
prt_slot_gsiE(0x0000),
|
|
|
|
prt_slot_gsiF(0x0001),
|
|
|
|
prt_slot_gsiG(0x0002),
|
|
|
|
prt_slot_gsiH(0x0003),
|
|
|
|
prt_slot_gsiE(0x0004),
|
|
|
|
prt_slot_gsiF(0x0005),
|
|
|
|
prt_slot_gsiG(0x0006),
|
|
|
|
prt_slot_gsiH(0x0007),
|
|
|
|
prt_slot_gsiE(0x0008),
|
|
|
|
prt_slot_gsiF(0x0009),
|
|
|
|
prt_slot_gsiG(0x000a),
|
|
|
|
prt_slot_gsiH(0x000b),
|
|
|
|
prt_slot_gsiE(0x000c),
|
|
|
|
prt_slot_gsiF(0x000d),
|
|
|
|
prt_slot_gsiG(0x000e),
|
|
|
|
prt_slot_gsiH(0x000f),
|
|
|
|
prt_slot_gsiE(0x0010),
|
|
|
|
prt_slot_gsiF(0x0011),
|
|
|
|
prt_slot_gsiG(0x0012),
|
|
|
|
prt_slot_gsiH(0x0013),
|
|
|
|
prt_slot_gsiE(0x0014),
|
|
|
|
prt_slot_gsiF(0x0015),
|
|
|
|
prt_slot_gsiG(0x0016),
|
|
|
|
prt_slot_gsiH(0x0017),
|
|
|
|
prt_slot_gsiE(0x0018),
|
|
|
|
|
|
|
|
/* INTA -> PIRQA for slot 25 - 31, but 30
|
|
|
|
see the default value of D<N>IR */
|
|
|
|
prt_slot_gsiA(0x0019),
|
|
|
|
prt_slot_gsiA(0x001a),
|
|
|
|
prt_slot_gsiA(0x001b),
|
|
|
|
prt_slot_gsiA(0x001c),
|
|
|
|
prt_slot_gsiA(0x001d),
|
|
|
|
|
|
|
|
/* PCIe->PCI bridge. use PIRQ[E-H] */
|
|
|
|
prt_slot_gsiE(0x001e),
|
|
|
|
|
|
|
|
prt_slot_gsiA(0x001f)
|
|
|
|
})
|
|
|
|
|
|
|
|
Method(_PRT, 0, NotSerialized) {
|
|
|
|
/* PCI IRQ routing table, example from ACPI 2.0a specification,
|
|
|
|
section 6.2.8.1 */
|
|
|
|
/* Note: we provide the same info as the PCI routing
|
|
|
|
table of the Bochs BIOS */
|
|
|
|
If (LEqual(\PICF, Zero)) {
|
|
|
|
Return (PRTP)
|
|
|
|
} Else {
|
|
|
|
Return (PRTA)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
Field(PCI0.ISA.PIRQ, ByteAcc, NoLock, Preserve) {
|
|
|
|
PRQA, 8,
|
|
|
|
PRQB, 8,
|
|
|
|
PRQC, 8,
|
|
|
|
PRQD, 8,
|
|
|
|
|
|
|
|
Offset(0x08),
|
|
|
|
PRQE, 8,
|
|
|
|
PRQF, 8,
|
|
|
|
PRQG, 8,
|
|
|
|
PRQH, 8
|
|
|
|
}
|
|
|
|
|
|
|
|
Method(IQST, 1, NotSerialized) {
|
|
|
|
// _STA method - get status
|
|
|
|
If (And(0x80, Arg0)) {
|
|
|
|
Return (0x09)
|
|
|
|
}
|
|
|
|
Return (0x0B)
|
|
|
|
}
|
ACPI DSDT: Make control method `IQCR` serialized
Forward-port the following commit from seabios:
commit 995bbeef78b338370f426bf8d0399038c3fa259c
Author: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Thu Oct 3 11:30:52 2013 +0200
The ASL Optimizing Compiler version 20130823-32 [Sep 11 2013] issues the
following warning.
$ make
[…]
Compiling IASL out/src/fw/acpi-dsdt.hex
out/src/fw/acpi-dsdt.dsl.i 360: Method(IQCR, 1, NotSerialized) {
Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within)
[…]
ASL Input: out/src/fw/acpi-dsdt.dsl.i - 475 lines, 19181 bytes, 316 keywords
AML Output: out/src/fw/acpi-dsdt.aml - 4407 bytes, 159 named objects, 157 executable opcodes
Listing File: out/src/fw/acpi-dsdt.lst - 143715 bytes
Hex Dump: out/src/fw/acpi-dsdt.hex - 41661 bytes
Compilation complete. 0 Errors, 0 Warnings, 1 Remarks, 246 Optimizations
[…]
After changing the parameter from `NotSerialized` to `Serialized`, the
remark is indeed gone and there is no size change.
The remark was added in ACPICA version 20130517 [1] and gives the
following explanation.
If a thread blocks within the method for any reason, and another thread
enters the method, the method will fail because an attempt will be
made to create the same (named) object twice.
In this case, issue a remark that the method should be marked
serialized. ACPICA BZ 909.
[1] https://github.com/acpica/acpica/commit/ba84d0fc18ba910a47a3f71c68a43543c06e6831
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reported-by: Marcel Apfelbaum <marcel.a@redhat.com>
Tested-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2013-11-14 13:12:47 +01:00
|
|
|
Method(IQCR, 1, Serialized) {
|
2013-07-24 17:56:02 +02:00
|
|
|
// _CRS method - get current settings
|
|
|
|
Name(PRR0, ResourceTemplate() {
|
|
|
|
Interrupt(, Level, ActiveHigh, Shared) { 0 }
|
|
|
|
})
|
|
|
|
CreateDWordField(PRR0, 0x05, PRRI)
|
|
|
|
Store(And(Arg0, 0x0F), PRRI)
|
|
|
|
Return (PRR0)
|
|
|
|
}
|
|
|
|
|
|
|
|
#define define_link(link, uid, reg) \
|
|
|
|
Device(link) { \
|
|
|
|
Name(_HID, EISAID("PNP0C0F")) \
|
|
|
|
Name(_UID, uid) \
|
|
|
|
Name(_PRS, ResourceTemplate() { \
|
|
|
|
Interrupt(, Level, ActiveHigh, Shared) { \
|
|
|
|
5, 10, 11 \
|
|
|
|
} \
|
|
|
|
}) \
|
|
|
|
Method(_STA, 0, NotSerialized) { \
|
|
|
|
Return (IQST(reg)) \
|
|
|
|
} \
|
|
|
|
Method(_DIS, 0, NotSerialized) { \
|
|
|
|
Or(reg, 0x80, reg) \
|
|
|
|
} \
|
|
|
|
Method(_CRS, 0, NotSerialized) { \
|
|
|
|
Return (IQCR(reg)) \
|
|
|
|
} \
|
|
|
|
Method(_SRS, 1, NotSerialized) { \
|
|
|
|
CreateDWordField(Arg0, 0x05, PRRI) \
|
|
|
|
Store(PRRI, reg) \
|
|
|
|
} \
|
|
|
|
}
|
|
|
|
|
|
|
|
define_link(LNKA, 0, PRQA)
|
|
|
|
define_link(LNKB, 1, PRQB)
|
|
|
|
define_link(LNKC, 2, PRQC)
|
|
|
|
define_link(LNKD, 3, PRQD)
|
|
|
|
define_link(LNKE, 4, PRQE)
|
|
|
|
define_link(LNKF, 5, PRQF)
|
|
|
|
define_link(LNKG, 6, PRQG)
|
|
|
|
define_link(LNKH, 7, PRQH)
|
|
|
|
|
|
|
|
#define define_gsi_link(link, uid, gsi) \
|
|
|
|
Device(link) { \
|
|
|
|
Name(_HID, EISAID("PNP0C0F")) \
|
|
|
|
Name(_UID, uid) \
|
|
|
|
Name(_PRS, ResourceTemplate() { \
|
|
|
|
Interrupt(, Level, ActiveHigh, Shared) { \
|
|
|
|
gsi \
|
|
|
|
} \
|
|
|
|
}) \
|
|
|
|
Name(_CRS, ResourceTemplate() { \
|
|
|
|
Interrupt(, Level, ActiveHigh, Shared) { \
|
|
|
|
gsi \
|
|
|
|
} \
|
|
|
|
}) \
|
|
|
|
Method(_SRS, 1, NotSerialized) { \
|
|
|
|
} \
|
|
|
|
}
|
|
|
|
|
|
|
|
define_gsi_link(GSIA, 0, 0x10)
|
|
|
|
define_gsi_link(GSIB, 0, 0x11)
|
|
|
|
define_gsi_link(GSIC, 0, 0x12)
|
|
|
|
define_gsi_link(GSID, 0, 0x13)
|
|
|
|
define_gsi_link(GSIE, 0, 0x14)
|
|
|
|
define_gsi_link(GSIF, 0, 0x15)
|
|
|
|
define_gsi_link(GSIG, 0, 0x16)
|
|
|
|
define_gsi_link(GSIH, 0, 0x17)
|
|
|
|
}
|
|
|
|
|
2014-06-02 15:25:15 +02:00
|
|
|
#include "hw/acpi/pc-hotplug.h"
|
2014-01-09 17:36:38 +01:00
|
|
|
#define CPU_STATUS_BASE ICH9_CPU_HOTPLUG_IO_BASE
|
2013-07-24 17:56:02 +02:00
|
|
|
#include "acpi-dsdt-cpu-hotplug.dsl"
|
|
|
|
|
|
|
|
|
|
|
|
/****************************************************************
|
|
|
|
* General purpose events
|
|
|
|
****************************************************************/
|
2014-06-02 15:25:29 +02:00
|
|
|
External(\_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD, MethodObj)
|
2013-07-24 17:56:02 +02:00
|
|
|
|
|
|
|
Scope(\_GPE) {
|
|
|
|
Name(_HID, "ACPI0006")
|
|
|
|
|
|
|
|
Method(_L00) {
|
|
|
|
}
|
|
|
|
Method(_L01) {
|
2013-12-13 17:22:12 +01:00
|
|
|
}
|
|
|
|
Method(_E02) {
|
2013-07-24 17:56:02 +02:00
|
|
|
// CPU hotplug event
|
|
|
|
\_SB.PRSC()
|
|
|
|
}
|
2014-06-02 15:25:29 +02:00
|
|
|
Method(_E03) {
|
|
|
|
// Memory hotplug event
|
|
|
|
\_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD()
|
2013-07-24 17:56:02 +02:00
|
|
|
}
|
|
|
|
Method(_L04) {
|
|
|
|
}
|
|
|
|
Method(_L05) {
|
|
|
|
}
|
|
|
|
Method(_L06) {
|
|
|
|
}
|
|
|
|
Method(_L07) {
|
|
|
|
}
|
|
|
|
Method(_L08) {
|
|
|
|
}
|
|
|
|
Method(_L09) {
|
|
|
|
}
|
|
|
|
Method(_L0A) {
|
|
|
|
}
|
|
|
|
Method(_L0B) {
|
|
|
|
}
|
|
|
|
Method(_L0C) {
|
|
|
|
}
|
|
|
|
Method(_L0D) {
|
|
|
|
}
|
|
|
|
Method(_L0E) {
|
|
|
|
}
|
|
|
|
Method(_L0F) {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|