2016-10-28 10:33:20 +02:00
|
|
|
/*
|
|
|
|
* QEMU Crypto Device Implementation
|
|
|
|
*
|
|
|
|
* Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Gonglei <arei.gonglei@huawei.com>
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
2020-10-14 15:37:22 +02:00
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
2016-10-28 10:33:20 +02:00
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "sysemu/cryptodev.h"
|
cryptodev: Support query-stats QMP command
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stats". This makes sense!)
Example:
~# virsh qemu-monitor-command vm '{"execute": "query-stats", \
"arguments": {"target": "cryptodev"} }' | jq
{
"return": [
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 7680
},
...
{
"name": "asym-decrypt-ops",
"value": 32
},
{
"name": "asym-encrypt-ops",
"value": 48
}
],
"qom-path": "/objects/cryptodev0" # support asym only
},
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 0
},
...
{
"name": "sym-decrypt-bytes",
"value": 5376
},
...
],
"qom-path": "/objects/cryptodev1" # support asym/sym
}
],
"id": "libvirt-422"
}
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-12-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:46 +01:00
|
|
|
#include "sysemu/stats.h"
|
2016-10-28 10:33:20 +02:00
|
|
|
#include "qapi/error.h"
|
cryptodev: Introduce 'query-cryptodev' QMP command
Now we have a QMP command to query crypto devices:
virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq
{
"return": [
{
"service": [
"akcipher",
"mac",
"hash",
"cipher"
],
"id": "cryptodev1",
"client": [
{
"queue": 0,
"type": "builtin"
}
]
},
{
"service": [
"akcipher"
],
"id": "cryptodev0",
"client": [
{
"queue": 0,
"type": "lkcf"
}
]
}
],
"id": "libvirt-417"
}
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-6-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:40 +01:00
|
|
|
#include "qapi/qapi-commands-cryptodev.h"
|
cryptodev: Support query-stats QMP command
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stats". This makes sense!)
Example:
~# virsh qemu-monitor-command vm '{"execute": "query-stats", \
"arguments": {"target": "cryptodev"} }' | jq
{
"return": [
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 7680
},
...
{
"name": "asym-decrypt-ops",
"value": 32
},
{
"name": "asym-encrypt-ops",
"value": 48
}
],
"qom-path": "/objects/cryptodev0" # support asym only
},
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 0
},
...
{
"name": "sym-decrypt-bytes",
"value": 5376
},
...
],
"qom-path": "/objects/cryptodev1" # support asym/sym
}
],
"id": "libvirt-422"
}
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-12-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:46 +01:00
|
|
|
#include "qapi/qapi-types-stats.h"
|
2016-10-28 10:33:20 +02:00
|
|
|
#include "qapi/visitor.h"
|
|
|
|
#include "qemu/config-file.h"
|
2022-10-08 10:50:27 +02:00
|
|
|
#include "qemu/error-report.h"
|
2023-03-01 11:58:45 +01:00
|
|
|
#include "qemu/main-loop.h"
|
2016-10-28 10:33:20 +02:00
|
|
|
#include "qom/object_interfaces.h"
|
2016-10-28 10:33:29 +02:00
|
|
|
#include "hw/virtio/virtio-crypto.h"
|
|
|
|
|
cryptodev: Support query-stats QMP command
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stats". This makes sense!)
Example:
~# virsh qemu-monitor-command vm '{"execute": "query-stats", \
"arguments": {"target": "cryptodev"} }' | jq
{
"return": [
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 7680
},
...
{
"name": "asym-decrypt-ops",
"value": 32
},
{
"name": "asym-encrypt-ops",
"value": 48
}
],
"qom-path": "/objects/cryptodev0" # support asym only
},
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 0
},
...
{
"name": "sym-decrypt-bytes",
"value": 5376
},
...
],
"qom-path": "/objects/cryptodev1" # support asym/sym
}
],
"id": "libvirt-422"
}
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-12-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:46 +01:00
|
|
|
#define SYM_ENCRYPT_OPS_STR "sym-encrypt-ops"
|
|
|
|
#define SYM_DECRYPT_OPS_STR "sym-decrypt-ops"
|
|
|
|
#define SYM_ENCRYPT_BYTES_STR "sym-encrypt-bytes"
|
|
|
|
#define SYM_DECRYPT_BYTES_STR "sym-decrypt-bytes"
|
|
|
|
|
|
|
|
#define ASYM_ENCRYPT_OPS_STR "asym-encrypt-ops"
|
|
|
|
#define ASYM_DECRYPT_OPS_STR "asym-decrypt-ops"
|
|
|
|
#define ASYM_SIGN_OPS_STR "asym-sign-ops"
|
|
|
|
#define ASYM_VERIFY_OPS_STR "asym-verify-ops"
|
|
|
|
#define ASYM_ENCRYPT_BYTES_STR "asym-encrypt-bytes"
|
|
|
|
#define ASYM_DECRYPT_BYTES_STR "asym-decrypt-bytes"
|
|
|
|
#define ASYM_SIGN_BYTES_STR "asym-sign-bytes"
|
|
|
|
#define ASYM_VERIFY_BYTES_STR "asym-verify-bytes"
|
|
|
|
|
|
|
|
typedef struct StatsArgs {
|
|
|
|
union StatsResultsType {
|
|
|
|
StatsResultList **stats;
|
|
|
|
StatsSchemaList **schema;
|
|
|
|
} result;
|
|
|
|
strList *names;
|
|
|
|
Error **errp;
|
|
|
|
} StatsArgs;
|
2016-10-28 10:33:20 +02:00
|
|
|
|
|
|
|
static QTAILQ_HEAD(, CryptoDevBackendClient) crypto_clients;
|
|
|
|
|
cryptodev: Introduce 'query-cryptodev' QMP command
Now we have a QMP command to query crypto devices:
virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq
{
"return": [
{
"service": [
"akcipher",
"mac",
"hash",
"cipher"
],
"id": "cryptodev1",
"client": [
{
"queue": 0,
"type": "builtin"
}
]
},
{
"service": [
"akcipher"
],
"id": "cryptodev0",
"client": [
{
"queue": 0,
"type": "lkcf"
}
]
}
],
"id": "libvirt-417"
}
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-6-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:40 +01:00
|
|
|
static int qmp_query_cryptodev_foreach(Object *obj, void *data)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend;
|
|
|
|
QCryptodevInfoList **infolist = data;
|
|
|
|
uint32_t services, i;
|
|
|
|
|
|
|
|
if (!object_dynamic_cast(obj, TYPE_CRYPTODEV_BACKEND)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
QCryptodevInfo *info = g_new0(QCryptodevInfo, 1);
|
|
|
|
info->id = g_strdup(object_get_canonical_path_component(obj));
|
|
|
|
|
|
|
|
backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
services = backend->conf.crypto_services;
|
|
|
|
for (i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) {
|
|
|
|
if (services & (1 << i)) {
|
|
|
|
QAPI_LIST_PREPEND(info->service, i);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < backend->conf.peers.queues; i++) {
|
|
|
|
CryptoDevBackendClient *cc = backend->conf.peers.ccs[i];
|
|
|
|
QCryptodevBackendClient *client = g_new0(QCryptodevBackendClient, 1);
|
|
|
|
|
|
|
|
client->queue = cc->queue_index;
|
|
|
|
client->type = cc->type;
|
|
|
|
QAPI_LIST_PREPEND(info->client, client);
|
|
|
|
}
|
|
|
|
|
|
|
|
QAPI_LIST_PREPEND(*infolist, info);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
QCryptodevInfoList *qmp_query_cryptodev(Error **errp)
|
|
|
|
{
|
|
|
|
QCryptodevInfoList *list = NULL;
|
|
|
|
Object *objs = container_get(object_get_root(), "/objects");
|
|
|
|
|
|
|
|
object_child_foreach(objs, qmp_query_cryptodev_foreach, &list);
|
|
|
|
|
|
|
|
return list;
|
|
|
|
}
|
2016-10-28 10:33:20 +02:00
|
|
|
|
2023-03-01 11:58:37 +01:00
|
|
|
CryptoDevBackendClient *cryptodev_backend_new_client(void)
|
2016-10-28 10:33:20 +02:00
|
|
|
{
|
|
|
|
CryptoDevBackendClient *cc;
|
|
|
|
|
2022-03-15 15:41:56 +01:00
|
|
|
cc = g_new0(CryptoDevBackendClient, 1);
|
2016-10-28 10:33:20 +02:00
|
|
|
QTAILQ_INSERT_TAIL(&crypto_clients, cc, next);
|
|
|
|
|
|
|
|
return cc;
|
|
|
|
}
|
|
|
|
|
|
|
|
void cryptodev_backend_free_client(
|
|
|
|
CryptoDevBackendClient *cc)
|
|
|
|
{
|
|
|
|
QTAILQ_REMOVE(&crypto_clients, cc, next);
|
|
|
|
g_free(cc->info_str);
|
|
|
|
g_free(cc);
|
|
|
|
}
|
|
|
|
|
|
|
|
void cryptodev_backend_cleanup(
|
|
|
|
CryptoDevBackend *backend,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->cleanup) {
|
|
|
|
bc->cleanup(backend, errp);
|
|
|
|
}
|
2023-03-01 11:58:44 +01:00
|
|
|
|
|
|
|
g_free(backend->sym_stat);
|
|
|
|
g_free(backend->asym_stat);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
2022-10-08 10:50:27 +02:00
|
|
|
int cryptodev_backend_create_session(
|
2016-10-28 10:33:21 +02:00
|
|
|
CryptoDevBackend *backend,
|
2022-06-11 08:42:43 +02:00
|
|
|
CryptoDevBackendSessionInfo *sess_info,
|
2022-10-08 10:50:27 +02:00
|
|
|
uint32_t queue_index,
|
|
|
|
CryptoDevCompletionFunc cb,
|
|
|
|
void *opaque)
|
2016-10-28 10:33:21 +02:00
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->create_session) {
|
2022-10-08 10:50:27 +02:00
|
|
|
return bc->create_session(backend, sess_info, queue_index, cb, opaque);
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
2022-10-08 10:50:27 +02:00
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
|
|
|
|
2022-06-11 08:42:43 +02:00
|
|
|
int cryptodev_backend_close_session(
|
2016-10-28 10:33:21 +02:00
|
|
|
CryptoDevBackend *backend,
|
|
|
|
uint64_t session_id,
|
2022-10-08 10:50:27 +02:00
|
|
|
uint32_t queue_index,
|
|
|
|
CryptoDevCompletionFunc cb,
|
|
|
|
void *opaque)
|
2016-10-28 10:33:21 +02:00
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->close_session) {
|
2022-10-08 10:50:27 +02:00
|
|
|
return bc->close_session(backend, session_id, queue_index, cb, opaque);
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
2022-10-08 10:50:27 +02:00
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
|
|
|
|
2022-06-11 08:42:43 +02:00
|
|
|
static int cryptodev_backend_operation(
|
2016-10-28 10:33:21 +02:00
|
|
|
CryptoDevBackend *backend,
|
2023-03-01 11:58:43 +01:00
|
|
|
CryptoDevBackendOpInfo *op_info)
|
2016-10-28 10:33:21 +02:00
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
2022-06-11 08:42:43 +02:00
|
|
|
if (bc->do_op) {
|
2023-03-01 11:58:43 +01:00
|
|
|
return bc->do_op(backend, op_info);
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
2022-10-08 10:50:27 +02:00
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
2016-10-28 10:33:29 +02:00
|
|
|
}
|
|
|
|
|
2023-03-01 11:58:44 +01:00
|
|
|
static int cryptodev_backend_account(CryptoDevBackend *backend,
|
|
|
|
CryptoDevBackendOpInfo *op_info)
|
|
|
|
{
|
|
|
|
enum QCryptodevBackendAlgType algtype = op_info->algtype;
|
|
|
|
int len;
|
|
|
|
|
|
|
|
if (algtype == QCRYPTODEV_BACKEND_ALG_ASYM) {
|
|
|
|
CryptoDevBackendAsymOpInfo *asym_op_info = op_info->u.asym_op_info;
|
|
|
|
len = asym_op_info->src_len;
|
|
|
|
switch (op_info->op_code) {
|
|
|
|
case VIRTIO_CRYPTO_AKCIPHER_ENCRYPT:
|
|
|
|
CryptodevAsymStatIncEncrypt(backend, len);
|
|
|
|
break;
|
|
|
|
case VIRTIO_CRYPTO_AKCIPHER_DECRYPT:
|
|
|
|
CryptodevAsymStatIncDecrypt(backend, len);
|
|
|
|
break;
|
|
|
|
case VIRTIO_CRYPTO_AKCIPHER_SIGN:
|
|
|
|
CryptodevAsymStatIncSign(backend, len);
|
|
|
|
break;
|
|
|
|
case VIRTIO_CRYPTO_AKCIPHER_VERIFY:
|
|
|
|
CryptodevAsymStatIncVerify(backend, len);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
|
|
|
}
|
|
|
|
} else if (algtype == QCRYPTODEV_BACKEND_ALG_SYM) {
|
|
|
|
CryptoDevBackendSymOpInfo *sym_op_info = op_info->u.sym_op_info;
|
|
|
|
len = sym_op_info->src_len;
|
|
|
|
switch (op_info->op_code) {
|
|
|
|
case VIRTIO_CRYPTO_CIPHER_ENCRYPT:
|
|
|
|
CryptodevSymStatIncEncrypt(backend, len);
|
|
|
|
break;
|
|
|
|
case VIRTIO_CRYPTO_CIPHER_DECRYPT:
|
|
|
|
CryptodevSymStatIncDecrypt(backend, len);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
error_report("Unsupported cryptodev alg type: %" PRIu32 "", algtype);
|
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
|
|
|
}
|
|
|
|
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
2023-03-01 11:58:45 +01:00
|
|
|
static void cryptodev_backend_throttle_timer_cb(void *opaque)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = (CryptoDevBackend *)opaque;
|
|
|
|
CryptoDevBackendOpInfo *op_info, *tmpop;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH_SAFE(op_info, &backend->opinfos, next, tmpop) {
|
|
|
|
QTAILQ_REMOVE(&backend->opinfos, op_info, next);
|
|
|
|
ret = cryptodev_backend_account(backend, op_info);
|
|
|
|
if (ret < 0) {
|
|
|
|
op_info->cb(op_info->opaque, ret);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
throttle_account(&backend->ts, true, ret);
|
|
|
|
cryptodev_backend_operation(backend, op_info);
|
|
|
|
if (throttle_enabled(&backend->tc) &&
|
|
|
|
throttle_schedule_timer(&backend->ts, &backend->tt, true)) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:29 +02:00
|
|
|
int cryptodev_backend_crypto_operation(
|
|
|
|
CryptoDevBackend *backend,
|
2023-03-01 11:58:43 +01:00
|
|
|
CryptoDevBackendOpInfo *op_info)
|
2016-10-28 10:33:29 +02:00
|
|
|
{
|
2023-03-01 11:58:44 +01:00
|
|
|
int ret;
|
2016-10-28 10:33:29 +02:00
|
|
|
|
2023-03-01 11:58:45 +01:00
|
|
|
if (!throttle_enabled(&backend->tc)) {
|
|
|
|
goto do_account;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (throttle_schedule_timer(&backend->ts, &backend->tt, true) ||
|
|
|
|
!QTAILQ_EMPTY(&backend->opinfos)) {
|
|
|
|
QTAILQ_INSERT_TAIL(&backend->opinfos, op_info, next);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
do_account:
|
2023-03-01 11:58:44 +01:00
|
|
|
ret = cryptodev_backend_account(backend, op_info);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2016-10-28 10:33:29 +02:00
|
|
|
}
|
|
|
|
|
2023-03-01 11:58:45 +01:00
|
|
|
throttle_account(&backend->ts, true, ret);
|
|
|
|
|
2023-03-01 11:58:43 +01:00
|
|
|
return cryptodev_backend_operation(backend, op_info);
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
static void
|
|
|
|
cryptodev_backend_get_queues(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint32_t value = backend->conf.peers.queues;
|
|
|
|
|
|
|
|
visit_type_uint32(v, name, &value, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
cryptodev_backend_set_queues(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint32_t value;
|
|
|
|
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 18:06:02 +02:00
|
|
|
if (!visit_type_uint32(v, name, &value, errp)) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-07 18:06:01 +02:00
|
|
|
return;
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
if (!value) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-07 18:06:01 +02:00
|
|
|
error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu32 "'",
|
|
|
|
object_get_typename(obj), name, value);
|
|
|
|
return;
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
backend->conf.peers.queues = value;
|
|
|
|
}
|
|
|
|
|
2023-03-01 11:58:45 +01:00
|
|
|
static void cryptodev_backend_set_throttle(CryptoDevBackend *backend, int field,
|
|
|
|
uint64_t value, Error **errp)
|
|
|
|
{
|
|
|
|
uint64_t orig = backend->tc.buckets[field].avg;
|
|
|
|
bool enabled = throttle_enabled(&backend->tc);
|
|
|
|
|
|
|
|
if (orig == value) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
backend->tc.buckets[field].avg = value;
|
|
|
|
if (!throttle_enabled(&backend->tc)) {
|
|
|
|
throttle_timers_destroy(&backend->tt);
|
|
|
|
cryptodev_backend_throttle_timer_cb(backend); /* drain opinfos */
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!throttle_is_valid(&backend->tc, errp)) {
|
|
|
|
backend->tc.buckets[field].avg = orig; /* revert change */
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!enabled) {
|
|
|
|
throttle_init(&backend->ts);
|
|
|
|
throttle_timers_init(&backend->tt, qemu_get_aio_context(),
|
|
|
|
QEMU_CLOCK_REALTIME,
|
|
|
|
cryptodev_backend_throttle_timer_cb, /* FIXME */
|
|
|
|
cryptodev_backend_throttle_timer_cb, backend);
|
|
|
|
}
|
|
|
|
|
|
|
|
throttle_config(&backend->ts, QEMU_CLOCK_REALTIME, &backend->tc);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_get_bps(Object *obj, Visitor *v,
|
|
|
|
const char *name, void *opaque,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint64_t value = backend->tc.buckets[THROTTLE_BPS_TOTAL].avg;
|
|
|
|
|
|
|
|
visit_type_uint64(v, name, &value, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_set_bps(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint64_t value;
|
|
|
|
|
|
|
|
if (!visit_type_uint64(v, name, &value, errp)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
cryptodev_backend_set_throttle(backend, THROTTLE_BPS_TOTAL, value, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_get_ops(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint64_t value = backend->tc.buckets[THROTTLE_OPS_TOTAL].avg;
|
|
|
|
|
|
|
|
visit_type_uint64(v, name, &value, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_set_ops(Object *obj, Visitor *v,
|
|
|
|
const char *name, void *opaque,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint64_t value;
|
|
|
|
|
|
|
|
if (!visit_type_uint64(v, name, &value, errp)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
cryptodev_backend_set_throttle(backend, THROTTLE_OPS_TOTAL, value, errp);
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
static void
|
|
|
|
cryptodev_backend_complete(UserCreatable *uc, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
|
|
|
|
CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
|
2023-03-01 11:58:44 +01:00
|
|
|
uint32_t services;
|
2023-03-01 11:58:45 +01:00
|
|
|
uint64_t value;
|
|
|
|
|
|
|
|
QTAILQ_INIT(&backend->opinfos);
|
|
|
|
value = backend->tc.buckets[THROTTLE_OPS_TOTAL].avg;
|
|
|
|
cryptodev_backend_set_throttle(backend, THROTTLE_OPS_TOTAL, value, errp);
|
|
|
|
value = backend->tc.buckets[THROTTLE_BPS_TOTAL].avg;
|
|
|
|
cryptodev_backend_set_throttle(backend, THROTTLE_BPS_TOTAL, value, errp);
|
2016-10-28 10:33:20 +02:00
|
|
|
|
|
|
|
if (bc->init) {
|
2019-12-05 18:46:33 +01:00
|
|
|
bc->init(backend, errp);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
2023-03-01 11:58:44 +01:00
|
|
|
|
|
|
|
services = backend->conf.crypto_services;
|
|
|
|
if (services & (1 << QCRYPTODEV_BACKEND_SERVICE_CIPHER)) {
|
|
|
|
backend->sym_stat = g_new0(CryptodevBackendSymStat, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (services & (1 << QCRYPTODEV_BACKEND_SERVICE_AKCIPHER)) {
|
|
|
|
backend->asym_stat = g_new0(CryptodevBackendAsymStat, 1);
|
|
|
|
}
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
2016-12-22 04:12:38 +01:00
|
|
|
void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
|
|
|
|
{
|
|
|
|
backend->is_used = used;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool cryptodev_backend_is_used(CryptoDevBackend *backend)
|
|
|
|
{
|
|
|
|
return backend->is_used;
|
|
|
|
}
|
|
|
|
|
2016-12-22 04:12:39 +01:00
|
|
|
void cryptodev_backend_set_ready(CryptoDevBackend *backend, bool ready)
|
|
|
|
{
|
|
|
|
backend->ready = ready;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool cryptodev_backend_is_ready(CryptoDevBackend *backend)
|
|
|
|
{
|
|
|
|
return backend->ready;
|
|
|
|
}
|
|
|
|
|
2016-12-22 04:12:38 +01:00
|
|
|
static bool
|
2017-08-30 00:03:37 +02:00
|
|
|
cryptodev_backend_can_be_deleted(UserCreatable *uc)
|
2016-12-22 04:12:38 +01:00
|
|
|
{
|
|
|
|
return !cryptodev_backend_is_used(CRYPTODEV_BACKEND(uc));
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
static void cryptodev_backend_instance_init(Object *obj)
|
|
|
|
{
|
2023-03-01 11:58:45 +01:00
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
/* Initialize devices' queues property to 1 */
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 18:05:54 +02:00
|
|
|
object_property_set_int(obj, "queues", 1, NULL);
|
2023-03-01 11:58:45 +01:00
|
|
|
|
|
|
|
throttle_config_init(&backend->tc);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_finalize(Object *obj)
|
|
|
|
{
|
2016-12-22 04:12:38 +01:00
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
2016-10-28 10:33:20 +02:00
|
|
|
|
2016-12-22 04:12:38 +01:00
|
|
|
cryptodev_backend_cleanup(backend, NULL);
|
2023-03-01 11:58:45 +01:00
|
|
|
if (throttle_enabled(&backend->tc)) {
|
|
|
|
throttle_timers_destroy(&backend->tt);
|
|
|
|
}
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
cryptodev: Support query-stats QMP command
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stats". This makes sense!)
Example:
~# virsh qemu-monitor-command vm '{"execute": "query-stats", \
"arguments": {"target": "cryptodev"} }' | jq
{
"return": [
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 7680
},
...
{
"name": "asym-decrypt-ops",
"value": 32
},
{
"name": "asym-encrypt-ops",
"value": 48
}
],
"qom-path": "/objects/cryptodev0" # support asym only
},
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 0
},
...
{
"name": "sym-decrypt-bytes",
"value": 5376
},
...
],
"qom-path": "/objects/cryptodev1" # support asym/sym
}
],
"id": "libvirt-422"
}
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-12-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:46 +01:00
|
|
|
static StatsList *cryptodev_backend_stats_add(const char *name, int64_t *val,
|
|
|
|
StatsList *stats_list)
|
|
|
|
{
|
|
|
|
Stats *stats = g_new0(Stats, 1);
|
|
|
|
|
|
|
|
stats->name = g_strdup(name);
|
|
|
|
stats->value = g_new0(StatsValue, 1);
|
|
|
|
stats->value->type = QTYPE_QNUM;
|
|
|
|
stats->value->u.scalar = *val;
|
|
|
|
|
|
|
|
QAPI_LIST_PREPEND(stats_list, stats);
|
|
|
|
return stats_list;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cryptodev_backend_stats_query(Object *obj, void *data)
|
|
|
|
{
|
|
|
|
StatsArgs *stats_args = data;
|
|
|
|
StatsResultList **stats_results = stats_args->result.stats;
|
|
|
|
StatsList *stats_list = NULL;
|
|
|
|
StatsResult *entry;
|
|
|
|
CryptoDevBackend *backend;
|
|
|
|
CryptodevBackendSymStat *sym_stat;
|
|
|
|
CryptodevBackendAsymStat *asym_stat;
|
|
|
|
|
|
|
|
if (!object_dynamic_cast(obj, TYPE_CRYPTODEV_BACKEND)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
sym_stat = backend->sym_stat;
|
|
|
|
if (sym_stat) {
|
|
|
|
stats_list = cryptodev_backend_stats_add(SYM_ENCRYPT_OPS_STR,
|
|
|
|
&sym_stat->encrypt_ops, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(SYM_DECRYPT_OPS_STR,
|
|
|
|
&sym_stat->decrypt_ops, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(SYM_ENCRYPT_BYTES_STR,
|
|
|
|
&sym_stat->encrypt_bytes, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(SYM_DECRYPT_BYTES_STR,
|
|
|
|
&sym_stat->decrypt_bytes, stats_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
asym_stat = backend->asym_stat;
|
|
|
|
if (asym_stat) {
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_ENCRYPT_OPS_STR,
|
|
|
|
&asym_stat->encrypt_ops, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_DECRYPT_OPS_STR,
|
|
|
|
&asym_stat->decrypt_ops, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_SIGN_OPS_STR,
|
|
|
|
&asym_stat->sign_ops, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_VERIFY_OPS_STR,
|
|
|
|
&asym_stat->verify_ops, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_ENCRYPT_BYTES_STR,
|
|
|
|
&asym_stat->encrypt_bytes, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_DECRYPT_BYTES_STR,
|
|
|
|
&asym_stat->decrypt_bytes, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_SIGN_BYTES_STR,
|
|
|
|
&asym_stat->sign_bytes, stats_list);
|
|
|
|
stats_list = cryptodev_backend_stats_add(ASYM_VERIFY_BYTES_STR,
|
|
|
|
&asym_stat->verify_bytes, stats_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
entry = g_new0(StatsResult, 1);
|
|
|
|
entry->provider = STATS_PROVIDER_CRYPTODEV;
|
2023-05-03 13:54:37 +02:00
|
|
|
entry->qom_path = object_get_canonical_path(obj);
|
cryptodev: Support query-stats QMP command
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stats". This makes sense!)
Example:
~# virsh qemu-monitor-command vm '{"execute": "query-stats", \
"arguments": {"target": "cryptodev"} }' | jq
{
"return": [
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 7680
},
...
{
"name": "asym-decrypt-ops",
"value": 32
},
{
"name": "asym-encrypt-ops",
"value": 48
}
],
"qom-path": "/objects/cryptodev0" # support asym only
},
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 0
},
...
{
"name": "sym-decrypt-bytes",
"value": 5376
},
...
],
"qom-path": "/objects/cryptodev1" # support asym/sym
}
],
"id": "libvirt-422"
}
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-12-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:46 +01:00
|
|
|
entry->stats = stats_list;
|
|
|
|
QAPI_LIST_PREPEND(*stats_results, entry);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_stats_cb(StatsResultList **result,
|
|
|
|
StatsTarget target,
|
|
|
|
strList *names, strList *targets,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
switch (target) {
|
|
|
|
case STATS_TARGET_CRYPTODEV:
|
|
|
|
{
|
|
|
|
Object *objs = container_get(object_get_root(), "/objects");
|
|
|
|
StatsArgs stats_args;
|
|
|
|
stats_args.result.stats = result;
|
|
|
|
stats_args.names = names;
|
|
|
|
stats_args.errp = errp;
|
|
|
|
|
|
|
|
object_child_foreach(objs, cryptodev_backend_stats_query, &stats_args);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static StatsSchemaValueList *cryptodev_backend_schemas_add(const char *name,
|
|
|
|
StatsSchemaValueList *list)
|
|
|
|
{
|
|
|
|
StatsSchemaValueList *schema_entry = g_new0(StatsSchemaValueList, 1);
|
|
|
|
|
|
|
|
schema_entry->value = g_new0(StatsSchemaValue, 1);
|
|
|
|
schema_entry->value->type = STATS_TYPE_CUMULATIVE;
|
|
|
|
schema_entry->value->name = g_strdup(name);
|
|
|
|
schema_entry->next = list;
|
|
|
|
|
|
|
|
return schema_entry;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_schemas_cb(StatsSchemaList **result,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
StatsSchemaValueList *stats_list = NULL;
|
|
|
|
const char *sym_stats[] = { SYM_ENCRYPT_OPS_STR, SYM_DECRYPT_OPS_STR,
|
|
|
|
SYM_ENCRYPT_BYTES_STR, SYM_DECRYPT_BYTES_STR };
|
|
|
|
const char *asym_stats[] = { ASYM_ENCRYPT_OPS_STR, ASYM_DECRYPT_OPS_STR,
|
|
|
|
ASYM_SIGN_OPS_STR, ASYM_VERIFY_OPS_STR,
|
|
|
|
ASYM_ENCRYPT_BYTES_STR, ASYM_DECRYPT_BYTES_STR,
|
|
|
|
ASYM_SIGN_BYTES_STR, ASYM_VERIFY_BYTES_STR };
|
|
|
|
|
|
|
|
for (int i = 0; i < ARRAY_SIZE(sym_stats); i++) {
|
|
|
|
stats_list = cryptodev_backend_schemas_add(sym_stats[i], stats_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (int i = 0; i < ARRAY_SIZE(asym_stats); i++) {
|
|
|
|
stats_list = cryptodev_backend_schemas_add(asym_stats[i], stats_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
add_stats_schema(result, STATS_PROVIDER_CRYPTODEV, STATS_TARGET_CRYPTODEV,
|
|
|
|
stats_list);
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
static void
|
|
|
|
cryptodev_backend_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc);
|
|
|
|
|
|
|
|
ucc->complete = cryptodev_backend_complete;
|
2016-12-22 04:12:38 +01:00
|
|
|
ucc->can_be_deleted = cryptodev_backend_can_be_deleted;
|
2016-10-28 10:33:20 +02:00
|
|
|
|
|
|
|
QTAILQ_INIT(&crypto_clients);
|
2020-09-22 00:10:23 +02:00
|
|
|
object_class_property_add(oc, "queues", "uint32",
|
|
|
|
cryptodev_backend_get_queues,
|
|
|
|
cryptodev_backend_set_queues,
|
|
|
|
NULL, NULL);
|
2023-03-01 11:58:45 +01:00
|
|
|
object_class_property_add(oc, "throttle-bps", "uint64",
|
|
|
|
cryptodev_backend_get_bps,
|
|
|
|
cryptodev_backend_set_bps,
|
|
|
|
NULL, NULL);
|
|
|
|
object_class_property_add(oc, "throttle-ops", "uint64",
|
|
|
|
cryptodev_backend_get_ops,
|
|
|
|
cryptodev_backend_set_ops,
|
|
|
|
NULL, NULL);
|
cryptodev: Support query-stats QMP command
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stats". This makes sense!)
Example:
~# virsh qemu-monitor-command vm '{"execute": "query-stats", \
"arguments": {"target": "cryptodev"} }' | jq
{
"return": [
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 7680
},
...
{
"name": "asym-decrypt-ops",
"value": 32
},
{
"name": "asym-encrypt-ops",
"value": 48
}
],
"qom-path": "/objects/cryptodev0" # support asym only
},
{
"provider": "cryptodev",
"stats": [
{
"name": "asym-verify-bytes",
"value": 0
},
...
{
"name": "sym-decrypt-bytes",
"value": 5376
},
...
],
"qom-path": "/objects/cryptodev1" # support asym/sym
}
],
"id": "libvirt-422"
}
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Message-Id: <20230301105847.253084-12-pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2023-03-01 11:58:46 +01:00
|
|
|
|
|
|
|
add_stats_callbacks(STATS_PROVIDER_CRYPTODEV, cryptodev_backend_stats_cb,
|
|
|
|
cryptodev_backend_schemas_cb);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo cryptodev_backend_info = {
|
|
|
|
.name = TYPE_CRYPTODEV_BACKEND,
|
|
|
|
.parent = TYPE_OBJECT,
|
|
|
|
.instance_size = sizeof(CryptoDevBackend),
|
|
|
|
.instance_init = cryptodev_backend_instance_init,
|
|
|
|
.instance_finalize = cryptodev_backend_finalize,
|
|
|
|
.class_size = sizeof(CryptoDevBackendClass),
|
|
|
|
.class_init = cryptodev_backend_class_init,
|
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_USER_CREATABLE },
|
|
|
|
{ }
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
static void
|
|
|
|
cryptodev_backend_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&cryptodev_backend_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(cryptodev_backend_register_types);
|