2016-10-28 10:33:20 +02:00
|
|
|
/*
|
|
|
|
* QEMU Crypto Device Implementation
|
|
|
|
*
|
|
|
|
* Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Gonglei <arei.gonglei@huawei.com>
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
2020-10-14 15:37:22 +02:00
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
2016-10-28 10:33:20 +02:00
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "sysemu/cryptodev.h"
|
|
|
|
#include "qapi/error.h"
|
|
|
|
#include "qapi/visitor.h"
|
|
|
|
#include "qemu/config-file.h"
|
|
|
|
#include "qom/object_interfaces.h"
|
2016-10-28 10:33:29 +02:00
|
|
|
#include "hw/virtio/virtio-crypto.h"
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
|
|
|
|
static QTAILQ_HEAD(, CryptoDevBackendClient) crypto_clients;
|
|
|
|
|
|
|
|
|
|
|
|
CryptoDevBackendClient *
|
|
|
|
cryptodev_backend_new_client(const char *model,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
CryptoDevBackendClient *cc;
|
|
|
|
|
|
|
|
cc = g_malloc0(sizeof(CryptoDevBackendClient));
|
|
|
|
cc->model = g_strdup(model);
|
|
|
|
if (name) {
|
|
|
|
cc->name = g_strdup(name);
|
|
|
|
}
|
|
|
|
|
|
|
|
QTAILQ_INSERT_TAIL(&crypto_clients, cc, next);
|
|
|
|
|
|
|
|
return cc;
|
|
|
|
}
|
|
|
|
|
|
|
|
void cryptodev_backend_free_client(
|
|
|
|
CryptoDevBackendClient *cc)
|
|
|
|
{
|
|
|
|
QTAILQ_REMOVE(&crypto_clients, cc, next);
|
|
|
|
g_free(cc->name);
|
|
|
|
g_free(cc->model);
|
|
|
|
g_free(cc->info_str);
|
|
|
|
g_free(cc);
|
|
|
|
}
|
|
|
|
|
|
|
|
void cryptodev_backend_cleanup(
|
|
|
|
CryptoDevBackend *backend,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->cleanup) {
|
|
|
|
bc->cleanup(backend, errp);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:21 +02:00
|
|
|
int64_t cryptodev_backend_sym_create_session(
|
|
|
|
CryptoDevBackend *backend,
|
|
|
|
CryptoDevBackendSymSessionInfo *sess_info,
|
|
|
|
uint32_t queue_index, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->create_session) {
|
|
|
|
return bc->create_session(backend, sess_info, queue_index, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
int cryptodev_backend_sym_close_session(
|
|
|
|
CryptoDevBackend *backend,
|
|
|
|
uint64_t session_id,
|
|
|
|
uint32_t queue_index, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->close_session) {
|
|
|
|
return bc->close_session(backend, session_id, queue_index, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:29 +02:00
|
|
|
static int cryptodev_backend_sym_operation(
|
2016-10-28 10:33:21 +02:00
|
|
|
CryptoDevBackend *backend,
|
|
|
|
CryptoDevBackendSymOpInfo *op_info,
|
|
|
|
uint32_t queue_index, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackendClass *bc =
|
|
|
|
CRYPTODEV_BACKEND_GET_CLASS(backend);
|
|
|
|
|
|
|
|
if (bc->do_sym_op) {
|
|
|
|
return bc->do_sym_op(backend, op_info, queue_index, errp);
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:29 +02:00
|
|
|
return -VIRTIO_CRYPTO_ERR;
|
|
|
|
}
|
|
|
|
|
|
|
|
int cryptodev_backend_crypto_operation(
|
|
|
|
CryptoDevBackend *backend,
|
|
|
|
void *opaque,
|
|
|
|
uint32_t queue_index, Error **errp)
|
|
|
|
{
|
|
|
|
VirtIOCryptoReq *req = opaque;
|
|
|
|
|
|
|
|
if (req->flags == CRYPTODEV_BACKEND_ALG_SYM) {
|
|
|
|
CryptoDevBackendSymOpInfo *op_info;
|
|
|
|
op_info = req->u.sym_op_info;
|
|
|
|
|
|
|
|
return cryptodev_backend_sym_operation(backend,
|
|
|
|
op_info, queue_index, errp);
|
|
|
|
} else {
|
|
|
|
error_setg(errp, "Unsupported cryptodev alg type: %" PRIu32 "",
|
|
|
|
req->flags);
|
|
|
|
return -VIRTIO_CRYPTO_NOTSUPP;
|
|
|
|
}
|
|
|
|
|
|
|
|
return -VIRTIO_CRYPTO_ERR;
|
2016-10-28 10:33:21 +02:00
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
static void
|
|
|
|
cryptodev_backend_get_queues(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint32_t value = backend->conf.peers.queues;
|
|
|
|
|
|
|
|
visit_type_uint32(v, name, &value, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
cryptodev_backend_set_queues(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
|
|
|
uint32_t value;
|
|
|
|
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 18:06:02 +02:00
|
|
|
if (!visit_type_uint32(v, name, &value, errp)) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-07 18:06:01 +02:00
|
|
|
return;
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
if (!value) {
|
error: Avoid unnecessary error_propagate() after error_setg()
Replace
error_setg(&err, ...);
error_propagate(errp, err);
by
error_setg(errp, ...);
Related pattern:
if (...) {
error_setg(&err, ...);
goto out;
}
...
out:
error_propagate(errp, err);
return;
When all paths to label out are that way, replace by
if (...) {
error_setg(errp, ...);
return;
}
and delete the label along with the error_propagate().
When we have at most one other path that actually needs to propagate,
and maybe one at the end that where propagation is unnecessary, e.g.
foo(..., &err);
if (err) {
goto out;
}
...
bar(..., &err);
out:
error_propagate(errp, err);
return;
move the error_propagate() to where it's needed, like
if (...) {
foo(..., &err);
error_propagate(errp, err);
return;
}
...
bar(..., errp);
return;
and transform the error_setg() as above.
In some places, the transformation results in obviously unnecessary
error_propagate(). The next few commits will eliminate them.
Bonus: the elimination of gotos will make later patches in this series
easier to review.
Candidates for conversion tracked down with this Coccinelle script:
@@
identifier err, errp;
expression list args;
@@
- error_setg(&err, args);
+ error_setg(errp, args);
... when != err
error_propagate(errp, err);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-34-armbru@redhat.com>
2020-07-07 18:06:01 +02:00
|
|
|
error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu32 "'",
|
|
|
|
object_get_typename(obj), name, value);
|
|
|
|
return;
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
backend->conf.peers.queues = value;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
cryptodev_backend_complete(UserCreatable *uc, Error **errp)
|
|
|
|
{
|
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
|
|
|
|
CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
|
|
|
|
|
|
|
|
if (bc->init) {
|
2019-12-05 18:46:33 +01:00
|
|
|
bc->init(backend, errp);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-22 04:12:38 +01:00
|
|
|
void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
|
|
|
|
{
|
|
|
|
backend->is_used = used;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool cryptodev_backend_is_used(CryptoDevBackend *backend)
|
|
|
|
{
|
|
|
|
return backend->is_used;
|
|
|
|
}
|
|
|
|
|
2016-12-22 04:12:39 +01:00
|
|
|
void cryptodev_backend_set_ready(CryptoDevBackend *backend, bool ready)
|
|
|
|
{
|
|
|
|
backend->ready = ready;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool cryptodev_backend_is_ready(CryptoDevBackend *backend)
|
|
|
|
{
|
|
|
|
return backend->ready;
|
|
|
|
}
|
|
|
|
|
2016-12-22 04:12:38 +01:00
|
|
|
static bool
|
2017-08-30 00:03:37 +02:00
|
|
|
cryptodev_backend_can_be_deleted(UserCreatable *uc)
|
2016-12-22 04:12:38 +01:00
|
|
|
{
|
|
|
|
return !cryptodev_backend_is_used(CRYPTODEV_BACKEND(uc));
|
|
|
|
}
|
|
|
|
|
2016-10-28 10:33:20 +02:00
|
|
|
static void cryptodev_backend_instance_init(Object *obj)
|
|
|
|
{
|
|
|
|
/* Initialize devices' queues property to 1 */
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 18:05:54 +02:00
|
|
|
object_property_set_int(obj, "queues", 1, NULL);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void cryptodev_backend_finalize(Object *obj)
|
|
|
|
{
|
2016-12-22 04:12:38 +01:00
|
|
|
CryptoDevBackend *backend = CRYPTODEV_BACKEND(obj);
|
2016-10-28 10:33:20 +02:00
|
|
|
|
2016-12-22 04:12:38 +01:00
|
|
|
cryptodev_backend_cleanup(backend, NULL);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
cryptodev_backend_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc);
|
|
|
|
|
|
|
|
ucc->complete = cryptodev_backend_complete;
|
2016-12-22 04:12:38 +01:00
|
|
|
ucc->can_be_deleted = cryptodev_backend_can_be_deleted;
|
2016-10-28 10:33:20 +02:00
|
|
|
|
|
|
|
QTAILQ_INIT(&crypto_clients);
|
2020-09-22 00:10:23 +02:00
|
|
|
object_class_property_add(oc, "queues", "uint32",
|
|
|
|
cryptodev_backend_get_queues,
|
|
|
|
cryptodev_backend_set_queues,
|
|
|
|
NULL, NULL);
|
2016-10-28 10:33:20 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo cryptodev_backend_info = {
|
|
|
|
.name = TYPE_CRYPTODEV_BACKEND,
|
|
|
|
.parent = TYPE_OBJECT,
|
|
|
|
.instance_size = sizeof(CryptoDevBackend),
|
|
|
|
.instance_init = cryptodev_backend_instance_init,
|
|
|
|
.instance_finalize = cryptodev_backend_finalize,
|
|
|
|
.class_size = sizeof(CryptoDevBackendClass),
|
|
|
|
.class_init = cryptodev_backend_class_init,
|
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_USER_CREATABLE },
|
|
|
|
{ }
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
static void
|
|
|
|
cryptodev_backend_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&cryptodev_backend_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(cryptodev_backend_register_types);
|