2017-11-17 12:29:13 +01:00
|
|
|
QA output created by 198
|
|
|
|
|
== create base ==
|
2020-06-25 14:55:31 +02:00
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=16777216
|
2017-11-17 12:29:13 +01:00
|
|
|
|
|
|
|
|
== writing whole image base ==
|
|
|
|
|
wrote 16777216/16777216 bytes at offset 0
|
|
|
|
|
16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
|
== create overlay ==
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 22:39:52 +02:00
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=16777216 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
2017-11-17 12:29:13 +01:00
|
|
|
|
|
|
|
|
== writing whole image layer ==
|
|
|
|
|
wrote 16777216/16777216 bytes at offset 0
|
|
|
|
|
16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
|
|
|
|
|
|
== verify pattern base ==
|
|
|
|
|
read 16777216/16777216 bytes at offset 0
|
|
|
|
|
16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
|
|
|
|
|
|
== verify pattern layer ==
|
|
|
|
|
read 16777216/16777216 bytes at offset 0
|
|
|
|
|
16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
|
|
|
|
|
|
== committing layer into base ==
|
|
|
|
|
Image committed.
|
|
|
|
|
|
|
|
|
|
== verify pattern base ==
|
|
|
|
|
read 16777216/16777216 bytes at offset 0
|
|
|
|
|
16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
|
|
|
|
|
|
== verify pattern layer ==
|
|
|
|
|
read 16777216/16777216 bytes at offset 0
|
|
|
|
|
16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
|
|
|
|
|
|
|
|
== checking image base ==
|
2019-11-07 17:37:06 +01:00
|
|
|
image: json:{ /* filtered */ }
|
2017-11-17 12:29:13 +01:00
|
|
|
file format: IMGFMT
|
2019-04-17 19:11:01 +02:00
|
|
|
virtual size: 16 MiB (16777216 bytes)
|
2017-11-17 12:29:13 +01:00
|
|
|
Format specific information:
|
qcow2: introduce compression type feature
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus compression type
defines the only compression algorithm used for the image, and thus,
for all image clusters.
The goal of the feature is to add support of other compression methods
to qcow2. For example, ZSTD which is more effective on compression than ZLIB.
The default compression is ZLIB. Images created with ZLIB compression type
are backward compatible with older qemu versions.
Adding of the compression type breaks a number of tests because now the
compression type is reported on image creation and there are some changes
in the qcow2 header in size and offsets.
The tests are fixed in the following ways:
* filter out compression_type for many tests
* fix header size, feature table size and backing file offset
affected tests: 031, 036, 061, 080
header_size +=8: 1 byte compression type
7 bytes padding
feature_table += 48: incompatible feature compression type
backing_file_offset += 56 (8 + 48 -> header_change + feature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 082, 085, 144, 182, 185, 198, 206,
242, 255, 274, 280
Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
QAPI part:
Acked-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200507082521.29210-2-dplotnikov@virtuozzo.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2020-05-07 10:25:18 +02:00
|
|
|
compression type: zlib
|
2017-11-17 12:29:13 +01:00
|
|
|
encrypt:
|
|
|
|
|
ivgen alg: plain64
|
|
|
|
|
hash alg: sha256
|
|
|
|
|
cipher alg: aes-256
|
|
|
|
|
uuid: 00000000-0000-0000-0000-000000000000
|
|
|
|
|
format: luks
|
|
|
|
|
cipher mode: xts
|
|
|
|
|
slots:
|
|
|
|
|
[0]:
|
|
|
|
|
active: true
|
|
|
|
|
iters: 1024
|
|
|
|
|
key offset: 4096
|
|
|
|
|
stripes: 4000
|
|
|
|
|
[1]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 262144
|
|
|
|
|
[2]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 520192
|
|
|
|
|
[3]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 778240
|
|
|
|
|
[4]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1036288
|
|
|
|
|
[5]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1294336
|
|
|
|
|
[6]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1552384
|
|
|
|
|
[7]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1810432
|
|
|
|
|
payload offset: 2068480
|
|
|
|
|
master key iters: 1024
|
|
|
|
|
|
|
|
|
|
== checking image layer ==
|
2019-11-07 17:37:06 +01:00
|
|
|
image: json:{ /* filtered */ }
|
2017-11-17 12:29:13 +01:00
|
|
|
file format: IMGFMT
|
2019-04-17 19:11:01 +02:00
|
|
|
virtual size: 16 MiB (16777216 bytes)
|
2017-11-17 12:29:13 +01:00
|
|
|
backing file: TEST_DIR/t.IMGFMT.base
|
iotests: Specify explicit backing format where sensible
There are many existing qcow2 images that specify a backing file but
no format. This has been the source of CVEs in the past, but has
become more prominent of a problem now that libvirt has switched to
-blockdev. With older -drive, at least the probing was always done by
qemu (so the only risk of a changed format between successive boots of
a guest was if qemu was upgraded and probed differently). But with
newer -blockdev, libvirt must specify a format; if libvirt guesses raw
where the image was formatted, this results in data corruption visible
to the guest; conversely, if libvirt guesses qcow2 where qemu was
using raw, this can result in potential security holes, so modern
libvirt instead refuses to use images without explicit backing format.
The change in libvirt to reject images without explicit backing format
has pointed out that a number of tools have been far too reliant on
probing in the past. It's time to set a better example in our own
iotests of properly setting this parameter.
iotest calls to create, rebase, and convert are all impacted to some
degree. It's a bit annoying that we are inconsistent on command line
- while all of those accept -o backing_file=...,backing_fmt=..., the
shortcuts are different: create and rebase have -b and -F, while
convert has -B but no -F. (amend has no shortcuts, but the previous
patch just deprecated the use of amend to change backing chains).
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200706203954.341758-9-eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-07-06 22:39:52 +02:00
|
|
|
backing file format: IMGFMT
|
2017-11-17 12:29:13 +01:00
|
|
|
Format specific information:
|
qcow2: introduce compression type feature
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus compression type
defines the only compression algorithm used for the image, and thus,
for all image clusters.
The goal of the feature is to add support of other compression methods
to qcow2. For example, ZSTD which is more effective on compression than ZLIB.
The default compression is ZLIB. Images created with ZLIB compression type
are backward compatible with older qemu versions.
Adding of the compression type breaks a number of tests because now the
compression type is reported on image creation and there are some changes
in the qcow2 header in size and offsets.
The tests are fixed in the following ways:
* filter out compression_type for many tests
* fix header size, feature table size and backing file offset
affected tests: 031, 036, 061, 080
header_size +=8: 1 byte compression type
7 bytes padding
feature_table += 48: incompatible feature compression type
backing_file_offset += 56 (8 + 48 -> header_change + feature_table_change)
* add "compression type" for test output matching when it isn't filtered
affected tests: 049, 060, 061, 065, 082, 085, 144, 182, 185, 198, 206,
242, 255, 274, 280
Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
QAPI part:
Acked-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200507082521.29210-2-dplotnikov@virtuozzo.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2020-05-07 10:25:18 +02:00
|
|
|
compression type: zlib
|
2017-11-17 12:29:13 +01:00
|
|
|
encrypt:
|
|
|
|
|
ivgen alg: plain64
|
|
|
|
|
hash alg: sha256
|
|
|
|
|
cipher alg: aes-256
|
|
|
|
|
uuid: 00000000-0000-0000-0000-000000000000
|
|
|
|
|
format: luks
|
|
|
|
|
cipher mode: xts
|
|
|
|
|
slots:
|
|
|
|
|
[0]:
|
|
|
|
|
active: true
|
|
|
|
|
iters: 1024
|
|
|
|
|
key offset: 4096
|
|
|
|
|
stripes: 4000
|
|
|
|
|
[1]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 262144
|
|
|
|
|
[2]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 520192
|
|
|
|
|
[3]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 778240
|
|
|
|
|
[4]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1036288
|
|
|
|
|
[5]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1294336
|
|
|
|
|
[6]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1552384
|
|
|
|
|
[7]:
|
|
|
|
|
active: false
|
|
|
|
|
key offset: 1810432
|
|
|
|
|
payload offset: 2068480
|
|
|
|
|
master key iters: 1024
|
|
|
|
|
*** done
|