authz: add QAuthZList object type for an access control list
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module.
To create an instance of this object via the QMP monitor, the syntax
used would be:
{
"execute": "object-add",
"arguments": {
"qom-type": "authz-list",
"id": "authz0",
"props": {
"rules": [
{ "match": "fred", "policy": "allow", "format": "exact" },
{ "match": "bob", "policy": "allow", "format": "exact" },
{ "match": "danb", "policy": "deny", "format": "glob" },
{ "match": "dan*", "policy": "allow", "format": "exact" },
],
"policy": "deny"
}
}
}
This sets up an authorization rule that allows 'fred', 'bob' and anyone
whose name starts with 'dan', except for 'danb'. Everyone unmatched is
denied.
It is not currently possible to create this via -object, since there is
no syntax supported to specify non-scalar properties for objects. This
is likely to be addressed by later support for using JSON with -object,
or an equivalent approach.
In any case the future "authz-listfile" object can be used from the
CLI and is likely a better choice, as it allows the ACL to be refreshed
automatically on change.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-10-21 15:54:59 +02:00
|
|
|
/*
|
|
|
|
* QEMU access control list authorization driver
|
|
|
|
*
|
|
|
|
* Copyright (c) 2018 Red Hat, Inc.
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "authz/list.h"
|
2019-03-15 15:51:17 +01:00
|
|
|
#include "trace.h"
|
authz: add QAuthZList object type for an access control list
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module.
To create an instance of this object via the QMP monitor, the syntax
used would be:
{
"execute": "object-add",
"arguments": {
"qom-type": "authz-list",
"id": "authz0",
"props": {
"rules": [
{ "match": "fred", "policy": "allow", "format": "exact" },
{ "match": "bob", "policy": "allow", "format": "exact" },
{ "match": "danb", "policy": "deny", "format": "glob" },
{ "match": "dan*", "policy": "allow", "format": "exact" },
],
"policy": "deny"
}
}
}
This sets up an authorization rule that allows 'fred', 'bob' and anyone
whose name starts with 'dan', except for 'danb'. Everyone unmatched is
denied.
It is not currently possible to create this via -object, since there is
no syntax supported to specify non-scalar properties for objects. This
is likely to be addressed by later support for using JSON with -object,
or an equivalent approach.
In any case the future "authz-listfile" object can be used from the
CLI and is likely a better choice, as it allows the ACL to be refreshed
automatically on change.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-10-21 15:54:59 +02:00
|
|
|
#include "qom/object_interfaces.h"
|
|
|
|
#include "qapi/qapi-visit-authz.h"
|
2019-05-23 16:35:07 +02:00
|
|
|
#include "qemu/module.h"
|
authz: add QAuthZList object type for an access control list
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module.
To create an instance of this object via the QMP monitor, the syntax
used would be:
{
"execute": "object-add",
"arguments": {
"qom-type": "authz-list",
"id": "authz0",
"props": {
"rules": [
{ "match": "fred", "policy": "allow", "format": "exact" },
{ "match": "bob", "policy": "allow", "format": "exact" },
{ "match": "danb", "policy": "deny", "format": "glob" },
{ "match": "dan*", "policy": "allow", "format": "exact" },
],
"policy": "deny"
}
}
}
This sets up an authorization rule that allows 'fred', 'bob' and anyone
whose name starts with 'dan', except for 'danb'. Everyone unmatched is
denied.
It is not currently possible to create this via -object, since there is
no syntax supported to specify non-scalar properties for objects. This
is likely to be addressed by later support for using JSON with -object,
or an equivalent approach.
In any case the future "authz-listfile" object can be used from the
CLI and is likely a better choice, as it allows the ACL to be refreshed
automatically on change.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-10-21 15:54:59 +02:00
|
|
|
|
|
|
|
static bool qauthz_list_is_allowed(QAuthZ *authz,
|
|
|
|
const char *identity,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
QAuthZList *lauthz = QAUTHZ_LIST(authz);
|
|
|
|
QAuthZListRuleList *rules = lauthz->rules;
|
|
|
|
|
|
|
|
while (rules) {
|
|
|
|
QAuthZListRule *rule = rules->value;
|
|
|
|
QAuthZListFormat format = rule->has_format ? rule->format :
|
|
|
|
QAUTHZ_LIST_FORMAT_EXACT;
|
|
|
|
|
|
|
|
trace_qauthz_list_check_rule(authz, rule->match, identity,
|
|
|
|
format, rule->policy);
|
|
|
|
switch (format) {
|
|
|
|
case QAUTHZ_LIST_FORMAT_EXACT:
|
|
|
|
if (g_str_equal(rule->match, identity)) {
|
|
|
|
return rule->policy == QAUTHZ_LIST_POLICY_ALLOW;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case QAUTHZ_LIST_FORMAT_GLOB:
|
|
|
|
if (g_pattern_match_simple(rule->match, identity)) {
|
|
|
|
return rule->policy == QAUTHZ_LIST_POLICY_ALLOW;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
g_warn_if_reached();
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
rules = rules->next;
|
|
|
|
}
|
|
|
|
|
|
|
|
trace_qauthz_list_default_policy(authz, identity, lauthz->policy);
|
|
|
|
return lauthz->policy == QAUTHZ_LIST_POLICY_ALLOW;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
qauthz_list_prop_set_policy(Object *obj,
|
|
|
|
int value,
|
|
|
|
Error **errp G_GNUC_UNUSED)
|
|
|
|
{
|
|
|
|
QAuthZList *lauthz = QAUTHZ_LIST(obj);
|
|
|
|
|
|
|
|
lauthz->policy = value;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
qauthz_list_prop_get_policy(Object *obj,
|
|
|
|
Error **errp G_GNUC_UNUSED)
|
|
|
|
{
|
|
|
|
QAuthZList *lauthz = QAUTHZ_LIST(obj);
|
|
|
|
|
|
|
|
return lauthz->policy;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
qauthz_list_prop_get_rules(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
QAuthZList *lauthz = QAUTHZ_LIST(obj);
|
|
|
|
|
|
|
|
visit_type_QAuthZListRuleList(v, name, &lauthz->rules, errp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
qauthz_list_prop_set_rules(Object *obj, Visitor *v, const char *name,
|
|
|
|
void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
QAuthZList *lauthz = QAUTHZ_LIST(obj);
|
|
|
|
QAuthZListRuleList *oldrules;
|
|
|
|
|
|
|
|
oldrules = lauthz->rules;
|
|
|
|
visit_type_QAuthZListRuleList(v, name, &lauthz->rules, errp);
|
|
|
|
|
|
|
|
qapi_free_QAuthZListRuleList(oldrules);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
qauthz_list_finalize(Object *obj)
|
|
|
|
{
|
|
|
|
QAuthZList *lauthz = QAUTHZ_LIST(obj);
|
|
|
|
|
|
|
|
qapi_free_QAuthZListRuleList(lauthz->rules);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
qauthz_list_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
QAuthZClass *authz = QAUTHZ_CLASS(oc);
|
|
|
|
|
|
|
|
object_class_property_add_enum(oc, "policy",
|
|
|
|
"QAuthZListPolicy",
|
|
|
|
&QAuthZListPolicy_lookup,
|
|
|
|
qauthz_list_prop_get_policy,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
qauthz_list_prop_set_policy);
|
authz: add QAuthZList object type for an access control list
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module.
To create an instance of this object via the QMP monitor, the syntax
used would be:
{
"execute": "object-add",
"arguments": {
"qom-type": "authz-list",
"id": "authz0",
"props": {
"rules": [
{ "match": "fred", "policy": "allow", "format": "exact" },
{ "match": "bob", "policy": "allow", "format": "exact" },
{ "match": "danb", "policy": "deny", "format": "glob" },
{ "match": "dan*", "policy": "allow", "format": "exact" },
],
"policy": "deny"
}
}
}
This sets up an authorization rule that allows 'fred', 'bob' and anyone
whose name starts with 'dan', except for 'danb'. Everyone unmatched is
denied.
It is not currently possible to create this via -object, since there is
no syntax supported to specify non-scalar properties for objects. This
is likely to be addressed by later support for using JSON with -object,
or an equivalent approach.
In any case the future "authz-listfile" object can be used from the
CLI and is likely a better choice, as it allows the ACL to be refreshed
automatically on change.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-10-21 15:54:59 +02:00
|
|
|
|
|
|
|
object_class_property_add(oc, "rules", "QAuthZListRule",
|
|
|
|
qauthz_list_prop_get_rules,
|
|
|
|
qauthz_list_prop_set_rules,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
NULL, NULL);
|
authz: add QAuthZList object type for an access control list
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module.
To create an instance of this object via the QMP monitor, the syntax
used would be:
{
"execute": "object-add",
"arguments": {
"qom-type": "authz-list",
"id": "authz0",
"props": {
"rules": [
{ "match": "fred", "policy": "allow", "format": "exact" },
{ "match": "bob", "policy": "allow", "format": "exact" },
{ "match": "danb", "policy": "deny", "format": "glob" },
{ "match": "dan*", "policy": "allow", "format": "exact" },
],
"policy": "deny"
}
}
}
This sets up an authorization rule that allows 'fred', 'bob' and anyone
whose name starts with 'dan', except for 'danb'. Everyone unmatched is
denied.
It is not currently possible to create this via -object, since there is
no syntax supported to specify non-scalar properties for objects. This
is likely to be addressed by later support for using JSON with -object,
or an equivalent approach.
In any case the future "authz-listfile" object can be used from the
CLI and is likely a better choice, as it allows the ACL to be refreshed
automatically on change.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-10-21 15:54:59 +02:00
|
|
|
|
|
|
|
authz->is_allowed = qauthz_list_is_allowed;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
QAuthZList *qauthz_list_new(const char *id,
|
|
|
|
QAuthZListPolicy policy,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
return QAUTHZ_LIST(
|
|
|
|
object_new_with_props(TYPE_QAUTHZ_LIST,
|
|
|
|
object_get_objects_root(),
|
|
|
|
id, errp,
|
|
|
|
"policy", QAuthZListPolicy_str(policy),
|
|
|
|
NULL));
|
|
|
|
}
|
|
|
|
|
|
|
|
ssize_t qauthz_list_append_rule(QAuthZList *auth,
|
|
|
|
const char *match,
|
|
|
|
QAuthZListPolicy policy,
|
|
|
|
QAuthZListFormat format,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
QAuthZListRule *rule;
|
|
|
|
QAuthZListRuleList *rules, *tmp;
|
|
|
|
size_t i = 0;
|
|
|
|
|
|
|
|
rule = g_new0(QAuthZListRule, 1);
|
|
|
|
rule->policy = policy;
|
|
|
|
rule->match = g_strdup(match);
|
|
|
|
rule->format = format;
|
|
|
|
rule->has_format = true;
|
|
|
|
|
|
|
|
tmp = g_new0(QAuthZListRuleList, 1);
|
|
|
|
tmp->value = rule;
|
|
|
|
|
|
|
|
rules = auth->rules;
|
|
|
|
if (rules) {
|
|
|
|
while (rules->next) {
|
|
|
|
i++;
|
|
|
|
rules = rules->next;
|
|
|
|
}
|
|
|
|
rules->next = tmp;
|
|
|
|
return i + 1;
|
|
|
|
} else {
|
|
|
|
auth->rules = tmp;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
ssize_t qauthz_list_insert_rule(QAuthZList *auth,
|
|
|
|
const char *match,
|
|
|
|
QAuthZListPolicy policy,
|
|
|
|
QAuthZListFormat format,
|
|
|
|
size_t index,
|
|
|
|
Error **errp)
|
|
|
|
{
|
|
|
|
QAuthZListRule *rule;
|
|
|
|
QAuthZListRuleList *rules, *tmp;
|
|
|
|
size_t i = 0;
|
|
|
|
|
|
|
|
rule = g_new0(QAuthZListRule, 1);
|
|
|
|
rule->policy = policy;
|
|
|
|
rule->match = g_strdup(match);
|
|
|
|
rule->format = format;
|
|
|
|
rule->has_format = true;
|
|
|
|
|
|
|
|
tmp = g_new0(QAuthZListRuleList, 1);
|
|
|
|
tmp->value = rule;
|
|
|
|
|
|
|
|
rules = auth->rules;
|
|
|
|
if (rules && index > 0) {
|
|
|
|
while (rules->next && i < (index - 1)) {
|
|
|
|
i++;
|
|
|
|
rules = rules->next;
|
|
|
|
}
|
|
|
|
tmp->next = rules->next;
|
|
|
|
rules->next = tmp;
|
|
|
|
return i + 1;
|
|
|
|
} else {
|
|
|
|
tmp->next = auth->rules;
|
|
|
|
auth->rules = tmp;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
ssize_t qauthz_list_delete_rule(QAuthZList *auth, const char *match)
|
|
|
|
{
|
|
|
|
QAuthZListRule *rule;
|
|
|
|
QAuthZListRuleList *rules, *prev;
|
|
|
|
size_t i = 0;
|
|
|
|
|
|
|
|
prev = NULL;
|
|
|
|
rules = auth->rules;
|
|
|
|
while (rules) {
|
|
|
|
rule = rules->value;
|
|
|
|
if (g_str_equal(rule->match, match)) {
|
|
|
|
if (prev) {
|
|
|
|
prev->next = rules->next;
|
|
|
|
} else {
|
|
|
|
auth->rules = rules->next;
|
|
|
|
}
|
|
|
|
rules->next = NULL;
|
|
|
|
qapi_free_QAuthZListRuleList(rules);
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
prev = rules;
|
|
|
|
rules = rules->next;
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static const TypeInfo qauthz_list_info = {
|
|
|
|
.parent = TYPE_QAUTHZ,
|
|
|
|
.name = TYPE_QAUTHZ_LIST,
|
|
|
|
.instance_size = sizeof(QAuthZList),
|
|
|
|
.instance_finalize = qauthz_list_finalize,
|
|
|
|
.class_init = qauthz_list_class_init,
|
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_USER_CREATABLE },
|
|
|
|
{ }
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
qauthz_list_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&qauthz_list_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
type_init(qauthz_list_register_types);
|