2015-02-06 04:55:47 +01:00
|
|
|
/*
|
|
|
|
* QEMU PowerPC pSeries Logical Partition (aka sPAPR) hardware System Emulator
|
|
|
|
*
|
|
|
|
* RTAS Real Time Clock
|
|
|
|
*
|
|
|
|
* Copyright (c) 2010-2011 David Gibson, IBM Corporation.
|
|
|
|
* Copyright 2014 David Gibson, Red Hat.
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
2018-02-01 12:18:31 +01:00
|
|
|
|
2016-01-26 19:16:58 +01:00
|
|
|
#include "qemu/osdep.h"
|
2015-06-12 15:01:30 +02:00
|
|
|
#include "qemu/timer.h"
|
2015-02-06 04:55:50 +01:00
|
|
|
#include "sysemu/sysemu.h"
|
2021-11-29 21:55:05 +01:00
|
|
|
#include "sysemu/rtc.h"
|
2015-02-06 04:55:47 +01:00
|
|
|
#include "hw/ppc/spapr.h"
|
2019-08-12 07:23:45 +02:00
|
|
|
#include "migration/vmstate.h"
|
2018-02-01 12:18:31 +01:00
|
|
|
#include "qapi/error.h"
|
2019-06-19 22:10:46 +02:00
|
|
|
#include "qapi/qapi-events-misc-target.h"
|
2016-03-20 18:16:19 +01:00
|
|
|
#include "qemu/cutils.h"
|
2019-05-23 16:35:07 +02:00
|
|
|
#include "qemu/module.h"
|
2015-02-06 04:55:47 +01:00
|
|
|
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
void spapr_rtc_read(SpaprRtcState *rtc, struct tm *tm, uint32_t *ns)
|
2015-02-06 04:55:49 +01:00
|
|
|
{
|
2015-02-06 04:55:50 +01:00
|
|
|
int64_t host_ns = qemu_clock_get_ns(rtc_clock);
|
2015-02-06 04:55:52 +01:00
|
|
|
int64_t guest_ns;
|
2015-02-06 04:55:50 +01:00
|
|
|
time_t guest_s;
|
|
|
|
|
2015-02-06 04:55:51 +01:00
|
|
|
assert(rtc);
|
|
|
|
|
2015-02-06 04:55:52 +01:00
|
|
|
guest_ns = host_ns + rtc->ns_offset;
|
2015-07-08 16:10:09 +02:00
|
|
|
guest_s = guest_ns / NANOSECONDS_PER_SECOND;
|
2015-02-06 04:55:50 +01:00
|
|
|
|
|
|
|
if (tm) {
|
|
|
|
gmtime_r(&guest_s, tm);
|
|
|
|
}
|
2015-02-06 04:55:49 +01:00
|
|
|
if (ns) {
|
2015-02-06 04:55:52 +01:00
|
|
|
*ns = guest_ns;
|
2015-02-06 04:55:49 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
int spapr_rtc_import_offset(SpaprRtcState *rtc, int64_t legacy_offset)
|
2015-02-06 04:55:52 +01:00
|
|
|
{
|
2017-03-07 10:23:40 +01:00
|
|
|
if (!rtc) {
|
2015-02-06 04:55:52 +01:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2015-07-08 16:10:09 +02:00
|
|
|
rtc->ns_offset = legacy_offset * NANOSECONDS_PER_SECOND;
|
2015-02-06 04:55:52 +01:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
static void rtas_get_time_of_day(PowerPCCPU *cpu, SpaprMachineState *spapr,
|
2015-02-06 04:55:47 +01:00
|
|
|
uint32_t token, uint32_t nargs,
|
|
|
|
target_ulong args,
|
|
|
|
uint32_t nret, target_ulong rets)
|
|
|
|
{
|
|
|
|
struct tm tm;
|
2015-02-06 04:55:49 +01:00
|
|
|
uint32_t ns;
|
2015-02-06 04:55:47 +01:00
|
|
|
|
2015-02-06 04:55:48 +01:00
|
|
|
if ((nargs != 0) || (nret != 8)) {
|
2015-02-06 04:55:47 +01:00
|
|
|
rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-03-07 10:23:40 +01:00
|
|
|
spapr_rtc_read(&spapr->rtc, &tm, &ns);
|
2015-02-06 04:55:47 +01:00
|
|
|
|
|
|
|
rtas_st(rets, 0, RTAS_OUT_SUCCESS);
|
|
|
|
rtas_st(rets, 1, tm.tm_year + 1900);
|
|
|
|
rtas_st(rets, 2, tm.tm_mon + 1);
|
|
|
|
rtas_st(rets, 3, tm.tm_mday);
|
|
|
|
rtas_st(rets, 4, tm.tm_hour);
|
|
|
|
rtas_st(rets, 5, tm.tm_min);
|
|
|
|
rtas_st(rets, 6, tm.tm_sec);
|
2015-02-06 04:55:49 +01:00
|
|
|
rtas_st(rets, 7, ns);
|
2015-02-06 04:55:47 +01:00
|
|
|
}
|
|
|
|
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
static void rtas_set_time_of_day(PowerPCCPU *cpu, SpaprMachineState *spapr,
|
2015-02-06 04:55:47 +01:00
|
|
|
uint32_t token, uint32_t nargs,
|
|
|
|
target_ulong args,
|
|
|
|
uint32_t nret, target_ulong rets)
|
|
|
|
{
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
SpaprRtcState *rtc = &spapr->rtc;
|
2015-02-06 04:55:47 +01:00
|
|
|
struct tm tm;
|
2015-02-06 04:55:50 +01:00
|
|
|
time_t new_s;
|
|
|
|
int64_t host_ns;
|
2015-02-06 04:55:47 +01:00
|
|
|
|
2015-02-06 04:55:48 +01:00
|
|
|
if ((nargs != 7) || (nret != 1)) {
|
|
|
|
rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-02-06 04:55:47 +01:00
|
|
|
tm.tm_year = rtas_ld(args, 0) - 1900;
|
|
|
|
tm.tm_mon = rtas_ld(args, 1) - 1;
|
|
|
|
tm.tm_mday = rtas_ld(args, 2);
|
|
|
|
tm.tm_hour = rtas_ld(args, 3);
|
|
|
|
tm.tm_min = rtas_ld(args, 4);
|
|
|
|
tm.tm_sec = rtas_ld(args, 5);
|
|
|
|
|
2015-02-06 04:55:50 +01:00
|
|
|
new_s = mktimegm(&tm);
|
|
|
|
if (new_s == -1) {
|
|
|
|
rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Generate a monitor event for the change */
|
2018-08-15 15:37:37 +02:00
|
|
|
qapi_event_send_rtc_change(qemu_timedate_diff(&tm));
|
2015-02-06 04:55:50 +01:00
|
|
|
|
|
|
|
host_ns = qemu_clock_get_ns(rtc_clock);
|
|
|
|
|
2015-07-08 16:10:09 +02:00
|
|
|
rtc->ns_offset = (new_s * NANOSECONDS_PER_SECOND) - host_ns;
|
2015-02-06 04:55:47 +01:00
|
|
|
|
|
|
|
rtas_st(rets, 0, RTAS_OUT_SUCCESS);
|
|
|
|
}
|
|
|
|
|
2015-02-06 04:55:53 +01:00
|
|
|
static void spapr_rtc_qom_date(Object *obj, struct tm *current_tm, Error **errp)
|
|
|
|
{
|
2017-03-07 10:23:40 +01:00
|
|
|
spapr_rtc_read(SPAPR_RTC(obj), current_tm, NULL);
|
2015-02-06 04:55:53 +01:00
|
|
|
}
|
|
|
|
|
2015-02-06 04:55:51 +01:00
|
|
|
static void spapr_rtc_realize(DeviceState *dev, Error **errp)
|
2015-02-06 04:55:47 +01:00
|
|
|
{
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
SpaprRtcState *rtc = SPAPR_RTC(dev);
|
2015-02-06 04:55:50 +01:00
|
|
|
struct tm tm;
|
|
|
|
time_t host_s;
|
|
|
|
int64_t rtc_ns;
|
|
|
|
|
|
|
|
/* Initialize the RTAS RTC from host time */
|
|
|
|
|
|
|
|
qemu_get_timedate(&tm, 0);
|
|
|
|
host_s = mktimegm(&tm);
|
|
|
|
rtc_ns = qemu_clock_get_ns(rtc_clock);
|
2015-07-08 16:10:09 +02:00
|
|
|
rtc->ns_offset = host_s * NANOSECONDS_PER_SECOND - rtc_ns;
|
2015-02-06 04:55:53 +01:00
|
|
|
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
object_property_add_tm(OBJECT(rtc), "date", spapr_rtc_qom_date);
|
2015-02-06 04:55:51 +01:00
|
|
|
}
|
|
|
|
|
2015-02-06 04:55:52 +01:00
|
|
|
static const VMStateDescription vmstate_spapr_rtc = {
|
|
|
|
.name = "spapr/rtc",
|
|
|
|
.version_id = 1,
|
|
|
|
.minimum_version_id = 1,
|
|
|
|
.fields = (VMStateField[]) {
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
VMSTATE_INT64(ns_offset, SpaprRtcState),
|
2015-02-06 04:55:52 +01:00
|
|
|
VMSTATE_END_OF_LIST()
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2015-02-06 04:55:51 +01:00
|
|
|
static void spapr_rtc_class_init(ObjectClass *oc, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(oc);
|
|
|
|
|
|
|
|
dc->realize = spapr_rtc_realize;
|
2015-02-06 04:55:52 +01:00
|
|
|
dc->vmsd = &vmstate_spapr_rtc;
|
2017-08-17 07:15:10 +02:00
|
|
|
/* Reason: This is an internal device only for handling the hypercalls */
|
|
|
|
dc->user_creatable = false;
|
2015-02-06 04:55:50 +01:00
|
|
|
|
2015-02-06 04:55:47 +01:00
|
|
|
spapr_rtas_register(RTAS_GET_TIME_OF_DAY, "get-time-of-day",
|
|
|
|
rtas_get_time_of_day);
|
|
|
|
spapr_rtas_register(RTAS_SET_TIME_OF_DAY, "set-time-of-day",
|
|
|
|
rtas_set_time_of_day);
|
|
|
|
}
|
2015-02-06 04:55:51 +01:00
|
|
|
|
|
|
|
static const TypeInfo spapr_rtc_info = {
|
|
|
|
.name = TYPE_SPAPR_RTC,
|
2017-03-07 10:23:40 +01:00
|
|
|
.parent = TYPE_DEVICE,
|
spapr: Use CamelCase properly
The qemu coding standard is to use CamelCase for type and structure names,
and the pseries code follows that... sort of. There are quite a lot of
places where we bend the rules in order to preserve the capitalization of
internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR".
That was a bad idea - it frequently leads to names ending up with hard to
read clusters of capital letters, and means they don't catch the eye as
type identifiers, which is kind of the point of the CamelCase convention in
the first place.
In short, keeping type identifiers look like CamelCase is more important
than preserving standard capitalization of internal "words". So, this
patch renames a heap of spapr internal type names to a more standard
CamelCase.
In addition to case changes, we also make some other identifier renames:
VIOsPAPR* -> SpaprVio*
The reverse word ordering was only ever used to mitigate the capital
cluster, so revert to the natural ordering.
VIOsPAPRVTYDevice -> SpaprVioVty
VIOsPAPRVLANDevice -> SpaprVioVlan
Brevity, since the "Device" didn't add useful information
sPAPRDRConnector -> SpaprDrc
sPAPRDRConnectorClass -> SpaprDrcClass
Brevity, and makes it clearer this is the same thing as a "DRC"
mentioned in many other places in the code
This is 100% a mechanical search-and-replace patch. It will, however,
conflict with essentially any and all outstanding patches touching the
spapr code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2019-03-06 05:35:37 +01:00
|
|
|
.instance_size = sizeof(SpaprRtcState),
|
2015-02-06 04:55:51 +01:00
|
|
|
.class_init = spapr_rtc_class_init,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void spapr_rtc_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&spapr_rtc_info);
|
|
|
|
}
|
|
|
|
type_init(spapr_rtc_register_types)
|