2012-09-28 17:22:47 +02:00
|
|
|
/*
|
|
|
|
* QEMU System Emulator block driver
|
|
|
|
*
|
|
|
|
* Copyright (c) 2011 IBM Corp.
|
|
|
|
* Copyright (c) 2012 Red Hat, Inc.
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
2016-01-29 18:50:05 +01:00
|
|
|
#include "qemu/osdep.h"
|
2012-12-17 18:19:44 +01:00
|
|
|
#include "block/block.h"
|
2016-10-27 18:07:00 +02:00
|
|
|
#include "block/blockjob_int.h"
|
2012-12-17 18:19:44 +01:00
|
|
|
#include "block/block_int.h"
|
2018-03-10 09:27:30 +01:00
|
|
|
#include "block/trace.h"
|
2015-10-19 17:53:22 +02:00
|
|
|
#include "sysemu/block-backend.h"
|
2018-02-01 12:18:31 +01:00
|
|
|
#include "qapi/error.h"
|
2018-02-11 10:36:01 +01:00
|
|
|
#include "qapi/qapi-events-block-core.h"
|
2015-03-17 17:22:46 +01:00
|
|
|
#include "qapi/qmp/qerror.h"
|
2015-09-01 15:48:02 +02:00
|
|
|
#include "qemu/coroutine.h"
|
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
2019-08-12 07:23:50 +02:00
|
|
|
#include "qemu/main-loop.h"
|
2012-12-17 18:20:00 +01:00
|
|
|
#include "qemu/timer.h"
|
2012-09-28 17:22:47 +02:00
|
|
|
|
2017-05-08 16:13:04 +02:00
|
|
|
/*
|
|
|
|
* The block job API is composed of two categories of functions.
|
|
|
|
*
|
|
|
|
* The first includes functions used by the monitor. The monitor is
|
|
|
|
* peculiar in that it accesses the block job list with block_job_get, and
|
|
|
|
* therefore needs consistency across block_job_get and the actual operation
|
|
|
|
* (e.g. block_job_set_speed). The consistency is achieved with
|
|
|
|
* aio_context_acquire/release. These functions are declared in blockjob.h.
|
|
|
|
*
|
|
|
|
* The second includes functions used by the block job drivers and sometimes
|
|
|
|
* by the core block layer. These do not care about locking, because the
|
|
|
|
* whole coroutine runs under the AioContext lock, and are declared in
|
|
|
|
* blockjob_int.h.
|
|
|
|
*/
|
|
|
|
|
2018-04-12 17:54:37 +02:00
|
|
|
static bool is_block_job(Job *job)
|
2016-04-04 15:43:51 +02:00
|
|
|
{
|
2018-04-12 17:54:37 +02:00
|
|
|
return job_type(job) == JOB_TYPE_BACKUP ||
|
|
|
|
job_type(job) == JOB_TYPE_COMMIT ||
|
|
|
|
job_type(job) == JOB_TYPE_MIRROR ||
|
|
|
|
job_type(job) == JOB_TYPE_STREAM;
|
|
|
|
}
|
|
|
|
|
|
|
|
BlockJob *block_job_next(BlockJob *bjob)
|
|
|
|
{
|
|
|
|
Job *job = bjob ? &bjob->job : NULL;
|
|
|
|
|
|
|
|
do {
|
|
|
|
job = job_next(job);
|
|
|
|
} while (job && !is_block_job(job));
|
|
|
|
|
|
|
|
return job ? container_of(job, BlockJob, job) : NULL;
|
2016-04-04 15:43:51 +02:00
|
|
|
}
|
|
|
|
|
2016-07-05 16:28:54 +02:00
|
|
|
BlockJob *block_job_get(const char *id)
|
|
|
|
{
|
2018-04-12 17:54:37 +02:00
|
|
|
Job *job = job_get(id);
|
2016-07-05 16:28:54 +02:00
|
|
|
|
2018-04-12 17:54:37 +02:00
|
|
|
if (job && is_block_job(job)) {
|
|
|
|
return container_of(job, BlockJob, job);
|
|
|
|
} else {
|
|
|
|
return NULL;
|
2016-07-05 16:28:54 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-04-13 18:50:05 +02:00
|
|
|
void block_job_free(Job *job)
|
2017-05-08 16:13:02 +02:00
|
|
|
{
|
2018-04-13 18:50:05 +02:00
|
|
|
BlockJob *bjob = container_of(job, BlockJob, job);
|
|
|
|
|
|
|
|
block_job_remove_all_bdrv(bjob);
|
|
|
|
blk_unref(bjob->blk);
|
|
|
|
error_free(bjob->blocker);
|
2017-05-08 16:13:02 +02:00
|
|
|
}
|
|
|
|
|
2017-05-08 16:13:03 +02:00
|
|
|
static char *child_job_get_parent_desc(BdrvChild *c)
|
|
|
|
{
|
|
|
|
BlockJob *job = c->opaque;
|
2018-04-12 17:57:08 +02:00
|
|
|
return g_strdup_printf("%s job '%s'", job_type_str(&job->job), job->job.id);
|
2017-05-08 16:13:03 +02:00
|
|
|
}
|
|
|
|
|
2017-12-12 19:04:28 +01:00
|
|
|
static void child_job_drained_begin(BdrvChild *c)
|
2017-05-08 16:13:03 +02:00
|
|
|
{
|
2017-12-12 19:04:28 +01:00
|
|
|
BlockJob *job = c->opaque;
|
2018-04-18 17:10:26 +02:00
|
|
|
job_pause(&job->job);
|
2017-05-08 16:13:03 +02:00
|
|
|
}
|
|
|
|
|
2018-03-22 14:11:20 +01:00
|
|
|
static bool child_job_drained_poll(BdrvChild *c)
|
|
|
|
{
|
|
|
|
BlockJob *bjob = c->opaque;
|
|
|
|
Job *job = &bjob->job;
|
|
|
|
const BlockJobDriver *drv = block_job_driver(bjob);
|
|
|
|
|
|
|
|
/* An inactive or completed job doesn't have any pending requests. Jobs
|
|
|
|
* with !job->busy are either already paused or have a pause point after
|
|
|
|
* being reentered, so no job driver code will run before they pause. */
|
2018-09-07 15:31:22 +02:00
|
|
|
if (!job->busy || job_is_completed(job)) {
|
2018-03-22 14:11:20 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Otherwise, assume that it isn't fully stopped yet, but allow the job to
|
|
|
|
* override this assumption. */
|
|
|
|
if (drv->drained_poll) {
|
|
|
|
return drv->drained_poll(bjob);
|
|
|
|
} else {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
block: Do not poll in bdrv_do_drained_end()
We should never poll anywhere in bdrv_do_drained_end() (including its
recursive callees like bdrv_drain_invoke()), because it does not cope
well with graph changes. In fact, it has been written based on the
postulation that no graph changes will happen in it.
Instead, the callers that want to poll must poll, i.e. all currently
globally available wrappers: bdrv_drained_end(),
bdrv_subtree_drained_end(), bdrv_unapply_subtree_drain(), and
bdrv_drain_all_end(). Graph changes there do not matter.
They can poll simply by passing a pointer to a drained_end_counter and
wait until it reaches 0.
This patch also adds a non-polling global wrapper for
bdrv_do_drained_end() that takes a drained_end_counter pointer. We need
such a variant because now no function called anywhere from
bdrv_do_drained_end() must poll. This includes
BdrvChildRole.drained_end(), which already must not poll according to
its interface documentation, but bdrv_child_cb_drained_end() just
violates that by invoking bdrv_drained_end() (which does poll).
Therefore, BdrvChildRole.drained_end() must take a *drained_end_counter
parameter, which bdrv_child_cb_drained_end() can pass on to the new
bdrv_drained_end_no_poll() function.
Note that we now have a pattern of all drained_end-related functions
either polling or receiving a *drained_end_counter to let the caller
poll based on that.
A problem with a single poll loop is that when the drained section in
bdrv_set_aio_context_ignore() ends, some nodes in the subgraph may be in
the old contexts, while others are in the new context already. To let
the collective poll in bdrv_drained_end() work correctly, we must not
hold a lock to the old context, so that the old context can make
progress in case it is different from the current context.
(In the process, remove the comment saying that the current context is
always the old context, because it is wrong.)
In all other places, all nodes in a subtree must be in the same context,
so we can just poll that. The exception of course is
bdrv_drain_all_end(), but that always runs in the main context, so we
can just poll NULL (like bdrv_drain_all_begin() does).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2019-07-19 11:26:14 +02:00
|
|
|
static void child_job_drained_end(BdrvChild *c, int *drained_end_counter)
|
2017-05-08 16:13:03 +02:00
|
|
|
{
|
2017-12-12 19:04:28 +01:00
|
|
|
BlockJob *job = c->opaque;
|
2018-04-18 17:10:26 +02:00
|
|
|
job_resume(&job->job);
|
2017-05-08 16:13:03 +02:00
|
|
|
}
|
|
|
|
|
2019-05-06 19:18:03 +02:00
|
|
|
static bool child_job_can_set_aio_ctx(BdrvChild *c, AioContext *ctx,
|
|
|
|
GSList **ignore, Error **errp)
|
|
|
|
{
|
|
|
|
BlockJob *job = c->opaque;
|
|
|
|
GSList *l;
|
|
|
|
|
|
|
|
for (l = job->nodes; l; l = l->next) {
|
|
|
|
BdrvChild *sibling = l->data;
|
|
|
|
if (!bdrv_child_can_set_aio_context(sibling, ctx, ignore, errp)) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void child_job_set_aio_ctx(BdrvChild *c, AioContext *ctx,
|
|
|
|
GSList **ignore)
|
|
|
|
{
|
|
|
|
BlockJob *job = c->opaque;
|
|
|
|
GSList *l;
|
|
|
|
|
|
|
|
for (l = job->nodes; l; l = l->next) {
|
|
|
|
BdrvChild *sibling = l->data;
|
|
|
|
if (g_slist_find(*ignore, sibling)) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
*ignore = g_slist_prepend(*ignore, sibling);
|
|
|
|
bdrv_set_aio_context_ignore(sibling->bs, ctx, ignore);
|
|
|
|
}
|
2019-05-06 19:18:04 +02:00
|
|
|
|
|
|
|
job->job.aio_context = ctx;
|
2019-05-06 19:18:03 +02:00
|
|
|
}
|
|
|
|
|
2020-05-13 13:05:13 +02:00
|
|
|
static const BdrvChildClass child_job = {
|
2017-12-12 19:04:28 +01:00
|
|
|
.get_parent_desc = child_job_get_parent_desc,
|
|
|
|
.drained_begin = child_job_drained_begin,
|
2018-03-22 14:11:20 +01:00
|
|
|
.drained_poll = child_job_drained_poll,
|
2017-12-12 19:04:28 +01:00
|
|
|
.drained_end = child_job_drained_end,
|
2019-05-06 19:18:03 +02:00
|
|
|
.can_set_aio_ctx = child_job_can_set_aio_ctx,
|
|
|
|
.set_aio_ctx = child_job_set_aio_ctx,
|
2017-12-12 19:04:28 +01:00
|
|
|
.stay_at_node = true,
|
2017-05-08 16:13:03 +02:00
|
|
|
};
|
|
|
|
|
2017-02-28 12:45:58 +01:00
|
|
|
void block_job_remove_all_bdrv(BlockJob *job)
|
|
|
|
{
|
2019-09-11 12:03:16 +02:00
|
|
|
/*
|
|
|
|
* bdrv_root_unref_child() may reach child_job_[can_]set_aio_ctx(),
|
|
|
|
* which will also traverse job->nodes, so consume the list one by
|
|
|
|
* one to make sure that such a concurrent access does not attempt
|
|
|
|
* to process an already freed BdrvChild.
|
|
|
|
*/
|
|
|
|
while (job->nodes) {
|
|
|
|
GSList *l = job->nodes;
|
2017-02-28 12:45:58 +01:00
|
|
|
BdrvChild *c = l->data;
|
2019-09-11 12:03:16 +02:00
|
|
|
|
|
|
|
job->nodes = l->next;
|
|
|
|
|
2017-02-28 12:45:58 +01:00
|
|
|
bdrv_op_unblock_all(c->bs, job->blocker);
|
|
|
|
bdrv_root_unref_child(c);
|
2019-09-11 12:03:16 +02:00
|
|
|
|
|
|
|
g_slist_free_1(l);
|
2017-02-28 12:45:58 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-06 17:41:31 +02:00
|
|
|
bool block_job_has_bdrv(BlockJob *job, BlockDriverState *bs)
|
|
|
|
{
|
|
|
|
GSList *el;
|
|
|
|
|
|
|
|
for (el = job->nodes; el; el = el->next) {
|
|
|
|
BdrvChild *c = el->data;
|
|
|
|
if (c->bs == bs) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-01-17 11:56:42 +01:00
|
|
|
int block_job_add_bdrv(BlockJob *job, const char *name, BlockDriverState *bs,
|
|
|
|
uint64_t perm, uint64_t shared_perm, Error **errp)
|
2016-10-28 09:08:04 +02:00
|
|
|
{
|
2017-01-17 11:56:42 +01:00
|
|
|
BdrvChild *c;
|
blockjob: Fix crash with IOthread when block commit after snapshot
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when do block commit
after snapshot. Just like below:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f7c7d91f700 (LWP 99907)]
0x00005576d0f65aab in bdrv_mirror_top_pwritev at ../block/mirror.c:1437
1437 ../block/mirror.c: No such file or directory.
(gdb) p s->job
$17 = (MirrorBlockJob *) 0x0
(gdb) p s->stop
$18 = false
Call trace of IO thread:
0 0x00005576d0f65aab in bdrv_mirror_top_pwritev at ../block/mirror.c:1437
1 0x00005576d0f7f3ab in bdrv_driver_pwritev at ../block/io.c:1174
2 0x00005576d0f8139d in bdrv_aligned_pwritev at ../block/io.c:1988
3 0x00005576d0f81b65 in bdrv_co_pwritev_part at ../block/io.c:2156
4 0x00005576d0f8e6b7 in blk_do_pwritev_part at ../block/block-backend.c:1260
5 0x00005576d0f8e84d in blk_aio_write_entry at ../block/block-backend.c:1476
...
Switch to qemu main thread:
0 0x00007f903be704ed in __lll_lock_wait at
/lib/../lib64/libpthread.so.0
1 0x00007f903be6bde6 in _L_lock_941 at /lib/../lib64/libpthread.so.0
2 0x00007f903be6bcdf in pthread_mutex_lock at
/lib/../lib64/libpthread.so.0
3 0x0000564b21456889 in qemu_mutex_lock_impl at
../util/qemu-thread-posix.c:79
4 0x0000564b213af8a5 in block_job_add_bdrv at ../blockjob.c:224
5 0x0000564b213b00ad in block_job_create at ../blockjob.c:440
6 0x0000564b21357c0a in mirror_start_job at ../block/mirror.c:1622
7 0x0000564b2135a9af in commit_active_start at ../block/mirror.c:1867
8 0x0000564b2133d132 in qmp_block_commit at ../blockdev.c:2768
9 0x0000564b2141fef3 in qmp_marshal_block_commit at
qapi/qapi-commands-block-core.c:346
10 0x0000564b214503c9 in do_qmp_dispatch_bh at
../qapi/qmp-dispatch.c:110
11 0x0000564b21451996 in aio_bh_poll at ../util/async.c:164
12 0x0000564b2146018e in aio_dispatch at ../util/aio-posix.c:381
13 0x0000564b2145187e in aio_ctx_dispatch at ../util/async.c:306
14 0x00007f9040239049 in g_main_context_dispatch at
/lib/../lib64/libglib-2.0.so.0
15 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:232
16 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:255
17 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:531
18 0x0000564b212304e1 in qemu_main_loop at ../softmmu/runstate.c:721
19 0x0000564b20f7975e in main at ../softmmu/main.c:50
In IO thread when do bdrv_mirror_top_pwritev, the job is NULL, and stop field
is false, this means the MirrorBDSOpaque "s" object has not been initialized
yet, and this object is initialized by block_job_create(), but the initialize
process is stuck in acquiring the lock.
In this situation, IO thread come to bdrv_mirror_top_pwritev(),which means that
mirror-top node is already inserted into block graph, but its bs->opaque->job
is not initialized.
The root cause is that qemu main thread do release/acquire when hold the lock,
at the same time, IO thread get the lock after release stage, and the crash
occured.
Actually, in this situation, job->job.aio_context will not equal to
qemu_get_aio_context(), and will be the same as bs->aio_context,
thus, no need to release the lock, becasue bdrv_root_attach_child()
will not change the context.
This patch fix this issue.
Fixes: 132ada80 "block: Adjust AioContexts when attaching nodes"
Signed-off-by: Michael Qiu <qiudayu@huayun.com>
Message-Id: <20210203024059.52683-1-08005325@163.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-02-03 03:40:59 +01:00
|
|
|
bool need_context_ops;
|
2017-01-17 11:56:42 +01:00
|
|
|
|
2019-05-13 15:46:18 +02:00
|
|
|
bdrv_ref(bs);
|
blockjob: Fix crash with IOthread when block commit after snapshot
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when do block commit
after snapshot. Just like below:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f7c7d91f700 (LWP 99907)]
0x00005576d0f65aab in bdrv_mirror_top_pwritev at ../block/mirror.c:1437
1437 ../block/mirror.c: No such file or directory.
(gdb) p s->job
$17 = (MirrorBlockJob *) 0x0
(gdb) p s->stop
$18 = false
Call trace of IO thread:
0 0x00005576d0f65aab in bdrv_mirror_top_pwritev at ../block/mirror.c:1437
1 0x00005576d0f7f3ab in bdrv_driver_pwritev at ../block/io.c:1174
2 0x00005576d0f8139d in bdrv_aligned_pwritev at ../block/io.c:1988
3 0x00005576d0f81b65 in bdrv_co_pwritev_part at ../block/io.c:2156
4 0x00005576d0f8e6b7 in blk_do_pwritev_part at ../block/block-backend.c:1260
5 0x00005576d0f8e84d in blk_aio_write_entry at ../block/block-backend.c:1476
...
Switch to qemu main thread:
0 0x00007f903be704ed in __lll_lock_wait at
/lib/../lib64/libpthread.so.0
1 0x00007f903be6bde6 in _L_lock_941 at /lib/../lib64/libpthread.so.0
2 0x00007f903be6bcdf in pthread_mutex_lock at
/lib/../lib64/libpthread.so.0
3 0x0000564b21456889 in qemu_mutex_lock_impl at
../util/qemu-thread-posix.c:79
4 0x0000564b213af8a5 in block_job_add_bdrv at ../blockjob.c:224
5 0x0000564b213b00ad in block_job_create at ../blockjob.c:440
6 0x0000564b21357c0a in mirror_start_job at ../block/mirror.c:1622
7 0x0000564b2135a9af in commit_active_start at ../block/mirror.c:1867
8 0x0000564b2133d132 in qmp_block_commit at ../blockdev.c:2768
9 0x0000564b2141fef3 in qmp_marshal_block_commit at
qapi/qapi-commands-block-core.c:346
10 0x0000564b214503c9 in do_qmp_dispatch_bh at
../qapi/qmp-dispatch.c:110
11 0x0000564b21451996 in aio_bh_poll at ../util/async.c:164
12 0x0000564b2146018e in aio_dispatch at ../util/aio-posix.c:381
13 0x0000564b2145187e in aio_ctx_dispatch at ../util/async.c:306
14 0x00007f9040239049 in g_main_context_dispatch at
/lib/../lib64/libglib-2.0.so.0
15 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:232
16 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:255
17 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:531
18 0x0000564b212304e1 in qemu_main_loop at ../softmmu/runstate.c:721
19 0x0000564b20f7975e in main at ../softmmu/main.c:50
In IO thread when do bdrv_mirror_top_pwritev, the job is NULL, and stop field
is false, this means the MirrorBDSOpaque "s" object has not been initialized
yet, and this object is initialized by block_job_create(), but the initialize
process is stuck in acquiring the lock.
In this situation, IO thread come to bdrv_mirror_top_pwritev(),which means that
mirror-top node is already inserted into block graph, but its bs->opaque->job
is not initialized.
The root cause is that qemu main thread do release/acquire when hold the lock,
at the same time, IO thread get the lock after release stage, and the crash
occured.
Actually, in this situation, job->job.aio_context will not equal to
qemu_get_aio_context(), and will be the same as bs->aio_context,
thus, no need to release the lock, becasue bdrv_root_attach_child()
will not change the context.
This patch fix this issue.
Fixes: 132ada80 "block: Adjust AioContexts when attaching nodes"
Signed-off-by: Michael Qiu <qiudayu@huayun.com>
Message-Id: <20210203024059.52683-1-08005325@163.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-02-03 03:40:59 +01:00
|
|
|
|
|
|
|
need_context_ops = bdrv_get_aio_context(bs) != job->job.aio_context;
|
|
|
|
|
|
|
|
if (need_context_ops && job->job.aio_context != qemu_get_aio_context()) {
|
2019-04-24 17:41:46 +02:00
|
|
|
aio_context_release(job->job.aio_context);
|
|
|
|
}
|
2020-05-13 13:05:15 +02:00
|
|
|
c = bdrv_root_attach_child(bs, name, &child_job, 0,
|
|
|
|
job->job.aio_context, perm, shared_perm, job,
|
|
|
|
errp);
|
blockjob: Fix crash with IOthread when block commit after snapshot
Currently, if guest has workloads, IO thread will acquire aio_context
lock before do io_submit, it leads to segmentfault when do block commit
after snapshot. Just like below:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f7c7d91f700 (LWP 99907)]
0x00005576d0f65aab in bdrv_mirror_top_pwritev at ../block/mirror.c:1437
1437 ../block/mirror.c: No such file or directory.
(gdb) p s->job
$17 = (MirrorBlockJob *) 0x0
(gdb) p s->stop
$18 = false
Call trace of IO thread:
0 0x00005576d0f65aab in bdrv_mirror_top_pwritev at ../block/mirror.c:1437
1 0x00005576d0f7f3ab in bdrv_driver_pwritev at ../block/io.c:1174
2 0x00005576d0f8139d in bdrv_aligned_pwritev at ../block/io.c:1988
3 0x00005576d0f81b65 in bdrv_co_pwritev_part at ../block/io.c:2156
4 0x00005576d0f8e6b7 in blk_do_pwritev_part at ../block/block-backend.c:1260
5 0x00005576d0f8e84d in blk_aio_write_entry at ../block/block-backend.c:1476
...
Switch to qemu main thread:
0 0x00007f903be704ed in __lll_lock_wait at
/lib/../lib64/libpthread.so.0
1 0x00007f903be6bde6 in _L_lock_941 at /lib/../lib64/libpthread.so.0
2 0x00007f903be6bcdf in pthread_mutex_lock at
/lib/../lib64/libpthread.so.0
3 0x0000564b21456889 in qemu_mutex_lock_impl at
../util/qemu-thread-posix.c:79
4 0x0000564b213af8a5 in block_job_add_bdrv at ../blockjob.c:224
5 0x0000564b213b00ad in block_job_create at ../blockjob.c:440
6 0x0000564b21357c0a in mirror_start_job at ../block/mirror.c:1622
7 0x0000564b2135a9af in commit_active_start at ../block/mirror.c:1867
8 0x0000564b2133d132 in qmp_block_commit at ../blockdev.c:2768
9 0x0000564b2141fef3 in qmp_marshal_block_commit at
qapi/qapi-commands-block-core.c:346
10 0x0000564b214503c9 in do_qmp_dispatch_bh at
../qapi/qmp-dispatch.c:110
11 0x0000564b21451996 in aio_bh_poll at ../util/async.c:164
12 0x0000564b2146018e in aio_dispatch at ../util/aio-posix.c:381
13 0x0000564b2145187e in aio_ctx_dispatch at ../util/async.c:306
14 0x00007f9040239049 in g_main_context_dispatch at
/lib/../lib64/libglib-2.0.so.0
15 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:232
16 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:255
17 0x0000564b21447368 in main_loop_wait at ../util/main-loop.c:531
18 0x0000564b212304e1 in qemu_main_loop at ../softmmu/runstate.c:721
19 0x0000564b20f7975e in main at ../softmmu/main.c:50
In IO thread when do bdrv_mirror_top_pwritev, the job is NULL, and stop field
is false, this means the MirrorBDSOpaque "s" object has not been initialized
yet, and this object is initialized by block_job_create(), but the initialize
process is stuck in acquiring the lock.
In this situation, IO thread come to bdrv_mirror_top_pwritev(),which means that
mirror-top node is already inserted into block graph, but its bs->opaque->job
is not initialized.
The root cause is that qemu main thread do release/acquire when hold the lock,
at the same time, IO thread get the lock after release stage, and the crash
occured.
Actually, in this situation, job->job.aio_context will not equal to
qemu_get_aio_context(), and will be the same as bs->aio_context,
thus, no need to release the lock, becasue bdrv_root_attach_child()
will not change the context.
This patch fix this issue.
Fixes: 132ada80 "block: Adjust AioContexts when attaching nodes"
Signed-off-by: Michael Qiu <qiudayu@huayun.com>
Message-Id: <20210203024059.52683-1-08005325@163.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-02-03 03:40:59 +01:00
|
|
|
if (need_context_ops && job->job.aio_context != qemu_get_aio_context()) {
|
2019-04-24 17:41:46 +02:00
|
|
|
aio_context_acquire(job->job.aio_context);
|
|
|
|
}
|
2017-01-17 11:56:42 +01:00
|
|
|
if (c == NULL) {
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
|
|
|
job->nodes = g_slist_prepend(job->nodes, c);
|
2016-10-28 09:08:04 +02:00
|
|
|
bdrv_op_block_all(bs, job->blocker);
|
2017-01-17 11:56:42 +01:00
|
|
|
|
|
|
|
return 0;
|
2016-10-28 09:08:04 +02:00
|
|
|
}
|
|
|
|
|
2018-08-17 14:53:05 +02:00
|
|
|
static void block_job_on_idle(Notifier *n, void *opaque)
|
|
|
|
{
|
2018-09-18 17:09:16 +02:00
|
|
|
aio_wait_kick();
|
2018-08-17 14:53:05 +02:00
|
|
|
}
|
|
|
|
|
2016-10-27 18:06:55 +02:00
|
|
|
bool block_job_is_internal(BlockJob *job)
|
|
|
|
{
|
2018-04-12 17:29:59 +02:00
|
|
|
return (job->job.id == NULL);
|
2016-10-27 18:06:55 +02:00
|
|
|
}
|
|
|
|
|
2018-01-19 15:54:40 +01:00
|
|
|
const BlockJobDriver *block_job_driver(BlockJob *job)
|
|
|
|
{
|
2018-05-14 14:51:21 +02:00
|
|
|
return container_of(job->job.driver, BlockJobDriver, job_driver);
|
2018-01-19 15:54:40 +01:00
|
|
|
}
|
|
|
|
|
2018-04-13 17:31:02 +02:00
|
|
|
/* Assumes the job_mutex is held */
|
|
|
|
static bool job_timer_pending(Job *job)
|
|
|
|
{
|
|
|
|
return timer_pending(&job->sleep_timer);
|
|
|
|
}
|
|
|
|
|
2012-09-28 17:22:47 +02:00
|
|
|
void block_job_set_speed(BlockJob *job, int64_t speed, Error **errp)
|
|
|
|
{
|
2021-01-16 22:46:50 +01:00
|
|
|
const BlockJobDriver *drv = block_job_driver(job);
|
2017-12-13 21:46:11 +01:00
|
|
|
int64_t old_speed = job->speed;
|
2012-09-28 17:22:47 +02:00
|
|
|
|
2018-04-13 17:19:31 +02:00
|
|
|
if (job_apply_verb(&job->job, JOB_VERB_SET_SPEED, errp)) {
|
blockjobs: add block_job_verb permission table
Which commands ("verbs") are appropriate for jobs in which state is
also somewhat burdensome to keep track of.
As of this commit, it looks rather useless, but begins to look more
interesting the more states we add to the STM table.
A recurring theme is that no verb will apply to an 'undefined' job.
Further, it's not presently possible to restrict the "pause" or "resume"
verbs any more than they are in this commit because of the asynchronous
nature of how jobs enter the PAUSED state; justifications for some
seemingly erroneous applications are given below.
=====
Verbs
=====
Cancel: Any state except undefined.
Pause: Any state except undefined;
'created': Requests that the job pauses as it starts.
'running': Normal usage. (PAUSED)
'paused': The job may be paused for internal reasons,
but the user may wish to force an indefinite
user-pause, so this is allowed.
'ready': Normal usage. (STANDBY)
'standby': Same logic as above.
Resume: Any state except undefined;
'created': Will lift a user's pause-on-start request.
'running': Will lift a pause request before it takes effect.
'paused': Normal usage.
'ready': Will lift a pause request before it takes effect.
'standby': Normal usage.
Set-speed: Any state except undefined, though ready may not be meaningful.
Complete: Only a 'ready' job may accept a complete request.
=======
Changes
=======
(1)
To facilitate "nice" error checking, all five major block-job verb
interfaces in blockjob.c now support an errp parameter:
- block_job_user_cancel is added as a new interface.
- block_job_user_pause gains an errp paramter
- block_job_user_resume gains an errp parameter
- block_job_set_speed already had an errp parameter.
- block_job_complete already had an errp parameter.
(2)
block-job-pause and block-job-resume will no longer no-op when trying
to pause an already paused job, or trying to resume a job that isn't
paused. These functions will now report that they did not perform the
action requested because it was not possible.
iotests have been adjusted to address this new behavior.
(3)
block-job-complete doesn't worry about checking !block_job_started,
because the permission table guards against this.
(4)
test-bdrv-drain's job implementation needs to announce that it is
'ready' now, in order to be completed.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2018-03-10 09:27:32 +01:00
|
|
|
return;
|
|
|
|
}
|
2018-01-18 20:25:40 +01:00
|
|
|
if (speed < 0) {
|
2019-11-26 14:39:55 +01:00
|
|
|
error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "speed",
|
|
|
|
"a non-negative value");
|
2012-09-28 17:22:47 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-01-18 20:25:40 +01:00
|
|
|
ratelimit_set_speed(&job->limit, speed, BLOCK_JOB_SLICE_TIME);
|
|
|
|
|
2012-09-28 17:22:47 +02:00
|
|
|
job->speed = speed;
|
2021-01-16 22:46:50 +01:00
|
|
|
|
|
|
|
if (drv->set_speed) {
|
|
|
|
drv->set_speed(job, speed);
|
|
|
|
}
|
|
|
|
|
2018-03-10 09:27:26 +01:00
|
|
|
if (speed && speed <= old_speed) {
|
2017-12-13 21:46:11 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* kick only if a timer is pending */
|
2018-04-13 17:31:02 +02:00
|
|
|
job_enter_cond(&job->job, job_timer_pending);
|
2012-09-28 17:22:47 +02:00
|
|
|
}
|
|
|
|
|
2018-01-18 21:19:38 +01:00
|
|
|
int64_t block_job_ratelimit_get_delay(BlockJob *job, uint64_t n)
|
|
|
|
{
|
|
|
|
if (!job->speed) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ratelimit_calculate_delay(&job->limit, n);
|
|
|
|
}
|
|
|
|
|
2016-10-27 18:06:55 +02:00
|
|
|
BlockJobInfo *block_job_query(BlockJob *job, Error **errp)
|
2012-09-28 17:22:48 +02:00
|
|
|
{
|
2016-10-27 18:06:55 +02:00
|
|
|
BlockJobInfo *info;
|
|
|
|
|
|
|
|
if (block_job_is_internal(job)) {
|
|
|
|
error_setg(errp, "Cannot query QEMU internal jobs");
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
info = g_new0(BlockJobInfo, 1);
|
2018-04-12 17:57:08 +02:00
|
|
|
info->type = g_strdup(job_type_str(&job->job));
|
2018-04-12 17:29:59 +02:00
|
|
|
info->device = g_strdup(job->job.id);
|
2020-09-23 12:56:46 +02:00
|
|
|
info->busy = qatomic_read(&job->job.busy);
|
2018-04-13 17:31:02 +02:00
|
|
|
info->paused = job->job.pause_count > 0;
|
2020-03-11 11:29:56 +01:00
|
|
|
info->offset = job->job.progress.current;
|
|
|
|
info->len = job->job.progress.total;
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
info->speed = job->speed;
|
|
|
|
info->io_status = job->iostatus;
|
2018-04-25 15:09:58 +02:00
|
|
|
info->ready = job_is_ready(&job->job),
|
2018-04-13 17:19:31 +02:00
|
|
|
info->status = job->job.status;
|
2018-04-19 17:54:56 +02:00
|
|
|
info->auto_finalize = job->job.auto_finalize;
|
|
|
|
info->auto_dismiss = job->job.auto_dismiss;
|
2018-04-19 17:30:16 +02:00
|
|
|
info->has_error = job->job.ret != 0;
|
|
|
|
info->error = job->job.ret ? g_strdup(strerror(-job->job.ret)) : NULL;
|
2012-09-28 17:22:48 +02:00
|
|
|
return info;
|
|
|
|
}
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
|
|
|
|
static void block_job_iostatus_set_err(BlockJob *job, int error)
|
|
|
|
{
|
|
|
|
if (job->iostatus == BLOCK_DEVICE_IO_STATUS_OK) {
|
|
|
|
job->iostatus = error == ENOSPC ? BLOCK_DEVICE_IO_STATUS_NOSPACE :
|
|
|
|
BLOCK_DEVICE_IO_STATUS_FAILED;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-04-23 18:04:57 +02:00
|
|
|
static void block_job_event_cancelled(Notifier *n, void *opaque)
|
2014-06-18 08:43:47 +02:00
|
|
|
{
|
2018-04-23 18:04:57 +02:00
|
|
|
BlockJob *job = opaque;
|
|
|
|
|
2016-10-27 18:06:55 +02:00
|
|
|
if (block_job_is_internal(job)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-04-12 17:57:08 +02:00
|
|
|
qapi_event_send_block_job_cancelled(job_type(&job->job),
|
2018-04-12 17:29:59 +02:00
|
|
|
job->job.id,
|
2020-03-11 11:29:56 +01:00
|
|
|
job->job.progress.total,
|
|
|
|
job->job.progress.current,
|
2018-08-15 15:37:37 +02:00
|
|
|
job->speed);
|
2014-06-18 08:43:47 +02:00
|
|
|
}
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
|
2018-04-23 18:04:57 +02:00
|
|
|
static void block_job_event_completed(Notifier *n, void *opaque)
|
2012-07-23 15:15:47 +02:00
|
|
|
{
|
2018-04-23 18:04:57 +02:00
|
|
|
BlockJob *job = opaque;
|
|
|
|
const char *msg = NULL;
|
|
|
|
|
2016-10-27 18:06:55 +02:00
|
|
|
if (block_job_is_internal(job)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-04-19 17:30:16 +02:00
|
|
|
if (job->job.ret < 0) {
|
|
|
|
msg = strerror(-job->job.ret);
|
2018-04-23 18:04:57 +02:00
|
|
|
}
|
|
|
|
|
2018-04-12 17:57:08 +02:00
|
|
|
qapi_event_send_block_job_completed(job_type(&job->job),
|
2018-04-12 17:29:59 +02:00
|
|
|
job->job.id,
|
2020-03-11 11:29:56 +01:00
|
|
|
job->job.progress.total,
|
|
|
|
job->job.progress.current,
|
2014-06-18 08:43:47 +02:00
|
|
|
job->speed,
|
|
|
|
!!msg,
|
2018-08-15 15:37:37 +02:00
|
|
|
msg);
|
2012-07-23 15:15:47 +02:00
|
|
|
}
|
|
|
|
|
2018-04-23 18:04:57 +02:00
|
|
|
static void block_job_event_pending(Notifier *n, void *opaque)
|
2018-03-10 09:27:42 +01:00
|
|
|
{
|
2018-04-23 18:04:57 +02:00
|
|
|
BlockJob *job = opaque;
|
|
|
|
|
2018-04-23 17:09:42 +02:00
|
|
|
if (block_job_is_internal(job)) {
|
|
|
|
return;
|
2018-03-10 09:27:42 +01:00
|
|
|
}
|
2018-04-23 17:09:42 +02:00
|
|
|
|
|
|
|
qapi_event_send_block_job_pending(job_type(&job->job),
|
2018-08-15 15:37:37 +02:00
|
|
|
job->job.id);
|
2018-03-10 09:27:42 +01:00
|
|
|
}
|
|
|
|
|
2018-04-25 14:56:09 +02:00
|
|
|
static void block_job_event_ready(Notifier *n, void *opaque)
|
|
|
|
{
|
|
|
|
BlockJob *job = opaque;
|
|
|
|
|
|
|
|
if (block_job_is_internal(job)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
qapi_event_send_block_job_ready(job_type(&job->job),
|
|
|
|
job->job.id,
|
2020-03-11 11:29:56 +01:00
|
|
|
job->job.progress.total,
|
|
|
|
job->job.progress.current,
|
2018-08-15 15:37:37 +02:00
|
|
|
job->speed);
|
2018-04-25 14:56:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-05-08 16:13:04 +02:00
|
|
|
/*
|
|
|
|
* API for block job drivers and the block layer. These functions are
|
|
|
|
* declared in blockjob_int.h.
|
|
|
|
*/
|
|
|
|
|
|
|
|
void *block_job_create(const char *job_id, const BlockJobDriver *driver,
|
2018-04-19 16:09:52 +02:00
|
|
|
JobTxn *txn, BlockDriverState *bs, uint64_t perm,
|
2017-05-08 16:13:04 +02:00
|
|
|
uint64_t shared_perm, int64_t speed, int flags,
|
|
|
|
BlockCompletionFunc *cb, void *opaque, Error **errp)
|
|
|
|
{
|
|
|
|
BlockBackend *blk;
|
|
|
|
BlockJob *job;
|
|
|
|
|
2018-04-19 17:54:56 +02:00
|
|
|
if (job_id == NULL && !(flags & JOB_INTERNAL)) {
|
2017-05-08 16:13:04 +02:00
|
|
|
job_id = bdrv_get_device_name(bs);
|
|
|
|
}
|
|
|
|
|
2020-04-28 21:26:46 +02:00
|
|
|
blk = blk_new_with_bs(bs, perm, shared_perm, errp);
|
|
|
|
if (!blk) {
|
2017-05-08 16:13:04 +02:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-04-23 16:06:26 +02:00
|
|
|
job = job_create(job_id, &driver->job_driver, txn, blk_get_aio_context(blk),
|
2018-04-19 17:30:16 +02:00
|
|
|
flags, cb, opaque, errp);
|
2018-04-12 17:29:59 +02:00
|
|
|
if (job == NULL) {
|
|
|
|
blk_unref(blk);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-04-12 17:54:37 +02:00
|
|
|
assert(is_block_job(&job->job));
|
2018-04-13 18:50:05 +02:00
|
|
|
assert(job->job.driver->free == &block_job_free);
|
2018-04-18 17:10:26 +02:00
|
|
|
assert(job->job.driver->user_resume == &block_job_user_resume);
|
2018-04-12 17:54:37 +02:00
|
|
|
|
2018-05-14 14:51:21 +02:00
|
|
|
job->blk = blk;
|
2017-05-08 16:13:04 +02:00
|
|
|
|
2018-04-23 18:04:57 +02:00
|
|
|
job->finalize_cancelled_notifier.notify = block_job_event_cancelled;
|
|
|
|
job->finalize_completed_notifier.notify = block_job_event_completed;
|
|
|
|
job->pending_notifier.notify = block_job_event_pending;
|
2018-04-25 14:56:09 +02:00
|
|
|
job->ready_notifier.notify = block_job_event_ready;
|
2018-08-17 14:53:05 +02:00
|
|
|
job->idle_notifier.notify = block_job_on_idle;
|
2018-04-23 18:04:57 +02:00
|
|
|
|
|
|
|
notifier_list_add(&job->job.on_finalize_cancelled,
|
|
|
|
&job->finalize_cancelled_notifier);
|
|
|
|
notifier_list_add(&job->job.on_finalize_completed,
|
|
|
|
&job->finalize_completed_notifier);
|
|
|
|
notifier_list_add(&job->job.on_pending, &job->pending_notifier);
|
2018-04-25 14:56:09 +02:00
|
|
|
notifier_list_add(&job->job.on_ready, &job->ready_notifier);
|
2018-08-17 14:53:05 +02:00
|
|
|
notifier_list_add(&job->job.on_idle, &job->idle_notifier);
|
2018-04-23 18:04:57 +02:00
|
|
|
|
2017-05-08 16:13:04 +02:00
|
|
|
error_setg(&job->blocker, "block device is in use by block job: %s",
|
2018-04-12 17:57:08 +02:00
|
|
|
job_type_str(&job->job));
|
2017-05-08 16:13:04 +02:00
|
|
|
block_job_add_bdrv(job, "main node", bs, 0, BLK_PERM_ALL, &error_abort);
|
|
|
|
|
|
|
|
bdrv_op_unblock(bs, BLOCK_OP_TYPE_DATAPLANE, job->blocker);
|
|
|
|
|
block-backend: Queue requests while drained
This fixes devices like IDE that can still start new requests from I/O
handlers in the CPU thread while the block backend is drained.
The basic assumption is that in a drain section, no new requests should
be allowed through a BlockBackend (blk_drained_begin/end don't exist,
we get drain sections only on the node level). However, there are two
special cases where requests should not be queued:
1. Block jobs: We already make sure that block jobs are paused in a
drain section, so they won't start new requests. However, if the
drain_begin is called on the job's BlockBackend first, it can happen
that we deadlock because the job stays busy until it reaches a pause
point - which it can't if its requests aren't processed any more.
The proper solution here would be to make all requests through the
job's filter node instead of using a BlockBackend. For now, just
disabling request queuing on the job BlockBackend is simpler.
2. In test cases where making requests through bdrv_* would be
cumbersome because we'd need a BdrvChild. As we already got the
functionality to disable request queuing from 1., use it in tests,
too, for convenience.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
2019-07-22 17:46:23 +02:00
|
|
|
/* Disable request queuing in the BlockBackend to avoid deadlocks on drain:
|
|
|
|
* The job reports that it's busy until it reaches a pause point. */
|
|
|
|
blk_set_disable_request_queuing(blk, true);
|
2019-05-06 19:18:03 +02:00
|
|
|
blk_set_allow_aio_context_change(blk, true);
|
2017-05-08 16:13:04 +02:00
|
|
|
|
|
|
|
/* Only set speed when necessary to avoid NotSupported error */
|
|
|
|
if (speed != 0) {
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
block_job_set_speed(job, speed, &local_err);
|
|
|
|
if (local_err) {
|
2018-04-19 17:30:16 +02:00
|
|
|
job_early_fail(&job->job);
|
2017-05-08 16:13:04 +02:00
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
}
|
2018-03-10 09:27:27 +01:00
|
|
|
|
2017-05-08 16:13:04 +02:00
|
|
|
return job;
|
|
|
|
}
|
|
|
|
|
2017-05-08 16:13:05 +02:00
|
|
|
void block_job_iostatus_reset(BlockJob *job)
|
|
|
|
{
|
2017-05-08 16:13:06 +02:00
|
|
|
if (job->iostatus == BLOCK_DEVICE_IO_STATUS_OK) {
|
|
|
|
return;
|
|
|
|
}
|
2018-04-18 17:10:26 +02:00
|
|
|
assert(job->job.user_paused && job->job.pause_count > 0);
|
2017-05-08 16:13:05 +02:00
|
|
|
job->iostatus = BLOCK_DEVICE_IO_STATUS_OK;
|
|
|
|
}
|
|
|
|
|
2018-04-18 17:10:26 +02:00
|
|
|
void block_job_user_resume(Job *job)
|
|
|
|
{
|
|
|
|
BlockJob *bjob = container_of(job, BlockJob, job);
|
|
|
|
block_job_iostatus_reset(bjob);
|
|
|
|
}
|
|
|
|
|
2016-04-18 11:36:38 +02:00
|
|
|
BlockErrorAction block_job_error_action(BlockJob *job, BlockdevOnError on_err,
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
int is_read, int error)
|
|
|
|
{
|
|
|
|
BlockErrorAction action;
|
|
|
|
|
|
|
|
switch (on_err) {
|
|
|
|
case BLOCKDEV_ON_ERROR_ENOSPC:
|
2016-06-29 17:41:35 +02:00
|
|
|
case BLOCKDEV_ON_ERROR_AUTO:
|
2014-06-18 08:43:30 +02:00
|
|
|
action = (error == ENOSPC) ?
|
|
|
|
BLOCK_ERROR_ACTION_STOP : BLOCK_ERROR_ACTION_REPORT;
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
break;
|
|
|
|
case BLOCKDEV_ON_ERROR_STOP:
|
2014-06-18 08:43:30 +02:00
|
|
|
action = BLOCK_ERROR_ACTION_STOP;
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
break;
|
|
|
|
case BLOCKDEV_ON_ERROR_REPORT:
|
2014-06-18 08:43:30 +02:00
|
|
|
action = BLOCK_ERROR_ACTION_REPORT;
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
break;
|
|
|
|
case BLOCKDEV_ON_ERROR_IGNORE:
|
2014-06-18 08:43:30 +02:00
|
|
|
action = BLOCK_ERROR_ACTION_IGNORE;
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
abort();
|
|
|
|
}
|
2016-10-27 18:06:55 +02:00
|
|
|
if (!block_job_is_internal(job)) {
|
2018-04-12 17:29:59 +02:00
|
|
|
qapi_event_send_block_job_error(job->job.id,
|
2016-10-27 18:06:55 +02:00
|
|
|
is_read ? IO_OPERATION_TYPE_READ :
|
|
|
|
IO_OPERATION_TYPE_WRITE,
|
2018-08-15 15:37:37 +02:00
|
|
|
action);
|
2016-10-27 18:06:55 +02:00
|
|
|
}
|
2014-06-18 08:43:30 +02:00
|
|
|
if (action == BLOCK_ERROR_ACTION_STOP) {
|
2019-03-19 10:24:42 +01:00
|
|
|
if (!job->job.user_paused) {
|
|
|
|
job_pause(&job->job);
|
|
|
|
/* make the pause user visible, which will be resumed from QMP. */
|
|
|
|
job->job.user_paused = true;
|
|
|
|
}
|
block: introduce block job error
The following behaviors are possible:
'report': The behavior is the same as in 1.1. An I/O error,
respectively during a read or a write, will complete the job immediately
with an error code.
'ignore': An I/O error, respectively during a read or a write, will be
ignored. For streaming, the job will complete with an error and the
backing file will be left in place. For mirroring, the sector will be
marked again as dirty and re-examined later.
'stop': The job will be paused and the job iostatus will be set to
failed or nospace, while the VM will keep running. This can only be
specified if the block device has rerror=stop and werror=stop or enospc.
'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others.
In all cases, even for 'report', the I/O error is reported as a QMP
event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR.
It is possible that while stopping the VM a BLOCK_IO_ERROR event will be
reported and will clobber the event from BLOCK_JOB_ERROR, or vice versa.
This is not really avoidable since stopping the VM completes all pending
I/O requests. In fact, it is already possible now that a series of
BLOCK_IO_ERROR events are reported with rerror=stop, because vm_stop
calls bdrv_drain_all and this can generate further errors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2012-09-28 17:22:58 +02:00
|
|
|
block_job_iostatus_set_err(job, error);
|
|
|
|
}
|
|
|
|
return action;
|
|
|
|
}
|