2010-10-20 10:18:55 +02:00
|
|
|
/*
|
|
|
|
* x3130_downstream.c
|
|
|
|
* TI X3130 pci express downstream port switch
|
|
|
|
*
|
|
|
|
* Copyright (c) 2010 Isaku Yamahata <yamahata at valinux co jp>
|
|
|
|
* VA Linux Systems Japan K.K.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
* with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
2016-01-26 19:17:15 +01:00
|
|
|
#include "qemu/osdep.h"
|
2013-02-04 15:40:22 +01:00
|
|
|
#include "hw/pci/pci_ids.h"
|
|
|
|
#include "hw/pci/msi.h"
|
|
|
|
#include "hw/pci/pcie.h"
|
2018-10-10 23:53:53 +02:00
|
|
|
#include "hw/pci/pcie_port.h"
|
2019-08-12 07:23:51 +02:00
|
|
|
#include "hw/qdev-properties.h"
|
2019-08-12 07:23:45 +02:00
|
|
|
#include "migration/vmstate.h"
|
2016-06-20 08:13:39 +02:00
|
|
|
#include "qapi/error.h"
|
2019-05-23 16:35:07 +02:00
|
|
|
#include "qemu/module.h"
|
2022-03-01 16:11:58 +01:00
|
|
|
#include "hw/pci-bridge/xio3130_downstream.h"
|
2010-10-20 10:18:55 +02:00
|
|
|
|
|
|
|
#define PCI_DEVICE_ID_TI_XIO3130D 0x8233 /* downstream port */
|
|
|
|
#define XIO3130_REVISION 0x1
|
|
|
|
#define XIO3130_MSI_OFFSET 0x70
|
|
|
|
#define XIO3130_MSI_SUPPORTED_FLAGS PCI_MSI_FLAGS_64BIT
|
|
|
|
#define XIO3130_MSI_NR_VECTOR 1
|
|
|
|
#define XIO3130_SSVID_OFFSET 0x80
|
|
|
|
#define XIO3130_SSVID_SVID 0
|
|
|
|
#define XIO3130_SSVID_SSID 0
|
|
|
|
#define XIO3130_EXP_OFFSET 0x90
|
|
|
|
#define XIO3130_AER_OFFSET 0x100
|
|
|
|
|
|
|
|
static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,
|
|
|
|
uint32_t val, int len)
|
|
|
|
{
|
pcie: check that slt ctrl changed before deleting
During boot, linux would sometimes overwrites control of a powered off
slot before powering it on. Unfortunately QEMU interprets that as a
power off request and ejects the device.
For example:
/x86_64-softmmu/qemu-system-x86_64 -enable-kvm -S -machine q35 \
-device pcie-root-port,id=pcie_root_port_0,slot=2,chassis=2,addr=0x2,bus=pcie.0 \
-monitor stdio disk.qcow2
(qemu)device_add virtio-balloon-pci,id=balloon,bus=pcie_root_port_0
(qemu)cont
Balloon is deleted during guest boot.
To fix, save control beforehand and check that power
or led state actually change before ejecting.
Note: this is more a hack than a solution, ideally we'd
find a better way to detect ejects, or move away
from ejects completely and instead monitor whether
it's safe to delete device due to e.g. its power state.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Igor Mammedov <imammedo@redhat.com>
2019-06-21 06:12:22 +02:00
|
|
|
uint16_t slt_ctl, slt_sta;
|
|
|
|
|
2019-07-11 21:24:18 +02:00
|
|
|
pcie_cap_slot_get(d, &slt_ctl, &slt_sta);
|
2010-10-20 10:18:55 +02:00
|
|
|
pci_bridge_write_config(d, address, val, len);
|
|
|
|
pcie_cap_flr_write_config(d, address, val, len);
|
pcie: check that slt ctrl changed before deleting
During boot, linux would sometimes overwrites control of a powered off
slot before powering it on. Unfortunately QEMU interprets that as a
power off request and ejects the device.
For example:
/x86_64-softmmu/qemu-system-x86_64 -enable-kvm -S -machine q35 \
-device pcie-root-port,id=pcie_root_port_0,slot=2,chassis=2,addr=0x2,bus=pcie.0 \
-monitor stdio disk.qcow2
(qemu)device_add virtio-balloon-pci,id=balloon,bus=pcie_root_port_0
(qemu)cont
Balloon is deleted during guest boot.
To fix, save control beforehand and check that power
or led state actually change before ejecting.
Note: this is more a hack than a solution, ideally we'd
find a better way to detect ejects, or move away
from ejects completely and instead monitor whether
it's safe to delete device due to e.g. its power state.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Igor Mammedov <imammedo@redhat.com>
2019-06-21 06:12:22 +02:00
|
|
|
pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len);
|
2010-11-16 09:26:12 +01:00
|
|
|
pcie_aer_write_config(d, address, val, len);
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void xio3130_downstream_reset(DeviceState *qdev)
|
|
|
|
{
|
2011-12-04 19:22:06 +01:00
|
|
|
PCIDevice *d = PCI_DEVICE(qdev);
|
2012-05-16 01:09:56 +02:00
|
|
|
|
2010-10-20 10:18:55 +02:00
|
|
|
pcie_cap_deverr_reset(d);
|
|
|
|
pcie_cap_slot_reset(d);
|
2014-08-24 15:32:18 +02:00
|
|
|
pcie_cap_arifwd_reset(d);
|
2010-10-20 10:18:55 +02:00
|
|
|
pci_bridge_reset(qdev);
|
|
|
|
}
|
|
|
|
|
2017-06-27 08:16:52 +02:00
|
|
|
static void xio3130_downstream_realize(PCIDevice *d, Error **errp)
|
2010-10-20 10:18:55 +02:00
|
|
|
{
|
2013-07-12 19:56:00 +02:00
|
|
|
PCIEPort *p = PCIE_PORT(d);
|
|
|
|
PCIESlot *s = PCIE_SLOT(d);
|
2010-10-20 10:18:55 +02:00
|
|
|
int rc;
|
|
|
|
|
2016-01-15 03:23:32 +01:00
|
|
|
pci_bridge_initfn(d, TYPE_PCIE_BUS);
|
2010-10-20 10:18:55 +02:00
|
|
|
pcie_port_init_reg(d);
|
|
|
|
|
|
|
|
rc = msi_init(d, XIO3130_MSI_OFFSET, XIO3130_MSI_NR_VECTOR,
|
|
|
|
XIO3130_MSI_SUPPORTED_FLAGS & PCI_MSI_FLAGS_64BIT,
|
2017-06-27 08:16:52 +02:00
|
|
|
XIO3130_MSI_SUPPORTED_FLAGS & PCI_MSI_FLAGS_MASKBIT,
|
|
|
|
errp);
|
2010-10-20 10:18:55 +02:00
|
|
|
if (rc < 0) {
|
2016-06-20 08:13:39 +02:00
|
|
|
assert(rc == -ENOTSUP);
|
2010-11-16 09:26:12 +01:00
|
|
|
goto err_bridge;
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
2016-06-10 11:54:23 +02:00
|
|
|
|
2010-10-20 10:18:55 +02:00
|
|
|
rc = pci_bridge_ssvid_init(d, XIO3130_SSVID_OFFSET,
|
2017-06-27 08:16:52 +02:00
|
|
|
XIO3130_SSVID_SVID, XIO3130_SSVID_SSID,
|
|
|
|
errp);
|
2010-10-20 10:18:55 +02:00
|
|
|
if (rc < 0) {
|
2022-02-18 11:23:03 +01:00
|
|
|
goto err_msi;
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
2016-06-10 11:54:23 +02:00
|
|
|
|
2010-10-20 10:18:55 +02:00
|
|
|
rc = pcie_cap_init(d, XIO3130_EXP_OFFSET, PCI_EXP_TYPE_DOWNSTREAM,
|
2017-06-27 08:16:52 +02:00
|
|
|
p->port, errp);
|
2010-10-20 10:18:55 +02:00
|
|
|
if (rc < 0) {
|
2010-11-16 09:26:12 +01:00
|
|
|
goto err_msi;
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
2010-12-22 07:14:35 +01:00
|
|
|
pcie_cap_flr_init(d);
|
2010-10-20 10:18:55 +02:00
|
|
|
pcie_cap_deverr_init(d);
|
2020-02-26 18:46:07 +01:00
|
|
|
pcie_cap_slot_init(d, s);
|
2016-06-10 11:54:23 +02:00
|
|
|
pcie_cap_arifwd_init(d);
|
|
|
|
|
2010-10-20 10:18:55 +02:00
|
|
|
pcie_chassis_create(s->chassis);
|
|
|
|
rc = pcie_chassis_add_slot(s);
|
|
|
|
if (rc < 0) {
|
2017-08-25 21:54:06 +02:00
|
|
|
error_setg(errp, "Can't add chassis slot, error %d", rc);
|
2010-11-16 09:26:12 +01:00
|
|
|
goto err_pcie_cap;
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
2016-06-10 11:54:23 +02:00
|
|
|
|
2016-12-21 09:21:31 +01:00
|
|
|
rc = pcie_aer_init(d, PCI_ERR_VER, XIO3130_AER_OFFSET,
|
2017-06-27 08:16:52 +02:00
|
|
|
PCI_ERR_SIZEOF, errp);
|
2010-11-16 09:26:12 +01:00
|
|
|
if (rc < 0) {
|
|
|
|
goto err;
|
|
|
|
}
|
2010-10-20 10:18:55 +02:00
|
|
|
|
2017-06-27 08:16:52 +02:00
|
|
|
return;
|
2010-11-16 09:26:12 +01:00
|
|
|
|
|
|
|
err:
|
|
|
|
pcie_chassis_del_slot(s);
|
|
|
|
err_pcie_cap:
|
|
|
|
pcie_cap_exit(d);
|
|
|
|
err_msi:
|
|
|
|
msi_uninit(d);
|
|
|
|
err_bridge:
|
2012-07-04 06:39:27 +02:00
|
|
|
pci_bridge_exitfn(d);
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
|
|
|
|
2012-07-04 06:39:27 +02:00
|
|
|
static void xio3130_downstream_exitfn(PCIDevice *d)
|
2010-10-20 10:18:55 +02:00
|
|
|
{
|
2013-07-12 19:56:00 +02:00
|
|
|
PCIESlot *s = PCIE_SLOT(d);
|
2010-11-16 09:26:12 +01:00
|
|
|
|
|
|
|
pcie_aer_exit(d);
|
|
|
|
pcie_chassis_del_slot(s);
|
2010-10-20 10:18:55 +02:00
|
|
|
pcie_cap_exit(d);
|
2010-11-16 09:26:12 +01:00
|
|
|
msi_uninit(d);
|
2012-07-04 06:39:27 +02:00
|
|
|
pci_bridge_exitfn(d);
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
|
|
|
|
2014-06-23 16:32:48 +02:00
|
|
|
static Property xio3130_downstream_props[] = {
|
|
|
|
DEFINE_PROP_BIT(COMPAT_PROP_PCP, PCIDevice, cap_present,
|
|
|
|
QEMU_PCIE_SLTCAP_PCP_BITNR, true),
|
|
|
|
DEFINE_PROP_END_OF_LIST()
|
|
|
|
};
|
|
|
|
|
2010-10-20 10:18:55 +02:00
|
|
|
static const VMStateDescription vmstate_xio3130_downstream = {
|
|
|
|
.name = "xio3130-express-downstream-port",
|
pci/bus: let it has higher migration priority
In the past, we prioritized IOMMU migration so that we have such a
priority order:
IOMMU > PCI Devices
When migrating a guest with both vIOMMU and a pcie-root-port, we'll
always migrate vIOMMU first, since pci buses will be seen to have the
same priority of general PCI devices.
That's problematic.
The thing is that PCI bus number information is stored in the root port,
and that is needed by vIOMMU during post_load(), e.g., to figure out
context entry for a device. If we don't have correct bus numbers for
devices, we won't be able to recover device state of the DMAR memory
regions, and things will be messed up.
So let's boost the PCIe root ports to be even with higher priority:
PCIe Root Port > IOMMU > PCI Devices
A smoke test shows that this patch fixes bug 1538953.
Also, apply this rule to all the PCI bus/bridge devices: ioh3420,
xio3130_downstream, xio3130_upstream, pcie_pci_bridge, pci-pci bridge,
i82801b11.
I noted that we set pcie_pci_bridge_dev_vmstate twice. Clean that up
together.
CC: Alex Williamson <alex.williamson@redhat.com>
CC: Marcel Apfelbaum <marcel@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Laurent Vivier <lvivier@redhat.com>
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1538953
Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2018-02-06 08:39:33 +01:00
|
|
|
.priority = MIG_PRI_PCI_BUS,
|
2010-10-20 10:18:55 +02:00
|
|
|
.version_id = 1,
|
|
|
|
.minimum_version_id = 1,
|
2010-10-25 07:46:47 +02:00
|
|
|
.post_load = pcie_cap_slot_post_load,
|
2010-10-20 10:18:55 +02:00
|
|
|
.fields = (VMStateField[]) {
|
2016-12-14 20:58:29 +01:00
|
|
|
VMSTATE_PCI_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot),
|
2013-07-12 19:56:00 +02:00
|
|
|
VMSTATE_STRUCT(parent_obj.parent_obj.parent_obj.exp.aer_log,
|
|
|
|
PCIESlot, 0, vmstate_pcie_aer_log, PCIEAERLog),
|
2010-10-20 10:18:55 +02:00
|
|
|
VMSTATE_END_OF_LIST()
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2011-12-04 19:22:06 +01:00
|
|
|
static void xio3130_downstream_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
2011-12-08 04:34:16 +01:00
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
2011-12-04 19:22:06 +01:00
|
|
|
PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
|
|
|
|
|
2019-05-13 08:19:38 +02:00
|
|
|
k->is_bridge = true;
|
2011-12-04 19:22:06 +01:00
|
|
|
k->config_write = xio3130_downstream_write_config;
|
2017-06-27 08:16:52 +02:00
|
|
|
k->realize = xio3130_downstream_realize;
|
2011-12-04 19:22:06 +01:00
|
|
|
k->exit = xio3130_downstream_exitfn;
|
|
|
|
k->vendor_id = PCI_VENDOR_ID_TI;
|
|
|
|
k->device_id = PCI_DEVICE_ID_TI_XIO3130D;
|
|
|
|
k->revision = XIO3130_REVISION;
|
2013-07-29 16:17:45 +02:00
|
|
|
set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
|
2011-12-08 04:34:16 +01:00
|
|
|
dc->desc = "TI X3130 Downstream Port of PCI Express Switch";
|
|
|
|
dc->reset = xio3130_downstream_reset;
|
|
|
|
dc->vmsd = &vmstate_xio3130_downstream;
|
2020-01-10 16:30:32 +01:00
|
|
|
device_class_set_props(dc, xio3130_downstream_props);
|
2011-12-04 19:22:06 +01:00
|
|
|
}
|
|
|
|
|
2013-01-10 16:19:07 +01:00
|
|
|
static const TypeInfo xio3130_downstream_info = {
|
2022-03-01 16:11:58 +01:00
|
|
|
.name = TYPE_XIO3130_DOWNSTREAM,
|
2013-07-12 19:56:00 +02:00
|
|
|
.parent = TYPE_PCIE_SLOT,
|
2011-12-08 04:34:16 +01:00
|
|
|
.class_init = xio3130_downstream_class_init,
|
2017-09-27 21:56:33 +02:00
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ INTERFACE_PCIE_DEVICE },
|
|
|
|
{ }
|
|
|
|
},
|
2010-10-20 10:18:55 +02:00
|
|
|
};
|
|
|
|
|
2012-02-09 15:20:55 +01:00
|
|
|
static void xio3130_downstream_register_types(void)
|
2010-10-20 10:18:55 +02:00
|
|
|
{
|
2011-12-08 04:34:16 +01:00
|
|
|
type_register_static(&xio3130_downstream_info);
|
2010-10-20 10:18:55 +02:00
|
|
|
}
|
|
|
|
|
2012-02-09 15:20:55 +01:00
|
|
|
type_init(xio3130_downstream_register_types)
|